[PATCH] powerpc/xmon: Do not compute/store the major opcode

[PATCH] powerpc/xmon: Do not compute/store the major opcode

[Mathieu Malaterre]

In commit 5b102782c7f4 ("powerpc/xmon: Enable disassembly files (compilation
changes)") usage of variable `op` has been removed. Completely remove opcode
computation since not used anymore.

Fix fatal warning:

arch/powerpc/xmon/ppc-dis.c: In function ‘lookup_powerpc’:
arch/powerpc/xmon/ppc-dis.c:96:17: error: variable ‘op’ set but not used [-Werror=unused-but-set-variable]
   unsigned long op;
                 ^~

Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
 arch/powerpc/xmon/ppc-dis.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/powerpc/xmon/ppc-dis.c b/arch/powerpc/xmon/ppc-dis.c
index 31db8c072acd..9deea5ee13f6 100644
--- a/arch/powerpc/xmon/ppc-dis.c
+++ b/arch/powerpc/xmon/ppc-dis.c
@@ -93,10 +93,6 @@ lookup_powerpc (unsigned long insn, ppc_cpu_t dialect)
 {
   const struct powerpc_opcode *opcode;
   const struct powerpc_opcode *opcode_end;
-  unsigned long op;
-
-  /* Get the major opcode of the instruction.  */
-  op = PPC_OP (insn);
 
   opcode_end = powerpc_opcodes + powerpc_num_opcodes;
   /* Find the first match in the opcode table for this major opcode.  */
-- 
2.11.0

Re: powerpc/xmon: Do not compute/store the major opcode

[Michael Ellerman]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 671 bytes --]

On Tue, 2017-12-26 at 13:25:47 UTC, Mathieu Malaterre wrote:
> In commit 5b102782c7f4 ("powerpc/xmon: Enable disassembly files (compilation
> changes)") usage of variable `op` has been removed. Completely remove opcode
> computation since not used anymore.
> 
> Fix fatal warning:
> 
> arch/powerpc/xmon/ppc-dis.c: In function ‘lookup_powerpc’:
> arch/powerpc/xmon/ppc-dis.c:96:17: error: variable ‘op’ set but not used [-Werror=unused-but-set-variable]
>    unsigned long op;
>                  ^~
> 
> Signed-off-by: Mathieu Malaterre <malat@debian.org>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/104d55ae4df928c205268c1eb83b80

cheers