* [PATCH] fsl: remove redundant pointer 'priv'
@ 2018-08-29 9:27 Colin King
2018-08-30 17:23 ` Li Yang
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-08-29 9:27 UTC (permalink / raw)
To: Roy Pledge, Li Yang, linuxppc-dev, linux-arm-kernel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer 'priv' is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
variable 'priv' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/soc/fsl/dpio/dpio-driver.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/soc/fsl/dpio/dpio-driver.c b/drivers/soc/fsl/dpio/dpio-driver.c
index b60b77bfaffa..e58fcc9096e8 100644
--- a/drivers/soc/fsl/dpio/dpio-driver.c
+++ b/drivers/soc/fsl/dpio/dpio-driver.c
@@ -50,13 +50,10 @@ static void unregister_dpio_irq_handlers(struct fsl_mc_device *dpio_dev)
static int register_dpio_irq_handlers(struct fsl_mc_device *dpio_dev, int cpu)
{
- struct dpio_priv *priv;
int error;
struct fsl_mc_device_irq *irq;
cpumask_t mask;
- priv = dev_get_drvdata(&dpio_dev->dev);
-
irq = dpio_dev->irqs[0];
error = devm_request_irq(&dpio_dev->dev,
irq->msi_desc->irq,
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] fsl: remove redundant pointer 'priv'
2018-08-29 9:27 [PATCH] fsl: remove redundant pointer 'priv' Colin King
@ 2018-08-30 17:23 ` Li Yang
0 siblings, 0 replies; 2+ messages in thread
From: Li Yang @ 2018-08-30 17:23 UTC (permalink / raw)
To: colin.king
Cc: Roy Pledge, linuxppc-dev,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
kernel-janitors, lkml
On Wed, Aug 29, 2018 at 4:29 AM Colin King <colin.king@canonical.com> wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer 'priv' is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> variable 'priv' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Merged for next after updated the title prefix.
Thanks!
> ---
> drivers/soc/fsl/dpio/dpio-driver.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/soc/fsl/dpio/dpio-driver.c b/drivers/soc/fsl/dpio/dpio-driver.c
> index b60b77bfaffa..e58fcc9096e8 100644
> --- a/drivers/soc/fsl/dpio/dpio-driver.c
> +++ b/drivers/soc/fsl/dpio/dpio-driver.c
> @@ -50,13 +50,10 @@ static void unregister_dpio_irq_handlers(struct fsl_mc_device *dpio_dev)
>
> static int register_dpio_irq_handlers(struct fsl_mc_device *dpio_dev, int cpu)
> {
> - struct dpio_priv *priv;
> int error;
> struct fsl_mc_device_irq *irq;
> cpumask_t mask;
>
> - priv = dev_get_drvdata(&dpio_dev->dev);
> -
> irq = dpio_dev->irqs[0];
> error = devm_request_irq(&dpio_dev->dev,
> irq->msi_desc->irq,
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-30 17:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-29 9:27 [PATCH] fsl: remove redundant pointer 'priv' Colin King
2018-08-30 17:23 ` Li Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox