* [PATCH v2] powerpc/powernv: add NULL check after kzalloc in opal_add_one_export
@ 2020-04-05 10:30 Qiujun Huang
2020-04-05 12:12 ` Christophe Leroy
0 siblings, 1 reply; 3+ messages in thread
From: Qiujun Huang @ 2020-04-05 10:30 UTC (permalink / raw)
To: benh, paulus, mpe, tglx; +Cc: linuxppc-dev, linux-kernel, Qiujun Huang
Here needs a NULL check.
Issue found by coccinelle.
Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
---
arch/powerpc/platforms/powernv/opal.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
index 2b3dfd0b6cdd..5b98c98817aa 100644
--- a/arch/powerpc/platforms/powernv/opal.c
+++ b/arch/powerpc/platforms/powernv/opal.c
@@ -808,9 +808,12 @@ static int opal_add_one_export(struct kobject *parent, const char *export_name,
rc = of_property_read_u64_array(np, prop_name, &vals[0], 2);
if (rc)
- goto out;
+ return rc;
attr = kzalloc(sizeof(*attr), GFP_KERNEL);
+ if (!attr)
+ return -ENOMEM;
+
name = kstrdup(export_name, GFP_KERNEL);
if (!name) {
rc = -ENOMEM;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] powerpc/powernv: add NULL check after kzalloc in opal_add_one_export
2020-04-05 10:30 [PATCH v2] powerpc/powernv: add NULL check after kzalloc in opal_add_one_export Qiujun Huang
@ 2020-04-05 12:12 ` Christophe Leroy
2020-04-05 12:20 ` Qiujun Huang
0 siblings, 1 reply; 3+ messages in thread
From: Christophe Leroy @ 2020-04-05 12:12 UTC (permalink / raw)
To: Qiujun Huang, benh, paulus, mpe, tglx; +Cc: linuxppc-dev, linux-kernel
Le 05/04/2020 à 12:30, Qiujun Huang a écrit :
> Here needs a NULL check.
>
> Issue found by coccinelle.
>
> Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
> ---
> arch/powerpc/platforms/powernv/opal.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
> index 2b3dfd0b6cdd..5b98c98817aa 100644
> --- a/arch/powerpc/platforms/powernv/opal.c
> +++ b/arch/powerpc/platforms/powernv/opal.c
> @@ -808,9 +808,12 @@ static int opal_add_one_export(struct kobject *parent, const char *export_name,
>
> rc = of_property_read_u64_array(np, prop_name, &vals[0], 2);
> if (rc)
> - goto out;
> + return rc;
Nice you changed that too.
Then there is no need the initialise attr and name to NULL in their
declaration, as they won't be used before they are assigned.
>
> attr = kzalloc(sizeof(*attr), GFP_KERNEL);
> + if (!attr)
> + return -ENOMEM;
> +
> name = kstrdup(export_name, GFP_KERNEL);
> if (!name) {
> rc = -ENOMEM;
>
Christophe
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] powerpc/powernv: add NULL check after kzalloc in opal_add_one_export
2020-04-05 12:12 ` Christophe Leroy
@ 2020-04-05 12:20 ` Qiujun Huang
0 siblings, 0 replies; 3+ messages in thread
From: Qiujun Huang @ 2020-04-05 12:20 UTC (permalink / raw)
To: Christophe Leroy; +Cc: LKML, paulus, tglx, linuxppc-dev
On Sun, Apr 5, 2020 at 8:12 PM Christophe Leroy <christophe.leroy@c-s.fr> wrote:
>
>
>
> Le 05/04/2020 à 12:30, Qiujun Huang a écrit :
> > Here needs a NULL check.
> >
> > Issue found by coccinelle.
> >
> > Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
> > ---
> > arch/powerpc/platforms/powernv/opal.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
> > index 2b3dfd0b6cdd..5b98c98817aa 100644
> > --- a/arch/powerpc/platforms/powernv/opal.c
> > +++ b/arch/powerpc/platforms/powernv/opal.c
> > @@ -808,9 +808,12 @@ static int opal_add_one_export(struct kobject *parent, const char *export_name,
> >
> > rc = of_property_read_u64_array(np, prop_name, &vals[0], 2);
> > if (rc)
> > - goto out;
> > + return rc;
>
> Nice you changed that too.
>
> Then there is no need the initialise attr and name to NULL in their
> declaration, as they won't be used before they are assigned.
So that's it.
>
> >
> > attr = kzalloc(sizeof(*attr), GFP_KERNEL);
> > + if (!attr)
> > + return -ENOMEM;
> > +
> > name = kstrdup(export_name, GFP_KERNEL);
> > if (!name) {
> > rc = -ENOMEM;
> >
>
> Christophe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-05 12:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-05 10:30 [PATCH v2] powerpc/powernv: add NULL check after kzalloc in opal_add_one_export Qiujun Huang
2020-04-05 12:12 ` Christophe Leroy
2020-04-05 12:20 ` Qiujun Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox