* [PATCH -next] powerpc/papr_scm: Make some symbols static
@ 2020-07-25 9:19 Wei Yongjun
2020-07-27 7:26 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2020-07-25 9:19 UTC (permalink / raw)
To: Hulk Robot, Michael Ellerman, Aneesh Kumar K.V, Dan Williams,
Vaibhav Jain, Santosh Sivaraj
Cc: linuxppc-dev, Wei Yongjun, linux-kernel
The sparse tool complains as follows:
arch/powerpc/platforms/pseries/papr_scm.c:97:1: warning:
symbol 'papr_nd_regions' was not declared. Should it be static?
arch/powerpc/platforms/pseries/papr_scm.c:98:1: warning:
symbol 'papr_ndr_lock' was not declared. Should it be static?
Those variables are not used outside of papr_scm.c, so this
commit marks them static.
Fixes: 85343a8da2d9 ("powerpc/papr/scm: Add bad memory ranges to nvdimm bad ranges")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
arch/powerpc/platforms/pseries/papr_scm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c
index 8fd441d32487..3d1235a76ba9 100644
--- a/arch/powerpc/platforms/pseries/papr_scm.c
+++ b/arch/powerpc/platforms/pseries/papr_scm.c
@@ -94,8 +94,8 @@ struct papr_scm_priv {
u64 health_bitmap;
};
-LIST_HEAD(papr_nd_regions);
-DEFINE_MUTEX(papr_ndr_lock);
+static LIST_HEAD(papr_nd_regions);
+static DEFINE_MUTEX(papr_ndr_lock);
static int drc_pmem_bind(struct papr_scm_priv *p)
{
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] powerpc/papr_scm: Make some symbols static
2020-07-25 9:19 [PATCH -next] powerpc/papr_scm: Make some symbols static Wei Yongjun
@ 2020-07-27 7:26 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2020-07-27 7:26 UTC (permalink / raw)
To: Vaibhav Jain, Wei Yongjun, Dan Williams, Hulk Robot,
Michael Ellerman, Santosh Sivaraj, Aneesh Kumar K.V
Cc: linuxppc-dev, linux-kernel
On Sat, 25 Jul 2020 17:19:49 +0800, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> arch/powerpc/platforms/pseries/papr_scm.c:97:1: warning:
> symbol 'papr_nd_regions' was not declared. Should it be static?
> arch/powerpc/platforms/pseries/papr_scm.c:98:1: warning:
> symbol 'papr_ndr_lock' was not declared. Should it be static?
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/papr_scm: Make some symbols static
https://git.kernel.org/powerpc/c/19a551b254e6c308348a46a65332aa03c01767ed
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-27 7:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-25 9:19 [PATCH -next] powerpc/papr_scm: Make some symbols static Wei Yongjun
2020-07-27 7:26 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox