From: Pavel Machek <pavel@ucw.cz>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Ricardo Ribalda" <ribalda@kernel.org>,
"Jimmy Su" <jimmy.su@intel.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Sekhar Nori" <nsekhar@ti.com>,
"Gwendal Grignou" <gwendal@chromium.org>,
dri-devel@lists.freedesktop.org,
"Jaroslav Kysela" <perex@perex.cz>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Paul Mackerras" <paulus@samba.org>,
"Moses Christopher Bollavarapu" <mosescb.dev@gmail.com>,
"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Evgeniy Polyakov" <zbr@ioremap.net>,
"Matt Johnston" <matt@codeconstruct.com.au>,
"Olli Salonen" <olli.salonen@iki.fi>,
"Angela Czubak" <acz@semihalf.com>,
"Robert Marko" <robert.marko@sartura.hr>,
"Luka Perkov" <luka.perkov@sartura.hr>,
"Sean Young" <sean@mess.org>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"Zheyu Ma" <zheyuma97@gmail.com>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
linux-omap@vge
Subject: Re: [PATCH 6/6] i2c: Make remove callback return void
Date: Sun, 17 Jul 2022 14:35:51 +0200 [thread overview]
Message-ID: <20220717123551.GJ14285@duo.ucw.cz> (raw)
In-Reply-To: <20220628140313.74984-7-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: Type: text/plain, Size: 773 bytes --]
Hi!
> From: Uwe Kleine-König <uwe@kleine-koenig.org>
>
> The value returned by an i2c driver's remove function is mostly ignored.
> (Only an error message is printed if the value is non-zero that the
> error is ignored.)
>
> So change the prototype of the remove function to return no value. This
> way driver authors are not tempted to assume that passing an error to
> the upper layer is a good idea. All drivers are adapted accordingly.
> There is no intended change of behaviour, all callbacks were prepared to
> return 0 before.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
2-4: Acked-by: Pavel Machek <pavel@ucw.cz>
Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #3: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
prev parent reply other threads:[~2022-07-17 23:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 14:03 [PATCH 0/6] i2c: Make remove callback return void Uwe Kleine-König
2022-06-28 14:03 ` [PATCH 6/6] " Uwe Kleine-König
2022-06-29 6:56 ` Peter Senna Tschudin
2022-06-29 7:03 ` Jeremy Kerr
2022-06-29 7:23 ` Uwe Kleine-König
2022-06-29 7:37 ` Javier Martinez Canillas
2022-06-29 7:55 ` Christophe Leroy
2022-06-29 8:09 ` Javier Martinez Canillas
2022-06-29 7:21 ` Benjamin Mugnier
2022-06-29 7:24 ` Crt Mori
2022-06-29 7:43 ` Uwe Kleine-König
2022-06-29 7:27 ` Benjamin Mugnier
2022-06-29 7:40 ` Heikki Krogerus
2022-06-29 9:05 ` Greg Kroah-Hartman
2022-06-29 9:20 ` Marek Behún
2022-06-29 10:40 ` Andy Shevchenko
2022-06-29 13:11 ` Andrey Ryabinin
2022-06-29 13:35 ` Uwe Kleine-König
2022-06-29 14:25 ` Maximilian Luz
2022-06-29 14:31 ` srinivas pandruvada
2022-06-29 14:41 ` Hans Verkuil
2022-06-29 14:50 ` Miguel Ojeda
2022-06-29 21:20 ` Luca Ceresoli
2022-07-01 17:00 ` Jonathan Cameron
2022-07-01 18:18 ` Peter Rosin
2022-07-05 10:08 ` Jean Delvare
2022-07-05 10:36 ` Uwe Kleine-König
2022-07-06 9:13 ` Vladimir Oltean
2022-07-06 9:31 ` Uwe Kleine-König
2022-07-17 12:35 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220717123551.GJ14285@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=acz@semihalf.com \
--cc=andrew@lunn.ch \
--cc=benjamin.tissoires@redhat.com \
--cc=cw00.choi@samsung.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gwendal@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=javierm@redhat.com \
--cc=jimmy.su@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-omap@vge \
--cc=luka.perkov@sartura.hr \
--cc=matt@codeconstruct.com.au \
--cc=miquel.raynal@bootlin.com \
--cc=mosescb.dev@gmail.com \
--cc=nsekhar@ti.com \
--cc=olli.salonen@iki.fi \
--cc=paulus@samba.org \
--cc=perex@perex.cz \
--cc=ribalda@kernel.org \
--cc=robert.marko@sartura.hr \
--cc=s.nawrocki@samsung.com \
--cc=sean@mess.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=zbr@ioremap.net \
--cc=zheyuma97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox