* [PATCH] powerpc/64: Fix unannotated intra-function call warning
@ 2023-02-17 4:32 Sathvika Vasireddy
2023-02-17 5:32 ` Stephen Rothwell
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sathvika Vasireddy @ 2023-02-17 4:32 UTC (permalink / raw)
To: linuxppc-dev; +Cc: sfr, peterz, sv, naveen.n.rao, jpoimboe
objtool throws the following warning:
arch/powerpc/kernel/head_64.o: warning: objtool: .text+0x6128:
unannotated intra-function call
Fix the warning by annotating start_initialization_book3s symbol with the
SYM_FUNC_START_LOCAL and SYM_FUNC_END macros.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Sathvika Vasireddy <sv@linux.ibm.com>
---
arch/powerpc/kernel/head_64.S | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/head_64.S b/arch/powerpc/kernel/head_64.S
index 3a7266fa8a18..1febb56ebaeb 100644
--- a/arch/powerpc/kernel/head_64.S
+++ b/arch/powerpc/kernel/head_64.S
@@ -472,7 +472,7 @@ SYM_FUNC_START_LOCAL(__mmu_off)
b . /* prevent speculative execution */
SYM_FUNC_END(__mmu_off)
-start_initialization_book3s:
+SYM_FUNC_START_LOCAL(start_initialization_book3s)
mflr r25
/* Setup some critical 970 SPRs before switching MMU off */
@@ -494,6 +494,7 @@ start_initialization_book3s:
mtlr r25
blr
+SYM_FUNC_END(start_initialization_book3s)
#endif
/*
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] powerpc/64: Fix unannotated intra-function call warning
2023-02-17 4:32 [PATCH] powerpc/64: Fix unannotated intra-function call warning Sathvika Vasireddy
@ 2023-02-17 5:32 ` Stephen Rothwell
2023-02-17 7:07 ` Josh Poimboeuf
2023-02-20 3:49 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Stephen Rothwell @ 2023-02-17 5:32 UTC (permalink / raw)
To: Sathvika Vasireddy
Cc: peterz, Nicholas Piggin, naveen.n.rao, linuxppc-dev, jpoimboe
[-- Attachment #1: Type: text/plain, Size: 1477 bytes --]
Hi all,
On Fri, 17 Feb 2023 10:02:26 +0530 Sathvika Vasireddy <sv@linux.ibm.com> wrote:
>
> objtool throws the following warning:
> arch/powerpc/kernel/head_64.o: warning: objtool: .text+0x6128:
> unannotated intra-function call
>
> Fix the warning by annotating start_initialization_book3s symbol with the
> SYM_FUNC_START_LOCAL and SYM_FUNC_END macros.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Sathvika Vasireddy <sv@linux.ibm.com>
> ---
> arch/powerpc/kernel/head_64.S | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/head_64.S b/arch/powerpc/kernel/head_64.S
> index 3a7266fa8a18..1febb56ebaeb 100644
> --- a/arch/powerpc/kernel/head_64.S
> +++ b/arch/powerpc/kernel/head_64.S
> @@ -472,7 +472,7 @@ SYM_FUNC_START_LOCAL(__mmu_off)
> b . /* prevent speculative execution */
> SYM_FUNC_END(__mmu_off)
>
> -start_initialization_book3s:
> +SYM_FUNC_START_LOCAL(start_initialization_book3s)
> mflr r25
>
> /* Setup some critical 970 SPRs before switching MMU off */
> @@ -494,6 +494,7 @@ start_initialization_book3s:
>
> mtlr r25
> blr
> +SYM_FUNC_END(start_initialization_book3s)
> #endif
>
> /*
> --
> 2.31.1
>
That at least makes the warning go away for me.
Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 58f24eea5278 ("powerpc/64s: Refactor initialisation after prom")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] powerpc/64: Fix unannotated intra-function call warning
2023-02-17 4:32 [PATCH] powerpc/64: Fix unannotated intra-function call warning Sathvika Vasireddy
2023-02-17 5:32 ` Stephen Rothwell
@ 2023-02-17 7:07 ` Josh Poimboeuf
2023-02-20 3:49 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Josh Poimboeuf @ 2023-02-17 7:07 UTC (permalink / raw)
To: Sathvika Vasireddy; +Cc: sfr, peterz, naveen.n.rao, linuxppc-dev
On Fri, Feb 17, 2023 at 10:02:26AM +0530, Sathvika Vasireddy wrote:
> objtool throws the following warning:
> arch/powerpc/kernel/head_64.o: warning: objtool: .text+0x6128:
> unannotated intra-function call
>
> Fix the warning by annotating start_initialization_book3s symbol with the
> SYM_FUNC_START_LOCAL and SYM_FUNC_END macros.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Sathvika Vasireddy <sv@linux.ibm.com>
Suggested-by: Josh Poimboeuf <jpoimboe@kernel.org>
--
Josh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/64: Fix unannotated intra-function call warning
2023-02-17 4:32 [PATCH] powerpc/64: Fix unannotated intra-function call warning Sathvika Vasireddy
2023-02-17 5:32 ` Stephen Rothwell
2023-02-17 7:07 ` Josh Poimboeuf
@ 2023-02-20 3:49 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2023-02-20 3:49 UTC (permalink / raw)
To: linuxppc-dev, Sathvika Vasireddy; +Cc: peterz, sfr, naveen.n.rao, jpoimboe
On Fri, 17 Feb 2023 10:02:26 +0530, Sathvika Vasireddy wrote:
> objtool throws the following warning:
> arch/powerpc/kernel/head_64.o: warning: objtool: .text+0x6128:
> unannotated intra-function call
>
> Fix the warning by annotating start_initialization_book3s symbol with the
> SYM_FUNC_START_LOCAL and SYM_FUNC_END macros.
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/64: Fix unannotated intra-function call warning
https://git.kernel.org/powerpc/c/38d73b671a817328334f2a70a23fed4d1f4a952c
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-20 3:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-17 4:32 [PATCH] powerpc/64: Fix unannotated intra-function call warning Sathvika Vasireddy
2023-02-17 5:32 ` Stephen Rothwell
2023-02-17 7:07 ` Josh Poimboeuf
2023-02-20 3:49 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox