* [PATCH] Perf: Calling available function for stats printing
@ 2024-05-16 13:49 Abhishek Dubey
0 siblings, 0 replies; 3+ messages in thread
From: Abhishek Dubey @ 2024-05-16 13:49 UTC (permalink / raw)
To: linuxppc-dev; +Cc: naveen.n.rao, maddy, npiggin, Abhishek Dubey
For printing dump_trace, use existing stats_print()
function.
Signed-off-by: Abhishek Dubey <adubey@linux.ibm.com>
---
tools/perf/builtin-report.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index dcd93ee5fc24..3cabd5b0bfec 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -1088,10 +1088,7 @@ static int __cmd_report(struct report *rep)
perf_session__fprintf_dsos(session, stdout);
if (dump_trace) {
- perf_session__fprintf_nr_events(session, stdout,
- rep->skip_empty);
- evlist__fprintf_nr_events(session->evlist, stdout,
- rep->skip_empty);
+ stats_print(rep);
return 0;
}
}
--
2.44.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] Perf: Calling available function for stats printing
@ 2024-06-27 13:37 Abhishek Dubey
2024-06-27 17:17 ` Ian Rogers
0 siblings, 1 reply; 3+ messages in thread
From: Abhishek Dubey @ 2024-06-27 13:37 UTC (permalink / raw)
To: linuxppc-dev
Cc: mark.rutland, irogers, peterz, adrian.hunter, npiggin,
linux-kernel, linux-perf-users, alexander.shishkin, mingo, jolsa,
namhyung, naveen.n.rao, Abhishek Dubey
For printing dump_trace, just use existing stats_print()
function.
Signed-off-by: Abhishek Dubey <adubey@linux.ibm.com>
---
tools/perf/builtin-report.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 69618fb0110b..8678eebc49e6 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -1089,10 +1089,7 @@ static int __cmd_report(struct report *rep)
perf_session__fprintf_dsos(session, stdout);
if (dump_trace) {
- perf_session__fprintf_nr_events(session, stdout,
- rep->skip_empty);
- evlist__fprintf_nr_events(session->evlist, stdout,
- rep->skip_empty);
+ stats_print(rep);
return 0;
}
}
--
2.44.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Perf: Calling available function for stats printing
2024-06-27 13:37 [PATCH] Perf: Calling available function for stats printing Abhishek Dubey
@ 2024-06-27 17:17 ` Ian Rogers
0 siblings, 0 replies; 3+ messages in thread
From: Ian Rogers @ 2024-06-27 17:17 UTC (permalink / raw)
To: Abhishek Dubey
Cc: mark.rutland, peterz, adrian.hunter, npiggin, linux-kernel,
linux-perf-users, alexander.shishkin, mingo, jolsa, namhyung,
naveen.n.rao, linuxppc-dev, chu howard
On Thu, Jun 27, 2024 at 6:37 AM Abhishek Dubey <adubey@linux.ibm.com> wrote:
>
> For printing dump_trace, just use existing stats_print()
> function.
>
> Signed-off-by: Abhishek Dubey <adubey@linux.ibm.com>
Thanks Abishek, the change looks good but it needs to be rebased on
top of Commit 411ee13598ef ("perf hist: Add symbol_conf.skip_empty") -
https://lore.kernel.org/r/20240607202918.2357459-4-namhyung@kernel.org
. Recently Howard Chu wrote a guide on this:
https://sberm.cn/blog/how-to-contrib-perf
Another small issue is the commit message should be "perf report: ..."
rather than "Perf: ...".
Thanks,
Ian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-27 17:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-27 13:37 [PATCH] Perf: Calling available function for stats printing Abhishek Dubey
2024-06-27 17:17 ` Ian Rogers
-- strict thread matches above, loose matches on Subject: below --
2024-05-16 13:49 Abhishek Dubey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox