* [PATCH] bus: fsl-mc: Fix an API misuse in fsl_mc_device_add()
@ 2025-05-26 8:36 Haoxiang Li
2025-05-26 9:03 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Haoxiang Li @ 2025-05-26 8:36 UTC (permalink / raw)
To: ioana.ciornei, agraf, German.Rivera, stuart.yoder, gregkh
Cc: linuxppc-dev, linux-kernel, Haoxiang Li, stable
In fsl_mc_device_add(), use put_device() to give up the
device reference instead of kfree().
Fixes: bbf9d17d9875 ("staging: fsl-mc: Freescale Management Complex (fsl-mc) bus driver")
Cc: stable@vger.kernel.org
Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
---
drivers/bus/fsl-mc/fsl-mc-bus.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c
index a8be8cf246fb..dfd79ecf65b6 100644
--- a/drivers/bus/fsl-mc/fsl-mc-bus.c
+++ b/drivers/bus/fsl-mc/fsl-mc-bus.c
@@ -905,9 +905,7 @@ int fsl_mc_device_add(struct fsl_mc_obj_desc *obj_desc,
return 0;
error_cleanup_dev:
- kfree(mc_dev->regions);
- kfree(mc_bus);
- kfree(mc_dev);
+ put_device(&mc_dev->dev);
return error;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] bus: fsl-mc: Fix an API misuse in fsl_mc_device_add()
2025-05-26 8:36 [PATCH] bus: fsl-mc: Fix an API misuse in fsl_mc_device_add() Haoxiang Li
@ 2025-05-26 9:03 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2025-05-26 9:03 UTC (permalink / raw)
To: Haoxiang Li
Cc: ioana.ciornei, agraf, German.Rivera, stuart.yoder, linuxppc-dev,
linux-kernel, stable
On Mon, May 26, 2025 at 04:36:22PM +0800, Haoxiang Li wrote:
> In fsl_mc_device_add(), use put_device() to give up the
> device reference instead of kfree().
>
> Fixes: bbf9d17d9875 ("staging: fsl-mc: Freescale Management Complex (fsl-mc) bus driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
> ---
> drivers/bus/fsl-mc/fsl-mc-bus.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c
> index a8be8cf246fb..dfd79ecf65b6 100644
> --- a/drivers/bus/fsl-mc/fsl-mc-bus.c
> +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c
> @@ -905,9 +905,7 @@ int fsl_mc_device_add(struct fsl_mc_obj_desc *obj_desc,
> return 0;
>
> error_cleanup_dev:
> - kfree(mc_dev->regions);
> - kfree(mc_bus);
> - kfree(mc_dev);
> + put_device(&mc_dev->dev);
>
> return error;
> }
No, sorry, this is not corrrect at all. Always test your patches before
submitting them.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-26 12:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-26 8:36 [PATCH] bus: fsl-mc: Fix an API misuse in fsl_mc_device_add() Haoxiang Li
2025-05-26 9:03 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox