* [PATCH] fix the interrupt loss problem on powerpc IPIC (2.6.23)
@ 2009-02-17 12:44 dayu
2009-02-17 14:12 ` Kumar Gala
0 siblings, 1 reply; 6+ messages in thread
From: dayu @ 2009-02-17 12:44 UTC (permalink / raw)
To: LeoLi, linux-kernel; +Cc: linuxppc-dev
From: Da Yu <dayu@datangmobile.cn>
Date: Tue, 17 Feb 2009 19:58:20 +0800
Subject: [PATCH] fix the interrupt loss problem on powerpc IPIC (2.6.23)
Signed-off-by: Da Yu <dayu@datangmobile.cn>
---
--- a/arch/powerpc/sysdev/ipic.c 2009-02-17 15:10:18.000000000 +0800
+++ b/arch/powerpc/sysdev/ipic.c 2009-02-17 20:05:28.000000000 +0800
@@ -561,8 +561,7 @@ static void ipic_ack_irq(unsigned int vi
spin_lock_irqsave(&ipic_lock, flags);
- temp =3D ipic_read(ipic->regs, ipic_info[src].pend);
- temp |=3D (1 << (31 - ipic_info[src].bit));
+ temp =3D 1 << (31 - ipic_info[src].bit);
ipic_write(ipic->regs, ipic_info[src].pend, temp);
spin_unlock_irqrestore(&ipic_lock, flags);
@@ -581,8 +580,7 @@ static void ipic_mask_irq_and_ack(unsign
temp &=3D ~(1 << (31 - ipic_info[src].bit));
ipic_write(ipic->regs, ipic_info[src].mask, temp);
- temp =3D ipic_read(ipic->regs, ipic_info[src].pend);
- temp |=3D (1 << (31 - ipic_info[src].bit));
+ temp =3D 1 << (31 - ipic_info[src].bit);
ipic_write(ipic->regs, ipic_info[src].pend, temp);
spin_unlock_irqrestore(&ipic_lock, flags);
=20
-----=D3=CA=BC=FE=D4=AD=BC=FE-----
=B7=A2=BC=FE=C8=CB: Li Yang-R58472 [mailto:LeoLi@freescale.com]=20
=B7=A2=CB=CD=CA=B1=BC=E4: 2009=C4=EA2=D4=C217=C8=D5 18:17
=CA=D5=BC=FE=C8=CB: =F3=CE=D3=ED; linux-kernel@vger.kernel.org
=B3=AD=CB=CD: linuxppc-dev@ozlabs.org
=D6=F7=CC=E2: RE: PROBLEM: incorrect interrupt ack lead to interrupt =
loss on freescale powerpc
> -----Original Message-----
> From: dayu@datangmobile.cn [mailto:dayu@datangmobile.cn]
> Sent: Tuesday, February 17, 2009 4:34 PM
> To: linux-kernel@vger.kernel.org
> Cc: Li Yang-R58472
> Subject: PROBLEM: incorrect interrupt ack lead to interrupt loss on=20
> freescale powerpc
>=20
> =20
> [1.] One line summary of the problem: incorrect interrupt ack lead to =
> interrupt loss
Acked-by: Li Yang <leoli@freescale.com>
However, please resend the patch with a brief description and =
Signed-off-by at the top of the patch. You can read the =
Documentation/SubmittiongPatches for more information, or even a Chinese =
version under Documentation/zh_CN/.
Here are some small comments about the patch itself,
--- a/arch/powerpc/sysdev/ipic.c 2009-02-17 15:10:18.000000000 +0800
+++ b/arch/powerpc/sysdev/ipic.c 2009-02-17 15:10:24.000000000 +0800
@@ -9,6 +9,7 @@
* under the terms of the GNU General Public License as published by =
the
* Free Software Foundation; either version 2 of the License, or (at =
your
* option) any later version.
+ * Da Yu <dayu@datangmobile.cn> fixed the interrupt loss problem on=20
+ powerpc IPIC
It's not recommended to add changelog in the source now. Please =
describe in the patch description area.
*/
#include <linux/kernel.h>
#include <linux/init.h>
@@ -561,8 +562,7 @@
=20
spin_lock_irqsave(&ipic_lock, flags);
=20
- temp =3D ipic_read(ipic->regs, ipic_info[src].pend);
- temp |=3D (1 << (31 - ipic_info[src].bit));
+ temp =3D (1 << (31 - ipic_info[src].bit));
Remove unneeded brackets.
ipic_write(ipic->regs, ipic_info[src].pend, temp);
=20
spin_unlock_irqrestore(&ipic_lock, flags); @@ -581,8 +581,7 @@
temp &=3D ~(1 << (31 - ipic_info[src].bit));
ipic_write(ipic->regs, ipic_info[src].mask, temp);
=20
- temp =3D ipic_read(ipic->regs, ipic_info[src].pend);
- temp |=3D (1 << (31 - ipic_info[src].bit));
+ temp =3D (1 << (31 - ipic_info[src].bit));
Same as above.
ipic_write(ipic->regs, ipic_info[src].pend, temp);
=20
spin_unlock_irqrestore(&ipic_lock, flags);
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fix the interrupt loss problem on powerpc IPIC (2.6.23)
2009-02-17 12:44 [PATCH] fix the interrupt loss problem on powerpc IPIC (2.6.23) dayu
@ 2009-02-17 14:12 ` Kumar Gala
2009-02-17 14:32 ` Josh Boyer
2009-02-17 14:38 ` Li Yang
0 siblings, 2 replies; 6+ messages in thread
From: Kumar Gala @ 2009-02-17 14:12 UTC (permalink / raw)
To: <dayu@datangmobile.cn>; +Cc: linuxppc-dev, linux-kernel
On Feb 17, 2009, at 6:44 AM, <dayu@datangmobile.cn> <dayu@datangmobile.cn
> wrote:
> From: Da Yu <dayu@datangmobile.cn>
> Date: Tue, 17 Feb 2009 19:58:20 +0800
> Subject: [PATCH] fix the interrupt loss problem on powerpc IPIC
> (2.6.23)
>
> Signed-off-by: Da Yu <dayu@datangmobile.cn>
> ---
Please provide a bit more description as to why this fixes the issue.
- k
>
>
> --- a/arch/powerpc/sysdev/ipic.c 2009-02-17 15:10:18.000000000 +0800
> +++ b/arch/powerpc/sysdev/ipic.c 2009-02-17 20:05:28.000000000 +0800
> @@ -561,8 +561,7 @@ static void ipic_ack_irq(unsigned int vi
>
> spin_lock_irqsave(&ipic_lock, flags);
>
> - temp = ipic_read(ipic->regs, ipic_info[src].pend);
> - temp |= (1 << (31 - ipic_info[src].bit));
> + temp = 1 << (31 - ipic_info[src].bit);
> ipic_write(ipic->regs, ipic_info[src].pend, temp);
>
> spin_unlock_irqrestore(&ipic_lock, flags);
> @@ -581,8 +580,7 @@ static void ipic_mask_irq_and_ack(unsign
> temp &= ~(1 << (31 - ipic_info[src].bit));
> ipic_write(ipic->regs, ipic_info[src].mask, temp);
>
> - temp = ipic_read(ipic->regs, ipic_info[src].pend);
> - temp |= (1 << (31 - ipic_info[src].bit));
> + temp = 1 << (31 - ipic_info[src].bit);
> ipic_write(ipic->regs, ipic_info[src].pend, temp);
>
> spin_unlock_irqrestore(&ipic_lock, flags);
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fix the interrupt loss problem on powerpc IPIC (2.6.23)
2009-02-17 14:12 ` Kumar Gala
@ 2009-02-17 14:32 ` Josh Boyer
2009-02-17 14:55 ` Li Yang
2009-02-17 14:38 ` Li Yang
1 sibling, 1 reply; 6+ messages in thread
From: Josh Boyer @ 2009-02-17 14:32 UTC (permalink / raw)
To: dayu; +Cc: linuxppc-dev, linux-kernel
On Tue, Feb 17, 2009 at 08:12:33AM -0600, Kumar Gala wrote:
>
> On Feb 17, 2009, at 6:44 AM, <dayu@datangmobile.cn> <dayu@datangmobile.cn
> > wrote:
>
>> From: Da Yu <dayu@datangmobile.cn>
>> Date: Tue, 17 Feb 2009 19:58:20 +0800
>> Subject: [PATCH] fix the interrupt loss problem on powerpc IPIC
>> (2.6.23)
>>
>> Signed-off-by: Da Yu <dayu@datangmobile.cn>
>> ---
>
> Please provide a bit more description as to why this fixes the issue.
Including whether it still applies to mainline, since your topic seems
to indicate it's for 2.6.23. That is pretty old by now.
josh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fix the interrupt loss problem on powerpc IPIC (2.6.23)
2009-02-17 14:32 ` Josh Boyer
@ 2009-02-17 14:55 ` Li Yang
0 siblings, 0 replies; 6+ messages in thread
From: Li Yang @ 2009-02-17 14:55 UTC (permalink / raw)
To: Josh Boyer; +Cc: linuxppc-dev, dayu, linux-kernel
On Tue, Feb 17, 2009 at 10:32 PM, Josh Boyer <jwboyer@linux.vnet.ibm.com> wrote:
> On Tue, Feb 17, 2009 at 08:12:33AM -0600, Kumar Gala wrote:
>>
>> On Feb 17, 2009, at 6:44 AM, <dayu@datangmobile.cn> <dayu@datangmobile.cn
>> > wrote:
>>
>>> From: Da Yu <dayu@datangmobile.cn>
>>> Date: Tue, 17 Feb 2009 19:58:20 +0800
>>> Subject: [PATCH] fix the interrupt loss problem on powerpc IPIC
>>> (2.6.23)
>>>
>>> Signed-off-by: Da Yu <dayu@datangmobile.cn>
>>> ---
>>
>> Please provide a bit more description as to why this fixes the issue.
>
> Including whether it still applies to mainline, since your topic seems
> to indicate it's for 2.6.23. That is pretty old by now.
The problem still exists in mainline. But the patch doesn't seem to apply.
Dayu,
Could you re-spin the patch for the latest kernel? Thanks.
- Leo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fix the interrupt loss problem on powerpc IPIC (2.6.23)
2009-02-17 14:12 ` Kumar Gala
2009-02-17 14:32 ` Josh Boyer
@ 2009-02-17 14:38 ` Li Yang
2009-02-17 14:43 ` Kumar Gala
1 sibling, 1 reply; 6+ messages in thread
From: Li Yang @ 2009-02-17 14:38 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev, <dayu@datangmobile.cn>, linux-kernel
On Tue, Feb 17, 2009 at 10:12 PM, Kumar Gala <galak@kernel.crashing.org> wrote:
>
> On Feb 17, 2009, at 6:44 AM, <dayu@datangmobile.cn> <dayu@datangmobile.cn>
> wrote:
>
>> From: Da Yu <dayu@datangmobile.cn>
>> Date: Tue, 17 Feb 2009 19:58:20 +0800
>> Subject: [PATCH] fix the interrupt loss problem on powerpc IPIC (2.6.23)
>>
>> Signed-off-by: Da Yu <dayu@datangmobile.cn>
>> ---
>
> Please provide a bit more description as to why this fixes the issue.
The pending register is write 1 clear. If there are more than one
external interrupts pending at the same time, acking the first
interrupt will also clear other interrupt pending bits. That will
cause loss of interrupt.
- Leo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fix the interrupt loss problem on powerpc IPIC (2.6.23)
2009-02-17 14:38 ` Li Yang
@ 2009-02-17 14:43 ` Kumar Gala
0 siblings, 0 replies; 6+ messages in thread
From: Kumar Gala @ 2009-02-17 14:43 UTC (permalink / raw)
To: Li Yang; +Cc: linuxppc-dev, <dayu@datangmobile.cn>, linux-kernel
On Feb 17, 2009, at 8:38 AM, Li Yang wrote:
> On Tue, Feb 17, 2009 at 10:12 PM, Kumar Gala <galak@kernel.crashing.org
> > wrote:
>>
>> On Feb 17, 2009, at 6:44 AM, <dayu@datangmobile.cn> <dayu@datangmobile.cn
>> >
>> wrote:
>>
>>> From: Da Yu <dayu@datangmobile.cn>
>>> Date: Tue, 17 Feb 2009 19:58:20 +0800
>>> Subject: [PATCH] fix the interrupt loss problem on powerpc IPIC
>>> (2.6.23)
>>>
>>> Signed-off-by: Da Yu <dayu@datangmobile.cn>
>>> ---
>>
>> Please provide a bit more description as to why this fixes the issue.
>
> The pending register is write 1 clear. If there are more than one
> external interrupts pending at the same time, acking the first
> interrupt will also clear other interrupt pending bits. That will
> cause loss of interrupt.
>
> - Leo
Thanks. That should be included in the commit message.
- k
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-02-17 14:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-17 12:44 [PATCH] fix the interrupt loss problem on powerpc IPIC (2.6.23) dayu
2009-02-17 14:12 ` Kumar Gala
2009-02-17 14:32 ` Josh Boyer
2009-02-17 14:55 ` Li Yang
2009-02-17 14:38 ` Li Yang
2009-02-17 14:43 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox