LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Documentation/ABI: hv_24x7: Fix the catalog_len attribute name
@ 2026-09-05 10:30 Karl Mehltretter
  2026-09-09 10:44 ` Tanushree Shah
  0 siblings, 1 reply; 2+ messages in thread
From: Karl Mehltretter @ 2026-09-05 10:30 UTC (permalink / raw)
  To: Madhavan Srinivasan; +Cc: Karl Mehltretter, Michael Ellerman, linuxppc-dev

arch/powerpc/perf/hv-24x7.c creates the attribute as catalog_len
(PAGE_0_ATTR(catalog_len, ...)); the ABI file has documented it as
catalog_length since it was written.

Use catalog_len.

Fixes: ad0a02b83477 ("powerpc/perf/hv_{gpci, 24x7}: Add documentation of device attributes")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
 .../ABI/testing/sysfs-bus-event_source-devices-hv_24x7          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/ABI/testing/sysfs-bus-event_source-devices-hv_24x7 b/Documentation/ABI/testing/sysfs-bus-event_source-devices-hv_24x7
index de390a010af8..9b231c80ea66 100644
--- a/Documentation/ABI/testing/sysfs-bus-event_source-devices-hv_24x7
+++ b/Documentation/ABI/testing/sysfs-bus-event_source-devices-hv_24x7
@@ -33,7 +33,7 @@ Description:
 		documented here:
 		https://raw.githubusercontent.com/jmesmon/catalog-24x7/master/hv-24x7-catalog.h
 
-What:		/sys/bus/event_source/devices/hv_24x7/interface/catalog_length
+What:		/sys/bus/event_source/devices/hv_24x7/interface/catalog_len
 Date:		February 2014
 Contact:	Linux on PowerPC Developer List <linuxppc-dev@lists.ozlabs.org>
 Description:
-- 
2.53.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Documentation/ABI: hv_24x7: Fix the catalog_len attribute name
  2026-09-05 10:30 [PATCH] Documentation/ABI: hv_24x7: Fix the catalog_len attribute name Karl Mehltretter
@ 2026-09-09 10:44 ` Tanushree Shah
  0 siblings, 0 replies; 2+ messages in thread
From: Tanushree Shah @ 2026-09-09 10:44 UTC (permalink / raw)
  To: Karl Mehltretter, Madhavan Srinivasan; +Cc: Michael Ellerman, linuxppc-dev


On 05/09/26 16:00, Karl Mehltretter wrote:
> arch/powerpc/perf/hv-24x7.c creates the attribute as catalog_len
> (PAGE_0_ATTR(catalog_len, ...)); the ABI file has documented it as
> catalog_length since it was written.
> 
> Use catalog_len.

Checked against arch/powerpc/perf/hv-24x7.c - the attribute is indeed
registered via PAGE_0_ATTR(catalog_len, ...), which means the sysfs file 
has always been catalog_len. The ABI documentation's use of 
catalog_length has been incorrect since the original commit ad0a02b83477 
and has never matched the actual code.

The rename to catalog_len looks correct.

Reviewed-by: Tanushree Shah <tshah@linux.ibm.com>


Thanks
Tanushree Shah
> 
> Fixes: ad0a02b83477 ("powerpc/perf/hv_{gpci, 24x7}: Add documentation of device attributes")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
>   .../ABI/testing/sysfs-bus-event_source-devices-hv_24x7          | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-event_source-devices-hv_24x7 b/Documentation/ABI/testing/sysfs-bus-event_source-devices-hv_24x7
> index de390a010af8..9b231c80ea66 100644
> --- a/Documentation/ABI/testing/sysfs-bus-event_source-devices-hv_24x7
> +++ b/Documentation/ABI/testing/sysfs-bus-event_source-devices-hv_24x7
> @@ -33,7 +33,7 @@ Description:
>   		documented here:
>   		https://raw.githubusercontent.com/jmesmon/catalog-24x7/master/hv-24x7-catalog.h
>   
> -What:		/sys/bus/event_source/devices/hv_24x7/interface/catalog_length
> +What:		/sys/bus/event_source/devices/hv_24x7/interface/catalog_len
>   Date:		February 2014
>   Contact:	Linux on PowerPC Developer List <linuxppc-dev@lists.ozlabs.org>
>   Description:



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-09 10:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-05 10:30 [PATCH] Documentation/ABI: hv_24x7: Fix the catalog_len attribute name Karl Mehltretter
2026-09-09 10:44 ` Tanushree Shah

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox