From: Mark Brown <broonie@kernel.org>
To: Shengjiu Wang <shengjiu.wang@gmail.com>
Cc: Shengjiu Wang <shengjiu.wang@nxp.com>,
Xiubo.Lee@gmail.com, festevam@gmail.com, nicoleotsuka@gmail.com,
lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: fsl_micfil: Add DC output remover control
Date: Tue, 21 Apr 2026 14:00:56 +0100 [thread overview]
Message-ID: <2b26c51c-d90b-4a47-99ca-652edd7f1f4e@sirena.org.uk> (raw)
In-Reply-To: <CAA+D8AN3kmU-FDHF-kb47=ayXbypka+Q0vO-i2Bpzq1GSABuQQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 764 bytes --]
On Tue, Apr 21, 2026 at 03:40:12PM +0800, Shengjiu Wang wrote:
> On Mon, Apr 20, 2026 at 8:50 PM Mark Brown <broonie@kernel.org> wrote:
> > > + /* Update DC Remover mode for all channels */
> > > + ret = snd_soc_component_update_bits(comp, REG_MICFIL_DC_OUT_CTRL,
> > > + MICFIL_DC_CTRL_CONFIG, reg_val);
> > This will return 0 not 1 when the value changes, meaning event
> > generation is missed. The mixer-test selftest should report this.
> snd_soc_component_update_bits() will return 1 if the value is changed.
> and the mixer-test pass
Ah, so it will - I'm used to the regmap one which doesn't do that and
instead has a separate function to get a bool back for changes. The
code is fine
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-04-21 13:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 8:53 [PATCH] ASoC: fsl_micfil: Add DC output remover control Shengjiu Wang
2026-04-20 12:50 ` Mark Brown
2026-04-21 7:40 ` Shengjiu Wang
2026-04-21 13:00 ` Mark Brown [this message]
2026-04-26 21:49 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b26c51c-d90b-4a47-99ca-652edd7f1f4e@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=shengjiu.wang@gmail.com \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox