From: Mark Brown <broonie@kernel.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com,
nicoleotsuka@gmail.com, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, linux-sound@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: fsl_micfil: Add DC output remover control
Date: Mon, 20 Apr 2026 13:50:26 +0100 [thread overview]
Message-ID: <6c6f94b1-a4fa-418a-b471-8e3c82305233@sirena.org.uk> (raw)
In-Reply-To: <20260420085344.2081805-1-shengjiu.wang@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 733 bytes --]
On Mon, Apr 20, 2026 at 04:53:44PM +0800, Shengjiu Wang wrote:
> +static int micfil_put_dc_out_remover_state(struct snd_kcontrol *kcontrol,
> + struct snd_ctl_elem_value *ucontrol)
> +{
> + if (val < 0 || val > 3)
> + return -EINVAL;
> +
> + ret = pm_runtime_resume_and_get(comp->dev);
> + if (ret)
> + return ret;
> +
> + micfil->dc_out_remover = val;
...
> + /* Update DC Remover mode for all channels */
> + ret = snd_soc_component_update_bits(comp, REG_MICFIL_DC_OUT_CTRL,
> + MICFIL_DC_CTRL_CONFIG, reg_val);
> +
> + pm_runtime_put_autosuspend(comp->dev);
> +
> + return ret;
This will return 0 not 1 when the value changes, meaning event
generation is missed. The mixer-test selftest should report this.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-04-20 12:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 8:53 [PATCH] ASoC: fsl_micfil: Add DC output remover control Shengjiu Wang
2026-04-20 12:50 ` Mark Brown [this message]
2026-04-21 7:40 ` Shengjiu Wang
2026-04-21 13:00 ` Mark Brown
2026-04-26 21:49 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c6f94b1-a4fa-418a-b471-8e3c82305233@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=shengjiu.wang@gmail.com \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox