LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
To: Randy Dunlap <rdunlap@infradead.org>, linux-sound@vger.kernel.org
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Shengjiu Wang <shengjiu.wang@gmail.com>,
	Xiubo Li <Xiubo.Lee@gmail.com>,
	Fabio Estevam <festevam@gmail.com>,
	Nicolin Chen <nicoleotsuka@gmail.com>,
	linuxppc-dev@lists.ozlabs.org,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	Maciej Strozek <mstrozek@opensource.cirrus.com>,
	Bard Liao <yung-chuan.liao@linux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
	patches@opensource.cirrus.com,
	Srinivas Kandagatla <srini@kernel.org>,
	linux-arm-msm@vger.kernel.org,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 13/14] ASoC: qcom: audioreach: use C-style "/*" comment
Date: Tue, 14 Jul 2026 09:05:41 +0100	[thread overview]
Message-ID: <3492f6ff-84c2-4694-a677-500320cf1f5f@oss.qualcomm.com> (raw)
In-Reply-To: <20260714014445.569992-14-rdunlap@infradead.org>



On 7/14/26 2:44 AM, Randy Dunlap wrote:
> Modify the "/**" to use "/*" instead since this is not a kernel-doc
> comment. This avoids all kernel-doc warnings in this header file:
> 
> Warning: include/uapi/sound/snd_ar_tokens.h:61 Cannot find identifier on line:
>  * %AR_TKN_U32_SUB_GRAPH_INSTANCE_ID:           Sub Graph Instance Id
> Warning: ../include/uapi/sound/snd_ar_tokens.h:62 Cannot find identifier on line: *
> Warning: ../include/uapi/sound/snd_ar_tokens.h:63 Cannot find identifier on line:
>  * %AR_TKN_U32_SUB_GRAPH_PERF_MODE:             Performance mode of subgraph
> Warning: include/uapi/sound/snd_ar_tokens.h:64 This comment starts with '/**', but isn't a kernel-doc comment.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>


Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>

--srini
> ---
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Srinivas Kandagatla <srini@kernel.org>
> Cc: linux-arm-msm@vger.kernel.org
> 
>  include/uapi/sound/snd_ar_tokens.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linext-2026-0710.orig/include/uapi/sound/snd_ar_tokens.h
> +++ linext-2026-0710/include/uapi/sound/snd_ar_tokens.h
> @@ -58,7 +58,7 @@ enum ar_event_types {
>  #define SND_SOC_AR_TPLG_FE_BE_GRAPH_CTL_MIX	256
>  #define SND_SOC_AR_TPLG_VOL_CTL			257
>  
> -/**
> +/*
>   * %AR_TKN_U32_SUB_GRAPH_INSTANCE_ID:		Sub Graph Instance Id
>   *
>   * %AR_TKN_U32_SUB_GRAPH_PERF_MODE:		Performance mode of subgraph



  reply	other threads:[~2026-07-14  8:05 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14  1:44 [PATCH 00/14] ASoC: clean up kernel-doc warnings Randy Dunlap
2026-07-14  1:44 ` [PATCH 01/14] ASoC: codecs: NeoFidelity: repair the kernel-doc format Randy Dunlap
2026-07-14 10:20   ` Mark Brown
2026-07-14 15:57     ` Randy Dunlap
2026-07-14 16:02       ` Randy Dunlap
2026-07-14 17:09       ` Mark Brown
2026-07-14  1:44 ` [PATCH 02/14] ASoC: fsl_asrc_common: fix all kernel-doc warnings Randy Dunlap
2026-07-14  1:44 ` [PATCH 03/14] ASoC: fsl_asrc: avoid " Randy Dunlap
2026-07-14  1:44 ` [PATCH 04/14] ASoC: fsl-dma: fix all " Randy Dunlap
2026-07-14  1:44 ` [PATCH 05/14] ASoC: fsl_easrc: use struct keyword on structs Randy Dunlap
2026-07-14  1:44 ` [PATCH 06/14] ASoC: fsl: mpc5200_dma: use the struct keyword for kernel-doc comments Randy Dunlap
2026-07-14  1:44 ` [PATCH 07/14] ASoC: fsl: mpc5200_psc_i2s: avoid kernel-doc warnings Randy Dunlap
2026-07-14  1:44 ` [PATCH 08/14] ASoC: fsl: p1022_ds: repair kernel-doc short descriptions Randy Dunlap
2026-07-14  1:44 ` [PATCH 09/14] ASoC: uniphier: don't use "/**" for non-kernel-doc comment Randy Dunlap
2026-07-14  1:44 ` [PATCH 10/14] ASoC: SDCA: correct enum names and add a missing struct field Randy Dunlap
2026-07-14  8:40   ` Charles Keepax
2026-07-14  1:44 ` [PATCH 11/14] ASoC: soc-acpi: fix all kernel-doc warnings Randy Dunlap
2026-07-14  1:44 ` [PATCH 12/14] ASoC: Intel: Skylake: convert SKL_TKNS to kernel-doc format Randy Dunlap
2026-07-14  1:44 ` [PATCH 13/14] ASoC: qcom: audioreach: use C-style "/*" comment Randy Dunlap
2026-07-14  8:05   ` Srinivas Kandagatla [this message]
2026-07-14  1:44 ` [PATCH 14/14] ASoC: wm8904: don't use "/**" for non-kernel-doc comments Randy Dunlap
2026-07-14  8:41   ` Charles Keepax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3492f6ff-84c2-4694-a677-500320cf1f5f@oss.qualcomm.com \
    --to=srinivas.kandagatla@oss.qualcomm.com \
    --cc=Xiubo.Lee@gmail.com \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=festevam@gmail.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mstrozek@opensource.cirrus.com \
    --cc=nicoleotsuka@gmail.com \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=rdunlap@infradead.org \
    --cc=shengjiu.wang@gmail.com \
    --cc=srini@kernel.org \
    --cc=tiwai@suse.com \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox