Re: [PATCH] powerpc: Watchdog timer support for GE Fanuc SBC610

[Kumar Gala <galak@kernel.crashing.org>]

On Nov 7, 2008, at 9:16 AM, Martyn Welch wrote:

> On Fri, 7 Nov 2008 08:44:45 -0600
> Kumar Gala <galak@kernel.crashing.org> wrote:
>>
>> On Nov 7, 2008, at 8:38 AM, Martyn Welch wrote:
>>
>>> Support for the SBC610 VPX Single Baord Computer from GE Fanuc
>>> (PowerPC
>>> MPC8641D).
>>>
>>> This patch adds support for the watchdog timer in the devices main
>>> FPGA.
>>> There are two identical watchdog timers at different offsets in the
>>> main
>>> FPGA, this driver is capable of supporting one of them. The watchdog
>>> timers
>>> are also capable of generating interrupts at a user-configurable
>>> threshold,
>>> though support for this operation is currently not supported by the
>>> driver.
>>>
>>> Signed-off-by: Martyn Welch <martyn.welch@gefanuc.com>
>>> ---
>>>
>>> arch/powerpc/boot/dts/gef_sbc610.dts           |   19 +
>>> arch/powerpc/configs/86xx/gef_sbc610_defconfig |    1
>>> drivers/watchdog/Kconfig                       |    6
>>> drivers/watchdog/Makefile                      |    1
>>> drivers/watchdog/gef_wdt.c                     |  333 +++++++++++++ 
>>> ++
>>> +++++++++
>>> 5 files changed, 360 insertions(+), 0 deletions(-)
>>
>> Can you break this into two patches.  One for the driver and one for
>> the arch/powerpc stuff.  the driver should go via the watchdog
>> maintainer (and CC that list).
>>
>
> Yeah - sorry, didn't think about that.
>
> Thinking about it, the driver is specific to GEF Fanuc boards,  
> should this be
> going into drivers/watchdog/ or would it be better for me to move it  
> to
> arch/powerpc?

It should still be in drivers/watchdog.

- k