[FSL P50x0] DPAA Ethernet issue

[FSL P50x0] DPAA Ethernet issue

[Christian Zigotzky]

Hi All,

The DPAA Ethernet doesn’t work anymore on our FSL P5020/P5040 boards [1] 
since the first updates after the final kernel 6.1 [2].
We bisected yesterday [3] and found the problematic commit [4]. I was 
able to revert it. After that the DPAA Ethernet works again. I created a 
patch for reverting the commit [4]. After patching and compiling, the 
DPAA Ethernet also works again.

It seems, that the new driver doesn’t work with our onboard DPAA network 
interfaces.

Could you please check your commit? [4]

Thanks,
Christian

[1] http://wiki.amiga.org/index.php?title=X5000
[2] https://forum.hyperion-entertainment.com/viewtopic.php?p=56326#p56326
[3] https://forum.hyperion-entertainment.com/viewtopic.php?p=56334#p56334
[4] lnet: dpaa: Convert to phylink: 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.1&id=5d93cfcf7360eac9903774fe94f626c9ead2049d

Re: [FSL P50x0] DPAA Ethernet issue

[Sean Anderson]

[-- Attachment #1: Type: text/plain, Size: 2378 bytes --]

Hi Christian,

+CC netdev folks

> Hi All,
> 
> The DPAA Ethernet doesn’t work anymore on our FSL P5020/P5040 boards [1] 
> since the first updates after the final kernel 6.1 [2].
> We bisected yesterday [3] and found the problematic commit [4]. I was 
> able to revert it. After that the DPAA Ethernet works again. I created a 
> patch for reverting the commit [4]. After patching and compiling, the 
> DPAA Ethernet also works again.

Thank you for testing this. Unfortunately, I have no P-series hardware,
so I was unable to test the 10gec/dtsec parts of this conversion. I had
hoped that this would get tested by someone with the hardware (at NXP)
before now, but it seems you get to be the "lucky" first user.

I see you have labeled one of your kernels as supporting QEMU.  Do you
happen to have instructions for running Linux on QEMU?

> It seems, that the new driver doesn’t work with our onboard DPAA network 
> interfaces.
> 
> Could you please check your commit? [4]

Can you try the following patch. I think my mail client will mangle it,
so I have also attached it to this email.

 From 3898c62106025209b26527ad1516b339eebb62f1 Mon Sep 17 00:00:00 2001
From: Sean Anderson <seanga2@gmail.com>
Date: Sun, 1 Jan 2023 13:00:21 -0500
Subject: [PATCH] net: dpaa: Fix dtsec check for PCS availability

We want to fail if the PCS is not available, not if it is available. Fix
this condition.

Fixes: 5d93cfcf7360 ("net: dpaa: Convert to phylink")
Reported-by: Christian Zigotzky <info@xenosoft.de>
Signed-off-by: Sean Anderson <seanga2@gmail.com>
---
  drivers/net/ethernet/freescale/fman/fman_dtsec.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/fman/fman_dtsec.c b/drivers/net/ethernet/freescale/fman/fman_dtsec.c
index 3c87820ca202..3462f2b78680 100644
--- a/drivers/net/ethernet/freescale/fman/fman_dtsec.c
+++ b/drivers/net/ethernet/freescale/fman/fman_dtsec.c
@@ -1431,7 +1431,7 @@ int dtsec_initialization(struct mac_device *mac_dev,
  	dtsec->dtsec_drv_param->tx_pad_crc = true;
  
  	phy_node = of_parse_phandle(mac_node, "tbi-handle", 0);
-	if (!phy_node || of_device_is_available(phy_node)) {
+	if (!phy_node || !of_device_is_available(phy_node)) {
  		of_node_put(phy_node);
  		err = -EINVAL;
  		dev_err_probe(mac_dev->dev, err,
-- 
2.37.1

[-- Attachment #2: 0001-net-dpaa-Fix-dtsec-check-for-PCS-availability.patch --]
[-- Type: text/x-patch, Size: 1213 bytes --]

From 3898c62106025209b26527ad1516b339eebb62f1 Mon Sep 17 00:00:00 2001
From: Sean Anderson <seanga2@gmail.com>
Date: Sun, 1 Jan 2023 13:00:21 -0500
Subject: [PATCH] net: dpaa: Fix dtsec check for PCS availability

We want to fail if the PCS is not available, not if it is available. Fix
this condition.

Fixes: 5d93cfcf7360 ("net: dpaa: Convert to phylink")
Reported-by: Christian Zigotzky <info@xenosoft.de>
Signed-off-by: Sean Anderson <seanga2@gmail.com>
---
 drivers/net/ethernet/freescale/fman/fman_dtsec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/fman/fman_dtsec.c b/drivers/net/ethernet/freescale/fman/fman_dtsec.c
index 3c87820ca202..3462f2b78680 100644
--- a/drivers/net/ethernet/freescale/fman/fman_dtsec.c
+++ b/drivers/net/ethernet/freescale/fman/fman_dtsec.c
@@ -1431,7 +1431,7 @@ int dtsec_initialization(struct mac_device *mac_dev,
 	dtsec->dtsec_drv_param->tx_pad_crc = true;
 
 	phy_node = of_parse_phandle(mac_node, "tbi-handle", 0);
-	if (!phy_node || of_device_is_available(phy_node)) {
+	if (!phy_node || !of_device_is_available(phy_node)) {
 		of_node_put(phy_node);
 		err = -EINVAL;
 		dev_err_probe(mac_dev->dev, err,
-- 
2.37.1

Re: [FSL P50x0] DPAA Ethernet issue

[Christian Zigotzky]

On 01 January 2023 at 07:11 pm, Sean Anderson wrote:

Thank you for testing this. Unfortunately, I have no P-series hardware,
so I was unable to test the 10gec/dtsec parts of this conversion. I had
hoped that this would get tested by someone with the hardware (at NXP)
before now, but it seems you get to be the "lucky" first user.

I see you have labeled one of your kernels as supporting QEMU.  Do you
happen to have instructions for running Linux on QEMU?

Can you try the following patch. I think my mail client will mangle it,  
so I have also attached it to this email.

------------

Hi Sean,

Thanks a lot for your answer.

I use the virtio-net device in a virtual e5500 QEMU/KVM HV machine. [1] [2]

I will test your patch as soon as possible.

Thanks,
Christian

[1] QEMU command: qemu-system-ppc64 -M ppce500 -cpu e5500 -m 1024 
-kernel uImage-6.2 -drive 
format=raw,file=void-live-powerpc-20220129.img,index=0,if=virtio -netdev 
user,id=mynet0 -device virtio-net,netdev=mynet0 -append "rw 
root=/dev/vda2" -device virtio-gpu -device virtio-mouse-pci -device 
virtio-keyboard-pci -device pci-ohci,id=newusb -audiodev 
id=sndbe,driver=pa,server=/run/user/1000/pulse/native -device 
usb-audio,bus=newusb.0 -enable-kvm -smp 4 -fsdev 
local,security_model=passthrough,id=fsdev0,path=/home/amigaone/Music 
-device virtio-9p-pci,id=fs0,fsdev=fsdev0,mount_tag=hostshare

[2] https://forum.hyperion-entertainment.com/viewtopic.php?p=46749

Re: [FSL P50x0] DPAA Ethernet issue

[Linux kernel regression tracking (#info)]

[TLDR: I'm adding this report to the list of tracked Linux kernel
regressions; all text you find below is based on a few templates
paragraphs you might have encountered already already in similar form.
See link in footer if these mails annoy you.]

On 01.01.23 15:18, Christian Zigotzky wrote:
> 
> The DPAA Ethernet doesn’t work anymore on our FSL P5020/P5040 boards [1]
> since the first updates after the final kernel 6.1 [2].
> We bisected yesterday [3] and found the problematic commit [4]. I was
> able to revert it. After that the DPAA Ethernet works again. I created a
> patch for reverting the commit [4]. After patching and compiling, the
> DPAA Ethernet also works again.
> 
> It seems, that the new driver doesn’t work with our onboard DPAA network
> interfaces.
> 
> Could you please check your commit? [4]
> 
> Thanks,
> Christian
> 
> [1] http://wiki.amiga.org/index.php?title=X5000
> [2] https://forum.hyperion-entertainment.com/viewtopic.php?p=56326#p56326
> [3] https://forum.hyperion-entertainment.com/viewtopic.php?p=56334#p56334
> [4] lnet: dpaa: Convert to phylink:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.1&id=5d93cfcf7360eac9903774fe94f626c9ead2049d

Thanks for the report. To be sure the issue doesn't fall through the
cracks unnoticed, I'm adding it to regzbot, the Linux kernel regression
tracking bot:

#regzbot ^introduced 5d93cfcf7360
#regzbot title lnet: dpaa: Ethernet issues
#regzbot ignore-activity

This isn't a regression? This issue or a fix for it are already
discussed somewhere else? It was fixed already? You want to clarify when
the regression started to happen? Or point out I got the title or
something else totally wrong? Then just reply and tell me -- ideally
while also telling regzbot about it, as explained by the page listed in
the footer of this mail.

Reminder for developers: When fixing the issue, add 'Link:' tags
pointing to the report (see page linked in footer for details).

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
-- 
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr

Annoyed by mails like this? Feel free to send them to /dev/null:
https://linux-regtracking.leemhuis.info/about/#infomails

Re: [FSL P50x0] DPAA Ethernet issue

[Christian Zigotzky]

On 02 January 2023 at 04:32 am, Christian Zigotzky wrote:
> On 01 January 2023 at 07:11 pm, Sean Anderson wrote:
>
> Thank you for testing this. Unfortunately, I have no P-series hardware,
> so I was unable to test the 10gec/dtsec parts of this conversion. I had
> hoped that this would get tested by someone with the hardware (at NXP)
> before now, but it seems you get to be the "lucky" first user.
>
> I see you have labeled one of your kernels as supporting QEMU.  Do you
> happen to have instructions for running Linux on QEMU?
>
> Can you try the following patch. I think my mail client will mangle 
> it,  so I have also attached it to this email.
>
> ------------
>
> Hi Sean,
>
> Thanks a lot for your answer.
>
> I use the virtio-net device in a virtual e5500 QEMU/KVM HV machine. 
> [1] [2]
>
> I will test your patch as soon as possible.
>
> Thanks,
> Christian
>
> [1] QEMU command: qemu-system-ppc64 -M ppce500 -cpu e5500 -m 1024 
> -kernel uImage-6.2 -drive 
> format=raw,file=void-live-powerpc-20220129.img,index=0,if=virtio 
> -netdev user,id=mynet0 -device virtio-net,netdev=mynet0 -append "rw 
> root=/dev/vda2" -device virtio-gpu -device virtio-mouse-pci -device 
> virtio-keyboard-pci -device pci-ohci,id=newusb -audiodev 
> id=sndbe,driver=pa,server=/run/user/1000/pulse/native -device 
> usb-audio,bus=newusb.0 -enable-kvm -smp 4 -fsdev 
> local,security_model=passthrough,id=fsdev0,path=/home/amigaone/Music 
> -device virtio-9p-pci,id=fs0,fsdev=fsdev0,mount_tag=hostshare
>
> [2] https://forum.hyperion-entertainment.com/viewtopic.php?p=46749

Hi Sean,

I tested your patch with the RC2 today but unfortunately the kernel 
doesn't link after compiling.

Error messages:

   LD      .tmp_vmlinux.kallsyms1
`.exit.text' referenced in section `__bug_table' of crypto/algboss.o: 
defined in discarded section `.exit.text' of crypto/algboss.o
`.exit.text' referenced in section `__bug_table' of crypto/algif_hash.o: 
defined in discarded section `.exit.text' of crypto/algif_hash.o
`.exit.text' referenced in section `__bug_table' of 
drivers/char/hw_random/core.o: defined in discarded section `.exit.text' 
of drivers/char/hw_random/core.o
make[1]: *** [scripts/Makefile.vmlinux:34: vmlinux] Error 1
make: *** [Makefile:1252: vmlinux] Error 2

Maybe it is not an issue because of the patch because the RC1 compilied 
and linked with the patch.

@Dave
Please test the RC1 with Sean's patch.

Download: http://www.xenosoft.de/uImage-6.2-dpaa-t1

sudo dmesg | grep -i dpaa

[    3.017121] fsl_dpaa_mac ffe4e8000.ethernet: FMan dTSEC version: 
0x08240101
[    3.017256] fsl_dpaa_mac ffe4e8000.ethernet: FMan MAC address: 
00:04:a3:6b:41:65
[    3.017534] fsl_dpaa_mac ffe4f0000.ethernet: 
of_get_mac_address(/soc@ffe000000/fman@400000/ethernet@f0000) failed
[    3.017745] fsl_dpaa_mac ffe4f0000.ethernet: of_get_phy_mode() for 
/soc@ffe000000/fman@400000/ethernet@f0000 failed. Defaulting to SGMII
[    3.017975] fsl_dpaa_mac: FMan XGEC version: 0x00010330
[    3.018293] fsl_dpaa_mac ffe5e8000.ethernet: FMan dTSEC version: 
0x08240101
[    3.018413] fsl_dpaa_mac ffe5e8000.ethernet: FMan MAC address: 
00:1e:c0:f8:01:59
[    3.018656] fsl_dpaa_mac ffe5f0000.ethernet: 
of_get_mac_address(/soc@ffe000000/fman@500000/ethernet@f0000) failed
[    3.018871] fsl_dpaa_mac ffe5f0000.ethernet: of_get_phy_mode() for 
/soc@ffe000000/fman@500000/ethernet@f0000 failed. Defaulting to SGMII
[    3.019099] fsl_dpaa_mac: FMan XGEC version: 0x00010330
[    3.021559] fsl_dpaa_mac ffe4e8000.ethernet eth0: Probed interface eth0
[    3.023358] fsl_dpaa_mac ffe4f0000.ethernet: Using random MAC 
address: 5e:d0:6f:2b:29:35
[    3.024041] fsl_dpaa_mac ffe4f0000.ethernet eth1: Probed interface eth1
[    3.026381] fsl_dpaa_mac ffe5e8000.ethernet eth2: Probed interface eth2
[    3.028199] fsl_dpaa_mac ffe5f0000.ethernet: Using random MAC 
address: c2:ec:b7:35:67:37
[    3.028878] fsl_dpaa_mac ffe5f0000.ethernet eth3: Probed interface eth3
[    7.543868] fsl_dpaa_mac ffe4e8000.ethernet eth0: PHY 
[mdio@ffe4e1120:03] driver [Generic PHY] (irq=POLL)
[    7.549774] fsl_dpaa_mac ffe4e8000.ethernet eth0: configuring for 
phy/rgmii link mode
[    7.583166] fsl_dpaa_mac ffe5e8000.ethernet eth2: PHY 
[mdio@ffe4e1120:07] driver [Generic PHY] (irq=POLL)
[    7.589079] fsl_dpaa_mac ffe5e8000.ethernet eth2: configuring for 
phy/rgmii link mode

Cheers,
Christian

Re: [FSL P50x0] DPAA Ethernet issue

[Christian Zigotzky]

[-- Attachment #1: Type: text/plain, Size: 2963 bytes --]



> On 3. Jan 2023, at 05:04, Christian Zigotzky <chzigotzky@xenosoft.de> wrote:
> 
> On 02 January 2023 at 04:32 am, Christian Zigotzky wrote:
>> On 01 January 2023 at 07:11 pm, Sean Anderson wrote:
>> 
>> Thank you for testing this. Unfortunately, I have no P-series hardware,
>> so I was unable to test the 10gec/dtsec parts of this conversion. I had
>> hoped that this would get tested by someone with the hardware (at NXP)
>> before now, but it seems you get to be the "lucky" first user.
>> 
>> I see you have labeled one of your kernels as supporting QEMU.  Do you
>> happen to have instructions for running Linux on QEMU?
>> 
>> Can you try the following patch. I think my mail client will mangle it,  so I have also attached it to this email.
>> 
>> ------------
>> 
>> Hi Sean,
>> 
>> Thanks a lot for your answer.
>> 
>> I use the virtio-net device in a virtual e5500 QEMU/KVM HV machine. [1] [2]
>> 
>> I will test your patch as soon as possible.
>> 
>> Thanks,
>> Christian
>> 
>> [1] QEMU command: qemu-system-ppc64 -M ppce500 -cpu e5500 -m 1024 -kernel uImage-6.2 -drive format=raw,file=void-live-powerpc-20220129.img,index=0,if=virtio -netdev user,id=mynet0 -device virtio-net,netdev=mynet0 -append "rw root=/dev/vda2" -device virtio-gpu -device virtio-mouse-pci -device virtio-keyboard-pci -device pci-ohci,id=newusb -audiodev id=sndbe,driver=pa,server=/run/user/1000/pulse/native -device usb-audio,bus=newusb.0 -enable-kvm -smp 4 -fsdev local,security_model=passthrough,id=fsdev0,path=/home/amigaone/Music -device virtio-9p-pci,id=fs0,fsdev=fsdev0,mount_tag=hostshare
>> 
>> [2] https://forum.hyperion-entertainment.com/viewtopic.php?p=46749
> 
> Hi Sean,
> 
> I tested your patch with the RC2 today but unfortunately the kernel doesn't link after compiling.
> 
> Error messages:
> 
>   LD      .tmp_vmlinux.kallsyms1
> `.exit.text' referenced in section `__bug_table' of crypto/algboss.o: defined in discarded section `.exit.text' of crypto/algboss.o
> `.exit.text' referenced in section `__bug_table' of crypto/algif_hash.o: defined in discarded section `.exit.text' of crypto/algif_hash.o
> `.exit.text' referenced in section `__bug_table' of drivers/char/hw_random/core.o: defined in discarded section `.exit.text' of drivers/char/hw_random/core.o
> make[1]: *** [scripts/Makefile.vmlinux:34: vmlinux] Error 1
> make: *** [Makefile:1252: vmlinux] Error 2
> 
> Maybe it is not an issue because of the patch because the RC1 compilied and linked with the patch.
> 
> @Dave
> Please test the RC1 with Sean's patch.
> 
> Download: http://www.xenosoft.de/uImage-6.2-dpaa-t1
> 
> Cheers,
> Christian

Hi Sean,

Dave successfully tested the DPAA Ethernet with the patched RC1 on his P5020 board (X5000) today.

Link to the test thread: https://forum.hyperion-entertainment.com/viewtopic.php?p=56360#p56360

Your patch has solved the issue. Thanks for your help.

Cheers,
Christian

[-- Attachment #2: Type: text/html, Size: 5129 bytes --]

Re: [FSL P50x0] DPAA Ethernet issue

[Sean Anderson]

On 1/2/23 02:58, Linux kernel regression tracking (#info) wrote:
> [TLDR: I'm adding this report to the list of tracked Linux kernel
> regressions; all text you find below is based on a few templates
> paragraphs you might have encountered already already in similar form.
> See link in footer if these mails annoy you.]
> 
> On 01.01.23 15:18, Christian Zigotzky wrote:
>> 
>> The DPAA Ethernet doesn’t work anymore on our FSL P5020/P5040 boards [1]
>> since the first updates after the final kernel 6.1 [2].
>> We bisected yesterday [3] and found the problematic commit [4]. I was
>> able to revert it. After that the DPAA Ethernet works again. I created a
>> patch for reverting the commit [4]. After patching and compiling, the
>> DPAA Ethernet also works again.
>> 
>> It seems, that the new driver doesn’t work with our onboard DPAA network
>> interfaces.
>> 
>> Could you please check your commit? [4]
>> 
>> Thanks,
>> Christian
>> 
>> [1] http://wiki.amiga.org/index.php?title=X5000
>> [2] https://forum.hyperion-entertainment.com/viewtopic.php?p=56326#p56326
>> [3] https://forum.hyperion-entertainment.com/viewtopic.php?p=56334#p56334
>> [4] lnet: dpaa: Convert to phylink:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.1&id=5d93cfcf7360eac9903774fe94f626c9ead2049d
> 
> Thanks for the report. To be sure the issue doesn't fall through the
> cracks unnoticed, I'm adding it to regzbot, the Linux kernel regression
> tracking bot:
> 
> #regzbot ^introduced 5d93cfcf7360
> #regzbot title lnet: dpaa: Ethernet issues
> #regzbot ignore-activity
> 
> This isn't a regression? This issue or a fix for it are already
> discussed somewhere else? It was fixed already? You want to clarify when
> the regression started to happen? Or point out I got the title or
> something else totally wrong? Then just reply and tell me -- ideally
> while also telling regzbot about it, as explained by the page listed in
> the footer of this mail.
> 
> Reminder for developers: When fixing the issue, add 'Link:' tags
> pointing to the report (see page linked in footer for details).
> 
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

#regzbot fix: 7dc618385419