From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Breno Leitao <leitao@debian.org>, linuxppc-dev@lists.ozlabs.org
Cc: Breno Leitao <leitao@debian.org>
Subject: Re: [1/9] powerpc/64s: Include cpu header
Date: Tue, 27 Nov 2018 20:22:17 +1100 (AEDT) [thread overview]
Message-ID: <433ywn5DdVz9s4s@ozlabs.org> (raw)
In-Reply-To: <1540220060-30162-1-git-send-email-leitao@debian.org>
On Mon, 2018-10-22 at 14:54:12 UTC, Breno Leitao wrote:
> Current powerpc security.c file is defining functions, as
> cpu_show_meltdown(), cpu_show_spectre_v{1,2} and others, that are being
> declared at linux/cpu.h header without including the header file that
> contains these declarations.
>
> This is being reported by sparse, which thinks that these functions are
> static, due to the lack of declaration:
>
> arch/powerpc/kernel/security.c:105:9: warning: symbol 'cpu_show_meltdown' was not declared. Should it be static?
> arch/powerpc/kernel/security.c:139:9: warning: symbol 'cpu_show_spectre_v1' was not declared. Should it be static?
> arch/powerpc/kernel/security.c:161:9: warning: symbol 'cpu_show_spectre_v2' was not declared. Should it be static?
> arch/powerpc/kernel/security.c:209:6: warning: symbol 'stf_barrier' was not declared. Should it be static?
> arch/powerpc/kernel/security.c:289:9: warning: symbol 'cpu_show_spec_store_bypass' was not declared. Should it be static?
>
> This patch simply includes the proper header (linux/cpu.h) to match
> function definition and declaration.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
Series applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/42e2acde1237878462b028f5a27d9c
cheers
prev parent reply other threads:[~2018-11-27 9:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 14:54 [PATCH 1/9] powerpc/64s: Include cpu header Breno Leitao
2018-10-22 14:54 ` [PATCH 2/9] powerpc/eeh: Declare pci_ers_result_name() as static Breno Leitao
2018-10-22 14:54 ` [PATCH 3/9] powerpc/mm: Remove extern from function definition Breno Leitao
2018-10-23 15:38 ` LEROY Christophe
2018-10-24 14:59 ` Breno Leitao
2018-10-24 15:12 ` LEROY Christophe
2018-10-31 14:43 ` Breno Leitao
2018-10-22 14:54 ` [PATCH 4/9] powerpc/xive: Define xive_do_source_eoi as static Breno Leitao
2018-10-22 14:54 ` [PATCH 5/9] powerpc/xmon: Define static functions Breno Leitao
2018-10-22 14:54 ` [PATCH 6/9] powerpc/lib: Declare static methods Breno Leitao
2018-10-22 14:54 ` [PATCH 7/9] powerpc/scom: Return NULL instead of 0 Breno Leitao
2018-10-22 14:54 ` [PATCH 8/9] powerpc/perf: Declare static identifier a such Breno Leitao
2018-10-22 14:54 ` [PATCH 9/9] powerpc/pkey: Define functions as static Breno Leitao
2018-11-27 9:22 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=433ywn5DdVz9s4s@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=leitao@debian.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox