LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: LEROY Christophe <christophe.leroy@c-s.fr>, mpe@ellerman.id.au
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 3/9] powerpc/mm: Remove extern from function definition
Date: Wed, 31 Oct 2018 11:43:25 -0300	[thread overview]
Message-ID: <8046a74f-6931-8f1a-6e27-57aeb04766c9@debian.org> (raw)
In-Reply-To: <20181024171228.Horde.g2r8Qp5NqN_pn0TW6sUFCw6@messagerie.si.c-s.fr>

Hi Christophe,

On 10/24/18 12:12 PM, LEROY Christophe wrote:
> Breno Leitao <leitao@debian.org> a écrit :
> 
>> hi Christophe,
>>
>> On 10/23/2018 12:38 PM, LEROY Christophe wrote:
>>> Breno Leitao <leitao@debian.org> a écrit :
>>>>
>>>> This patch removes the keyword from the definition part, while keeps
>>>> it in
>>>> the declaration part.
>>>
>>> I think checkpatch also says that extern should be avoided in
>>> declarations.
>>
>> Thanks for the review. I tried to look at this complain, but I didn't see
>> this behavior on checkpatch.pl from kernel 4.19. I created a commit
>> that adds
>> a new extern prototype and checked the patch. Take a look:
> 
> Use option --strict with checkpatch.pl

Thanks. I fixed this patch and resent a v2 with this fix.

Michael,

If you happen to accept this series, please ignore this patch (3/9) and
use a v2 as its replacement:

https://patchwork.ozlabs.org/patch/991444/

  reply	other threads:[~2018-10-31 14:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-22 14:54 [PATCH 1/9] powerpc/64s: Include cpu header Breno Leitao
2018-10-22 14:54 ` [PATCH 2/9] powerpc/eeh: Declare pci_ers_result_name() as static Breno Leitao
2018-10-22 14:54 ` [PATCH 3/9] powerpc/mm: Remove extern from function definition Breno Leitao
2018-10-23 15:38   ` LEROY Christophe
2018-10-24 14:59     ` Breno Leitao
2018-10-24 15:12       ` LEROY Christophe
2018-10-31 14:43         ` Breno Leitao [this message]
2018-10-22 14:54 ` [PATCH 4/9] powerpc/xive: Define xive_do_source_eoi as static Breno Leitao
2018-10-22 14:54 ` [PATCH 5/9] powerpc/xmon: Define static functions Breno Leitao
2018-10-22 14:54 ` [PATCH 6/9] powerpc/lib: Declare static methods Breno Leitao
2018-10-22 14:54 ` [PATCH 7/9] powerpc/scom: Return NULL instead of 0 Breno Leitao
2018-10-22 14:54 ` [PATCH 8/9] powerpc/perf: Declare static identifier a such Breno Leitao
2018-10-22 14:54 ` [PATCH 9/9] powerpc/pkey: Define functions as static Breno Leitao
2018-11-27  9:22 ` [1/9] powerpc/64s: Include cpu header Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8046a74f-6931-8f1a-6e27-57aeb04766c9@debian.org \
    --to=leitao@debian.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox