* [PATCH] powerpc/cell: set no_llseek in spufs_cntl_fops [not found] <ad61d4443d93fcfb442bd6367eefde3e04201bef.1493801155.git.geliangtang@gmail.com> @ 2017-05-06 15:37 ` Geliang Tang 2019-07-08 1:19 ` Michael Ellerman 0 siblings, 1 reply; 2+ messages in thread From: Geliang Tang @ 2017-05-06 15:37 UTC (permalink / raw) To: Jeremy Kerr, Arnd Bergmann, Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman Cc: Geliang Tang, linuxppc-dev, linux-kernel In spufs_cntl_fops, since we use nonseekable_open() to open, we should use no_llseek() to seek, not generic_file_llseek(). Signed-off-by: Geliang Tang <geliangtang@gmail.com> --- arch/powerpc/platforms/cell/spufs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/cell/spufs/file.c b/arch/powerpc/platforms/cell/spufs/file.c index ae2f740..738ef8d 100644 --- a/arch/powerpc/platforms/cell/spufs/file.c +++ b/arch/powerpc/platforms/cell/spufs/file.c @@ -456,7 +456,7 @@ static const struct file_operations spufs_cntl_fops = { .release = spufs_cntl_release, .read = simple_attr_read, .write = simple_attr_write, - .llseek = generic_file_llseek, + .llseek = no_llseek, .mmap = spufs_cntl_mmap, }; -- 2.9.3 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc/cell: set no_llseek in spufs_cntl_fops 2017-05-06 15:37 ` [PATCH] powerpc/cell: set no_llseek in spufs_cntl_fops Geliang Tang @ 2019-07-08 1:19 ` Michael Ellerman 0 siblings, 0 replies; 2+ messages in thread From: Michael Ellerman @ 2019-07-08 1:19 UTC (permalink / raw) To: Geliang Tang, Jeremy Kerr, Arnd Bergmann, Benjamin Herrenschmidt, Paul Mackerras Cc: Geliang Tang, linuxppc-dev, linux-kernel On Sat, 2017-05-06 at 15:37:20 UTC, Geliang Tang wrote: > In spufs_cntl_fops, since we use nonseekable_open() to open, we > should use no_llseek() to seek, not generic_file_llseek(). > > Signed-off-by: Geliang Tang <geliangtang@gmail.com> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/658829dfe75c49e879e0c4c9cbcd3bd1e4fbdcf5 cheers ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-08 2:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <ad61d4443d93fcfb442bd6367eefde3e04201bef.1493801155.git.geliangtang@gmail.com>
2017-05-06 15:37 ` [PATCH] powerpc/cell: set no_llseek in spufs_cntl_fops Geliang Tang
2019-07-08 1:19 ` Michael Ellerman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox