Re: 2.6.21-mm2 -- powerpc missing kset

Re: 2.6.21-mm2 -- powerpc missing kset

[Andy Whitcroft]

Getting this new compile failure on powerpc:

-apw

arch/powerpc/platforms/pseries/power.c:31: warning: `struct subsystem'
declared inside parameter list
arch/powerpc/platforms/pseries/power.c:31: warning: its scope is only
this definition or declaration, which is probably not what you want
arch/powerpc/platforms/pseries/power.c:37: warning: `struct subsystem'
declared inside parameter list
arch/powerpc/platforms/pseries/power.c:55: warning: initialization from
incompatible pointer type
arch/powerpc/platforms/pseries/power.c:56: warning: initialization from
incompatible pointer type
arch/powerpc/platforms/pseries/power.c: In function `pm_init':
arch/powerpc/platforms/pseries/power.c:75: error: structure has no
member named `kset'
make[2]: *** [arch/powerpc/platforms/pseries/power.o] Error 1
make[1]: *** [arch/powerpc/platforms/pseries] Error 2
make: *** [arch/powerpc/platforms] Error 2

Re: 2.6.21-mm2 -- powerpc missing kset

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

On Thu, 10 May 2007 12:48:28 +0100 Andy Whitcroft <apw@shadowen.org> wrote:
>
> arch/powerpc/platforms/pseries/power.c:31: warning: `struct subsystem'
> declared inside parameter list

There is no explicit reference to struct subsystem in the current version
of that file.

--
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: 2.6.21-mm2 -- powerpc missing kset

[Randy Dunlap]

On Thu, 10 May 2007 22:16:31 +1000 Stephen Rothwell wrote:

> On Thu, 10 May 2007 12:48:28 +0100 Andy Whitcroft <apw@shadowen.org> wrote:
> >
> > arch/powerpc/platforms/pseries/power.c:31: warning: `struct subsystem'
> > declared inside parameter list
> 
> There is no explicit reference to struct subsystem in the current version
> of that file.

There is in 2.6.21-mm2.  Are you saying that it's been fixed
somewhere else?  (where?)


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: 2.6.21-mm2 -- powerpc missing kset

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]

On Thu, 10 May 2007 08:48:02 -0700 Randy Dunlap <randy.dunlap@oracle.com> wrote:
>
> On Thu, 10 May 2007 22:16:31 +1000 Stephen Rothwell wrote:
>
> > On Thu, 10 May 2007 12:48:28 +0100 Andy Whitcroft <apw@shadowen.org> wrote:
> > >
> > > arch/powerpc/platforms/pseries/power.c:31: warning: `struct subsystem'
> > > declared inside parameter list
> >
> > There is no explicit reference to struct subsystem in the current version
> > of that file.
>
> There is in 2.6.21-mm2.  Are you saying that it's been fixed
> somewhere else?  (where?)

Linus' tree.  It was fixed by commit
823bccfc4002296ba88c3ad0f049e1abd8108d30 ('remove "struct subsystem" as
it is no longer needed') from Greg Kroah-Hartman dated 2007-04-14 which
was applied before v2.6.21-mm2 (according to gitk).

--
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]