LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] RapidIO: documentation update
@ 2011-09-15 13:19 Alexandre Bounine
  2011-09-17 10:05 ` Micha Nelissen
  0 siblings, 1 reply; 3+ messages in thread
From: Alexandre Bounine @ 2011-09-15 13:19 UTC (permalink / raw)
  To: akpm, linux-kernel, linuxppc-dev; +Cc: Alexandre Bounine, Liu Gang

Update rapidio.txt to reflect changes from recent patch.
See http://marc.info/?l=linux-kernel&m=131285620113589&w=2 for details.

Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com>
Cc: Liu Gang <Gang.Liu@freescale.com>
---
 Documentation/rapidio/rapidio.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Documentation/rapidio/rapidio.txt b/Documentation/rapidio/rapidio.txt
index be70ee1..c75694b 100644
--- a/Documentation/rapidio/rapidio.txt
+++ b/Documentation/rapidio/rapidio.txt
@@ -144,7 +144,7 @@ and the default device ID in order to access the device on the active port.
 
 After the host has completed enumeration of the entire network it releases
 devices by clearing device ID locks (calls rio_clear_locks()). For each endpoint
-in the system, it sets the Master Enable bit in the Port General Control CSR
+in the system, it sets the Discovered bit in the Port General Control CSR
 to indicate that enumeration is completed and agents are allowed to execute
 passive discovery of the network.
 
-- 
1.7.6

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] RapidIO: documentation update
  2011-09-15 13:19 [PATCH] RapidIO: documentation update Alexandre Bounine
@ 2011-09-17 10:05 ` Micha Nelissen
  2011-09-19  0:20   ` Bounine, Alexandre
  0 siblings, 1 reply; 3+ messages in thread
From: Micha Nelissen @ 2011-09-17 10:05 UTC (permalink / raw)
  To: Alexandre Bounine; +Cc: Liu Gang, akpm, linuxppc-dev, linux-kernel

Alexandre Bounine wrote:
>  After the host has completed enumeration of the entire network it releases
>  devices by clearing device ID locks (calls rio_clear_locks()). For each endpoint
> -in the system, it sets the Master Enable bit in the Port General Control CSR
> +in the system, it sets the Discovered bit in the Port General Control CSR
>  to indicate that enumeration is completed and agents are allowed to execute
>  passive discovery of the network.

The host needs to set both. Without Master Enable an agent is not
supposed to initiate transactions on the "bus", that's the meaning of
that bit.

Micha

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] RapidIO: documentation update
  2011-09-17 10:05 ` Micha Nelissen
@ 2011-09-19  0:20   ` Bounine, Alexandre
  0 siblings, 0 replies; 3+ messages in thread
From: Bounine, Alexandre @ 2011-09-19  0:20 UTC (permalink / raw)
  To: Micha Nelissen; +Cc: Liu Gang, akpm, linuxppc-dev, linux-kernel

Micha Nelissen wrote:
>=20
> Alexandre Bounine wrote:
> >  After the host has completed enumeration of the entire network it
releases
> >  devices by clearing device ID locks (calls rio_clear_locks()). For
each endpoint
> > -in the system, it sets the Master Enable bit in the Port General
Control CSR
> > +in the system, it sets the Discovered bit in the Port General
Control CSR
> >  to indicate that enumeration is completed and agents are allowed to
execute
> >  passive discovery of the network.
>=20
> The host needs to set both. Without Master Enable an agent is not
> supposed to initiate transactions on the "bus", that's the meaning of
> that bit.

This is correct and host set both bits: Master_Enable and Discovered.
The documentation change above is related to event that triggers
discovery process.
In this context the change shown above is sufficient.
Please see the original code patch submitted by Liu Gang.

Alex.
  =20

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-09-19  0:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-15 13:19 [PATCH] RapidIO: documentation update Alexandre Bounine
2011-09-17 10:05 ` Micha Nelissen
2011-09-19  0:20   ` Bounine, Alexandre

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox