* [PATCH] powerpc: Fix build failure when CONFIG_USB=y
@ 2014-08-21 13:16 Pranith Kumar
2014-09-16 4:12 ` Alistair Popple
0 siblings, 1 reply; 2+ messages in thread
From: Pranith Kumar @ 2014-08-21 13:16 UTC (permalink / raw)
To: Alistair Popple, Matt Porter, Benjamin Herrenschmidt,
Paul Mackerras, Michael Ellerman, open list:LINUX FOR POWERPC...,
open list
We are enabling USB unconditionally which results in following build failure
drivers/built-in.o: In function `tb_drom_read':
(.text+0x1b62b70): undefined reference to `usb_speed_string'
make: *** [vmlinux] Error
Enable USB only if USB_SUPPORT is set to avoid such failures
Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
---
arch/powerpc/platforms/44x/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig
index 3e7deb2..82f2da2 100644
--- a/arch/powerpc/platforms/44x/Kconfig
+++ b/arch/powerpc/platforms/44x/Kconfig
@@ -215,7 +215,7 @@ config AKEBONO
select NET_VENDOR_IBM
select IBM_EMAC_EMAC4
select IBM_EMAC_RGMII_WOL
- select USB
+ select USB if USB_SUPPORT
select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD
select USB_EHCI_HCD_PLATFORM if USB_EHCI_HCD
select MMC_SDHCI
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc: Fix build failure when CONFIG_USB=y
2014-08-21 13:16 [PATCH] powerpc: Fix build failure when CONFIG_USB=y Pranith Kumar
@ 2014-09-16 4:12 ` Alistair Popple
0 siblings, 0 replies; 2+ messages in thread
From: Alistair Popple @ 2014-09-16 4:12 UTC (permalink / raw)
To: Pranith Kumar; +Cc: open list, Paul Mackerras, open list:LINUX FOR POWERPC...
Thanks for fixing these!
Acked-by: Alistair Popple <alistair@popple.id.au>
On Thu, 21 Aug 2014 09:16:04 Pranith Kumar wrote:
> We are enabling USB unconditionally which results in following build failure
>
> drivers/built-in.o: In function `tb_drom_read':
> (.text+0x1b62b70): undefined reference to `usb_speed_string'
> make: *** [vmlinux] Error
>
> Enable USB only if USB_SUPPORT is set to avoid such failures
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> ---
> arch/powerpc/platforms/44x/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/44x/Kconfig
> b/arch/powerpc/platforms/44x/Kconfig index 3e7deb2..82f2da2 100644
> --- a/arch/powerpc/platforms/44x/Kconfig
> +++ b/arch/powerpc/platforms/44x/Kconfig
> @@ -215,7 +215,7 @@ config AKEBONO
> select NET_VENDOR_IBM
> select IBM_EMAC_EMAC4
> select IBM_EMAC_RGMII_WOL
> - select USB
> + select USB if USB_SUPPORT
> select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD
> select USB_EHCI_HCD_PLATFORM if USB_EHCI_HCD
> select MMC_SDHCI
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-16 4:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-21 13:16 [PATCH] powerpc: Fix build failure when CONFIG_USB=y Pranith Kumar
2014-09-16 4:12 ` Alistair Popple
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox