From: Alexander Graf <agraf@suse.de>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: kvm@vger.kernel.org, gleb@redhat.com, mtosatti@redhat.com,
kvm-ppc@vger.kernel.org, yongjun_wei@trendmicro.com.cn,
paulus@samba.org, scottwood@freescale.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH -next] kvm/ppc/mpic: fix missing unlock in set_base_addr()
Date: Thu, 2 May 2013 13:17:37 +0200 [thread overview]
Message-ID: <59415357-8C42-4269-91F4-33AB69C35B93@suse.de> (raw)
In-Reply-To: <CAPgLHd9S4JbRpB9ipzDyysWqAkismVMu2W=Z2mhuVHzJXv4NrQ@mail.gmail.com>
On 02.05.2013, at 07:17, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>=20
> Add the missing unlock before return from function set_base_addr()
> when disables the mapping.
>=20
> Introduced by commit 5df554ad5b7522ea62b0ff9d5be35183494efc21
> (kvm/ppc/mpic: in-kernel MPIC emulation)
>=20
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Thanks, applied to kvm-ppc-queue.
Alex
> ---
> arch/powerpc/kvm/mpic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/arch/powerpc/kvm/mpic.c b/arch/powerpc/kvm/mpic.c
> index f3148f8..0047a70 100644
> --- a/arch/powerpc/kvm/mpic.c
> +++ b/arch/powerpc/kvm/mpic.c
> @@ -1475,8 +1475,8 @@ static int set_base_addr(struct openpic *opp, =
struct kvm_device_attr *attr)
>=20
> map_mmio(opp);
>=20
> - mutex_unlock(&opp->kvm->slots_lock);
> out:
> + mutex_unlock(&opp->kvm->slots_lock);
> return 0;
> }
>=20
>=20
prev parent reply other threads:[~2013-05-02 11:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 5:17 [PATCH -next] kvm/ppc/mpic: fix missing unlock in set_base_addr() Wei Yongjun
2013-05-02 11:17 ` Alexander Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59415357-8C42-4269-91F4-33AB69C35B93@suse.de \
--to=agraf@suse.de \
--cc=gleb@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mtosatti@redhat.com \
--cc=paulus@samba.org \
--cc=scottwood@freescale.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox