* [PATCH -next] kvm/ppc/mpic: fix missing unlock in set_base_addr()
@ 2013-05-02 5:17 Wei Yongjun
2013-05-02 11:17 ` Alexander Graf
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-05-02 5:17 UTC (permalink / raw)
To: mtosatti, gleb, agraf, benh, paulus, scottwood
Cc: yongjun_wei, linuxppc-dev, kvm-ppc, kvm
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Add the missing unlock before return from function set_base_addr()
when disables the mapping.
Introduced by commit 5df554ad5b7522ea62b0ff9d5be35183494efc21
(kvm/ppc/mpic: in-kernel MPIC emulation)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
arch/powerpc/kvm/mpic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kvm/mpic.c b/arch/powerpc/kvm/mpic.c
index f3148f8..0047a70 100644
--- a/arch/powerpc/kvm/mpic.c
+++ b/arch/powerpc/kvm/mpic.c
@@ -1475,8 +1475,8 @@ static int set_base_addr(struct openpic *opp, struct kvm_device_attr *attr)
map_mmio(opp);
- mutex_unlock(&opp->kvm->slots_lock);
out:
+ mutex_unlock(&opp->kvm->slots_lock);
return 0;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] kvm/ppc/mpic: fix missing unlock in set_base_addr()
2013-05-02 5:17 [PATCH -next] kvm/ppc/mpic: fix missing unlock in set_base_addr() Wei Yongjun
@ 2013-05-02 11:17 ` Alexander Graf
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Graf @ 2013-05-02 11:17 UTC (permalink / raw)
To: Wei Yongjun
Cc: kvm, gleb, mtosatti, kvm-ppc, yongjun_wei, paulus, scottwood,
linuxppc-dev
On 02.05.2013, at 07:17, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>=20
> Add the missing unlock before return from function set_base_addr()
> when disables the mapping.
>=20
> Introduced by commit 5df554ad5b7522ea62b0ff9d5be35183494efc21
> (kvm/ppc/mpic: in-kernel MPIC emulation)
>=20
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Thanks, applied to kvm-ppc-queue.
Alex
> ---
> arch/powerpc/kvm/mpic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/arch/powerpc/kvm/mpic.c b/arch/powerpc/kvm/mpic.c
> index f3148f8..0047a70 100644
> --- a/arch/powerpc/kvm/mpic.c
> +++ b/arch/powerpc/kvm/mpic.c
> @@ -1475,8 +1475,8 @@ static int set_base_addr(struct openpic *opp, =
struct kvm_device_attr *attr)
>=20
> map_mmio(opp);
>=20
> - mutex_unlock(&opp->kvm->slots_lock);
> out:
> + mutex_unlock(&opp->kvm->slots_lock);
> return 0;
> }
>=20
>=20
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-02 11:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-02 5:17 [PATCH -next] kvm/ppc/mpic: fix missing unlock in set_base_addr() Wei Yongjun
2013-05-02 11:17 ` Alexander Graf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox