* [PATCH misc-next] drivers/misc: remove redundant rc variable
@ 2021-12-15 6:04 cgel.zte
2021-12-15 8:52 ` Andrew Donnellan
2021-12-26 21:52 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: cgel.zte @ 2021-12-15 6:04 UTC (permalink / raw)
To: fbarrat
Cc: ajd, arnd, gregkh, Zeal Robot, linux-kernel, Minghao Chi,
linuxppc-dev
From: Minghao Chi <chi.minghao@zte.com.cn>
Return value from ocxl_context_attach() directly instead
of taking this in another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
drivers/misc/ocxl/file.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c
index e70525eedaae..d881f5e40ad9 100644
--- a/drivers/misc/ocxl/file.c
+++ b/drivers/misc/ocxl/file.c
@@ -74,7 +74,6 @@ static long afu_ioctl_attach(struct ocxl_context *ctx,
{
struct ocxl_ioctl_attach arg;
u64 amr = 0;
- int rc;
pr_debug("%s for context %d\n", __func__, ctx->pasid);
@@ -86,8 +85,7 @@ static long afu_ioctl_attach(struct ocxl_context *ctx,
return -EINVAL;
amr = arg.amr & mfspr(SPRN_UAMOR);
- rc = ocxl_context_attach(ctx, amr, current->mm);
- return rc;
+ return ocxl_context_attach(ctx, amr, current->mm);
}
static long afu_ioctl_get_metadata(struct ocxl_context *ctx,
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH misc-next] drivers/misc: remove redundant rc variable
2021-12-15 6:04 [PATCH misc-next] drivers/misc: remove redundant rc variable cgel.zte
@ 2021-12-15 8:52 ` Andrew Donnellan
2021-12-26 21:52 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Donnellan @ 2021-12-15 8:52 UTC (permalink / raw)
To: cgel.zte, fbarrat
Cc: arnd, gregkh, Zeal Robot, linux-kernel, Minghao Chi, linuxppc-dev
On 15/12/21 5:04 pm, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Return value from ocxl_context_attach() directly instead
> of taking this in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH misc-next] drivers/misc: remove redundant rc variable
2021-12-15 6:04 [PATCH misc-next] drivers/misc: remove redundant rc variable cgel.zte
2021-12-15 8:52 ` Andrew Donnellan
@ 2021-12-26 21:52 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2021-12-26 21:52 UTC (permalink / raw)
To: cgel.zte, fbarrat
Cc: ajd, arnd, gregkh, Zeal Robot, linux-kernel, Minghao Chi,
linuxppc-dev
On Wed, 15 Dec 2021 06:04:38 +0000, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Return value from ocxl_context_attach() directly instead
> of taking this in another redundant variable.
>
>
Applied to powerpc/next.
[1/1] drivers/misc: remove redundant rc variable
https://git.kernel.org/powerpc/c/30e120e6a9d247cec7effd55fd6783d5c619ed4c
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-26 21:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-15 6:04 [PATCH misc-next] drivers/misc: remove redundant rc variable cgel.zte
2021-12-15 8:52 ` Andrew Donnellan
2021-12-26 21:52 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox