* [PATCH V2] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS
@ 2013-09-05 2:41 Jia Hongtao
2013-09-05 18:41 ` Kumar Gala
0 siblings, 1 reply; 5+ messages in thread
From: Jia Hongtao @ 2013-09-05 2:41 UTC (permalink / raw)
To: linuxppc-dev, B07421; +Cc: hongtao.jia, Wei.Yang
In both B4 and T4240QDS platform PCA9547 I2C bus multiplexer is used.
The sub-nodes are also reorganized according to right I2C topology.
Signed-off-by: Jia Hongtao <hongtao.jia@freescale.com>
---
V2 change log:
Reorganized the sub-nodes under I2C multiplexer to represent right topology.
arch/powerpc/boot/dts/b4qds.dtsi | 49 +++++++++++++++++-----------
arch/powerpc/boot/dts/t4240qds.dts | 67 ++++++++++++++++++++++----------------
2 files changed, 69 insertions(+), 47 deletions(-)
diff --git a/arch/powerpc/boot/dts/b4qds.dtsi b/arch/powerpc/boot/dts/b4qds.dtsi
index e6d2f8f..de8cb38 100644
--- a/arch/powerpc/boot/dts/b4qds.dtsi
+++ b/arch/powerpc/boot/dts/b4qds.dtsi
@@ -120,25 +120,36 @@
};
i2c@118000 {
- eeprom@50 {
- compatible = "at24,24c64";
- reg = <0x50>;
- };
- eeprom@51 {
- compatible = "at24,24c256";
- reg = <0x51>;
- };
- eeprom@53 {
- compatible = "at24,24c256";
- reg = <0x53>;
- };
- eeprom@57 {
- compatible = "at24,24c256";
- reg = <0x57>;
- };
- rtc@68 {
- compatible = "dallas,ds3232";
- reg = <0x68>;
+ pca9547@77 {
+ compatible = "philips,pca9547";
+ reg = <0x77>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ channel@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ eeprom@50 {
+ compatible = "at24,24c64";
+ reg = <0x50>;
+ };
+ eeprom@51 {
+ compatible = "at24,24c256";
+ reg = <0x51>;
+ };
+ eeprom@53 {
+ compatible = "at24,24c256";
+ reg = <0x53>;
+ };
+ eeprom@57 {
+ compatible = "at24,24c256";
+ reg = <0x57>;
+ };
+ rtc@68 {
+ compatible = "dallas,ds3232";
+ reg = <0x68>;
+ };
+ };
};
};
diff --git a/arch/powerpc/boot/dts/t4240qds.dts b/arch/powerpc/boot/dts/t4240qds.dts
index 0555976..ae68595 100644
--- a/arch/powerpc/boot/dts/t4240qds.dts
+++ b/arch/powerpc/boot/dts/t4240qds.dts
@@ -118,34 +118,45 @@
};
i2c@118000 {
- eeprom@51 {
- compatible = "at24,24c256";
- reg = <0x51>;
- };
- eeprom@52 {
- compatible = "at24,24c256";
- reg = <0x52>;
- };
- eeprom@53 {
- compatible = "at24,24c256";
- reg = <0x53>;
- };
- eeprom@54 {
- compatible = "at24,24c256";
- reg = <0x54>;
- };
- eeprom@55 {
- compatible = "at24,24c256";
- reg = <0x55>;
- };
- eeprom@56 {
- compatible = "at24,24c256";
- reg = <0x56>;
- };
- rtc@68 {
- compatible = "dallas,ds3232";
- reg = <0x68>;
- interrupts = <0x1 0x1 0 0>;
+ pca9547@77 {
+ compatible = "philips,pca9547";
+ reg = <0x77>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ channel@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ eeprom@51 {
+ compatible = "at24,24c256";
+ reg = <0x51>;
+ };
+ eeprom@52 {
+ compatible = "at24,24c256";
+ reg = <0x52>;
+ };
+ eeprom@53 {
+ compatible = "at24,24c256";
+ reg = <0x53>;
+ };
+ eeprom@54 {
+ compatible = "at24,24c256";
+ reg = <0x54>;
+ };
+ eeprom@55 {
+ compatible = "at24,24c256";
+ reg = <0x55>;
+ };
+ eeprom@56 {
+ compatible = "at24,24c256";
+ reg = <0x56>;
+ };
+ rtc@68 {
+ compatible = "dallas,ds3232";
+ reg = <0x68>;
+ interrupts = <0x1 0x1 0 0>;
+ };
+ };
};
};
};
--
1.8.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH V2] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS
2013-09-05 2:41 [PATCH V2] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS Jia Hongtao
@ 2013-09-05 18:41 ` Kumar Gala
2013-09-06 3:33 ` Jia Hongtao-B38951
0 siblings, 1 reply; 5+ messages in thread
From: Kumar Gala @ 2013-09-05 18:41 UTC (permalink / raw)
To: Jia Hongtao; +Cc: B07421, linuxppc-dev, Wei.Yang
On Sep 4, 2013, at 9:41 PM, Jia Hongtao wrote:
> In both B4 and T4240QDS platform PCA9547 I2C bus multiplexer is used.
> The sub-nodes are also reorganized according to right I2C topology.
>=20
> Signed-off-by: Jia Hongtao <hongtao.jia@freescale.com>
> ---
> V2 change log:
> Reorganized the sub-nodes under I2C multiplexer to represent right =
topology.
>=20
> arch/powerpc/boot/dts/b4qds.dtsi | 49 +++++++++++++++++-----------
> arch/powerpc/boot/dts/t4240qds.dts | 67 =
++++++++++++++++++++++----------------
> 2 files changed, 69 insertions(+), 47 deletions(-)
>=20
> diff --git a/arch/powerpc/boot/dts/b4qds.dtsi =
b/arch/powerpc/boot/dts/b4qds.dtsi
> index e6d2f8f..de8cb38 100644
> --- a/arch/powerpc/boot/dts/b4qds.dtsi
> +++ b/arch/powerpc/boot/dts/b4qds.dtsi
> @@ -120,25 +120,36 @@
> };
>=20
> i2c@118000 {
> - eeprom@50 {
> - compatible =3D "at24,24c64";
> - reg =3D <0x50>;
> - };
> - eeprom@51 {
> - compatible =3D "at24,24c256";
> - reg =3D <0x51>;
> - };
> - eeprom@53 {
> - compatible =3D "at24,24c256";
> - reg =3D <0x53>;
> - };
> - eeprom@57 {
> - compatible =3D "at24,24c256";
> - reg =3D <0x57>;
> - };
> - rtc@68 {
> - compatible =3D "dallas,ds3232";
> - reg =3D <0x68>;
> + pca9547@77 {
> + compatible =3D "philips,pca9547";
We seem to be using nxp instead of philips now.
> + reg =3D <0x77>;
> + #address-cells =3D <1>;
> + #size-cells =3D <0>;
> + channel@0 {
channel should probably be i2c
[same comments below]
> + #address-cells =3D <1>;
> + #size-cells =3D <0>;
> + reg =3D <0>;
> + eeprom@50 {
> + compatible =3D =
"at24,24c64";
> + reg =3D <0x50>;
> + };
> + eeprom@51 {
> + compatible =3D =
"at24,24c256";
> + reg =3D <0x51>;
> + };
> + eeprom@53 {
> + compatible =3D =
"at24,24c256";
> + reg =3D <0x53>;
> + };
> + eeprom@57 {
> + compatible =3D =
"at24,24c256";
> + reg =3D <0x57>;
> + };
> + rtc@68 {
> + compatible =3D =
"dallas,ds3232";
> + reg =3D <0x68>;
> + };
> + };
> };
> };
>=20
> diff --git a/arch/powerpc/boot/dts/t4240qds.dts =
b/arch/powerpc/boot/dts/t4240qds.dts
> index 0555976..ae68595 100644
> --- a/arch/powerpc/boot/dts/t4240qds.dts
> +++ b/arch/powerpc/boot/dts/t4240qds.dts
> @@ -118,34 +118,45 @@
> };
>=20
> i2c@118000 {
> - eeprom@51 {
> - compatible =3D "at24,24c256";
> - reg =3D <0x51>;
> - };
> - eeprom@52 {
> - compatible =3D "at24,24c256";
> - reg =3D <0x52>;
> - };
> - eeprom@53 {
> - compatible =3D "at24,24c256";
> - reg =3D <0x53>;
> - };
> - eeprom@54 {
> - compatible =3D "at24,24c256";
> - reg =3D <0x54>;
> - };
> - eeprom@55 {
> - compatible =3D "at24,24c256";
> - reg =3D <0x55>;
> - };
> - eeprom@56 {
> - compatible =3D "at24,24c256";
> - reg =3D <0x56>;
> - };
> - rtc@68 {
> - compatible =3D "dallas,ds3232";
> - reg =3D <0x68>;
> - interrupts =3D <0x1 0x1 0 0>;
> + pca9547@77 {
> + compatible =3D "philips,pca9547";
> + reg =3D <0x77>;
> + #address-cells =3D <1>;
> + #size-cells =3D <0>;
> + channel@0 {
> + #address-cells =3D <1>;
> + #size-cells =3D <0>;
> + reg =3D <0>;
> + eeprom@51 {
> + compatible =3D =
"at24,24c256";
> + reg =3D <0x51>;
> + };
> + eeprom@52 {
> + compatible =3D =
"at24,24c256";
> + reg =3D <0x52>;
> + };
> + eeprom@53 {
> + compatible =3D =
"at24,24c256";
> + reg =3D <0x53>;
> + };
> + eeprom@54 {
> + compatible =3D =
"at24,24c256";
> + reg =3D <0x54>;
> + };
> + eeprom@55 {
> + compatible =3D =
"at24,24c256";
> + reg =3D <0x55>;
> + };
> + eeprom@56 {
> + compatible =3D =
"at24,24c256";
> + reg =3D <0x56>;
> + };
> + rtc@68 {
> + compatible =3D =
"dallas,ds3232";
> + reg =3D <0x68>;
> + interrupts =3D <0x1 0x1 =
0 0>;
> + };
> + };
> };
> };
> };
> --=20
> 1.8.0
>=20
>=20
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH V2] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS
2013-09-05 18:41 ` Kumar Gala
@ 2013-09-06 3:33 ` Jia Hongtao-B38951
2013-09-06 16:10 ` Kumar Gala
0 siblings, 1 reply; 5+ messages in thread
From: Jia Hongtao-B38951 @ 2013-09-06 3:33 UTC (permalink / raw)
To: Kumar Gala, Wood Scott-B07421
Cc: linuxppc-dev@lists.ozlabs.org, Wei.Yang@windriver.com
> -----Original Message-----
> From: Kumar Gala [mailto:galak@kernel.crashing.org]
> Sent: Friday, September 06, 2013 2:41 AM
> To: Jia Hongtao-B38951
> Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421;
> Wei.Yang@windriver.com
> Subject: Re: [PATCH V2] powerpc: Add I2C bus multiplexer node for B4 and
> T4240QDS
>=20
>=20
> On Sep 4, 2013, at 9:41 PM, Jia Hongtao wrote:
>=20
> > In both B4 and T4240QDS platform PCA9547 I2C bus multiplexer is used.
> > The sub-nodes are also reorganized according to right I2C topology.
> >
> > Signed-off-by: Jia Hongtao <hongtao.jia@freescale.com>
> > ---
> > V2 change log:
> > Reorganized the sub-nodes under I2C multiplexer to represent right
> topology.
> >
> > arch/powerpc/boot/dts/b4qds.dtsi | 49 +++++++++++++++++-----------
> > arch/powerpc/boot/dts/t4240qds.dts | 67 ++++++++++++++++++++++---------
> -------
> > 2 files changed, 69 insertions(+), 47 deletions(-)
> >
> > diff --git a/arch/powerpc/boot/dts/b4qds.dtsi
> b/arch/powerpc/boot/dts/b4qds.dtsi
> > index e6d2f8f..de8cb38 100644
> > --- a/arch/powerpc/boot/dts/b4qds.dtsi
> > +++ b/arch/powerpc/boot/dts/b4qds.dtsi
> > @@ -120,25 +120,36 @@
> > };
> >
> > i2c@118000 {
> > - eeprom@50 {
> > - compatible =3D "at24,24c64";
> > - reg =3D <0x50>;
> > - };
> > - eeprom@51 {
> > - compatible =3D "at24,24c256";
> > - reg =3D <0x51>;
> > - };
> > - eeprom@53 {
> > - compatible =3D "at24,24c256";
> > - reg =3D <0x53>;
> > - };
> > - eeprom@57 {
> > - compatible =3D "at24,24c256";
> > - reg =3D <0x57>;
> > - };
> > - rtc@68 {
> > - compatible =3D "dallas,ds3232";
> > - reg =3D <0x68>;
> > + pca9547@77 {
> > + compatible =3D "philips,pca9547";
>=20
> We seem to be using nxp instead of philips now.
>=20
> > + reg =3D <0x77>;
> > + #address-cells =3D <1>;
> > + #size-cells =3D <0>;
> > + channel@0 {
>=20
> channel should probably be i2c
Is there any standard for the name?
i2c is ok but I think channel is more intuitional.
Hi Scott,
What do you think of it.
Thanks.
-Hongtao
>=20
> [same comments below]
>=20
> > + #address-cells =3D <1>;
> > + #size-cells =3D <0>;
> > + reg =3D <0>;
> > + eeprom@50 {
> > + compatible =3D "at24,24c64";
> > + reg =3D <0x50>;
> > + };
> > + eeprom@51 {
> > + compatible =3D "at24,24c256";
> > + reg =3D <0x51>;
> > + };
> > + eeprom@53 {
> > + compatible =3D "at24,24c256";
> > + reg =3D <0x53>;
> > + };
> > + eeprom@57 {
> > + compatible =3D "at24,24c256";
> > + reg =3D <0x57>;
> > + };
> > + rtc@68 {
> > + compatible =3D "dallas,ds3232";
> > + reg =3D <0x68>;
> > + };
> > + };
> > };
> > };
> >
> > diff --git a/arch/powerpc/boot/dts/t4240qds.dts
> b/arch/powerpc/boot/dts/t4240qds.dts
> > index 0555976..ae68595 100644
> > --- a/arch/powerpc/boot/dts/t4240qds.dts
> > +++ b/arch/powerpc/boot/dts/t4240qds.dts
> > @@ -118,34 +118,45 @@
> > };
> >
> > i2c@118000 {
> > - eeprom@51 {
> > - compatible =3D "at24,24c256";
> > - reg =3D <0x51>;
> > - };
> > - eeprom@52 {
> > - compatible =3D "at24,24c256";
> > - reg =3D <0x52>;
> > - };
> > - eeprom@53 {
> > - compatible =3D "at24,24c256";
> > - reg =3D <0x53>;
> > - };
> > - eeprom@54 {
> > - compatible =3D "at24,24c256";
> > - reg =3D <0x54>;
> > - };
> > - eeprom@55 {
> > - compatible =3D "at24,24c256";
> > - reg =3D <0x55>;
> > - };
> > - eeprom@56 {
> > - compatible =3D "at24,24c256";
> > - reg =3D <0x56>;
> > - };
> > - rtc@68 {
> > - compatible =3D "dallas,ds3232";
> > - reg =3D <0x68>;
> > - interrupts =3D <0x1 0x1 0 0>;
> > + pca9547@77 {
> > + compatible =3D "philips,pca9547";
> > + reg =3D <0x77>;
> > + #address-cells =3D <1>;
> > + #size-cells =3D <0>;
> > + channel@0 {
> > + #address-cells =3D <1>;
> > + #size-cells =3D <0>;
> > + reg =3D <0>;
> > + eeprom@51 {
> > + compatible =3D "at24,24c256";
> > + reg =3D <0x51>;
> > + };
> > + eeprom@52 {
> > + compatible =3D "at24,24c256";
> > + reg =3D <0x52>;
> > + };
> > + eeprom@53 {
> > + compatible =3D "at24,24c256";
> > + reg =3D <0x53>;
> > + };
> > + eeprom@54 {
> > + compatible =3D "at24,24c256";
> > + reg =3D <0x54>;
> > + };
> > + eeprom@55 {
> > + compatible =3D "at24,24c256";
> > + reg =3D <0x55>;
> > + };
> > + eeprom@56 {
> > + compatible =3D "at24,24c256";
> > + reg =3D <0x56>;
> > + };
> > + rtc@68 {
> > + compatible =3D "dallas,ds3232";
> > + reg =3D <0x68>;
> > + interrupts =3D <0x1 0x1 0 0>;
> > + };
> > + };
> > };
> > };
> > };
> > --
> > 1.8.0
> >
> >
> > _______________________________________________
> > Linuxppc-dev mailing list
> > Linuxppc-dev@lists.ozlabs.org
> > https://lists.ozlabs.org/listinfo/linuxppc-dev
>=20
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH V2] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS
2013-09-06 3:33 ` Jia Hongtao-B38951
@ 2013-09-06 16:10 ` Kumar Gala
2013-09-09 1:34 ` Jia Hongtao-B38951
0 siblings, 1 reply; 5+ messages in thread
From: Kumar Gala @ 2013-09-06 16:10 UTC (permalink / raw)
To: Jia Hongtao-B38951
Cc: Wood Scott-B07421, linuxppc-dev@lists.ozlabs.org,
Wei.Yang@windriver.com
On Sep 5, 2013, at 10:33 PM, Jia Hongtao-B38951 wrote:
>> -----Original Message-----
>> From: Kumar Gala [mailto:galak@kernel.crashing.org]
>> Sent: Friday, September 06, 2013 2:41 AM
>> To: Jia Hongtao-B38951
>> Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421;
>> Wei.Yang@windriver.com
>> Subject: Re: [PATCH V2] powerpc: Add I2C bus multiplexer node for B4 and
>> T4240QDS
>>
>>
>> On Sep 4, 2013, at 9:41 PM, Jia Hongtao wrote:
>>
>>> In both B4 and T4240QDS platform PCA9547 I2C bus multiplexer is used.
>>> The sub-nodes are also reorganized according to right I2C topology.
>>>
>>> Signed-off-by: Jia Hongtao <hongtao.jia@freescale.com>
>>> ---
>>> V2 change log:
>>> Reorganized the sub-nodes under I2C multiplexer to represent right
>> topology.
>>>
>>> arch/powerpc/boot/dts/b4qds.dtsi | 49 +++++++++++++++++-----------
>>> arch/powerpc/boot/dts/t4240qds.dts | 67 ++++++++++++++++++++++---------
>> -------
>>> 2 files changed, 69 insertions(+), 47 deletions(-)
>>>
>>> diff --git a/arch/powerpc/boot/dts/b4qds.dtsi
>> b/arch/powerpc/boot/dts/b4qds.dtsi
>>> index e6d2f8f..de8cb38 100644
>>> --- a/arch/powerpc/boot/dts/b4qds.dtsi
>>> +++ b/arch/powerpc/boot/dts/b4qds.dtsi
>>> @@ -120,25 +120,36 @@
>>> };
>>>
>>> i2c@118000 {
>>> - eeprom@50 {
>>> - compatible = "at24,24c64";
>>> - reg = <0x50>;
>>> - };
>>> - eeprom@51 {
>>> - compatible = "at24,24c256";
>>> - reg = <0x51>;
>>> - };
>>> - eeprom@53 {
>>> - compatible = "at24,24c256";
>>> - reg = <0x53>;
>>> - };
>>> - eeprom@57 {
>>> - compatible = "at24,24c256";
>>> - reg = <0x57>;
>>> - };
>>> - rtc@68 {
>>> - compatible = "dallas,ds3232";
>>> - reg = <0x68>;
>>> + pca9547@77 {
>>> + compatible = "philips,pca9547";
>>
>> We seem to be using nxp instead of philips now.
This is based on Documentation/devicetree/bindings/vendor-prefixes.txt
>>
>>> + reg = <0x77>;
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + channel@0 {
>>
>> channel should probably be i2c
>
>
> Is there any standard for the name?
> i2c is ok but I think channel is more intuitional.
>
> Hi Scott,
> What do you think of it.
Basing my comments on Documentation/devicetree/bindings/i2c/i2c-mux.txt
>
> Thanks.
> -Hongtao
>
>
>>
>> [same comments below]
>>
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + reg = <0>;
>>> + eeprom@50 {
>>> + compatible = "at24,24c64";
>>> + reg = <0x50>;
>>> + };
>>> + eeprom@51 {
>>> + compatible = "at24,24c256";
>>> + reg = <0x51>;
>>> + };
>>> + eeprom@53 {
>>> + compatible = "at24,24c256";
>>> + reg = <0x53>;
>>> + };
>>> + eeprom@57 {
>>> + compatible = "at24,24c256";
>>> + reg = <0x57>;
>>> + };
>>> + rtc@68 {
>>> + compatible = "dallas,ds3232";
>>> + reg = <0x68>;
>>> + };
>>> + };
>>> };
>>> };
>>>
>>> diff --git a/arch/powerpc/boot/dts/t4240qds.dts
>> b/arch/powerpc/boot/dts/t4240qds.dts
>>> index 0555976..ae68595 100644
>>> --- a/arch/powerpc/boot/dts/t4240qds.dts
>>> +++ b/arch/powerpc/boot/dts/t4240qds.dts
>>> @@ -118,34 +118,45 @@
>>> };
>>>
>>> i2c@118000 {
>>> - eeprom@51 {
>>> - compatible = "at24,24c256";
>>> - reg = <0x51>;
>>> - };
>>> - eeprom@52 {
>>> - compatible = "at24,24c256";
>>> - reg = <0x52>;
>>> - };
>>> - eeprom@53 {
>>> - compatible = "at24,24c256";
>>> - reg = <0x53>;
>>> - };
>>> - eeprom@54 {
>>> - compatible = "at24,24c256";
>>> - reg = <0x54>;
>>> - };
>>> - eeprom@55 {
>>> - compatible = "at24,24c256";
>>> - reg = <0x55>;
>>> - };
>>> - eeprom@56 {
>>> - compatible = "at24,24c256";
>>> - reg = <0x56>;
>>> - };
>>> - rtc@68 {
>>> - compatible = "dallas,ds3232";
>>> - reg = <0x68>;
>>> - interrupts = <0x1 0x1 0 0>;
>>> + pca9547@77 {
>>> + compatible = "philips,pca9547";
>>> + reg = <0x77>;
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + channel@0 {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + reg = <0>;
>>> + eeprom@51 {
>>> + compatible = "at24,24c256";
>>> + reg = <0x51>;
>>> + };
>>> + eeprom@52 {
>>> + compatible = "at24,24c256";
>>> + reg = <0x52>;
>>> + };
>>> + eeprom@53 {
>>> + compatible = "at24,24c256";
>>> + reg = <0x53>;
>>> + };
>>> + eeprom@54 {
>>> + compatible = "at24,24c256";
>>> + reg = <0x54>;
>>> + };
>>> + eeprom@55 {
>>> + compatible = "at24,24c256";
>>> + reg = <0x55>;
>>> + };
>>> + eeprom@56 {
>>> + compatible = "at24,24c256";
>>> + reg = <0x56>;
>>> + };
>>> + rtc@68 {
>>> + compatible = "dallas,ds3232";
>>> + reg = <0x68>;
>>> + interrupts = <0x1 0x1 0 0>;
>>> + };
>>> + };
>>> };
>>> };
>>> };
>>> --
>>> 1.8.0
>>>
>>>
>>> _______________________________________________
>>> Linuxppc-dev mailing list
>>> Linuxppc-dev@lists.ozlabs.org
>>> https://lists.ozlabs.org/listinfo/linuxppc-dev
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH V2] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS
2013-09-06 16:10 ` Kumar Gala
@ 2013-09-09 1:34 ` Jia Hongtao-B38951
0 siblings, 0 replies; 5+ messages in thread
From: Jia Hongtao-B38951 @ 2013-09-09 1:34 UTC (permalink / raw)
To: Kumar Gala
Cc: Wood Scott-B07421, linuxppc-dev@lists.ozlabs.org,
Wei.Yang@windriver.com
Great thanks.
I will update the patch and send it soon.
-Hongtao
> -----Original Message-----
> From: Linuxppc-dev [mailto:linuxppc-dev-
> bounces+b38951=3Dfreescale.com@lists.ozlabs.org] On Behalf Of Kumar Gala
> Sent: Saturday, September 07, 2013 12:10 AM
> To: Jia Hongtao-B38951
> Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org;
> Wei.Yang@windriver.com
> Subject: Re: [PATCH V2] powerpc: Add I2C bus multiplexer node for B4 and
> T4240QDS
>=20
>=20
> On Sep 5, 2013, at 10:33 PM, Jia Hongtao-B38951 wrote:
>=20
> >> -----Original Message-----
> >> From: Kumar Gala [mailto:galak@kernel.crashing.org]
> >> Sent: Friday, September 06, 2013 2:41 AM
> >> To: Jia Hongtao-B38951
> >> Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421;
> >> Wei.Yang@windriver.com
> >> Subject: Re: [PATCH V2] powerpc: Add I2C bus multiplexer node for B4
> >> and T4240QDS
> >>
> >>
> >> On Sep 4, 2013, at 9:41 PM, Jia Hongtao wrote:
> >>
> >>> In both B4 and T4240QDS platform PCA9547 I2C bus multiplexer is used.
> >>> The sub-nodes are also reorganized according to right I2C topology.
> >>>
> >>> Signed-off-by: Jia Hongtao <hongtao.jia@freescale.com>
> >>> ---
> >>> V2 change log:
> >>> Reorganized the sub-nodes under I2C multiplexer to represent right
> >> topology.
> >>>
> >>> arch/powerpc/boot/dts/b4qds.dtsi | 49 +++++++++++++++++-----------
> >>> arch/powerpc/boot/dts/t4240qds.dts | 67
> >>> ++++++++++++++++++++++---------
> >> -------
> >>> 2 files changed, 69 insertions(+), 47 deletions(-)
> >>>
> >>> diff --git a/arch/powerpc/boot/dts/b4qds.dtsi
> >> b/arch/powerpc/boot/dts/b4qds.dtsi
> >>> index e6d2f8f..de8cb38 100644
> >>> --- a/arch/powerpc/boot/dts/b4qds.dtsi
> >>> +++ b/arch/powerpc/boot/dts/b4qds.dtsi
> >>> @@ -120,25 +120,36 @@
> >>> };
> >>>
> >>> i2c@118000 {
> >>> - eeprom@50 {
> >>> - compatible =3D "at24,24c64";
> >>> - reg =3D <0x50>;
> >>> - };
> >>> - eeprom@51 {
> >>> - compatible =3D "at24,24c256";
> >>> - reg =3D <0x51>;
> >>> - };
> >>> - eeprom@53 {
> >>> - compatible =3D "at24,24c256";
> >>> - reg =3D <0x53>;
> >>> - };
> >>> - eeprom@57 {
> >>> - compatible =3D "at24,24c256";
> >>> - reg =3D <0x57>;
> >>> - };
> >>> - rtc@68 {
> >>> - compatible =3D "dallas,ds3232";
> >>> - reg =3D <0x68>;
> >>> + pca9547@77 {
> >>> + compatible =3D "philips,pca9547";
> >>
> >> We seem to be using nxp instead of philips now.
>=20
> This is based on Documentation/devicetree/bindings/vendor-prefixes.txt
>=20
> >>
> >>> + reg =3D <0x77>;
> >>> + #address-cells =3D <1>;
> >>> + #size-cells =3D <0>;
> >>> + channel@0 {
> >>
> >> channel should probably be i2c
> >
> >
> > Is there any standard for the name?
> > i2c is ok but I think channel is more intuitional.
> >
> > Hi Scott,
> > What do you think of it.
>=20
> Basing my comments on Documentation/devicetree/bindings/i2c/i2c-mux.txt
>=20
>=20
> >
> > Thanks.
> > -Hongtao
> >
> >
> >>
> >> [same comments below]
> >>
> >>> + #address-cells =3D <1>;
> >>> + #size-cells =3D <0>;
> >>> + reg =3D <0>;
> >>> + eeprom@50 {
> >>> + compatible =3D "at24,24c64";
> >>> + reg =3D <0x50>;
> >>> + };
> >>> + eeprom@51 {
> >>> + compatible =3D "at24,24c256";
> >>> + reg =3D <0x51>;
> >>> + };
> >>> + eeprom@53 {
> >>> + compatible =3D "at24,24c256";
> >>> + reg =3D <0x53>;
> >>> + };
> >>> + eeprom@57 {
> >>> + compatible =3D "at24,24c256";
> >>> + reg =3D <0x57>;
> >>> + };
> >>> + rtc@68 {
> >>> + compatible =3D "dallas,ds3232";
> >>> + reg =3D <0x68>;
> >>> + };
> >>> + };
> >>> };
> >>> };
> >>>
> >>> diff --git a/arch/powerpc/boot/dts/t4240qds.dts
> >> b/arch/powerpc/boot/dts/t4240qds.dts
> >>> index 0555976..ae68595 100644
> >>> --- a/arch/powerpc/boot/dts/t4240qds.dts
> >>> +++ b/arch/powerpc/boot/dts/t4240qds.dts
> >>> @@ -118,34 +118,45 @@
> >>> };
> >>>
> >>> i2c@118000 {
> >>> - eeprom@51 {
> >>> - compatible =3D "at24,24c256";
> >>> - reg =3D <0x51>;
> >>> - };
> >>> - eeprom@52 {
> >>> - compatible =3D "at24,24c256";
> >>> - reg =3D <0x52>;
> >>> - };
> >>> - eeprom@53 {
> >>> - compatible =3D "at24,24c256";
> >>> - reg =3D <0x53>;
> >>> - };
> >>> - eeprom@54 {
> >>> - compatible =3D "at24,24c256";
> >>> - reg =3D <0x54>;
> >>> - };
> >>> - eeprom@55 {
> >>> - compatible =3D "at24,24c256";
> >>> - reg =3D <0x55>;
> >>> - };
> >>> - eeprom@56 {
> >>> - compatible =3D "at24,24c256";
> >>> - reg =3D <0x56>;
> >>> - };
> >>> - rtc@68 {
> >>> - compatible =3D "dallas,ds3232";
> >>> - reg =3D <0x68>;
> >>> - interrupts =3D <0x1 0x1 0 0>;
> >>> + pca9547@77 {
> >>> + compatible =3D "philips,pca9547";
> >>> + reg =3D <0x77>;
> >>> + #address-cells =3D <1>;
> >>> + #size-cells =3D <0>;
> >>> + channel@0 {
> >>> + #address-cells =3D <1>;
> >>> + #size-cells =3D <0>;
> >>> + reg =3D <0>;
> >>> + eeprom@51 {
> >>> + compatible =3D "at24,24c256";
> >>> + reg =3D <0x51>;
> >>> + };
> >>> + eeprom@52 {
> >>> + compatible =3D "at24,24c256";
> >>> + reg =3D <0x52>;
> >>> + };
> >>> + eeprom@53 {
> >>> + compatible =3D "at24,24c256";
> >>> + reg =3D <0x53>;
> >>> + };
> >>> + eeprom@54 {
> >>> + compatible =3D "at24,24c256";
> >>> + reg =3D <0x54>;
> >>> + };
> >>> + eeprom@55 {
> >>> + compatible =3D "at24,24c256";
> >>> + reg =3D <0x55>;
> >>> + };
> >>> + eeprom@56 {
> >>> + compatible =3D "at24,24c256";
> >>> + reg =3D <0x56>;
> >>> + };
> >>> + rtc@68 {
> >>> + compatible =3D "dallas,ds3232";
> >>> + reg =3D <0x68>;
> >>> + interrupts =3D <0x1 0x1 0 0>;
> >>> + };
> >>> + };
> >>> };
> >>> };
> >>> };
> >>> --
> >>> 1.8.0
> >>>
> >>>
> >>> _______________________________________________
> >>> Linuxppc-dev mailing list
> >>> Linuxppc-dev@lists.ozlabs.org
> >>> https://lists.ozlabs.org/listinfo/linuxppc-dev
> >>
> >
>=20
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-09 1:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-05 2:41 [PATCH V2] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS Jia Hongtao
2013-09-05 18:41 ` Kumar Gala
2013-09-06 3:33 ` Jia Hongtao-B38951
2013-09-06 16:10 ` Kumar Gala
2013-09-09 1:34 ` Jia Hongtao-B38951
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox