* [PATCH kernel] powerpc/prom_init: Pass the "os-term" message to hypervisor
@ 2020-03-12 7:44 Alexey Kardashevskiy
2020-03-13 11:57 ` Michael Ellerman
2020-03-26 12:06 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Alexey Kardashevskiy @ 2020-03-12 7:44 UTC (permalink / raw)
To: linuxppc-dev
Cc: Alexey Kardashevskiy, Ram Pai, Thiago Jung Bauermann, kvm-ppc,
David Gibson
The "os-term" RTAS calls has one argument with a message address of
OS termination cause. rtas_os_term() already passes it but the recently
added prom_init's version of that missed it; it also does not fill args
correctly.
This passes the message address and initializes the number of arguments.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
arch/powerpc/kernel/prom_init.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
index 577345382b23..673f13b87db1 100644
--- a/arch/powerpc/kernel/prom_init.c
+++ b/arch/powerpc/kernel/prom_init.c
@@ -1773,6 +1773,9 @@ static void __init prom_rtas_os_term(char *str)
if (token == 0)
prom_panic("Could not get token for ibm,os-term\n");
os_term_args.token = cpu_to_be32(token);
+ os_term_args.nargs = cpu_to_be32(1);
+ os_term_args.nret = cpu_to_be32(1);
+ os_term_args.args[0] = cpu_to_be32(__pa(str));
prom_rtas_hcall((uint64_t)&os_term_args);
}
#endif /* CONFIG_PPC_SVM */
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH kernel] powerpc/prom_init: Pass the "os-term" message to hypervisor
2020-03-12 7:44 [PATCH kernel] powerpc/prom_init: Pass the "os-term" message to hypervisor Alexey Kardashevskiy
@ 2020-03-13 11:57 ` Michael Ellerman
2020-03-26 12:06 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2020-03-13 11:57 UTC (permalink / raw)
To: Alexey Kardashevskiy, linuxppc-dev
Cc: Alexey Kardashevskiy, Ram Pai, kvm-ppc, Thiago Jung Bauermann,
David Gibson
Alexey Kardashevskiy <aik@ozlabs.ru> writes:
> The "os-term" RTAS calls has one argument with a message address of
> OS termination cause. rtas_os_term() already passes it but the recently
> added prom_init's version of that missed it; it also does not fill args
> correctly.
>
> This passes the message address and initializes the number of arguments.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
I added:
Fixes: 6a9c930bd775 ("powerpc/prom_init: Add the ESM call to prom_init")
cheers
> diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
> index 577345382b23..673f13b87db1 100644
> --- a/arch/powerpc/kernel/prom_init.c
> +++ b/arch/powerpc/kernel/prom_init.c
> @@ -1773,6 +1773,9 @@ static void __init prom_rtas_os_term(char *str)
> if (token == 0)
> prom_panic("Could not get token for ibm,os-term\n");
> os_term_args.token = cpu_to_be32(token);
> + os_term_args.nargs = cpu_to_be32(1);
> + os_term_args.nret = cpu_to_be32(1);
> + os_term_args.args[0] = cpu_to_be32(__pa(str));
> prom_rtas_hcall((uint64_t)&os_term_args);
> }
> #endif /* CONFIG_PPC_SVM */
> --
> 2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH kernel] powerpc/prom_init: Pass the "os-term" message to hypervisor
2020-03-12 7:44 [PATCH kernel] powerpc/prom_init: Pass the "os-term" message to hypervisor Alexey Kardashevskiy
2020-03-13 11:57 ` Michael Ellerman
@ 2020-03-26 12:06 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2020-03-26 12:06 UTC (permalink / raw)
To: Alexey Kardashevskiy, linuxppc-dev
Cc: Alexey Kardashevskiy, Ram Pai, kvm-ppc, Thiago Jung Bauermann,
David Gibson
On Thu, 2020-03-12 at 07:44:04 UTC, Alexey Kardashevskiy wrote:
> The "os-term" RTAS calls has one argument with a message address of
> OS termination cause. rtas_os_term() already passes it but the recently
> added prom_init's version of that missed it; it also does not fill args
> correctly.
>
> This passes the message address and initializes the number of arguments.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/74bb84e5117146fa73eb9d01305975c53022b3c3
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-26 12:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-12 7:44 [PATCH kernel] powerpc/prom_init: Pass the "os-term" message to hypervisor Alexey Kardashevskiy
2020-03-13 11:57 ` Michael Ellerman
2020-03-26 12:06 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox