From: Michael Ellerman <mpe@ellerman.id.au>
To: Joel Stanley <joel@jms.id.au>, linuxppc-dev@lists.ozlabs.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>, oohall@gmail.com
Subject: Re: [RFC PATCH 2/3] powerpc/pci: Remove MVE code
Date: Tue, 20 Jun 2023 23:16:19 +1000 [thread overview]
Message-ID: <87jzvyp93w.fsf@mail.lhotse> (raw)
In-Reply-To: <20230613045202.294451-3-joel@jms.id.au>
Joel Stanley <joel@jms.id.au> writes:
> With IODA1 support gone the OPAL calls to set MVE are dead code. Remove
> them.
>
> TODO: Do we have rules for removing unused OPAL APIs? Should we leave it
> in opal.h? opal-call.c?
I don't think we have any rules for removal.
When skiboot was being actively developed Stewart and I did try to keep
the skiboot and kernel opal-api.h in sync, but I haven't checked on the
state of that for a few years. ... And I just checked and boy they are
*not* in sync anymore.
But anyway opal.h and opal-call.c are just kernel internal, so I think
we just remove unused code there as normal.
cheers
next prev parent reply other threads:[~2023-06-20 13:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 4:51 [RFC PATCH 0/3] powernv/pci: Remove unused IODA1 support Joel Stanley
2023-06-13 4:52 ` [RFC PATCH 1/3] powernv/pci: Remove ioda1 support Joel Stanley
2023-06-13 4:52 ` [RFC PATCH 2/3] powerpc/pci: Remove MVE code Joel Stanley
2023-06-20 13:16 ` Michael Ellerman [this message]
2023-06-13 4:52 ` [RFC PATCH 3/3] powernv/pci: Remove last IODA1 defines Joel Stanley
2023-07-03 5:26 ` [RFC PATCH 0/3] powernv/pci: Remove unused IODA1 support Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzvyp93w.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=aik@ozlabs.ru \
--cc=joel@jms.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oohall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox