Re: [linuxppc-dev] Patch notification: 1 patch updated

Re: [linuxppc-dev] Patch notification: 1 patch updated

[Christian Zigotzky]

Hello,

I believe Patchwork did not fully associate the latest revision of my patch series with the previous one.

Please use the following latest patch.

Thanks,
Christian

—-
The Nemo board requires the PCIe ports to be initialized before the
SB600 ISA bridge can be accessed.

Since pas_pci_init() is now called later during boot, the i8259
initialization in pas_init_IRQ() happens too early and accesses
registers that are not yet mapped, preventing the board from booting.

Move the Nemo-specific i8259 initialization to pas_add_bridge(),
after the ISA bridge has been discovered.

Suggested-by: Darren Stevens <darren at stevens-zone.net>
Tested-by: Christian Zigotzky <chzigotzky at xenosoft.de>
Signed-off-by: Christian Zigotzky <chzigotzky at xenosoft.de>
---
 arch/powerpc/platforms/pasemi/pasemi.h |  6 ++++++
 arch/powerpc/platforms/pasemi/pci.c    |  5 +++++
 arch/powerpc/platforms/pasemi/setup.c  | 12 ++++--------
 3 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/arch/powerpc/platforms/pasemi/pasemi.h b/arch/powerpc/platforms/pasemi/pasemi.h
index 6f6743b8e48d..c37e5c684bb9 100644
--- a/arch/powerpc/platforms/pasemi/pasemi.h
+++ b/arch/powerpc/platforms/pasemi/pasemi.h
@@ -7,6 +7,12 @@ extern void pas_pci_init(void);
 struct pci_dev;
 extern void pas_pci_dma_dev_setup(struct pci_dev *dev);
 
+#ifdef CONFIG_PPC_PASEMI_NEMO
+extern void __init nemo_init_IRQ(void);
+#else
+static inline void __init nemo_init_IRQ(void) { }
+#endif
+
 void __iomem *__init pasemi_pci_getcfgaddr(struct pci_dev *dev, int offset);
 
 extern void __init pasemi_map_registers(void);
diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi/pci.c
index 2df955274652..fb53782da7ec 100644
--- a/arch/powerpc/platforms/pasemi/pci.c
+++ b/arch/powerpc/platforms/pasemi/pci.c
@@ -265,6 +265,11 @@ static int __init pas_add_bridge(struct device_node *dev)
 	 */
 	isa_bridge_find_early(hose);
 
+	/*
+	 * ISA bridge is now active, add the i8259 cascade (if needed)
+	 */
+	nemo_init_IRQ();
+
 	return 0;
 }
 
diff --git a/arch/powerpc/platforms/pasemi/setup.c b/arch/powerpc/platforms/pasemi/setup.c
index d03b41336901..c410e29414ee 100644
--- a/arch/powerpc/platforms/pasemi/setup.c
+++ b/arch/powerpc/platforms/pasemi/setup.c
@@ -214,10 +214,12 @@ static void sb600_8259_cascade(struct irq_desc *desc)
 	chip->irq_eoi(&desc->irq_data);
 }
 
-static void __init nemo_init_IRQ(struct mpic *mpic)
+void __init nemo_init_IRQ(void)
 {
 	struct device_node *np;
 	int gpio_virq;
+	struct mpic *mpic;
+
 	/* Connect the SB600's legacy i8259 controller */
 	np = of_find_node_by_path("/pxp at 0,e0000000");
 	i8259_init(np, 0);
@@ -228,14 +230,10 @@ static void __init nemo_init_IRQ(struct mpic *mpic)
 	irq_set_chained_handler(gpio_virq, sb600_8259_cascade);
 	mpic_unmask_irq(irq_get_irq_data(gpio_virq));
 
+	mpic = irq_get_chip_data(gpio_virq);
 	irq_set_default_domain(mpic->irqhost);
 }
 
-#else
-
-static inline void nemo_init_IRQ(struct mpic *mpic)
-{
-}
 #endif
 
 static __init void pas_init_IRQ(void)
@@ -298,8 +296,6 @@ static __init void pas_init_IRQ(void)
 		mpic_unmask_irq(irq_get_irq_data(nmi_virq));
 	}
 
-	nemo_init_IRQ(mpic);
-
 	of_node_put(mpic_node);
 	of_node_put(root);
 }
-- 
2.43.0

Re: [linuxppc-dev] Patch notification: 1 patch updated

[Christophe Leroy (CS GROUP)]

Hi Christian,

Le 07/08/2026 à 15:44, Christian Zigotzky a écrit :
> Hello,
> 
> I believe Patchwork did not fully associate the latest revision of my patch series with the previous one.

Not sure what you mean, in patchwork we have:

https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260801043458.12500-1-chzigotzky@xenosoft.de/

So I marked following ones as been superseded by it:

https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260701125941.906-2-chzigotzky@xenosoft.de/

https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260701105501.2093-1-chzigotzky@xenosoft.de/

Did I miss something ?

Thanks
Christophe


> 
> Please use the following latest patch.
> 
> Thanks,
> Christian
> 
> —-
> The Nemo board requires the PCIe ports to be initialized before the
> SB600 ISA bridge can be accessed.
> 
> Since pas_pci_init() is now called later during boot, the i8259
> initialization in pas_init_IRQ() happens too early and accesses
> registers that are not yet mapped, preventing the board from booting.
> 
> Move the Nemo-specific i8259 initialization to pas_add_bridge(),
> after the ISA bridge has been discovered.
> 
> Suggested-by: Darren Stevens <darren at stevens-zone.net>
> Tested-by: Christian Zigotzky <chzigotzky at xenosoft.de>
> Signed-off-by: Christian Zigotzky <chzigotzky at xenosoft.de>
> ---
>   arch/powerpc/platforms/pasemi/pasemi.h |  6 ++++++
>   arch/powerpc/platforms/pasemi/pci.c    |  5 +++++
>   arch/powerpc/platforms/pasemi/setup.c  | 12 ++++--------
>   3 files changed, 15 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/pasemi/pasemi.h b/arch/powerpc/platforms/pasemi/pasemi.h
> index 6f6743b8e48d..c37e5c684bb9 100644
> --- a/arch/powerpc/platforms/pasemi/pasemi.h
> +++ b/arch/powerpc/platforms/pasemi/pasemi.h
> @@ -7,6 +7,12 @@ extern void pas_pci_init(void);
>   struct pci_dev;
>   extern void pas_pci_dma_dev_setup(struct pci_dev *dev);
>   
> +#ifdef CONFIG_PPC_PASEMI_NEMO
> +extern void __init nemo_init_IRQ(void);
> +#else
> +static inline void __init nemo_init_IRQ(void) { }
> +#endif
> +
>   void __iomem *__init pasemi_pci_getcfgaddr(struct pci_dev *dev, int offset);
>   
>   extern void __init pasemi_map_registers(void);
> diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi/pci.c
> index 2df955274652..fb53782da7ec 100644
> --- a/arch/powerpc/platforms/pasemi/pci.c
> +++ b/arch/powerpc/platforms/pasemi/pci.c
> @@ -265,6 +265,11 @@ static int __init pas_add_bridge(struct device_node *dev)
>   	 */
>   	isa_bridge_find_early(hose);
>   
> +	/*
> +	 * ISA bridge is now active, add the i8259 cascade (if needed)
> +	 */
> +	nemo_init_IRQ();
> +
>   	return 0;
>   }
>   
> diff --git a/arch/powerpc/platforms/pasemi/setup.c b/arch/powerpc/platforms/pasemi/setup.c
> index d03b41336901..c410e29414ee 100644
> --- a/arch/powerpc/platforms/pasemi/setup.c
> +++ b/arch/powerpc/platforms/pasemi/setup.c
> @@ -214,10 +214,12 @@ static void sb600_8259_cascade(struct irq_desc *desc)
>   	chip->irq_eoi(&desc->irq_data);
>   }
>   
> -static void __init nemo_init_IRQ(struct mpic *mpic)
> +void __init nemo_init_IRQ(void)
>   {
>   	struct device_node *np;
>   	int gpio_virq;
> +	struct mpic *mpic;
> +
>   	/* Connect the SB600's legacy i8259 controller */
>   	np = of_find_node_by_path("/pxp at 0,e0000000");
>   	i8259_init(np, 0);
> @@ -228,14 +230,10 @@ static void __init nemo_init_IRQ(struct mpic *mpic)
>   	irq_set_chained_handler(gpio_virq, sb600_8259_cascade);
>   	mpic_unmask_irq(irq_get_irq_data(gpio_virq));
>   
> +	mpic = irq_get_chip_data(gpio_virq);
>   	irq_set_default_domain(mpic->irqhost);
>   }
>   
> -#else
> -
> -static inline void nemo_init_IRQ(struct mpic *mpic)
> -{
> -}
>   #endif
>   
>   static __init void pas_init_IRQ(void)
> @@ -298,8 +296,6 @@ static __init void pas_init_IRQ(void)
>   		mpic_unmask_irq(irq_get_irq_data(nmi_virq));
>   	}
>   
> -	nemo_init_IRQ(mpic);
> -
>   	of_node_put(mpic_node);
>   	of_node_put(root);
>   }

Re: [linuxppc-dev] Patch notification: 1 patch updated

[Christian Zigotzky]

Hi Christophe,

On 07 August 2026 at 03:52 pm, Christophe Leroy (CS GROUP) <chleroy@kernel.org> wrote:

> Hi Christian,

> Not sure what you mean, in patchwork we have:

> https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260801043458.12500-1-chzigotzky@xenosoft.de/

I see.


> So I marked following ones as been superseded by it

Great!

Thank you for your help,

Christian

Re: [linuxppc-dev] Patch notification: 1 patch updated

[Christophe Leroy]

Le 03/02/2020 à 02:00, Patchwork a écrit :
> Hello,
> 
> The following patch (submitted by you) has been updated in Patchwork:
> 
>   * linuxppc-dev: powerpc/nohash: Don't flush all TLBs when flushing one page
>       - http://patchwork.ozlabs.org/patch/1231983/
>       - for: Linux PPC development
>      was: New
>      now: Superseded

Superseded ? By what ?

I sent a v2 for book3s/32, but this one is for nohash.

Christophe

Re: [linuxppc-dev] Patch notification: 1 patch updated

[Segher Boessenkool]

On Mon, Feb 03, 2020 at 07:21:52AM +0100, Christophe Leroy wrote:
> Le 03/02/2020 à 02:00, Patchwork a écrit :
> >The following patch (submitted by you) has been updated in Patchwork:
> >
> >  * linuxppc-dev: powerpc/nohash: Don't flush all TLBs when flushing one 
> >  page
> >      - http://patchwork.ozlabs.org/patch/1231983/
> >      - for: Linux PPC development
> >     was: New
> >     now: Superseded
> 
> Superseded ? By what ?
> 
> I sent a v2 for book3s/32, but this one is for nohash.

Other than the prefix, those patches have an identical subject.  It
looks like something automated (maybe Michael himself ;-) ) was confused
by that :-)


Segher

Re: [linuxppc-dev] Patch notification: 1 patch updated

[Christophe LEROY]

Hello Michael and Scott,

I see that the status of the below patch has been changed to 'Not 
Applicable' in the linuxppc-dev Patchwork.


About this serie, David S. Miller said:

Sujet : Re: [PATCH 0/2] get rid of immrbar_virt_to_phys()
Date : Wed, 08 Feb 2017 13:17:32 -0500 (EST)
De : David Miller <davem@davemloft.net>
Pour : christophe.leroy@c-s.fr
Copie à : leoli@freescale.com, qiang.zhao@nxp.com, oss@buserror.net, 
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, 
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org

From: Christophe Leroy <christophe.leroy@c-s.fr>
Date: Tue,  7 Feb 2017 10:05:07 +0100 (CET)

 > ucc_geth ethernet driver is the only driver using 
immrbar_virt_to_phys() and it uses it incorrectly.
 >
 > This patch fixes ucc_geth driver then removes immrbar_virt_to_phys()

Feel free to merge this via whatever tree handles that SOC fsl driver.

Acked-by: David S. Miller <davem@davemloft.net>




Therefore, who is going to commit this patch ?

Regards
Christophe



Le 07/04/2017 à 14:10, Patchwork a écrit :
> Hello,
>
> The following patch (submitted by you) has been updated in patchwork:
>
>  * linuxppc-dev: [1/2] net: ethernet: ucc_geth: fix MEM_PART_MURAM mode
>      - http://patchwork.ozlabs.org/patch/725043/
>      - for: Linux PPC development
>     was: New
>     now: Not Applicable
>
> This email is a notification only - you do not need to respond.
>
> Happy patchworking.
>
> --
>
> This is an automated mail sent by the patchwork system at
> patchwork.ozlabs.org. To stop receiving these notifications, edit
> your mail settings at:
>   http://patchwork.ozlabs.org/mail/
>

Re: [linuxppc-dev] Patch notification: 1 patch updated

[Michael Ellerman]

Christophe LEROY <christophe.leroy@c-s.fr> writes:

> Hello Michael and Scott,
>
> I see that the status of the below patch has been changed to 'Not=20
> Applicable' in the linuxppc-dev Patchwork.
>
> About this serie, David S. Miller said:
>
> Sujet : Re: [PATCH 0/2] get rid of immrbar_virt_to_phys()
> Date : Wed, 08 Feb 2017 13:17:32 -0500 (EST)
> De : David Miller <davem@davemloft.net>
> Pour : christophe.leroy@c-s.fr
> Copie =C3=A0 : leoli@freescale.com, qiang.zhao@nxp.com, oss@buserror.net,=
=20
> linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,=20
> netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org
>
> From: Christophe Leroy <christophe.leroy@c-s.fr>
> Date: Tue,  7 Feb 2017 10:05:07 +0100 (CET)
>
>  > ucc_geth ethernet driver is the only driver using=20
> immrbar_virt_to_phys() and it uses it incorrectly.
>  >
>  > This patch fixes ucc_geth driver then removes immrbar_virt_to_phys()
>
> Feel free to merge this via whatever tree handles that SOC fsl driver.
>
> Acked-by: David S. Miller <davem@davemloft.net>
>
> Therefore, who is going to commit this patch ?

Sorry my bad, I tend to mark all "net:" patches as not applicable
because Dave nearly always takes them.

But I'll put this back to new and delegate it to Scott.
=20
cheers