LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: Caleb Crome <caleb@crome.org>,
	Maciej S. Szmigiero <mail@maciej.szmigiero.name>,
	Mark Brown <broonie@kernel.org>,
	timur@tabi.org, broonie@kernel.org, mail@maciej.szmigiero.name,
	alsa-devel@alsa-project.org, kernel@pengutronix.de,
	linux-kernel@vger.kernel.org, caleb@crome.org,
	lgirdwood@gmail.com, arnaud.mouiche@invoxia.com, lukma@denx.de,
	fabio.estevam@nxp.com, linuxppc-dev@lists.ozlabs.org,
	alsa-devel@alsa-project.org
Subject: Applied "ASoC: fsl_ssi: Redefine RX and TX macros" to the asoc tree
Date: Thu, 22 Feb 2018 13:17:13 +0000	[thread overview]
Message-ID: <E1eoqkL-0006UU-Na@debutante> (raw)
In-Reply-To: <1515990087-11598-2-git-send-email-nicoleotsuka@gmail.com>

The patch

   ASoC: fsl_ssi: Redefine RX and TX macros

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 1476105c3f4a6b8f0c6c1fe07295fc85cbffbd83 Mon Sep 17 00:00:00 2001
From: Nicolin Chen <nicoleotsuka@gmail.com>
Date: Mon, 12 Feb 2018 14:03:09 -0800
Subject: [PATCH] ASoC: fsl_ssi: Redefine RX and TX macros

The RX and TX macros were defined implicitly and there was
a potential risk if someone changes their values.

Since they were defined to index the array ssi->regvals[2],
this patch moves these two macros to fsl_ssi.c, closer to
its owner ssi->regvals. And it also puts some comments here
to limit their value within [0, 1].

Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
Tested-by: Caleb Crome <caleb@crome.org>
Tested-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Reviewed-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/fsl/fsl_ssi.c | 4 ++++
 sound/soc/fsl/fsl_ssi.h | 3 ---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 24fb672f3c65..3c8dd609e42e 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -56,6 +56,10 @@
 #include "fsl_ssi.h"
 #include "imx-pcm.h"
 
+/* Define RX and TX to index ssi->regvals array; Can be 0 or 1 only */
+#define RX 0
+#define TX 1
+
 /**
  * FSLSSI_I2S_FORMATS: audio formats supported by the SSI
  *
diff --git a/sound/soc/fsl/fsl_ssi.h b/sound/soc/fsl/fsl_ssi.h
index de2fdc5db726..18f8dd5209d5 100644
--- a/sound/soc/fsl/fsl_ssi.h
+++ b/sound/soc/fsl/fsl_ssi.h
@@ -12,9 +12,6 @@
 #ifndef _MPC8610_I2S_H
 #define _MPC8610_I2S_H
 
-#define RX 0
-#define TX 1
-
 /* -- SSI Register Map -- */
 
 /* SSI Transmit Data Register 0 */
-- 
2.16.1

  reply	other threads:[~2018-02-22 13:17 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-15  4:21 [PATCH v3 00/17] ASoC: fsl_ssi: Clean up - program flow level Nicolin Chen
2018-01-15  4:21 ` [PATCH v3 01/17] ASoC: fsl_ssi: Redefine RX and TX macros Nicolin Chen
2018-02-22 13:17   ` Mark Brown [this message]
2018-01-15  4:21 ` [PATCH v3 02/17] ASoC: fsl_ssi: Keep ssi->i2s_net updated Nicolin Chen
2018-01-15  4:21 ` [PATCH v3 03/17] ASoC: fsl_ssi: Clean up set_dai_tdm_slot() Nicolin Chen
2018-01-15  4:21 ` [PATCH v3 04/17] ASoC: fsl_ssi: Maintain a mask of active streams Nicolin Chen
2018-02-22 13:17   ` Applied "ASoC: fsl_ssi: Maintain a mask of active streams" to the asoc tree Mark Brown
2018-01-15  4:21 ` [PATCH v3 05/17] ASoC: fsl_ssi: Rename fsl_ssi_disable_val macro Nicolin Chen
2018-02-22 13:16   ` Applied "ASoC: fsl_ssi: Rename fsl_ssi_disable_val macro" to the asoc tree Mark Brown
2018-01-15  4:21 ` [PATCH v3 06/17] ASoC: fsl_ssi: Clear FIFO directly in fsl_ssi_config() Nicolin Chen
2018-01-15  4:21 ` [PATCH v3 07/17] ASoC: fsl_ssi: Clean up helper functions of trigger() Nicolin Chen
2018-02-22 13:16   ` Applied "ASoC: fsl_ssi: Clean up helper functions of trigger()" to the asoc tree Mark Brown
2018-01-15  4:21 ` [PATCH v3 08/17] ASoC: fsl_ssi: Add DAIFMT define for AC97 Nicolin Chen
2018-01-15  4:21 ` [PATCH v3 09/17] ASoC: fsl_ssi: Clean up fsl_ssi_setup_regvals() Nicolin Chen
2018-01-15  4:21 ` [PATCH v3 10/17] ASoC: fsl_ssi: Set xFEN0 and xFEN1 together Nicolin Chen
2018-01-15  4:21 ` [PATCH v3 11/17] ASoC: fsl_ssi: Use snd_soc_init_dma_data instead Nicolin Chen
2018-01-15  4:21 ` [PATCH v3 12/17] ASoC: fsl_ssi: Move one-time configurations to probe() Nicolin Chen
2018-01-15  4:21 ` [PATCH v3 13/17] ASoC: fsl_ssi: Setup AC97 in fsl_ssi_hw_init() Nicolin Chen
2018-01-15  4:21 ` [PATCH v3 14/17] ASoC: fsl_ssi: Clean up _fsl_ssi_set_dai_fmt() Nicolin Chen
2018-01-15 21:16   ` Maciej S. Szmigiero
2018-01-15 21:40     ` Nicolin Chen
2018-01-15  4:21 ` [PATCH v3 15/17] ASoC: fsl_ssi: Add bool synchronous to mark synchronous mode Nicolin Chen
2018-02-22 13:16   ` Applied "ASoC: fsl_ssi: Add bool synchronous to mark synchronous mode" to the asoc tree Mark Brown
2018-01-15  4:21 ` [PATCH v3 16/17] ASoC: fsl_ssi: Move DT related code to a separate probe() Nicolin Chen
2018-01-15 21:16   ` Maciej S. Szmigiero
2018-01-15 21:32     ` Nicolin Chen
2018-01-15  4:21 ` [PATCH v3 17/17] ASoC: fsl_ssi: Use ssi->streams instead of reading register Nicolin Chen
2018-01-15 18:35 ` [PATCH v3 00/17] ASoC: fsl_ssi: Clean up - program flow level Caleb Crome

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1eoqkL-0006UU-Na@debutante \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnaud.mouiche@invoxia.com \
    --cc=caleb@crome.org \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lukma@denx.de \
    --cc=mail@maciej.szmigiero.name \
    --cc=nicoleotsuka@gmail.com \
    --cc=timur@tabi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox