From: Kumar Gala <galak@kernel.crashing.org>
To: Robert Schwebel <r.schwebel@pengutronix.de>
Cc: linuxppc-dev@ozlabs.org, Domen Puncer <domen@coderock.org>
Subject: Re: fec_mpc5200: reset FEC on error
Date: Tue, 15 Apr 2008 10:29:26 -0500 [thread overview]
Message-ID: <F7AFD26F-39FE-4C1F-8918-F799F65F9559@kernel.crashing.org> (raw)
In-Reply-To: <20080415152638.GW13814@pengutronix.de>
On Apr 15, 2008, at 10:26 AM, Robert Schwebel wrote:
> From: Sascha Hauer <s.hauer@pengutronix.de>
>
> The error handling for the mpc5200 fec interrupt is broken. The
> intended
> behaviour is like this:
>
> * If one of FEC_IEVENT_RFIFO_ERROR and FEC_IEVENT_XFIFO_ERROR happens,
> the datasheet says (MPC5200B User's Guide R1.2, p. 14-13): "When this
> occurs, software must ensure both the FIFO Controller and BestComm
> are
> soft-reset".
>
> * On any other error (non-TFINT) interrupt, just issue a debug
> message.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>
> ---
> drivers/net/fec_mpc52xx.c | 23 +++++++++++++----------
> 1 file changed, 13 insertions(+), 10 deletions(-)
>
You really need to also copy netdev and patches to drivers/net.
- k
next prev parent reply other threads:[~2008-04-15 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-15 15:26 fec_mpc5200: reset FEC on error Robert Schwebel
2008-04-15 15:29 ` Kumar Gala [this message]
2008-04-15 15:32 ` Robert Schwebel
2008-04-15 15:44 ` Robert Schwebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F7AFD26F-39FE-4C1F-8918-F799F65F9559@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=domen@coderock.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=r.schwebel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox