* [PATCH] powerpc: Include asm/nmi.c in mobility.c for watchdog_hardlockup_set_timeout_pct()
@ 2023-06-29 19:45 Douglas Anderson
2023-06-29 20:19 ` Randy Dunlap
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Douglas Anderson @ 2023-06-29 19:45 UTC (permalink / raw)
To: Andrew Morton
Cc: Nathan Lynch, Petr Mladek, Jilin Yuan, Tom Rix, Randy Dunlap,
Haren Myneni, Douglas Anderson, linux-kernel, Luis Chamberlain,
Nicholas Piggin, Greg Kroah-Hartman, Laurent Dufour, linuxppc-dev
The powerpc/platforms/pseries/mobility.c calls
watchdog_hardlockup_set_timeout_pct(), which is declared in
<asm/nmi.h>. We used to automatically get <asm/nmi.h> included, but
that changed as of commit 7ca8fe94aa92 ("watchdog/hardlockup: define
HARDLOCKUP_DETECTOR_ARCH"). Let's add the explicit include.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Closes: https://lore.kernel.org/r/af19b76d-aa4b-6c88-9cac-eae4b2072497@infradead.org
Fixes: 7ca8fe94aa92 ("watchdog/hardlockup: define HARDLOCKUP_DETECTOR_ARCH")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
arch/powerpc/platforms/pseries/mobility.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc/platforms/pseries/mobility.c
index cd632ba9ebff..0161226d8fec 100644
--- a/arch/powerpc/platforms/pseries/mobility.c
+++ b/arch/powerpc/platforms/pseries/mobility.c
@@ -24,6 +24,7 @@
#include <linux/stringify.h>
#include <asm/machdep.h>
+#include <asm/nmi.h>
#include <asm/rtas.h>
#include "pseries.h"
#include "vas.h" /* vas_migration_handler() */
--
2.41.0.255.g8b1d071c50-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] powerpc: Include asm/nmi.c in mobility.c for watchdog_hardlockup_set_timeout_pct()
2023-06-29 19:45 [PATCH] powerpc: Include asm/nmi.c in mobility.c for watchdog_hardlockup_set_timeout_pct() Douglas Anderson
@ 2023-06-29 20:19 ` Randy Dunlap
2023-06-30 9:19 ` Petr Mladek
2023-07-03 11:39 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2023-06-29 20:19 UTC (permalink / raw)
To: Douglas Anderson, Andrew Morton
Cc: Nathan Lynch, Petr Mladek, Jilin Yuan, Tom Rix, Haren Myneni,
linux-kernel, Luis Chamberlain, Nicholas Piggin,
Greg Kroah-Hartman, Laurent Dufour, linuxppc-dev
On 6/29/23 12:45, Douglas Anderson wrote:
> The powerpc/platforms/pseries/mobility.c calls
> watchdog_hardlockup_set_timeout_pct(), which is declared in
> <asm/nmi.h>. We used to automatically get <asm/nmi.h> included, but
> that changed as of commit 7ca8fe94aa92 ("watchdog/hardlockup: define
> HARDLOCKUP_DETECTOR_ARCH"). Let's add the explicit include.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Closes: https://lore.kernel.org/r/af19b76d-aa4b-6c88-9cac-eae4b2072497@infradead.org
> Fixes: 7ca8fe94aa92 ("watchdog/hardlockup: define HARDLOCKUP_DETECTOR_ARCH")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
>
> arch/powerpc/platforms/pseries/mobility.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc/platforms/pseries/mobility.c
> index cd632ba9ebff..0161226d8fec 100644
> --- a/arch/powerpc/platforms/pseries/mobility.c
> +++ b/arch/powerpc/platforms/pseries/mobility.c
> @@ -24,6 +24,7 @@
> #include <linux/stringify.h>
>
> #include <asm/machdep.h>
> +#include <asm/nmi.h>
> #include <asm/rtas.h>
> #include "pseries.h"
> #include "vas.h" /* vas_migration_handler() */
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] powerpc: Include asm/nmi.c in mobility.c for watchdog_hardlockup_set_timeout_pct()
2023-06-29 19:45 [PATCH] powerpc: Include asm/nmi.c in mobility.c for watchdog_hardlockup_set_timeout_pct() Douglas Anderson
2023-06-29 20:19 ` Randy Dunlap
@ 2023-06-30 9:19 ` Petr Mladek
2023-07-03 11:39 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Petr Mladek @ 2023-06-30 9:19 UTC (permalink / raw)
To: Douglas Anderson
Cc: Nathan Lynch, Jilin Yuan, Tom Rix, Randy Dunlap, Haren Myneni,
linux-kernel, Luis Chamberlain, Nicholas Piggin,
Greg Kroah-Hartman, Andrew Morton, Laurent Dufour, linuxppc-dev
On Thu 2023-06-29 12:45:06, Douglas Anderson wrote:
> The powerpc/platforms/pseries/mobility.c calls
> watchdog_hardlockup_set_timeout_pct(), which is declared in
> <asm/nmi.h>. We used to automatically get <asm/nmi.h> included, but
> that changed as of commit 7ca8fe94aa92 ("watchdog/hardlockup: define
> HARDLOCKUP_DETECTOR_ARCH"). Let's add the explicit include.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Closes: https://lore.kernel.org/r/af19b76d-aa4b-6c88-9cac-eae4b2072497@infradead.org
> Fixes: 7ca8fe94aa92 ("watchdog/hardlockup: define HARDLOCKUP_DETECTOR_ARCH")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Thanks for the patch:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] powerpc: Include asm/nmi.c in mobility.c for watchdog_hardlockup_set_timeout_pct()
2023-06-29 19:45 [PATCH] powerpc: Include asm/nmi.c in mobility.c for watchdog_hardlockup_set_timeout_pct() Douglas Anderson
2023-06-29 20:19 ` Randy Dunlap
2023-06-30 9:19 ` Petr Mladek
@ 2023-07-03 11:39 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2023-07-03 11:39 UTC (permalink / raw)
To: Andrew Morton, Douglas Anderson
Cc: Nathan Lynch, Petr Mladek, Jilin Yuan, Greg Kroah-Hartman,
Randy Dunlap, Haren Myneni, linux-kernel, Luis Chamberlain,
Nicholas Piggin, Tom Rix, Laurent Dufour, linuxppc-dev
On Thu, 29 Jun 2023 12:45:06 -0700, Douglas Anderson wrote:
> The powerpc/platforms/pseries/mobility.c calls
> watchdog_hardlockup_set_timeout_pct(), which is declared in
> <asm/nmi.h>. We used to automatically get <asm/nmi.h> included, but
> that changed as of commit 7ca8fe94aa92 ("watchdog/hardlockup: define
> HARDLOCKUP_DETECTOR_ARCH"). Let's add the explicit include.
>
>
> [...]
Applied to powerpc/next.
[1/1] powerpc: Include asm/nmi.c in mobility.c for watchdog_hardlockup_set_timeout_pct()
https://git.kernel.org/powerpc/c/6cb44bef35ac11724ef22c5ae4f1bc607e2ef3d8
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-03 11:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-29 19:45 [PATCH] powerpc: Include asm/nmi.c in mobility.c for watchdog_hardlockup_set_timeout_pct() Douglas Anderson
2023-06-29 20:19 ` Randy Dunlap
2023-06-30 9:19 ` Petr Mladek
2023-07-03 11:39 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox