LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Chinmay Rath <rathc@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>
Cc: npiggin@gmail.com, harshpb@linux.ibm.com, lvivier@redhat.com,
	linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org,
	andrew.jones@linux.dev, sbhat@linux.ibm.com
Subject: Re: [kvm-unit-tests RFC PATCH 1/6] powerpc: add pmu tests
Date: Wed, 10 Jun 2026 14:57:04 +0530	[thread overview]
Message-ID: <a406db02-3aeb-4922-b6b1-8a030ca45a7b@linux.ibm.com> (raw)
In-Reply-To: <0c95c25f-1400-4912-befc-c5b32968d9ab@redhat.com>


On 6/8/26 19:27, Thomas Huth wrote:
> On 08/06/2026 14.45, Thomas Huth wrote:
>> On 02/06/2026 08.48, Chinmay Rath wrote:
>>> From: Nicholas Piggin <npiggin@gmail.com>
>>>
>>> Add some initial PMU testing.
>>>
>>> - PMC5/6 tests
>>> - PMAE / PMI test
>>> - BHRB basic tests
>>>
>>> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
>>> Signed-off-by: Chinmay Rath <rathc@linux.ibm.com>
>>> ---
>>>   lib/powerpc/asm/processor.h |   2 +
>>>   lib/powerpc/asm/reg.h       |   9 +
>>>   lib/powerpc/asm/setup.h     |   1 +
>>>   lib/powerpc/setup.c         |  20 ++
>>>   powerpc/Makefile.common     |   3 +-
>>>   powerpc/pmu.c               | 567 
>>> ++++++++++++++++++++++++++++++++++++
>>>   powerpc/unittests.cfg       |   3 +
>>>   7 files changed, 604 insertions(+), 1 deletion(-)
>>>   create mode 100644 powerpc/pmu.c
>>
>>   Hi Chinmay,
>>
>> the problem with Clang on Travis [*] still seems to persist:
>>
>>   https://app.travis-ci.com/github/huth/kvm-unit-tests/jobs/639614142
>>
>> Could you please have a look?
>>
>>   Thanks,
>>    Thomas
>>
>>
>> [*] This already happened with Nicolas' last version:
>>
>>   https://www.spinics.net/lists/kvm/msg351218.html
>
> I managed to get access to a ppc64 machine. The error is:
>
> /tmp/pmu-eab466.s: Assembler messages:
> /tmp/pmu-eab466.s:1649: Error: unrecognized opcode: `ldat'
> clang: error: assembler command failed with exit code 1 (use -v to see 
> invocation)
> make: *** [<builtin>: powerpc/pmu.o] Error 1
>
>  HTH,
>   Thomas
Hi Thomas,

Thanks for looking into this and providing the exact error message.

I was looking into this Travis CI job that you pointed to and noticed 
that the clang version being used was 14.
I was wondering, would it be possible to use a newer version of clang 
for the job since LDAT is a legit PPC insn,
that was introduced with Power 9, ISA version 3.0, way back a decade in 
2016 !
So I was wondering if using a newer version of clang that recognizes the 
instruction would be a better approach.

I checked the .travis.yml file (config) for the job, which mentions :
|apt_packages: clang qemu-system-ppc|

Can we change it to something like :
|apt_packages: clang19 qemu-system-ppc |or (clang-19)  ?

In the same config s390x uses a specific version of clang that is 11 in 
similar manner.

However if you'd still prefer working around LDAT, I could try with 
LDARX instead, but I am unable to verify if
clang-14 will recognize that since the oldest version of clang I could 
find in ppc64le repo was clang-15 which
was able to work with LDAT as well. Hence, could you help me with 
providing the steps to use Travis-CI so I could verify ?
(I had skipped doing the credit card payment while signing up, in case 
that's mandatory for Travis CI. Pardon me I'm new to it XD)

Thanks,
Chinmay



  reply	other threads:[~2026-06-10  9:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02  6:48 [kvm-unit-tests RFC PATCH 0/6] powerpc improvements Chinmay Rath
2026-06-02  6:48 ` [kvm-unit-tests RFC PATCH 1/6] powerpc: add pmu tests Chinmay Rath
2026-06-08 12:45   ` Thomas Huth
2026-06-08 13:57     ` Thomas Huth
2026-06-10  9:27       ` Chinmay Rath [this message]
2026-06-10 11:33         ` Thomas Huth
2026-06-02  6:48 ` [kvm-unit-tests RFC PATCH 2/6] configure: Make arch_libdir a first-class entity Chinmay Rath
2026-06-02 15:54   ` Andrew Jones
2026-06-05  8:34     ` Chinmay Rath
2026-06-10 11:30   ` Thomas Huth
2026-06-02  6:48 ` [kvm-unit-tests RFC PATCH 3/6] powerpc: Remove remnants of ppc64 directory and build structure Chinmay Rath
2026-06-02  6:48 ` [kvm-unit-tests RFC PATCH 4/6] powerpc: gitlab CI update Chinmay Rath
2026-06-08 12:48   ` Thomas Huth
2026-06-10  9:36     ` Chinmay Rath
2026-06-02  6:48 ` [kvm-unit-tests RFC PATCH 5/6] scripts/arch-run.bash: Fix run_panic() success exit status Chinmay Rath
2026-06-02  6:48 ` [kvm-unit-tests RFC PATCH 6/6] powerpc: Add a panic test Chinmay Rath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a406db02-3aeb-4922-b6b1-8a030ca45a7b@linux.ibm.com \
    --to=rathc@linux.ibm.com \
    --cc=andrew.jones@linux.dev \
    --cc=harshpb@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lvivier@redhat.com \
    --cc=npiggin@gmail.com \
    --cc=sbhat@linux.ibm.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox