* [PATCH 9/9] sound/ppc/snd_ps3.c: fix error return code [not found] <1428233914-4503-1-git-send-email-Julia.Lawall@lip6.fr> @ 2015-04-05 11:38 ` Julia Lawall 2015-04-05 11:52 ` Geert Uytterhoeven 2015-04-05 12:12 ` Julia Lawall 0 siblings, 2 replies; 6+ messages in thread From: Julia Lawall @ 2015-04-05 11:38 UTC (permalink / raw) To: Geoff Levand Cc: cbe-oss-dev, alsa-devel, Takashi Iwai, kernel-janitors, linux-kernel, Jaroslav Kysela, linuxppc-dev From: Julia Lawall <Julia.Lawall@lip6.fr> Initialize ret before returning on failure, as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- sound/ppc/snd_ps3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/ppc/snd_ps3.c b/sound/ppc/snd_ps3.c index 1aa52ef..9b18b52 100644 --- a/sound/ppc/snd_ps3.c +++ b/sound/ppc/snd_ps3.c @@ -1040,6 +1040,7 @@ static int __devinit snd_ps3_driver_probe(struct ps3_system_bus_device *dev) GFP_KERNEL); if (!the_card.null_buffer_start_vaddr) { pr_info("%s: nullbuffer alloc failed\n", __func__); + ret = -ENOMEM; goto clean_preallocate; } pr_debug("%s: null vaddr=%p dma=%#llx\n", __func__, ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 9/9] sound/ppc/snd_ps3.c: fix error return code 2015-04-05 11:38 ` [PATCH 9/9] sound/ppc/snd_ps3.c: fix error return code Julia Lawall @ 2015-04-05 11:52 ` Geert Uytterhoeven 2015-04-05 12:12 ` Julia Lawall 1 sibling, 0 replies; 6+ messages in thread From: Geert Uytterhoeven @ 2015-04-05 11:52 UTC (permalink / raw) To: Julia Lawall Cc: cbe-oss-dev@lists.ozlabs.org, ALSA Development Mailing List, Geoff Levand, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Jaroslav Kysela, Takashi Iwai, linuxppc-dev@lists.ozlabs.org On Sun, Apr 5, 2015 at 1:38 PM, Julia Lawall <Julia.Lawall@lip6.fr> wrote: > From: Julia Lawall <Julia.Lawall@lip6.fr> > > Initialize ret before returning on failure, as done elsewhere in the > function. > diff --git a/sound/ppc/snd_ps3.c b/sound/ppc/snd_ps3.c > index 1aa52ef..9b18b52 100644 > --- a/sound/ppc/snd_ps3.c > +++ b/sound/ppc/snd_ps3.c > @@ -1040,6 +1040,7 @@ static int __devinit snd_ps3_driver_probe(struct ps3_system_bus_device *dev) > GFP_KERNEL); > if (!the_card.null_buffer_start_vaddr) { > pr_info("%s: nullbuffer alloc failed\n", __func__); > + ret = -ENOMEM; > goto clean_preallocate; > } > pr_debug("%s: null vaddr=%p dma=%#llx\n", __func__, This has already been applied in 2012? commit c86b93628e5649fd7bb0574b570a51b2b02d586c Author: Julia Lawall <Julia.Lawall@lip6.fr> AuthorDate: Sun Aug 19 09:02:59 2012 +0200 Commit: Takashi Iwai <tiwai@suse.de> CommitDate: Mon Aug 20 11:01:14 2012 +0200 ALSA: sound/ppc/snd_ps3.c: fix error return code Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 9/9] sound/ppc/snd_ps3.c: fix error return code 2015-04-05 11:38 ` [PATCH 9/9] sound/ppc/snd_ps3.c: fix error return code Julia Lawall 2015-04-05 11:52 ` Geert Uytterhoeven @ 2015-04-05 12:12 ` Julia Lawall 1 sibling, 0 replies; 6+ messages in thread From: Julia Lawall @ 2015-04-05 12:12 UTC (permalink / raw) To: Julia Lawall Cc: cbe-oss-dev, alsa-devel, Geoff Levand, kernel-janitors, linux-kernel, Jaroslav Kysela, Takashi Iwai, linuxppc-dev Please ignore. Wrong patch set. On Sun, 5 Apr 2015, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall@lip6.fr> > > Initialize ret before returning on failure, as done elsewhere in the > function. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > ( > if@p1 (\(ret < 0\|ret != 0\)) > { ... return ret; } > | > ret@p1 = 0 > ) > ... when != ret = e1 > when != &ret > *if(...) > { > ... when != ret = e2 > when forall > return ret; > } > > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > sound/ppc/snd_ps3.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/ppc/snd_ps3.c b/sound/ppc/snd_ps3.c > index 1aa52ef..9b18b52 100644 > --- a/sound/ppc/snd_ps3.c > +++ b/sound/ppc/snd_ps3.c > @@ -1040,6 +1040,7 @@ static int __devinit snd_ps3_driver_probe(struct ps3_system_bus_device *dev) > GFP_KERNEL); > if (!the_card.null_buffer_start_vaddr) { > pr_info("%s: nullbuffer alloc failed\n", __func__); > + ret = -ENOMEM; > goto clean_preallocate; > } > pr_debug("%s: null vaddr=%p dma=%#llx\n", __func__, > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <1416746890-22719-1-git-send-email-Julia.Lawall@lip6.fr>]
* [PATCH 9/9] sound/ppc/snd_ps3.c: fix error return code [not found] <1416746890-22719-1-git-send-email-Julia.Lawall@lip6.fr> @ 2014-11-23 12:48 ` Julia Lawall 2014-11-23 13:18 ` Julia Lawall 0 siblings, 1 reply; 6+ messages in thread From: Julia Lawall @ 2014-11-23 12:48 UTC (permalink / raw) To: Geoff Levand Cc: cbe-oss-dev, alsa-devel, Takashi Iwai, kernel-janitors, linux-kernel, Jaroslav Kysela, linuxppc-dev From: Julia Lawall <Julia.Lawall@lip6.fr> Initialize ret before returning on failure, as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- sound/ppc/snd_ps3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/ppc/snd_ps3.c b/sound/ppc/snd_ps3.c index 1aa52ef..9b18b52 100644 --- a/sound/ppc/snd_ps3.c +++ b/sound/ppc/snd_ps3.c @@ -1040,6 +1040,7 @@ static int __devinit snd_ps3_driver_probe(struct ps3_system_bus_device *dev) GFP_KERNEL); if (!the_card.null_buffer_start_vaddr) { pr_info("%s: nullbuffer alloc failed\n", __func__); + ret = -ENOMEM; goto clean_preallocate; } pr_debug("%s: null vaddr=%p dma=%#llx\n", __func__, ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 9/9] sound/ppc/snd_ps3.c: fix error return code 2014-11-23 12:48 ` Julia Lawall @ 2014-11-23 13:18 ` Julia Lawall 0 siblings, 0 replies; 6+ messages in thread From: Julia Lawall @ 2014-11-23 13:18 UTC (permalink / raw) To: Geoff Levand; +Cc: cbe-oss-dev, linuxppc-dev Wrong patch, please ignore. julia On Sun, 23 Nov 2014, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall@lip6.fr> > > Initialize ret before returning on failure, as done elsewhere in the > function. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > ( > if@p1 (\(ret < 0\|ret != 0\)) > { ... return ret; } > | > ret@p1 = 0 > ) > ... when != ret = e1 > when != &ret > *if(...) > { > ... when != ret = e2 > when forall > return ret; > } > > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > sound/ppc/snd_ps3.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/ppc/snd_ps3.c b/sound/ppc/snd_ps3.c > index 1aa52ef..9b18b52 100644 > --- a/sound/ppc/snd_ps3.c > +++ b/sound/ppc/snd_ps3.c > @@ -1040,6 +1040,7 @@ static int __devinit snd_ps3_driver_probe(struct ps3_system_bus_device *dev) > GFP_KERNEL); > if (!the_card.null_buffer_start_vaddr) { > pr_info("%s: nullbuffer alloc failed\n", __func__); > + ret = -ENOMEM; > goto clean_preallocate; > } > pr_debug("%s: null vaddr=%p dma=%#llx\n", __func__, > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <1345359780-18647-1-git-send-email-Julia.Lawall@lip6.fr>]
* [PATCH 9/9] sound/ppc/snd_ps3.c: fix error return code [not found] <1345359780-18647-1-git-send-email-Julia.Lawall@lip6.fr> @ 2012-08-19 7:02 ` Julia Lawall 0 siblings, 0 replies; 6+ messages in thread From: Julia Lawall @ 2012-08-19 7:02 UTC (permalink / raw) To: Geoff Levand Cc: cbe-oss-dev, alsa-devel, Takashi Iwai, kernel-janitors, linux-kernel, Jaroslav Kysela, linuxppc-dev From: Julia Lawall <Julia.Lawall@lip6.fr> Initialize ret before returning on failure, as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- sound/ppc/snd_ps3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/ppc/snd_ps3.c b/sound/ppc/snd_ps3.c index 1aa52ef..9b18b52 100644 --- a/sound/ppc/snd_ps3.c +++ b/sound/ppc/snd_ps3.c @@ -1040,6 +1040,7 @@ static int __devinit snd_ps3_driver_probe(struct ps3_system_bus_device *dev) GFP_KERNEL); if (!the_card.null_buffer_start_vaddr) { pr_info("%s: nullbuffer alloc failed\n", __func__); + ret = -ENOMEM; goto clean_preallocate; } pr_debug("%s: null vaddr=%p dma=%#llx\n", __func__, ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-04-05 12:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1428233914-4503-1-git-send-email-Julia.Lawall@lip6.fr>
2015-04-05 11:38 ` [PATCH 9/9] sound/ppc/snd_ps3.c: fix error return code Julia Lawall
2015-04-05 11:52 ` Geert Uytterhoeven
2015-04-05 12:12 ` Julia Lawall
[not found] <1416746890-22719-1-git-send-email-Julia.Lawall@lip6.fr>
2014-11-23 12:48 ` Julia Lawall
2014-11-23 13:18 ` Julia Lawall
[not found] <1345359780-18647-1-git-send-email-Julia.Lawall@lip6.fr>
2012-08-19 7:02 ` Julia Lawall
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox