* [PATCH] powerpc/numa: Correct kernel message severity
@ 2018-03-13 10:11 Vipin K Parashar
2018-03-13 10:28 ` Christophe LEROY
0 siblings, 1 reply; 3+ messages in thread
From: Vipin K Parashar @ 2018-03-13 10:11 UTC (permalink / raw)
To: linuxppc-dev; +Cc: nfont, Vipin K Parashar
printk in unmap_cpu_from_node() uses KERN_ERR message severity
for a WARNING message. Correct message severity to KERN_WARNING.
Signed-off-by: Vipin K Parashar <vipin@linux.vnet.ibm.com>
---
arch/powerpc/mm/numa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index edd8d0b..79c94cc 100644
--- a/arch/powerpc/mm/numa.c
+++ b/arch/powerpc/mm/numa.c
@@ -163,7 +163,7 @@ static void unmap_cpu_from_node(unsigned long cpu)
if (cpumask_test_cpu(cpu, node_to_cpumask_map[node])) {
cpumask_clear_cpu(cpu, node_to_cpumask_map[node]);
} else {
- printk(KERN_ERR "WARNING: cpu %lu not found in node %d\n",
+ printk(KERN_WARNING "WARNING: cpu %lu not found in node %d\n",
cpu, node);
}
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/numa: Correct kernel message severity
2018-03-13 10:11 [PATCH] powerpc/numa: Correct kernel message severity Vipin K Parashar
@ 2018-03-13 10:28 ` Christophe LEROY
2018-03-14 7:53 ` Vipin K Parashar
0 siblings, 1 reply; 3+ messages in thread
From: Christophe LEROY @ 2018-03-13 10:28 UTC (permalink / raw)
To: Vipin K Parashar, linuxppc-dev; +Cc: nfont
Le 13/03/2018 à 11:11, Vipin K Parashar a écrit :
> printk in unmap_cpu_from_node() uses KERN_ERR message severity
> for a WARNING message. Correct message severity to KERN_WARNING.
>
> Signed-off-by: Vipin K Parashar <vipin@linux.vnet.ibm.com>
> ---
> arch/powerpc/mm/numa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
> index edd8d0b..79c94cc 100644
> --- a/arch/powerpc/mm/numa.c
> +++ b/arch/powerpc/mm/numa.c
> @@ -163,7 +163,7 @@ static void unmap_cpu_from_node(unsigned long cpu)
> if (cpumask_test_cpu(cpu, node_to_cpumask_map[node])) {
> cpumask_clear_cpu(cpu, node_to_cpumask_map[node]);
> } else {
> - printk(KERN_ERR "WARNING: cpu %lu not found in node %d\n",
> + printk(KERN_WARNING "WARNING: cpu %lu not found in node %d\n",
> cpu, node);
Why not take the opportunity to use pr_warn() instead, hence to put back
the cpu and node vars on the same line.
Christophe
> }
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/numa: Correct kernel message severity
2018-03-13 10:28 ` Christophe LEROY
@ 2018-03-14 7:53 ` Vipin K Parashar
0 siblings, 0 replies; 3+ messages in thread
From: Vipin K Parashar @ 2018-03-14 7:53 UTC (permalink / raw)
To: Christophe LEROY, linuxppc-dev; +Cc: nfont
On Tuesday 13 March 2018 03:58 PM, Christophe LEROY wrote:
>
>
> Le 13/03/2018 à 11:11, Vipin K Parashar a écrit :
>> printk in unmap_cpu_from_node() uses KERN_ERR message severity
>> for a WARNING message. Correct message severity to KERN_WARNING.
>>
>> Signed-off-by: Vipin K Parashar <vipin@linux.vnet.ibm.com>
>> ---
>> arch/powerpc/mm/numa.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
>> index edd8d0b..79c94cc 100644
>> --- a/arch/powerpc/mm/numa.c
>> +++ b/arch/powerpc/mm/numa.c
>> @@ -163,7 +163,7 @@ static void unmap_cpu_from_node(unsigned long cpu)
>> if (cpumask_test_cpu(cpu, node_to_cpumask_map[node])) {
>> cpumask_clear_cpu(cpu, node_to_cpumask_map[node]);
>> } else {
>> - printk(KERN_ERR "WARNING: cpu %lu not found in node %d\n",
>> + printk(KERN_WARNING "WARNING: cpu %lu not found in node %d\n",
> > cpu, node);
>
> Why not take the opportunity to use pr_warn() instead, hence to put
> back the cpu and node vars on the same line.
>
> Christophe
>
Yes, Thanks!!
Send v2.
>> }
>> }
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-14 7:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-13 10:11 [PATCH] powerpc/numa: Correct kernel message severity Vipin K Parashar
2018-03-13 10:28 ` Christophe LEROY
2018-03-14 7:53 ` Vipin K Parashar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox