[PATCH-next] powerpc/interrupt: Remove duplicate header file

[PATCH-next] powerpc/interrupt: Remove duplicate header file

[johnny.chenyi]

From: Chen Yi <johnny.chenyi@huawei.com>

Delete one of the header files <asm/interrupt.h> that are included
twice.

Signed-off-by: Chen Yi <johnny.chenyi@huawei.com>
---
 arch/powerpc/kernel/interrupt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/powerpc/kernel/interrupt.c b/arch/powerpc/kernel/interrupt.c
index c4dd4b8f9cfa..f64ace0208b7 100644
--- a/arch/powerpc/kernel/interrupt.c
+++ b/arch/powerpc/kernel/interrupt.c
@@ -7,7 +7,6 @@
 #include <asm/asm-prototypes.h>
 #include <asm/kup.h>
 #include <asm/cputime.h>
-#include <asm/interrupt.h>
 #include <asm/hw_irq.h>
 #include <asm/interrupt.h>
 #include <asm/kprobes.h>
-- 
2.31.0

Re: [PATCH-next] powerpc/interrupt: Remove duplicate header file

[Christophe Leroy]

Le 08/04/2021 à 05:56, johnny.chenyi@huawei.com a écrit :
> From: Chen Yi <johnny.chenyi@huawei.com>
> 
> Delete one of the header files <asm/interrupt.h> that are included
> twice.

Guys, we have been flooded with such tiny patches over the last weeks, some changes being sent 
several times by different people.

That one is included in 
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20210323062916.295346-1-wanjiabing@vivo.com/

And was already submitted a few hours earlier by someone else: 
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/1616464656-59372-1-git-send-email-zhouchuangao@vivo.com/

Could you work all together and cook an overall patch including all duplicate removal from 
arch/powerpc/ files ?

Best way would be I think to file an issue at https://github.com/linuxppc/issues/issues , then you 
do a complete analysis and list in the issue all places to be modified, then once the analysis is 
complete you send a full single patch.

Thanks
Christophe

> 
> Signed-off-by: Chen Yi <johnny.chenyi@huawei.com>
> ---
>   arch/powerpc/kernel/interrupt.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/powerpc/kernel/interrupt.c b/arch/powerpc/kernel/interrupt.c
> index c4dd4b8f9cfa..f64ace0208b7 100644
> --- a/arch/powerpc/kernel/interrupt.c
> +++ b/arch/powerpc/kernel/interrupt.c
> @@ -7,7 +7,6 @@
>   #include <asm/asm-prototypes.h>
>   #include <asm/kup.h>
>   #include <asm/cputime.h>
> -#include <asm/interrupt.h>
>   #include <asm/hw_irq.h>
>   #include <asm/interrupt.h>
>   #include <asm/kprobes.h>
> 

Re: [PATCH-next] powerpc/interrupt: Remove duplicate header file

[Chenyi (Johnny)]

在 2021/4/8 12:57, Christophe Leroy 写道:
> 
> 
> Le 08/04/2021 à 05:56, johnny.chenyi@huawei.com a écrit :
>> From: Chen Yi <johnny.chenyi@huawei.com>
>>
>> Delete one of the header files <asm/interrupt.h> that are included
>> twice.
> 
> Guys, we have been flooded with such tiny patches over the last weeks, 
> some changes being sent several times by different people.
> 
> That one is included in 
> https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20210323062916.295346-1-wanjiabing@vivo.com/ 
> 
> 
> And was already submitted a few hours earlier by someone else: 
> https://patchwork.ozlabs.org/project/linuxppc-dev/patch/1616464656-59372-1-git-send-email-zhouchuangao@vivo.com/ 
> 
> 
> Could you work all together and cook an overall patch including all 
> duplicate removal from arch/powerpc/ files ?
> 
> Best way would be I think to file an issue at 
> https://github.com/linuxppc/issues/issues , then you do a complete 
> analysis and list in the issue all places to be modified, then once the 
> analysis is complete you send a full single patch.
> 
> Thanks
> Christophe
>
Dear Christophe,
	Thanks for your reply, I have checked that thers is no header files 
which has been included twice by mistake in arch/powerpc/.I would file 
an issue next time.

Best regards,
Chen Yi


>>
>> Signed-off-by: Chen Yi <johnny.chenyi@huawei.com>
>> ---
>>   arch/powerpc/kernel/interrupt.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/powerpc/kernel/interrupt.c 
>> b/arch/powerpc/kernel/interrupt.c
>> index c4dd4b8f9cfa..f64ace0208b7 100644
>> --- a/arch/powerpc/kernel/interrupt.c
>> +++ b/arch/powerpc/kernel/interrupt.c
>> @@ -7,7 +7,6 @@
>>   #include <asm/asm-prototypes.h>
>>   #include <asm/kup.h>
>>   #include <asm/cputime.h>
>> -#include <asm/interrupt.h>
>>   #include <asm/hw_irq.h>
>>   #include <asm/interrupt.h>
>>   #include <asm/kprobes.h>
>>
> .