Remove progress msgs from MMU_init()

Remove progress msgs from MMU_init()

[Mark A. Greer]

This dates back to a discussion in May.  This patch addresses point 1)
in the email below by ripping out the progress msgs from MMU_init().
This would allow us to get rid of all the xxx_set_bat() routines in the
various platform files.

Does anyone object to this patch?

Mark

http://ozlabs.org/pipermail/linuxppc-dev/2005-May/019120.html

Re: Remove progress msgs from MMU_init()

[Dan Malek]

On Aug 30, 2005, at 7:38 PM, Mark A. Greer wrote:

> Does anyone object to this patch?

Don't you still need this to run stuff like xmon and kgdb?

Thanks.

	-- Dan

Re: Remove progress msgs from MMU_init()

[Mark A. Greer]

On Tue, Aug 30, 2005 at 09:09:55PM -0400, Dan Malek wrote:
> 
> On Aug 30, 2005, at 7:38 PM, Mark A. Greer wrote:
> 
> >Does anyone object to this patch?
> 
> Don't you still need this to run stuff like xmon and kgdb?

Those should work with just an io_block_mapping() which will be active
before setup_arch() calls xmon() and breakpoint().

The problem with progress msgs in MMU_init() is that they try to bang on
the uart before ioremaps/io_block_mappings are active.  That's why I (and
others) had the xxx_set_bat() hack.

Mark

Remove progress msgs from MMU_init()

[Mark A. Greer]

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

With that patch this time...Argh...
--

This dates back to a discussion in May.  This patch addresses point 1)
in the email below by ripping out the progress msgs from MMU_init().
This would allow us to get rid of all the xxx_set_bat() routines in the
various platform files.

Does anyone object to this patch?

Mark

http://ozlabs.org/pipermail/linuxppc-dev/2005-May/019120.html

[-- Attachment #2: mmu_init.patch --]
[-- Type: text/plain, Size: 1128 bytes --]

diff --git a/arch/ppc/mm/init.c b/arch/ppc/mm/init.c
--- a/arch/ppc/mm/init.c
+++ b/arch/ppc/mm/init.c
@@ -237,9 +237,6 @@ void MMU_setup(void)
  */
 void __init MMU_init(void)
 {
-	if (ppc_md.progress)
-		ppc_md.progress("MMU:enter", 0x111);
-
 	/* parse args from command line */
 	MMU_setup();
 
@@ -272,13 +269,9 @@ void __init MMU_init(void)
 	set_phys_avail(total_lowmem);
 
 	/* Initialize the MMU hardware */
-	if (ppc_md.progress)
-		ppc_md.progress("MMU:hw init", 0x300);
 	MMU_init_hw();
 
 	/* Map in all of RAM starting at KERNELBASE */
-	if (ppc_md.progress)
-		ppc_md.progress("MMU:mapin", 0x301);
 	mapin_ram();
 
 #ifdef CONFIG_HIGHMEM
@@ -289,17 +282,12 @@ void __init MMU_init(void)
 	ioremap_bot = ioremap_base;
 
 	/* Map in I/O resources */
-	if (ppc_md.progress)
-		ppc_md.progress("MMU:setio", 0x302);
 	if (ppc_md.setup_io_mappings)
 		ppc_md.setup_io_mappings();
 
 	/* Initialize the context management stuff */
 	mmu_context_init();
 
-	if (ppc_md.progress)
-		ppc_md.progress("MMU:exit", 0x211);
-
 #ifdef CONFIG_BOOTX_TEXT
 	/* By default, we are no longer mapped */
        	boot_text_mapped = 0;

Re: Remove progress msgs from MMU_init()

[Paul Mackerras]

Mark A. Greer writes:

> Does anyone object to this patch?

Seems fine to me.  Those progress calls are only for debugging.

Paul.

Re: Remove progress msgs from MMU_init()

[Mark A. Greer]

On Wed, Aug 31, 2005 at 01:41:30PM +1000, Paul Mackerras wrote:
> Mark A. Greer writes:
> 
> > Does anyone object to this patch?
> 
> Seems fine to me.  Those progress calls are only for debugging.

Thanks Paul.

I'll send the patch to Andrew as soon as the next -mm patch comes out.

Mark