* [PATCH v3 03/11] tracing/syscalls: add compat syscall metadata [not found] <1476182576-15247-1-git-send-email-marcin.nowakowski@imgtec.com> @ 2016-10-11 10:42 ` Marcin Nowakowski 2016-10-12 8:50 ` Michael Ellerman 2016-10-11 10:42 ` [PATCH v3 08/11] powerpc/tracing: fix compat syscall handling Marcin Nowakowski 1 sibling, 1 reply; 7+ messages in thread From: Marcin Nowakowski @ 2016-10-11 10:42 UTC (permalink / raw) To: linux-kernel Cc: linux-api, luto, rostedt, Marcin Nowakowski, Ingo Molnar, Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman, linuxppc-dev Now that compat syscalls are properly distinguished from native calls, we can add metadata for compat syscalls as well. All the macros used to generate the metadata are the same as for standard syscalls, but with a compat_ prefix to distinguish them easily. Signed-off-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/include/asm/ftrace.h | 15 +++++--- include/linux/compat.h | 74 +++++++++++++++++++++++++++++++++++++++ kernel/trace/trace_syscalls.c | 8 +++-- 3 files changed, 90 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/include/asm/ftrace.h b/arch/powerpc/include/asm/ftrace.h index 686c5f7..9697a73 100644 --- a/arch/powerpc/include/asm/ftrace.h +++ b/arch/powerpc/include/asm/ftrace.h @@ -73,12 +73,17 @@ struct dyn_arch_ftrace { static inline bool arch_syscall_match_sym_name(const char *sym, const char *name) { /* - * Compare the symbol name with the system call name. Skip the .sys or .SyS - * prefix from the symbol name and the sys prefix from the system call name and - * just match the rest. This is only needed on ppc64 since symbol names on - * 32bit do not start with a period so the generic function will work. + * Compare the symbol name with the system call name. Skip the .sys, + * .SyS or .compat_sys prefix from the symbol name and the sys prefix + * from the system call name and just match the rest. This is only + * needed on ppc64 since symbol names on 32bit do not start with a + * period so the generic function will work. */ - return !strcmp(sym + 4, name + 3); + int prefix_len = 3; + + if (!strncasecmp(name, "compat_", 7)) + prefix_len = 10; + return !strcmp(sym + prefix_len + 1, name + prefix_len); } #endif #endif /* CONFIG_FTRACE_SYSCALLS && !__ASSEMBLY__ */ diff --git a/include/linux/compat.h b/include/linux/compat.h index 6360939..ef2a70f 100644 --- a/include/linux/compat.h +++ b/include/linux/compat.h @@ -30,7 +30,80 @@ #define __SC_DELOUSE(t,v) ((t)(unsigned long)(v)) #endif +#ifdef CONFIG_FTRACE_SYSCALLS +#ifndef __SC_STR_ADECL +#define __SC_STR_ADECL(t, a) #a +#endif + +#ifndef __SC_STR_TDECL +#define __SC_STR_TDECL(t, a) #t +#endif + +extern struct trace_event_class event_class_syscall_enter; +extern struct trace_event_class event_class_syscall_exit; +extern struct trace_event_functions enter_syscall_print_funcs; +extern struct trace_event_functions exit_syscall_print_funcs; + +#define COMPAT_SYSCALL_TRACE_ENTER_EVENT(sname) \ + static struct syscall_metadata __syscall_meta_compat_##sname; \ + static struct trace_event_call __used \ + event_enter_compat_##sname = { \ + .class = &event_class_syscall_enter, \ + { \ + .name = "compat_sys_enter"#sname, \ + }, \ + .event.funcs = &enter_syscall_print_funcs, \ + .data = (void *)&__syscall_meta_compat_##sname,\ + .flags = TRACE_EVENT_FL_CAP_ANY, \ + }; \ + static struct trace_event_call __used \ + __attribute__((section("_ftrace_events"))) \ + *__event_enter_compat_##sname = &event_enter_compat_##sname; + +#define COMPAT_SYSCALL_TRACE_EXIT_EVENT(sname) \ + static struct syscall_metadata __syscall_meta_compat_##sname; \ + static struct trace_event_call __used \ + event_exit_compat_##sname = { \ + .class = &event_class_syscall_exit, \ + { \ + .name = "compat_sys_exit"#sname, \ + }, \ + .event.funcs = &exit_syscall_print_funcs, \ + .data = (void *)&__syscall_meta_compat_##sname,\ + .flags = TRACE_EVENT_FL_CAP_ANY, \ + }; \ + static struct trace_event_call __used \ + __attribute__((section("_ftrace_events"))) \ + *__event_exit_compat_##sname = &event_exit_compat_##sname; + +#define COMPAT_SYSCALL_METADATA(sname, nb, ...) \ + static const char *types_compat_##sname[] = { \ + __MAP(nb,__SC_STR_TDECL,__VA_ARGS__) \ + }; \ + static const char *args_compat_##sname[] = { \ + __MAP(nb,__SC_STR_ADECL,__VA_ARGS__) \ + }; \ + COMPAT_SYSCALL_TRACE_ENTER_EVENT(sname); \ + COMPAT_SYSCALL_TRACE_EXIT_EVENT(sname); \ + static struct syscall_metadata __used \ + __syscall_meta_compat_##sname = { \ + .name = "compat_sys"#sname, \ + .nb_args = nb, \ + .types = nb ? types_compat_##sname : NULL, \ + .args = nb ? args_compat_##sname : NULL, \ + .enter_event = &event_enter_compat_##sname, \ + .exit_event = &event_exit_compat_##sname, \ + .enter_fields = LIST_HEAD_INIT(__syscall_meta_compat_##sname.enter_fields), \ + }; \ + static struct syscall_metadata __used \ + __attribute__((section("__syscalls_metadata"))) \ + *__p_syscall_meta_compat_##sname = &__syscall_meta_compat_##sname; +#else +#define COMPAT_SYSCALL_METADATA(sname, nb, ...) +#endif + #define COMPAT_SYSCALL_DEFINE0(name) \ + COMPAT_SYSCALL_METADATA(_##name, 0); \ asmlinkage long compat_sys_##name(void) #define COMPAT_SYSCALL_DEFINE1(name, ...) \ @@ -47,6 +120,7 @@ COMPAT_SYSCALL_DEFINEx(6, _##name, __VA_ARGS__) #define COMPAT_SYSCALL_DEFINEx(x, name, ...) \ + COMPAT_SYSCALL_METADATA(name, x, __VA_ARGS__) \ asmlinkage long compat_sys##name(__MAP(x,__SC_DECL,__VA_ARGS__))\ __attribute__((alias(__stringify(compat_SyS##name)))); \ static inline long C_SYSC##name(__MAP(x,__SC_DECL,__VA_ARGS__));\ diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c index fe7fc33..409f83e 100644 --- a/kernel/trace/trace_syscalls.c +++ b/kernel/trace/trace_syscalls.c @@ -35,12 +35,16 @@ static struct syscall_metadata **syscalls_metadata; static inline bool arch_syscall_match_sym_name(const char *sym, const char *name) { /* - * Only compare after the "sys" prefix. Archs that use + * Only compare after the "sys" or "compat_sys" prefix. Archs that use * syscall wrappers may have syscalls symbols aliases prefixed * with ".SyS" or ".sys" instead of "sys", leading to an unwanted * mismatch. */ - return !strcmp(sym + 3, name + 3); + int prefix_len = 3; + + if (!strncasecmp(sym, "compat_", 7)) + prefix_len = 10; + return !strcmp(sym + prefix_len, name + prefix_len); } #endif -- 2.7.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v3 03/11] tracing/syscalls: add compat syscall metadata 2016-10-11 10:42 ` [PATCH v3 03/11] tracing/syscalls: add compat syscall metadata Marcin Nowakowski @ 2016-10-12 8:50 ` Michael Ellerman 2016-10-12 13:09 ` Marcin Nowakowski 0 siblings, 1 reply; 7+ messages in thread From: Michael Ellerman @ 2016-10-12 8:50 UTC (permalink / raw) To: Marcin Nowakowski, linux-kernel Cc: linux-api, luto, rostedt, Marcin Nowakowski, Ingo Molnar, Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev Marcin Nowakowski <marcin.nowakowski@imgtec.com> writes: > Now that compat syscalls are properly distinguished from native calls, > we can add metadata for compat syscalls as well. > All the macros used to generate the metadata are the same as for > standard syscalls, but with a compat_ prefix to distinguish them easily. > > Signed-off-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com> > Cc: Steven Rostedt <rostedt@goodmis.org> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: linuxppc-dev@lists.ozlabs.org > --- > arch/powerpc/include/asm/ftrace.h | 15 +++++--- > include/linux/compat.h | 74 +++++++++++++++++++++++++++++++++++++++ > kernel/trace/trace_syscalls.c | 8 +++-- > 3 files changed, 90 insertions(+), 7 deletions(-) > > diff --git a/arch/powerpc/include/asm/ftrace.h b/arch/powerpc/include/asm/ftrace.h > index 686c5f7..9697a73 100644 > --- a/arch/powerpc/include/asm/ftrace.h > +++ b/arch/powerpc/include/asm/ftrace.h > @@ -73,12 +73,17 @@ struct dyn_arch_ftrace { > static inline bool arch_syscall_match_sym_name(const char *sym, const char *name) > { > /* > - * Compare the symbol name with the system call name. Skip the .sys or .SyS > - * prefix from the symbol name and the sys prefix from the system call name and > - * just match the rest. This is only needed on ppc64 since symbol names on > - * 32bit do not start with a period so the generic function will work. > + * Compare the symbol name with the system call name. Skip the .sys, > + * .SyS or .compat_sys prefix from the symbol name and the sys prefix > + * from the system call name and just match the rest. This is only > + * needed on ppc64 since symbol names on 32bit do not start with a > + * period so the generic function will work. > */ > - return !strcmp(sym + 4, name + 3); > + int prefix_len = 3; > + > + if (!strncasecmp(name, "compat_", 7)) > + prefix_len = 10; > + return !strcmp(sym + prefix_len + 1, name + prefix_len); > } It's annoying that we have to duplicate all that just to do a + 1. How about this as a precursor? cheers diff --git a/Documentation/trace/ftrace-design.txt b/Documentation/trace/ftrace-design.txt index dd5f916b351d..bd65f2adeb09 100644 --- a/Documentation/trace/ftrace-design.txt +++ b/Documentation/trace/ftrace-design.txt @@ -226,10 +226,6 @@ You need very few things to get the syscalls tracing in an arch. - If the system call table on this arch is more complicated than a simple array of addresses of the system calls, implement an arch_syscall_addr to return the address of a given system call. -- If the symbol names of the system calls do not match the function names on - this arch, define ARCH_HAS_SYSCALL_MATCH_SYM_NAME in asm/ftrace.h and - implement arch_syscall_match_sym_name with the appropriate logic to return - true if the function name corresponds with the symbol name. - Tag this arch as HAVE_SYSCALL_TRACEPOINTS. diff --git a/arch/powerpc/include/asm/ftrace.h b/arch/powerpc/include/asm/ftrace.h index 686c5f70eb84..dc48f5b2878d 100644 --- a/arch/powerpc/include/asm/ftrace.h +++ b/arch/powerpc/include/asm/ftrace.h @@ -60,6 +60,12 @@ struct dyn_arch_ftrace { struct module *mod; }; #endif /* CONFIG_DYNAMIC_FTRACE */ + +#ifdef PPC64_ELF_ABI_v1 +/* On ppc64 ABIv1 (BE) we have to skip the leading '.' in the symbol name */ +#define ARCH_SYM_NAME_SKIP_CHARS 1 +#endif + #endif /* __ASSEMBLY__ */ #ifdef CONFIG_DYNAMIC_FTRACE_WITH_REGS @@ -67,20 +73,4 @@ struct dyn_arch_ftrace { #endif #endif -#if defined(CONFIG_FTRACE_SYSCALLS) && !defined(__ASSEMBLY__) -#ifdef PPC64_ELF_ABI_v1 -#define ARCH_HAS_SYSCALL_MATCH_SYM_NAME -static inline bool arch_syscall_match_sym_name(const char *sym, const char *name) -{ - /* - * Compare the symbol name with the system call name. Skip the .sys or .SyS - * prefix from the symbol name and the sys prefix from the system call name and - * just match the rest. This is only needed on ppc64 since symbol names on - * 32bit do not start with a period so the generic function will work. - */ - return !strcmp(sym + 4, name + 3); -} -#endif -#endif /* CONFIG_FTRACE_SYSCALLS && !__ASSEMBLY__ */ - #endif /* _ASM_POWERPC_FTRACE */ diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c index b2b6efc083a4..91a7315dbe43 100644 --- a/kernel/trace/trace_syscalls.c +++ b/kernel/trace/trace_syscalls.c @@ -31,8 +31,11 @@ extern struct syscall_metadata *__stop_syscalls_metadata[]; static struct syscall_metadata **syscalls_metadata; -#ifndef ARCH_HAS_SYSCALL_MATCH_SYM_NAME -static inline bool arch_syscall_match_sym_name(const char *sym, const char *name) +#ifndef ARCH_SYM_NAME_SKIP_CHARS +#define ARCH_SYM_NAME_SKIP_CHARS 0 +#endif + +static inline bool syscall_match_sym_name(const char *sym, const char *name) { /* * Only compare after the "sys" prefix. Archs that use @@ -40,9 +43,8 @@ static inline bool arch_syscall_match_sym_name(const char *sym, const char *name * with ".SyS" or ".sys" instead of "sys", leading to an unwanted * mismatch. */ - return !strcmp(sym + 3, name + 3); + return !strcmp(sym + 3 + ARCH_SYM_NAME_SKIP_CHARS, name + 3); } -#endif #ifdef ARCH_TRACE_IGNORE_COMPAT_SYSCALLS /* @@ -88,11 +90,11 @@ find_syscall_meta(unsigned long syscall) stop = __stop_syscalls_metadata; kallsyms_lookup(syscall, NULL, NULL, NULL, str); - if (arch_syscall_match_sym_name(str, "sys_ni_syscall")) + if (syscall_match_sym_name(str, "sys_ni_syscall")) return NULL; for ( ; start < stop; start++) { - if ((*start)->name && arch_syscall_match_sym_name(str, (*start)->name)) + if ((*start)->name && syscall_match_sym_name(str, (*start)->name)) return *start; } return NULL; ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v3 03/11] tracing/syscalls: add compat syscall metadata 2016-10-12 8:50 ` Michael Ellerman @ 2016-10-12 13:09 ` Marcin Nowakowski 2016-10-13 9:33 ` Michael Ellerman 0 siblings, 1 reply; 7+ messages in thread From: Marcin Nowakowski @ 2016-10-12 13:09 UTC (permalink / raw) To: Michael Ellerman, linux-kernel Cc: linux-api, luto, rostedt, Ingo Molnar, Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev On 12.10.2016 10:50, Michael Ellerman wrote: > <...> > It's annoying that we have to duplicate all that just to do a + 1. > > How about this as a precursor? > <...> Thanks for the suggestion - unless anyone sees a reason to keep the current solution I'll change it. Marcin ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 03/11] tracing/syscalls: add compat syscall metadata 2016-10-12 13:09 ` Marcin Nowakowski @ 2016-10-13 9:33 ` Michael Ellerman 0 siblings, 0 replies; 7+ messages in thread From: Michael Ellerman @ 2016-10-13 9:33 UTC (permalink / raw) To: Marcin Nowakowski, linux-kernel Cc: linux-api, luto, rostedt, Ingo Molnar, Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev Marcin Nowakowski <marcin.nowakowski@imgtec.com> writes: > On 12.10.2016 10:50, Michael Ellerman wrote: >> <...> >> It's annoying that we have to duplicate all that just to do a + 1. >> >> How about this as a precursor? > > <...> > > Thanks for the suggestion - unless anyone sees a reason to keep the > current solution I'll change it. Thanks. I forgot to add my SOB so here it is: Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> cheers ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3 08/11] powerpc/tracing: fix compat syscall handling [not found] <1476182576-15247-1-git-send-email-marcin.nowakowski@imgtec.com> 2016-10-11 10:42 ` [PATCH v3 03/11] tracing/syscalls: add compat syscall metadata Marcin Nowakowski @ 2016-10-11 10:42 ` Marcin Nowakowski 2016-10-12 9:59 ` Michael Ellerman 1 sibling, 1 reply; 7+ messages in thread From: Marcin Nowakowski @ 2016-10-11 10:42 UTC (permalink / raw) To: linux-kernel Cc: linux-api, luto, rostedt, Marcin Nowakowski, Ingo Molnar, Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman, linuxppc-dev Adapt the code to make use of new syscall handling interface Signed-off-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/include/asm/ftrace.h | 11 +++++++++++ arch/powerpc/kernel/ftrace.c | 4 ++++ 2 files changed, 15 insertions(+) diff --git a/arch/powerpc/include/asm/ftrace.h b/arch/powerpc/include/asm/ftrace.h index 9697a73..d2ea3b6 100644 --- a/arch/powerpc/include/asm/ftrace.h +++ b/arch/powerpc/include/asm/ftrace.h @@ -86,6 +86,17 @@ static inline bool arch_syscall_match_sym_name(const char *sym, const char *name return !strcmp(sym + prefix_len + 1, name + prefix_len); } #endif + +#if defined(CONFIG_COMPAT) +#include <linux/compat.h> +#include <asm/compat.h> + +#define ARCH_COMPAT_SYSCALL_NUMBERS_OVERLAP 1 +static inline bool arch_trace_is_compat_syscall(struct pt_regs *regs) +{ + return in_compat_syscall(); +} +#endif /* CONFIG_COMPAT */ #endif /* CONFIG_FTRACE_SYSCALLS && !__ASSEMBLY__ */ #endif /* _ASM_POWERPC_FTRACE */ diff --git a/arch/powerpc/kernel/ftrace.c b/arch/powerpc/kernel/ftrace.c index 5bfb35f..12c00f7 100644 --- a/arch/powerpc/kernel/ftrace.c +++ b/arch/powerpc/kernel/ftrace.c @@ -606,6 +606,10 @@ unsigned long prepare_ftrace_return(unsigned long parent, unsigned long ip) #if defined(CONFIG_FTRACE_SYSCALLS) && defined(CONFIG_PPC64) unsigned long __init arch_syscall_addr(int nr, bool compat) { +#ifdef CONFIG_COMPAT + if (compat) + return sys_call_table[nr*2+1]; +#endif return sys_call_table[nr*2]; } #endif /* CONFIG_FTRACE_SYSCALLS && CONFIG_PPC64 */ -- 2.7.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v3 08/11] powerpc/tracing: fix compat syscall handling 2016-10-11 10:42 ` [PATCH v3 08/11] powerpc/tracing: fix compat syscall handling Marcin Nowakowski @ 2016-10-12 9:59 ` Michael Ellerman 2016-10-12 13:10 ` Marcin Nowakowski 0 siblings, 1 reply; 7+ messages in thread From: Michael Ellerman @ 2016-10-12 9:59 UTC (permalink / raw) To: Marcin Nowakowski, linux-kernel Cc: linux-api, luto, rostedt, Marcin Nowakowski, Ingo Molnar, Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev Marcin Nowakowski <marcin.nowakowski@imgtec.com> writes: > Adapt the code to make use of new syscall handling interface > > Signed-off-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com> > Cc: Steven Rostedt <rostedt@goodmis.org> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: linuxppc-dev@lists.ozlabs.org > --- > arch/powerpc/include/asm/ftrace.h | 11 +++++++++++ > arch/powerpc/kernel/ftrace.c | 4 ++++ I went to test this and noticed the exit and enter events appear to be reversed in time? (your series on top of 24532f768121) ls-4221 [003] .... 83.766113: compat_sys_rt_sigprocmask -> 0x2 ls-4221 [003] .... 83.766137: compat_sys_rt_sigprocmask(how: 2, nset: 1010db30, oset: 0, sigsetsize: 8) ls-4221 [003] .... 83.766175: compat_sys_rt_sigaction -> 0x14 ls-4221 [003] .... 83.766175: compat_sys_rt_sigaction(sig: 14, act: ffbd33c4, oact: ffbd3338, sigsetsize: 8) ls-4221 [003] .... 83.766177: compat_sys_rt_sigaction -> 0x15 ls-4221 [003] .... 83.766177: compat_sys_rt_sigaction(sig: 15, act: ffbd33c4, oact: ffbd3338, sigsetsize: 8) ls-4221 [003] .... 83.766178: compat_sys_rt_sigaction -> 0x16 ls-4221 [003] .... 83.766178: compat_sys_rt_sigaction(sig: 16, act: ffbd33d4, oact: ffbd3348, sigsetsize: 8) ls-4221 [003] .... 83.766179: sys_setpgid -> 0x107d ls-4221 [003] .... 83.766179: sys_setpgid(pid: 107d, pgid: 107d) ls-4221 [003] .... 83.766180: compat_sys_rt_sigprocmask -> 0x0 ls-4221 [003] .... 83.766181: compat_sys_rt_sigprocmask(how: 0, nset: ffbd34b0, oset: ffbd3530, sigsetsize: 8) ls-4221 [003] .... 83.766186: compat_sys_ioctl -> 0xff ls-4221 [003] .... 83.766187: compat_sys_ioctl(fd: ff, cmd: 80047476, arg32: ffbd3488) ls-4221 [003] .... 83.766188: compat_sys_rt_sigprocmask -> 0x2 ls-4221 [003] .... 83.766189: compat_sys_rt_sigprocmask(how: 2, nset: ffbd3530, oset: 0, sigsetsize: 8) ls-4221 [003] .... 83.766189: sys_close -> 0x4 ls-4221 [003] .... 83.766190: sys_close(fd: 4) ls-4221 [003] .... 83.766191: sys_read -> 0x3 ls-4221 [003] .... 83.766191: sys_read(fd: 3, buf: ffbd35dc, count: 1) ls-4221 [003] .... 83.766235: sys_close -> 0x3 ls-4221 [003] .... 83.766235: sys_close(fd: 3) cheers ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 08/11] powerpc/tracing: fix compat syscall handling 2016-10-12 9:59 ` Michael Ellerman @ 2016-10-12 13:10 ` Marcin Nowakowski 0 siblings, 0 replies; 7+ messages in thread From: Marcin Nowakowski @ 2016-10-12 13:10 UTC (permalink / raw) To: Michael Ellerman, linux-kernel Cc: linux-api, luto, rostedt, Ingo Molnar, Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev On 12.10.2016 11:59, Michael Ellerman wrote: > I went to test this and noticed the exit and enter events appear to be > reversed in time? (your series on top of 24532f768121) thanks for testing the patch - I've found a bug that has sneaked in while cleaning up the patches before submission ... I'll fix it in the next iteration. Marcin ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-10-13 9:33 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1476182576-15247-1-git-send-email-marcin.nowakowski@imgtec.com>
2016-10-11 10:42 ` [PATCH v3 03/11] tracing/syscalls: add compat syscall metadata Marcin Nowakowski
2016-10-12 8:50 ` Michael Ellerman
2016-10-12 13:09 ` Marcin Nowakowski
2016-10-13 9:33 ` Michael Ellerman
2016-10-11 10:42 ` [PATCH v3 08/11] powerpc/tracing: fix compat syscall handling Marcin Nowakowski
2016-10-12 9:59 ` Michael Ellerman
2016-10-12 13:10 ` Marcin Nowakowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox