* Re: mpc8568e-mds: pci-e is broken
From: Kumar Gala @ 2008-01-23 22:04 UTC (permalink / raw)
To: avorontsov; +Cc: linuxppc-dev
In-Reply-To: <20080123195022.GA21157@localhost.localdomain>
On Jan 23, 2008, at 1:50 PM, Anton Vorontsov wrote:
> On Wed, Jan 23, 2008 at 01:42:56PM -0600, Kumar Gala wrote:
> [...]
>>> PCI: Probing PCI hardware
>>> PCI: 0001:01:00.0: class b20 doesn't match header type 01. Ignoring
>>> class.
>>> PCI: Closing bogus Apple Firmware region 1 on bus 0x02
>>> PCI: Closing bogus Apple Firmware region 2 on bus 0x02
>>
>> odd, you shouldn't see these anymore w/my git tree.
>
> Yup, I noticed few commits that are trying to fix this. And these
> fixes do work for PCI, but not for PCI-E...
I see these now.. I think I'm too lazy to think of a way to fix this.
> [...]
>>> static void __devinit __pcibios_fixup_bus(struct pci_bus *bus)
>>> {
>>> ...
>>> if (i >= 3 && bus->self->transparent)
>>> continue;
>>> ...
>>> }
>>>
>>> That new check doesn't work, here bus->self->transparent == 0.
>>> Could it be that the message below is the root cause?
>>>
>>> PCI: 0001:01:00.0: class b20 doesn't match header type 01. Ignoring
>>> class.
>>
>> this is expected but of how FSL hw reports itself.
>
> Well. I see only two places were transparent flag is applied:
> drivers/pci/quirks.c:quirk_transparent_bridge()
> and
> drivers/pci/probe.c:pci_setup_device() in the PCI_HEADER_TYPE_BRIDGE.
>
> So, obviously probe.c is skipping our PCI-E, thus not setting
> transparent flag, no?
>
>>> I.e. drivers/pci/probe.c just don't setting transparent flag.
>>> I wonder if we need use quirk_transparent_bridge() here or
>>> we can fix it other way?
>>>
>>> Just in case, I'm observing that message for a long long time, and
>>> it didn't tell upon any functionality till now.
>>
>>
>> Is this with the 8568 MDS in standalone or plugged into the back
>> pane?
>
> This is standalone setup.
do you have a card plugged in?
- k
^ permalink raw reply
* Re: [PATCH v6] [POWERPC] Add LED driver for Promess Motion-PRO board.
From: Stephen Rothwell @ 2008-01-23 22:34 UTC (permalink / raw)
To: Marian Balakowicz; +Cc: linuxppc-dev
In-Reply-To: <20080123121159.21197.37027.stgit@zion.izotz.org>
[-- Attachment #1: Type: text/plain, Size: 541 bytes --]
Hi Marian,
On Wed, 23 Jan 2008 13:12:19 +0100 Marian Balakowicz <m8@semihalf.com> wrote:
>
> + label = of_get_property(op->node, "label", NULL);
> + if (label == NULL) {
> + printk(KERN_ERR __FILE__ ": "
> + "No label property provided for LED %s\n",
> + op->node->full_name);
> + err = -EINVAL;
> + goto err_free;
You need an iounmap(mpled->gpt) here - or preferably jump to the one in
the error path below.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply
* Re: [PATCH] [POWERPC] Move RapidIO support code from arch/ppc
From: Stephen Rothwell @ 2008-01-23 22:40 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev, Wei.Zhang
In-Reply-To: <Pine.LNX.4.64.0801230637510.4478@blarg.am.freescale.net>
[-- Attachment #1: Type: text/plain, Size: 1154 bytes --]
Hi Kumar,
On Wed, 23 Jan 2008 06:38:29 -0600 (CST) Kumar Gala <galak@kernel.crashing.org> wrote:
>
> +++ b/arch/ppc/platforms/85xx/mpc85xx_ads_common.c
> @@ -190,6 +188,7 @@ mpc85xx_exclude_device(u_char bus, u_char devfn)
> #endif /* CONFIG_PCI */
>
> #ifdef CONFIG_RAPIDIO
> +extern void mpc85xx_rio_setup(int law_start, int law_size);
Ooops! This should be in a header file, of course.
> +++ b/arch/ppc/platforms/85xx/stx_gp3.c
> @@ -270,6 +269,7 @@ int mpc85xx_exclude_device(u_char bus, u_char devfn)
> #endif /* CONFIG_PCI */
>
> #ifdef CONFIG_RAPIDIO
> +extern void mpc85xx_rio_setup(int law_start, int law_size);
And again.
I guess this is just temporary in which case we can probably live with
it. But do not forget to fix it up.
> +++ b/arch/ppc/platforms/85xx/tqm85xx.c
> @@ -309,6 +308,7 @@ int mpc85xx_exclude_device(u_char bus, u_char devfn)
> #endif /* CONFIG_PCI */
>
> #ifdef CONFIG_RAPIDIO
> +extern void mpc85xx_rio_setup(int law_start, int law_size);
Third time lucky? :-)
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply
* Re: [PATCHv2 7/8] [POWERPC] Rename commproc to cpm1 and cpm2_common.c to cpm2.c
From: Stephen Rothwell @ 2008-01-23 22:57 UTC (permalink / raw)
To: Jochen Friedrich; +Cc: Scott Wood, Kernel, Linux, linuxppc-dev list
In-Reply-To: <479764F5.1000105@scram.de>
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
Hi Jochen,
On Wed, 23 Jan 2008 17:01:57 +0100 Jochen Friedrich <jochen@scram.de> wrote:
>
> +++ b/arch/powerpc/platforms/8xx/ep88xc.c
> @@ -15,7 +15,7 @@
> #include <asm/machdep.h>
> #include <asm/io.h>
> #include <asm/udbg.h>
> -#include <asm/commproc.h>
> +#include <asm/cpm1.h>
> #include <asm/mpc8xx.h>
Something has whitespace damaged this patch.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply
* Re: [MPC5200] problem running FEC and ATA
From: Wolfgang Denk @ 2008-01-23 22:58 UTC (permalink / raw)
To: Mehlan, Markus (Ritter Elektronik); +Cc: linuxppc-dev
In-Reply-To: <FACFFB02D783C64FB2CEF2D6825F6FC206EEF1CF@SRVEXC01.sts.saurer.vpn>
In message <FACFFB02D783C64FB2CEF2D6825F6FC206EEF1CF@SRVEXC01.sts.saurer.vpn> you wrote:
>
> > Is it really exactly the same CPU revision? My guess is that
> > one is rev. B and the other one is older...
>
> The processor on my board which needs the BSDIS-patch has following
> label:
> MPC5200CVR400B
And the one which doesn't need it is a ...?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
I'd rather be led to hell than managed to heaven.
^ permalink raw reply
* Re: [MPC5200] problem running FEC and ATA
From: Wolfgang Denk @ 2008-01-23 23:01 UTC (permalink / raw)
To: Juergen Beisert; +Cc: linuxppc-dev, Mehlan, Markus (Ritter Elektronik)
In-Reply-To: <200801231003.15045.jbe@pengutronix.de>
In message <200801231003.15045.jbe@pengutronix.de> you wrote:
>
> The one who needs this patch (CPU card vendor 1):
>
> MPC5200CVR400B, M62C REV 1, QCW0723T
>
> The CPUs who do not need this patch (CPU card vendor 2):
>
> SPC5200CBV400B, M62C REV 1, QAG0610C
> MPC5200CVR400B, M62C REV 1, QAJ0613F
This is all Rev. B stuff, and the patch should be applied to all of
them (actually the patch can always be applied - it will be activated
depending on the PVR reading).
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
It is impractical for the standard to attempt to constrain the
behavior of code that does not obey the constraints of the standard.
- Doug Gwyn
^ permalink raw reply
* [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c
From: Roel Kluin @ 2008-01-23 22:37 UTC (permalink / raw)
To: jwboyer, lkml; +Cc: linuxppc-dev
logical/bitand typo
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c
index ebf9e21..dcfb459 100644
--- a/arch/powerpc/boot/4xx.c
+++ b/arch/powerpc/boot/4xx.c
@@ -104,7 +104,7 @@ void ibm4xx_denali_fixup_memsize(void)
val = DDR_GET_VAL(val, DDR_CS_MAP, DDR_CS_MAP_SHIFT);
cs = 0;
while (val) {
- if (val && 0x1)
+ if (val & 0x1)
cs++;
val = val >> 1;
}
^ permalink raw reply related
* Re: [PATCH] [POWERPC] Move RapidIO support code from arch/ppc
From: Kumar Gala @ 2008-01-23 23:00 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linuxppc-dev, Wei.Zhang
In-Reply-To: <20080124094017.8afc5077.sfr@canb.auug.org.au>
On Jan 23, 2008, at 4:40 PM, Stephen Rothwell wrote:
> Hi Kumar,
>
> On Wed, 23 Jan 2008 06:38:29 -0600 (CST) Kumar Gala <galak@kernel.crashing.org
> > wrote:
>>
>> +++ b/arch/ppc/platforms/85xx/mpc85xx_ads_common.c
>> @@ -190,6 +188,7 @@ mpc85xx_exclude_device(u_char bus, u_char devfn)
>> #endif /* CONFIG_PCI */
>>
>> #ifdef CONFIG_RAPIDIO
>> +extern void mpc85xx_rio_setup(int law_start, int law_size);
>
> Ooops! This should be in a header file, of course.
>
>> +++ b/arch/ppc/platforms/85xx/stx_gp3.c
>> @@ -270,6 +269,7 @@ int mpc85xx_exclude_device(u_char bus, u_char
>> devfn)
>> #endif /* CONFIG_PCI */
>>
>> #ifdef CONFIG_RAPIDIO
>> +extern void mpc85xx_rio_setup(int law_start, int law_size);
>
> And again.
>
> I guess this is just temporary in which case we can probably live with
> it. But do not forget to fix it up.
>
>> +++ b/arch/ppc/platforms/85xx/tqm85xx.c
>> @@ -309,6 +308,7 @@ int mpc85xx_exclude_device(u_char bus, u_char
>> devfn)
>> #endif /* CONFIG_PCI */
>>
>> #ifdef CONFIG_RAPIDIO
>> +extern void mpc85xx_rio_setup(int law_start, int law_size);
>
> Third time lucky? :-)
They were in a header file, however in moving the code over the header
ends up in arch/powerpc/sysdev/fsl_rio.h. I don't think there is a
simple way to include that in arch/ppc code today (and I don't want to
invent one).
My goal is to just kill 85xx for arch/ppc.
- k
^ permalink raw reply
* Re: [PATCH v2] Fix handling of memreserve if the range lands in highmem
From: Paul Mackerras @ 2008-01-23 23:04 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
In-Reply-To: <Pine.LNX.4.64.0801100120290.13810@blarg.am.freescale.net>
Kumar Gala writes:
> There were several issues if a memreserve range existed and happened
> to be in highmem:
>
> * The bootmem allocator is only aware of lowmem so calling
> reserve_bootmem with a highmem address would cause a BUG_ON
> * All highmem pages were provided to the buddy allocator
>
> Added a lmb_is_reserved() api that we now use to determine if a highem
> page should continue to be PageReserved or provided to the buddy
> allocator.
>
> Also, we incorrectly reported the amount of pages reserved since all
> highmem pages are initally marked reserved and we clear the
> PageReserved flag as we "free" up the highmem pages.
This patch breaks all the 64-bit configs since 64-bit doesn't have
total_lowmem. The extra complexity is only needed in the
CONFIG_HIGHMEM case, so an ifdef would be one solution, though an ugly
one. We do already have an ifdef just above the place you changed in
arch/powerpc/mm/mem.c which you could just enlarge rather than adding
a new ifdef.
And clearly I can't pull your tree until this is sorted somehow...
Paul.
^ permalink raw reply
* Re: mpc8568e-mds: pci-e is broken
From: Kumar Gala @ 2008-01-23 23:02 UTC (permalink / raw)
To: avorontsov; +Cc: linuxppc-dev
In-Reply-To: <B4582CB3-2065-40D5-9C16-B0EE1943D83A@kernel.crashing.org>
Anton,
Can you try this patch and see if it resolves the issue for you.. (You'll
still get the Apple FW messages)
- k
diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c
index 4005739..bf13c21 100644
--- a/arch/powerpc/sysdev/fsl_pci.c
+++ b/arch/powerpc/sysdev/fsl_pci.c
@@ -133,22 +133,23 @@ void fsl_pcibios_fixup_bus(struct pci_bus *bus)
struct pci_controller *hose = (struct pci_controller *) bus->sysdata;
int i;
- /* deal with bogus pci_bus when we don't have anything connected on PCIe */
- if (hose->indirect_type & PPC_INDIRECT_TYPE_NO_PCIE_LINK) {
- if (bus->parent) {
- for (i = 0; i < 4; ++i)
- bus->resource[i] = bus->parent->resource[i];
- }
- }
-
- if (fsl_pcie_bus_fixup &&
- (bus->parent == hose->bus) &&
- early_find_capability(hose, 0, 0, PCI_CAP_ID_EXP)) {
+ if ((bus->parent == hose->bus) &&
+ ((fsl_pcie_bus_fixup &&
+ early_find_capability(hose, 0, 0, PCI_CAP_ID_EXP)) ||
+ (hose->indirect_type & PPC_INDIRECT_TYPE_NO_PCIE_LINK)))
+ {
for (i = 0; i < 4; ++i) {
- if (bus->resource[i] && bus->parent->resource[i]) {
- bus->resource[i]->start = bus->parent->resource[i]->start;
- bus->resource[i]->end = bus->parent->resource[i]->end;
- bus->resource[i]->flags = bus->parent->resource[i]->flags;
+ struct resource *res = bus->resource[i];
+ struct resource *par = bus->parent->resource[i];
+ if (res) {
+ res->start = 0;
+ res->end = 0;
+ res->flags = 0;
+ }
+ if (res && par) {
+ res->start = par->start;
+ res->end = par->end;
+ res->flags = par->flags;
}
}
}
^ permalink raw reply related
* Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c
From: Joe Perches @ 2008-01-23 23:05 UTC (permalink / raw)
To: Roel Kluin, Andy Whitcroft; +Cc: linuxppc-dev, lkml
In-Reply-To: <4797C1AD.3040307@tiscali.nl>
On Wed, 2008-01-23 at 23:37 +0100, Roel Kluin wrote:
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c
> index ebf9e21..dcfb459 100644
> --- a/arch/powerpc/boot/4xx.c
> +++ b/arch/powerpc/boot/4xx.c
> @@ -104,7 +104,7 @@ void ibm4xx_denali_fixup_memsize(void)
> val = DDR_GET_VAL(val, DDR_CS_MAP, DDR_CS_MAP_SHIFT);
> cs = 0;
> while (val) {
> - if (val && 0x1)
> + if (val & 0x1)
> cs++;
> val = val >> 1;
I think this pattern should be added to checkpatch
Signed-off-by: Joe Perches <joe@perches.com>
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 579f50f..147e573 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1337,6 +1337,11 @@ sub process {
}
}
+# Check for bitwise tests written as boolean
+ if ($line =~ /\&\&\s*0[xX]/) {
+ WARN("boolean test with hexadecimal, perhaps just 1 \&?\n" . $herecurr);
+ }
+
# if and else should not have general statements after it
if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/ &&
$1 !~ /^\s*(?:\sif|{|\\|$)/) {
^ permalink raw reply related
* Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c
From: Roel Kluin @ 2008-01-24 0:18 UTC (permalink / raw)
To: Joe Perches; +Cc: linuxppc-dev, lkml
In-Reply-To: <1201129527.4988.69.camel@localhost>
Joe Perches wrote:
> On Wed, 2008-01-23 at 23:37 +0100, Roel Kluin wrote:
>> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
>> ---
>> diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c
>> index ebf9e21..dcfb459 100644
>> --- a/arch/powerpc/boot/4xx.c
>> +++ b/arch/powerpc/boot/4xx.c
>> @@ -104,7 +104,7 @@ void ibm4xx_denali_fixup_memsize(void)
>> val = DDR_GET_VAL(val, DDR_CS_MAP, DDR_CS_MAP_SHIFT);
>> cs = 0;
>> while (val) {
>> - if (val && 0x1)
>> + if (val & 0x1)
>> cs++;
>> val = val >> 1;
>
> I think this pattern should be added to checkpatch
I agree but...
> Signed-off-by: Joe Perches <joe@perches.com>
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 579f50f..147e573 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1337,6 +1337,11 @@ sub process {
> }
> }
>
> +# Check for bitwise tests written as boolean
> + if ($line =~ /\&\&\s*0[xX]/) {
> + WARN("boolean test with hexadecimal, perhaps just 1 \&?\n" . $herecurr);
> + }
> +
when you use git-grep -n "\(&&\|||\)${s}0x\([A-Z0-9]*\|[a-z0-9]*\)",
(with s="[[:space:]]*") there will be false positives like
if (relocation < -0x20000 || 0x1fffc < relocation)
if (ARCH_SUN4C_SUN4 && addr < 0xe0000000 && 0x20000000 - len < addr) {
(and more)
However, if you search with
git-grep -n " \(&&\|||\)${s}0x\([A-Z0-9]*\|[a-z0-9]*\)$s\()\|&&\|||\)"
you won't get these false positives, but you do get the one I fixed.
Also there is the same logic flipped (though it did not give matches at
this time):
git-grep -n " \(&&\|||\|(\)${s}0x\([A-Z0-9]*\|[a-z0-9]*\)$s\(&&\|||\)"
so i'd propose to change that to
--
Catch boolean tests with hexadecimals, based on suggestion by Joe Perches
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 579f50f..8ac7c7b 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1337,6 +1337,12 @@ sub process {
}
}
+# Check for bitwise tests written as boolean
+ if ($line =~ /(?:(?:\(|\&\&|\|\|)\s*0[xX]\s*(?:&&|\|\|)|
+ (?:\&\&|\|\|)\s*0[xX]\s*(?:\)|&&|\|\|))/) {
+ WARN("boolean test with hexadecimal, perhaps just 1 \& or \|?\n" . $herecurr);
+ }
+
# if and else should not have general statements after it
if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/ &&
$1 !~ /^\s*(?:\sif|{|\\|$)/) {
^ permalink raw reply related
* Re: [PATCH 3/4 v4] POWERPC: Add initial iomega StorCenter board port.
From: Stephen Rothwell @ 2008-01-24 0:50 UTC (permalink / raw)
To: Jon Loeliger; +Cc: linuxppc-dev
In-Reply-To: <E1JHkYk-00010g-M2@jdl.com>
[-- Attachment #1: Type: text/plain, Size: 654 bytes --]
Hi Jon,
On Wed, 23 Jan 2008 12:42:50 -0600 Jon Loeliger <jdl@jdl.com> wrote:
>
> +++ b/arch/powerpc/platforms/embedded6xx/storcenter.c
> +static void __init storcenter_init_IRQ(void)
> +{
> + struct mpic *mpic;
> + struct device_node *dnp;
> + const void *prop;
> + int size;
> + phys_addr_t paddr;
> +
> + dnp = of_find_node_by_type(NULL, "open-pic");
> + if (dnp == NULL)
> + return;
> +
> + prop = of_get_property(dnp, "reg", &size);
> + if (prop == NULL)
> + return;
You need an of_node_put(dnp) before you return.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply
* Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c
From: Joe Perches @ 2008-01-24 0:39 UTC (permalink / raw)
To: Roel Kluin; +Cc: linuxppc-dev, lkml
In-Reply-To: <4797D968.1030101@tiscali.nl>
On Thu, 2008-01-24 at 01:18 +0100, Roel Kluin wrote:
> when you use git-grep -n "\(&&\|||\)${s}0x\([A-Z0-9]*\|[a-z0-9]*\)",
> (with s="[[:space:]]*") there will be false positives []
> so i'd propose to change that to
> +# Check for bitwise tests written as boolean
> + if ($line =~ /(?:(?:\(|\&\&|\|\|)\s*0[xX]\s*(?:&&|\|\|)|
> + (?:\&\&|\|\|)\s*0[xX]\s*(?:\)|&&|\|\|))/) {
> + WARN("boolean test with hexadecimal, perhaps just 1 \& or \|?\n" . $herecurr);
> + }
> +
All 13 false positives are "hex_constant logical_test variable".
I think that Linus would say that they are all poor style.
Still, fine by me. cheers, Joe
^ permalink raw reply
* USB device for ppc440epx
From: Leonid @ 2008-01-24 1:01 UTC (permalink / raw)
To: linuxppc-embedded
In-Reply-To: <20080123193557.AF0C8670018@mail194-sin.bigfish.com>
Hi:
does somebody have code example for USB 2.0 device implementation for
ppc440epx, preferably Mass Storage device, but any will do.
If not for ppc440epx (Sequoia board), ppc440ep (Yosemite) code will also
help (according to CPU user manual USB device interface is practically
the same).
If this is already present in Linux kernel tree (from what version?),
where it is located?=20
Thanks,
Leonid.
^ permalink raw reply
* Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c
From: Josh Boyer @ 2008-01-24 1:17 UTC (permalink / raw)
To: Roel Kluin; +Cc: linuxppc-dev, sr, lkml
In-Reply-To: <4797C1AD.3040307@tiscali.nl>
On Wed, 23 Jan 2008 23:37:33 +0100
Roel Kluin <12o3l@tiscali.nl> wrote:
> logical/bitand typo
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c
> index ebf9e21..dcfb459 100644
> --- a/arch/powerpc/boot/4xx.c
> +++ b/arch/powerpc/boot/4xx.c
> @@ -104,7 +104,7 @@ void ibm4xx_denali_fixup_memsize(void)
> val = DDR_GET_VAL(val, DDR_CS_MAP, DDR_CS_MAP_SHIFT);
> cs = 0;
> while (val) {
> - if (val && 0x1)
> + if (val & 0x1)
> cs++;
> val = val >> 1;
> }
Hm, good catch.
Stefan, have you had problems with this code at all?
josh
^ permalink raw reply
* Re: USB device for ppc440epx
From: Josh Boyer @ 2008-01-24 1:20 UTC (permalink / raw)
To: Leonid; +Cc: linuxppc-embedded
In-Reply-To: <406A31B117F2734987636D6CCC93EE3C02CEE287@ehost011-3.exch011.intermedia.net>
On Wed, 23 Jan 2008 17:01:02 -0800
"Leonid" <Leonid@a-k-a.net> wrote:
> Hi:
>
> does somebody have code example for USB 2.0 device implementation for
> ppc440epx, preferably Mass Storage device, but any will do.
>
> If not for ppc440epx (Sequoia board), ppc440ep (Yosemite) code will also
> help (according to CPU user manual USB device interface is practically
> the same).
>
> If this is already present in Linux kernel tree (from what version?),
> where it is located?
USB mass storage works on 440EP already. It'll be in 2.6.25 in
arch/powerpc. I would suspect 440EPx works as well.
BTW, it's considered impolite to hijack a thread to ask a completely
unrelated question.
josh
^ permalink raw reply
* RE: USB device for ppc440epx
From: Leonid @ 2008-01-24 1:34 UTC (permalink / raw)
To: Josh Boyer; +Cc: linuxppc-embedded
In-Reply-To: <20080123192003.03f4fa0b@zod.rchland.ibm.com>
Hi, Josh:
Ooops, I didn't notice I have hijacked someone's thread, I thought I
created a new one. I am very sorry if I have done so, I'll be more
careful.
Regarding USB Mass Storage there are device drivers (Host side) of
course. However I am asking regarding USB device implementation itself.
Can you point me to source files where this implementation is present
for 440ep/epx?
Linux has several examples of devices (like Zero Gadget) and I have used
it with ARM CPUs. But I am not sure it is working on 440epx also.
Thanks,
Leonid.=20
-----Original Message-----
From: Josh Boyer [mailto:jwboyer@linux.vnet.ibm.com]=20
Sent: Wednesday, January 23, 2008 5:20 PM
To: Leonid
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: USB device for ppc440epx
On Wed, 23 Jan 2008 17:01:02 -0800
"Leonid" <Leonid@a-k-a.net> wrote:
> Hi:
>=20
> does somebody have code example for USB 2.0 device implementation for=20
> ppc440epx, preferably Mass Storage device, but any will do.
>=20
> If not for ppc440epx (Sequoia board), ppc440ep (Yosemite) code will=20
> also help (according to CPU user manual USB device interface is=20
> practically the same).
>=20
> If this is already present in Linux kernel tree (from what version?),=20
> where it is located?
USB mass storage works on 440EP already. It'll be in 2.6.25 in
arch/powerpc. I would suspect 440EPx works as well.
BTW, it's considered impolite to hijack a thread to ask a completely
unrelated question.
josh
^ permalink raw reply
* RE: patches for 2.6.25
From: Liu Yu @ 2008-01-24 1:51 UTC (permalink / raw)
To: Kumar Gala, linuxppc-dev
In-Reply-To: <Pine.LNX.4.64.0801211041100.14676@blarg.am.freescale.net>
How about this one?
http://patchwork.ozlabs.org/linuxppc/patch?id=3D15942
=20
> -----Original Message-----
> From: linuxppc-dev-bounces+b13201=3Dfreescale.com@ozlabs.org=20
> [mailto:linuxppc-dev-bounces+b13201=3Dfreescale.com@ozlabs.org]=20
> On Behalf Of Kumar Gala
> Sent: Tuesday, January 22, 2008 12:43 AM
> To: linuxppc-dev@ozlabs.org
> Subject: patches for 2.6.25
>=20
> I'm sure I missed some patches for 2.6.25, so please point=20
> any out that people would like to see get in.
>=20
> - k
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>=20
^ permalink raw reply
* Re: [PATCH 1/2] [POWERPC] 8xx: Use machine_*_initcall() hooks in platform code
From: Kumar Gala @ 2008-01-24 1:51 UTC (permalink / raw)
To: Grant Likely; +Cc: linuxppc-dev
In-Reply-To: <20080121185806.13486.56429.stgit@trillian.secretlab.ca>
On Mon, 21 Jan 2008, Grant Likely wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
>
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> ---
>
> arch/powerpc/platforms/8xx/ep88xc.c | 5 ++---
> arch/powerpc/platforms/8xx/mpc86xads_setup.c | 5 ++---
> arch/powerpc/platforms/8xx/mpc885ads_setup.c | 5 ++---
> 3 files changed, 6 insertions(+), 9 deletions(-)
>
applied.
- k
^ permalink raw reply
* Re: [PATCH] [POWERPC] Add fixed-phy support for fs_enet
From: Kumar Gala @ 2008-01-24 1:51 UTC (permalink / raw)
To: Jochen Friedrich
Cc: Kernel, Linux, linuxppc-dev, Paul Mackerras, netdev, Scott Wood,
Garzik, Jeff
In-Reply-To: <4767E677.7010200@scram.de>
On Tue, 18 Dec 2007, Jochen Friedrich wrote:
> This patch adds support to use the fixed-link property
> of an ethernet node to fs_enet for the
> CONFIG_PPC_CPM_NEW_BINDING case.
>
> Signed-off-by: Jochen Friedrich <jochen@scram.de>
> Acked-by: Jeff Garzik <jeff@garzik.org>
> Acked-by: Vitali Bordug <vitb@kernel.crashing.org>
> ---
> drivers/net/fs_enet/fs_enet-main.c | 9 ++++++++-
> 1 files changed, 8 insertions(+), 1 deletions(-)
>
applied.
- k
^ permalink raw reply
* Re: [PATCH 0/4 v4] Add StorCenter port
From: Kumar Gala @ 2008-01-24 1:51 UTC (permalink / raw)
To: Jon Loeliger; +Cc: linuxppc-dev
In-Reply-To: <E1JHkXl-00010I-DV@jdl.com>
On Wed, 23 Jan 2008, Jon Loeliger wrote:
> Kumar,
>
> Here is the StorCenter port with the MTD partitions
> re-written to be hard-coded PHYSMAP partitions for now.
>
> Addressed list and private commentary as well.
>
> Janitorial Karma has now caussed it to be 4 patches
> instead of the original 3.
>
> Please pick up for 2.6.25!
>
> Thanks,
> jdl
applied.
- k
^ permalink raw reply
* Re: [PATCH 3/4 v4] POWERPC: Add initial iomega StorCenter board port.
From: Kumar Gala @ 2008-01-24 1:54 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linuxppc-dev, Jon Loeliger
In-Reply-To: <20080124115018.69551acf.sfr@canb.auug.org.au>
On Jan 23, 2008, at 6:50 PM, Stephen Rothwell wrote:
> Hi Jon,
>
> On Wed, 23 Jan 2008 12:42:50 -0600 Jon Loeliger <jdl@jdl.com> wrote:
>>
>> +++ b/arch/powerpc/platforms/embedded6xx/storcenter.c
>> +static void __init storcenter_init_IRQ(void)
>> +{
>> + struct mpic *mpic;
>> + struct device_node *dnp;
>> + const void *prop;
>> + int size;
>> + phys_addr_t paddr;
>> +
>> + dnp = of_find_node_by_type(NULL, "open-pic");
>> + if (dnp == NULL)
>> + return;
>> +
>> + prop = of_get_property(dnp, "reg", &size);
>> + if (prop == NULL)
>> + return;
>
> You need an of_node_put(dnp) before you return.
Fixed up by your friendly maintainer.
- k
^ permalink raw reply
* Please pull from 'for-2.6.25' branch
From: Kumar Gala @ 2008-01-24 1:56 UTC (permalink / raw)
To: Paul Mackerras; +Cc: linuxppc-dev
Please pull from 'for-2.6.25' branch of
master.kernel.org:/pub/scm/linux/kernel/git/galak/powerpc.git for-2.6.25
to receive the following updates:
(I fixed up the memreserve patch, it builds for me on ppc64)
Documentation/powerpc/00-INDEX | 3
Documentation/powerpc/booting-without-of.txt | 91 +
Documentation/powerpc/qe_firmware.txt | 295 ++++
arch/powerpc/Kconfig | 3
arch/powerpc/boot/.gitignore | 1
arch/powerpc/boot/Makefile | 10
arch/powerpc/boot/cuboot-824x.c | 53
arch/powerpc/boot/cuboot-83xx.c | 3
arch/powerpc/boot/cuboot-85xx.c | 5
arch/powerpc/boot/devtree.c | 14
arch/powerpc/boot/dts/adder875-redboot.dts | 184 ++
arch/powerpc/boot/dts/adder875-uboot.dts | 183 ++
arch/powerpc/boot/dts/ep8248e.dts | 207 +++
arch/powerpc/boot/dts/mpc8313erdb.dts | 49
arch/powerpc/boot/dts/mpc832x_mds.dts | 51
arch/powerpc/boot/dts/mpc8349emitx.dts | 30
arch/powerpc/boot/dts/mpc8349emitxgp.dts | 1
arch/powerpc/boot/dts/mpc834x_mds.dts | 2
arch/powerpc/boot/dts/mpc836x_mds.dts | 1
arch/powerpc/boot/dts/mpc8377_mds.dts | 279 ++++
arch/powerpc/boot/dts/mpc8378_mds.dts | 265 +++
arch/powerpc/boot/dts/mpc8379_mds.dts | 293 ++++
arch/powerpc/boot/dts/mpc8544ds.dts | 6
arch/powerpc/boot/dts/mpc8572ds.dts | 7
arch/powerpc/boot/dts/mpc8610_hpcd.dts | 113 +
arch/powerpc/boot/dts/mpc8641_hpcn.dts | 48
arch/powerpc/boot/dts/storcenter.dts | 138 ++
arch/powerpc/boot/ep8248e.c | 55
arch/powerpc/boot/ops.h | 14
arch/powerpc/boot/redboot-8xx.c | 58
arch/powerpc/boot/redboot.h | 56
arch/powerpc/boot/wrapper | 2
arch/powerpc/configs/adder875-redboot_defconfig | 798 +++++++++++
arch/powerpc/configs/adder875-uboot_defconfig | 798 +++++++++++
arch/powerpc/configs/ep8248e_defconfig | 821 +++++++++++
arch/powerpc/configs/mpc8313_rdb_defconfig | 46
arch/powerpc/configs/mpc834x_itx_defconfig | 3
arch/powerpc/configs/mpc8610_hpcd_defconfig | 171 ++
arch/powerpc/configs/storcenter_defconfig | 1174 +++++++++++++++++
arch/powerpc/kernel/Makefile | 1
arch/powerpc/kernel/head_fsl_booke.S | 20
arch/powerpc/kernel/pci-common.c | 8
arch/powerpc/kernel/pci_32.c | 58
arch/powerpc/kernel/rio.c | 52
arch/powerpc/math-emu/op-4.h | 40
arch/powerpc/mm/fsl_booke_mmu.c | 6
arch/powerpc/mm/lmb.c | 13
arch/powerpc/mm/mem.c | 21
arch/powerpc/platforms/82xx/Kconfig | 13
arch/powerpc/platforms/82xx/Makefile | 1
arch/powerpc/platforms/82xx/ep8248e.c | 324 ++++
arch/powerpc/platforms/83xx/mpc8313_rdb.c | 13
arch/powerpc/platforms/83xx/mpc832x_mds.c | 5
arch/powerpc/platforms/83xx/mpc832x_rdb.c | 10
arch/powerpc/platforms/83xx/mpc834x_itx.c | 12
arch/powerpc/platforms/83xx/mpc834x_mds.c | 5
arch/powerpc/platforms/83xx/mpc836x_mds.c | 5
arch/powerpc/platforms/83xx/mpc837x_mds.c | 56
arch/powerpc/platforms/83xx/mpc83xx.h | 3
arch/powerpc/platforms/83xx/usb.c | 46
arch/powerpc/platforms/85xx/mpc85xx_ads.c | 18
arch/powerpc/platforms/85xx/mpc85xx_cds.c | 6
arch/powerpc/platforms/85xx/mpc85xx_mds.c | 7
arch/powerpc/platforms/86xx/mpc8610_hpcd.c | 15
arch/powerpc/platforms/86xx/mpc86xx_hpcn.c | 14
arch/powerpc/platforms/8xx/Kconfig | 9
arch/powerpc/platforms/8xx/Makefile | 1
arch/powerpc/platforms/8xx/adder875.c | 118 +
arch/powerpc/platforms/8xx/ep88xc.c | 5
arch/powerpc/platforms/8xx/mpc86xads_setup.c | 5
arch/powerpc/platforms/8xx/mpc885ads_setup.c | 5
arch/powerpc/platforms/Kconfig | 6
arch/powerpc/platforms/embedded6xx/Kconfig | 23
arch/powerpc/platforms/embedded6xx/Makefile | 1
arch/powerpc/platforms/embedded6xx/mpc7448_hpc2.c | 2
arch/powerpc/platforms/embedded6xx/storcenter.c | 192 ++
arch/powerpc/sysdev/Makefile | 3
arch/powerpc/sysdev/fsl_pci.c | 150 --
arch/powerpc/sysdev/fsl_rio.c | 932 +++++++++++++
arch/powerpc/sysdev/fsl_rio.h | 20
arch/powerpc/sysdev/fsl_soc.c | 103 +
arch/powerpc/sysdev/ipic.c | 62
arch/powerpc/sysdev/mpic.c | 4
arch/powerpc/sysdev/qe_lib/Kconfig | 2
arch/powerpc/sysdev/qe_lib/qe.c | 247 +++
arch/powerpc/sysdev/qe_lib/ucc_slow.c | 10
arch/ppc/kernel/Makefile | 1
arch/ppc/kernel/rio.c | 52
arch/ppc/platforms/85xx/mpc85xx_ads_common.c | 3
arch/ppc/platforms/85xx/stx_gp3.c | 2
arch/ppc/platforms/85xx/tqm85xx.c | 2
arch/ppc/syslib/Makefile | 1
arch/ppc/syslib/ppc85xx_rio.c | 932 -------------
arch/ppc/syslib/ppc85xx_rio.h | 20
drivers/net/fs_enet/fs_enet-main.c | 9
drivers/net/phy/Kconfig | 32
drivers/net/phy/fixed.c | 445 ++----
drivers/rapidio/rio.c | 5
drivers/serial/Kconfig | 10
drivers/serial/Makefile | 1
drivers/serial/cpm_uart/cpm_uart_cpm2.c | 2
drivers/serial/ucc_uart.c | 1514 ++++++++++++++++++++++
include/asm-powerpc/immap_qe.h | 34
include/asm-powerpc/lmb.h | 1
include/asm-powerpc/mpc8260.h | 1
include/asm-powerpc/pci-bridge.h | 3
include/asm-powerpc/qe.h | 61
include/asm-powerpc/system.h | 2
include/linux/phy_fixed.h | 51
109 files changed, 10511 insertions(+), 1676 deletions(-)
Anton Vorontsov (1):
[POWERPC] MPC8349E-mITX: introduce localbus and pata nodes
Becky Bruce (1):
[POWERPC] Fixup use of phys_addr_t in mpic code
Dale Farnsworth (1):
[POWERPC] 85xx: Respect KERNELBASE, PAGE_OFFSET, and PHYSICAL_START on e500
Grant Likely (1):
[POWERPC] 8xx: Use machine_*_initcall() hooks in platform code
Jochen Friedrich (1):
fs_enet: Add fixed-phy support for fs_enet
John Rigby (2):
[POWERPC] Add support for mpc512x interrupts to ipic
[POWERPC] Add IPIC Kconfig option
Jon Loeliger (4):
[POWERPC] Add _nmask_and_or_msr() declartion to asm-powerpc/system.h
[POWERPC] Add StorCenter DTS first draft.
[POWERPC] Add initial iomega StorCenter board port.
[POWERPC] Add initial storcenter config file.
Kumar Gala (13):
[POWERPC] Fix handling of memreserve if the range lands in highmem
[POWERPC] Ensure we only handle PowerMac PCI bus fixup for memory resources
[POWERPC] Fixup transparent P2P resources
[POWERPC] FSL: Rework PCI/PCIe support for 85xx/86xx
[POWERPC] Remove update_bridge_resource
[POWERPC] 85xx: convert boards to use machine_device_initcall
[POWERPC] 83xx: convert boards to use machine_device_initcall
[POWERPC] bootwrapper: Add find_node_by_alias and dt_fixup_mac_address_by_alias
[POWERPC] bootwrapper: convert cuboot-8{3,5}xx to dt_fixup_mac_address_by_alias
[POWERPC] Fix incorrect interrupt map on FSL reference boards
[RAPIDIO] Fix compile error and warning
[POWERPC] Move RapidIO support code from arch/ppc
[POWERPC] Fix compile error if CONFIG_STX_GP3 is defined
Li Yang (3):
[POWERPC] 83xx: add device trees for MPC837x MDS board
[POWERPC] 83xx: Add MPC837x USB platform support
[POWERPC] 83xx: USB device tree cleanups
Liu Yu (1):
[POWERPC] Fix carry bug in 128-bit unsigned integer adding
Paul Gortmaker (1):
[POWERPC] 85xx: mpc85xx_ads: add in missing of_node_put()
Scott Wood (7):
[POWERPC] fsl_soc: Fix get_immrbase() to use ranges, rather than reg.
[POWERPC] 8xx: Analogue & Micro Adder875 board support.
[POWERPC] 82xx: Embedded Planet EP8248E support
[POWERPC] 83xx: MPC8313e RBD add NAND to device tree
[POWERPC] 83xx: MPC8313e RDB - Add NOR flash to the device tree.
[POWERPC] 83xx: Update MPC8313e RDB defconfig for MTD, NAND, JFFS2.
[POWERPC] 8xx: adder875 - Fix flash bus-width and remove duplicate __initdata
Timur Tabi (4):
[POWERPC] QE: Add ability to upload QE firmware
[POWERPC] QE: Add support for Freescale QUICCEngine UART
[POWERPC] qe-uart: add support for Freescale QUICCEngine UART
[POWERPC] Update MPC8610 HPCD to support audio drivers
Vitaly Bordug (3):
phy/fixed.c: rework to not duplicate PHY layer functionality
[POWERPC] MPC8349E-mITX: Vitesse 7385 PHY is not connected to the MDIO bus
[POWERPC] fsl_soc: add support to gianfar for fixed-link property
Wade Farnsworth (2):
[POWERPC] 86xx: Add localbus and flash nodes to mpc8641_hpcn.dts
[POWERPC] 86xx: MPC8641 HPCN - call of_platform_bus_probe()
^ permalink raw reply
* Re: patches for 2.6.25
From: Kumar Gala @ 2008-01-24 2:21 UTC (permalink / raw)
To: Liu Yu; +Cc: linuxppc-dev
In-Reply-To: <6EBEC19BF4A8F843BCD6B9155BBE2515D52D1A@zch01exm26.fsl.freescale.net>
On Jan 23, 2008, at 7:51 PM, Liu Yu wrote:
>
> How about this one?
> http://patchwork.ozlabs.org/linuxppc/patch?id=15942
I've been trying to get some feedback from the glibc guys. The code
is pretty common and if the issues exists in one it exists in the
other.. I'm not sure if they have solved it some other way already.
- k
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox