* Re: [i2c] [PATCH] mpc i2c driver, compare to NO_IRQ instead of zero
From: Jon Smirl @ 2008-01-25 17:13 UTC (permalink / raw)
To: i2c, linuxppc-dev
In-Reply-To: <20080121200740.13800.20524.stgit@terra.home>
Any final objections to this patch? When these were changed to 0
instead of NO_IRQ it should have broken polling mode on ppc. ppc would
treat polling mode, NO_IRQ=-1, as an error.
On powerpc this change is a NOP since NO_IRQ=0.
On 1/21/08, Jon Smirl <jonsmirl@gmail.com> wrote:
> Alter the mpc i2c driver to use the NO_IRQ symbol instead of the constant zero when checking for valid interrupts. NO_IRQ=-1 on ppc and NO_IRQ=0 on powerpc so the checks against zero are not correct.
>
> Signed-off-by: Jon Smirl <jonsmirl@gmail.com>
> ---
>
> drivers/i2c/busses/i2c-mpc.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
>
> diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
> index bbe787b..d20959d 100644
> --- a/drivers/i2c/busses/i2c-mpc.c
> +++ b/drivers/i2c/busses/i2c-mpc.c
> @@ -99,7 +99,7 @@ static int i2c_wait(struct mpc_i2c *i2c, unsigned timeout, int writing)
> u32 x;
> int result = 0;
>
> - if (i2c->irq == 0)
> + if (i2c->irq == NO_IRQ)
> {
> while (!(readb(i2c->base + MPC_I2C_SR) & CSR_MIF)) {
> schedule();
> @@ -329,7 +329,7 @@ static int fsl_i2c_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> i2c->irq = platform_get_irq(pdev, 0);
> - if (i2c->irq < 0) {
> + if (i2c->irq < NO_IRQ) {
> result = -ENXIO;
> goto fail_get_irq;
> }
> @@ -344,7 +344,7 @@ static int fsl_i2c_probe(struct platform_device *pdev)
> goto fail_map;
> }
>
> - if (i2c->irq != 0)
> + if (i2c->irq != NO_IRQ)
> if ((result = request_irq(i2c->irq, mpc_i2c_isr,
> IRQF_SHARED, "i2c-mpc", i2c)) < 0) {
> printk(KERN_ERR
> @@ -367,7 +367,7 @@ static int fsl_i2c_probe(struct platform_device *pdev)
> return result;
>
> fail_add:
> - if (i2c->irq != 0)
> + if (i2c->irq != NO_IRQ)
> free_irq(i2c->irq, i2c);
> fail_irq:
> iounmap(i2c->base);
> @@ -384,7 +384,7 @@ static int fsl_i2c_remove(struct platform_device *pdev)
> i2c_del_adapter(&i2c->adap);
> platform_set_drvdata(pdev, NULL);
>
> - if (i2c->irq != 0)
> + if (i2c->irq != NO_IRQ)
> free_irq(i2c->irq, i2c);
>
> iounmap(i2c->base);
>
>
> _______________________________________________
> i2c mailing list
> i2c@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/i2c
>
--
Jon Smirl
jonsmirl@gmail.com
^ permalink raw reply
* Re: [PATCH 6/9] add the mpc8315 rdb defconfig
From: Kumar Gala @ 2008-01-25 21:23 UTC (permalink / raw)
To: Kim Phillips; +Cc: linuxppc-dev
In-Reply-To: <20080124204705.0e7e5693.kim.phillips@freescale.com>
On Thu, 24 Jan 2008, Kim Phillips wrote:
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> ---
> arch/powerpc/configs/mpc8315_rdb_defconfig | 1417 ++++++++++++++++++++++++++++
> 1 files changed, 1417 insertions(+), 0 deletions(-)
> create mode 100644 arch/powerpc/configs/mpc8315_rdb_defconfig
>
applied.
- k
^ permalink raw reply
* Re: [PATCH 2/9] powerpc: add base platform support for the mpc8315 rdb board
From: Kumar Gala @ 2008-01-25 21:21 UTC (permalink / raw)
To: Kim Phillips; +Cc: linuxppc-dev
In-Reply-To: <20080124204600.d16c5142.kim.phillips@freescale.com>
On Thu, 24 Jan 2008, Kim Phillips wrote:
> mpc8315 identical to mpc8313 here, just check compatible.
>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> ---
> arch/powerpc/platforms/83xx/Kconfig | 2 +-
> arch/powerpc/platforms/83xx/mpc831x_rdb.c | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
applied.
- k
^ permalink raw reply
* Re: [PATCH 3/9] powerpc: Add the MPC8315E RDB dts
From: Kumar Gala @ 2008-01-25 21:22 UTC (permalink / raw)
To: Kim Phillips; +Cc: linuxppc-dev
In-Reply-To: <20080124204606.53bd2a1b.kim.phillips@freescale.com>
On Thu, 24 Jan 2008, Kim Phillips wrote:
> Add the dts for the MPC8315E Reference Development Board (RDB).
>
> The board is a mini-ITX reference board with 128M DDR2, 8M flash,
> 32M NAND, USB, PCI, gigabit ethernet, SATA, and serial.
>
> Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> ---
> arch/powerpc/boot/dts/mpc8315erdb.dts | 287 +++++++++++++++++++++++++++++++++
> 1 files changed, 287 insertions(+), 0 deletions(-)
> create mode 100644 arch/powerpc/boot/dts/mpc8315erdb.dts
>
applied. fixed up spi node
- k
^ permalink raw reply
* Re: [PATCH 3/5] [POWERPC][SPI] use brg-frequency for SPI in QE
From: Kumar Gala @ 2008-01-25 21:20 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: linuxppc-dev
In-Reply-To: <20080124154003.GC23246@localhost.localdomain>
On Thu, 24 Jan 2008, Anton Vorontsov wrote:
> In case of QE we can use brg-frequency (which is qeclk/2).
> Thus no need to divide sysclk in the spi_mpc83xx.
>
> This patch also adds code to use get_brgfreq() on QE chips.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> Acked-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> arch/powerpc/sysdev/fsl_soc.c | 44 ++++++++++++++++++++++++++++------------
> drivers/spi/spi_mpc83xx.c | 6 +----
> 2 files changed, 32 insertions(+), 18 deletions(-)
>
applied
- k
^ permalink raw reply
* Re: [PATCH 1/9] powerpc: fold the mpc8313 platform into the mpc831x platform
From: Kumar Gala @ 2008-01-25 21:21 UTC (permalink / raw)
To: Kim Phillips; +Cc: linuxppc-dev
In-Reply-To: <20080124204551.10cea5fd.kim.phillips@freescale.com>
On Thu, 24 Jan 2008, Kim Phillips wrote:
> prepare for adding support for the mpc8315 rdb,
> since they are identical wrt platform code.
>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> ---
> Kumar, this set of patches is base support for two new boards - the
> mpc8315e rdb and the mpc837xe rdb. Please consider for 2.6.25. Thanks.
>
> arch/powerpc/configs/mpc8313_rdb_defconfig | 2 +-
> arch/powerpc/platforms/83xx/Kconfig | 6 ++--
> arch/powerpc/platforms/83xx/Makefile | 2 +-
> .../83xx/{mpc8313_rdb.c => mpc831x_rdb.c} | 35 +++++++------------
> 4 files changed, 18 insertions(+), 27 deletions(-)
> rename arch/powerpc/platforms/83xx/{mpc8313_rdb.c => mpc831x_rdb.c} (70%)
>
applied.
- k
^ permalink raw reply
* Re: [PATCH 4/5] [POWERPC] fsl_spi_init and users: stop using device_type = "spi"
From: Kumar Gala @ 2008-01-25 21:20 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: linuxppc-dev
In-Reply-To: <20080124154007.GD23246@localhost.localdomain>
On Thu, 24 Jan 2008, Anton Vorontsov wrote:
> Also:
> - rename "fsl_spi" to "fsl,spi";
> - add and use cell-index property, if found;
> - split probing code out of fsl_spi_init, thus we can call
> it for legacy device_type probing and new "compatible" probing.
>
> Per http://ozlabs.org/pipermail/linuxppc-dev/2007-December/048388.html
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> Documentation/powerpc/booting-without-of.txt | 8 +-
> arch/powerpc/boot/dts/mpc8313erdb.dts | 4 +-
> arch/powerpc/boot/dts/mpc832x_mds.dts | 8 +-
> arch/powerpc/boot/dts/mpc832x_rdb.dts | 8 +-
> arch/powerpc/boot/dts/mpc8349emitx.dts | 4 +-
> arch/powerpc/boot/dts/mpc8349emitxgp.dts | 4 +-
> arch/powerpc/boot/dts/mpc834x_mds.dts | 4 +-
> arch/powerpc/boot/dts/mpc836x_mds.dts | 8 +-
> arch/powerpc/boot/dts/mpc836x_rdk.dts | 6 +-
> arch/powerpc/boot/dts/mpc8568mds.dts | 8 +-
> arch/powerpc/sysdev/fsl_soc.c | 94 ++++++++++++++++----------
> 11 files changed, 88 insertions(+), 68 deletions(-)
>
applied. (sans _rdk)
- k
^ permalink raw reply
* Re: [PATCH 1/5] [POWERPC] qe_lib and users: get rid of most device_types and model
From: Kumar Gala @ 2008-01-25 21:19 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: linuxppc-dev
In-Reply-To: <20080124153959.GA23246@localhost.localdomain>
On Thu, 24 Jan 2008, Anton Vorontsov wrote:
> Now we're searching for "fsl,qe", "fsl,qe-muram", "fsl,qe-muram-data"
> and "fsl,qe-ic".
>
> Unfortunately it's still impossible to remove device_type = "qe"
> from the existing device trees (except for MPC8360E-RDK), because
> older u-boots are looking for it.
>
> Per http://ozlabs.org/pipermail/linuxppc-dev/2007-December/048388.html
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> Documentation/powerpc/booting-without-of.txt | 11 +++--
> arch/powerpc/boot/dts/mpc832x_mds.dts | 9 ++--
> arch/powerpc/boot/dts/mpc832x_rdb.dts | 10 +++--
> arch/powerpc/boot/dts/mpc836x_mds.dts | 10 +++--
> arch/powerpc/boot/dts/mpc836x_rdk.dts | 1 -
> arch/powerpc/boot/dts/mpc8568mds.dts | 10 +++--
> arch/powerpc/platforms/83xx/mpc832x_mds.c | 11 +++--
> arch/powerpc/platforms/83xx/mpc832x_rdb.c | 11 +++--
> arch/powerpc/platforms/83xx/mpc836x_mds.c | 11 +++--
> arch/powerpc/platforms/85xx/mpc85xx_mds.c | 32 ++++++++-----
> arch/powerpc/sysdev/fsl_soc.c | 5 ++-
> arch/powerpc/sysdev/qe_lib/qe.c | 63 ++++++++++++++++++--------
> 12 files changed, 117 insertions(+), 67 deletions(-)
>
applied, however _rdk will need fixing.
- k
^ permalink raw reply
* Re: [PATCH 9/9] powerpc: add the mpc837x rdb defconfig
From: Kumar Gala @ 2008-01-25 21:24 UTC (permalink / raw)
To: Kim Phillips; +Cc: linuxppc-dev, Joe D'Abbraccio
In-Reply-To: <20080124204721.87859a3c.kim.phillips@freescale.com>
On Thu, 24 Jan 2008, Kim Phillips wrote:
> Signed-off-by: Joe D'Abbraccio <ljd015@freescale.com>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> ---
> arch/powerpc/configs/mpc837x_rdb_defconfig | 887 ++++++++++++++++++++++++++++
> 1 files changed, 887 insertions(+), 0 deletions(-)
> create mode 100644 arch/powerpc/configs/mpc837x_rdb_defconfig
>
applied.
- k
^ permalink raw reply
* Re: [PATCH 5/9] powerpc: ipic: add interrupt vector 94
From: Kumar Gala @ 2008-01-25 21:23 UTC (permalink / raw)
To: Kim Phillips; +Cc: linuxppc-dev, Jerry Huang
In-Reply-To: <20080124204650.48578c7f.kim.phillips@freescale.com>
On Thu, 24 Jan 2008, Kim Phillips wrote:
> this is used on the mpc8315 SoC for DMA error interrupts.
>
> Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> ---
> arch/powerpc/sysdev/ipic.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
applied. (fyi, the irq is for TDM DMA, not general DMA)
- k
^ permalink raw reply
* Re: [PATCH 7/9] powerpc: add MPC837x RDB platform support
From: Kumar Gala @ 2008-01-25 21:24 UTC (permalink / raw)
To: Kim Phillips; +Cc: linuxppc-dev, Joe D'Abbraccio
In-Reply-To: <20080124204711.02ba14f0.kim.phillips@freescale.com>
On Thu, 24 Jan 2008, Kim Phillips wrote:
> primarily based on mpc837x mds code.
>
> Signed-off-by: Joe D'Abbraccio <ljd015@freescale.com>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> ---
> arch/powerpc/platforms/83xx/Kconfig | 8 ++-
> arch/powerpc/platforms/83xx/Makefile | 1 +
> arch/powerpc/platforms/83xx/mpc837x_rdb.c | 99 +++++++++++++++++++++++++++++
> 3 files changed, 107 insertions(+), 1 deletions(-)
> create mode 100644 arch/powerpc/platforms/83xx/mpc837x_rdb.c
>
applied.
- k
^ permalink raw reply
* Re: [PATCH 8/9] powerpc: add the mpc837[789]_rdb dts files
From: Kumar Gala @ 2008-01-25 21:24 UTC (permalink / raw)
To: Kim Phillips; +Cc: linuxppc-dev, Joe D'Abbraccio
In-Reply-To: <20080124204718.33a30ab5.kim.phillips@freescale.com>
On Thu, 24 Jan 2008, Kim Phillips wrote:
> Add the dts files for the MPC838xE Reference Development Board (RDB).
>
> The board is a mini-ITX reference board with 256M DDR2, 8M flash,
> 32M NAND, USB, PCI, gigabit ethernet, SATA, and serial.
>
> the difference among the three files is the 8377 has two, the 8378
> none, and the 8379 has four sata controllers.
>
> partially based on the 8379 mds device trees.
>
> Signed-off-by: Joe D'Abbraccio <ljd015@freescale.com>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> ---
> arch/powerpc/boot/dts/mpc8377_rdb.dts | 296 +++++++++++++++++++++++++++++++
> arch/powerpc/boot/dts/mpc8378_rdb.dts | 282 ++++++++++++++++++++++++++++++
> arch/powerpc/boot/dts/mpc8379_rdb.dts | 310 +++++++++++++++++++++++++++++++++
applied. (fixed spi nodes).
- k
^ permalink raw reply
* Re: [PATCH 2/5] [POWERPC][NET] ucc_geth_mii and users: get rid of device_type
From: Kumar Gala @ 2008-01-25 21:20 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: linuxppc-dev, Jeff Garzik, netdev
In-Reply-To: <20080124154001.GB23246@localhost.localdomain>
On Thu, 24 Jan 2008, Anton Vorontsov wrote:
> device_type property is bogus, thus use proper compatible.
>
> Also change compatible property to "fsl,ucc-mdio".
>
> Per http://ozlabs.org/pipermail/linuxppc-dev/2007-December/048388.html
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> arch/powerpc/boot/dts/mpc832x_mds.dts | 3 +--
> arch/powerpc/boot/dts/mpc832x_rdb.dts | 3 +--
> arch/powerpc/boot/dts/mpc836x_mds.dts | 3 +--
> arch/powerpc/boot/dts/mpc836x_rdk.dts | 3 +--
> arch/powerpc/boot/dts/mpc8568mds.dts | 2 +-
> drivers/net/ucc_geth_mii.c | 3 +++
> 6 files changed, 8 insertions(+), 9 deletions(-)
>
applied. (same comment about rdk)
- k
^ permalink raw reply
* Re: [PATCH 4/9] enable FSL SATA driver config for Freescale SoCs
From: Kumar Gala @ 2008-01-25 21:23 UTC (permalink / raw)
To: Kim Phillips; +Cc: linux-ide, linuxppc-dev, Jeff Garzik, Jerry Huang
In-Reply-To: <20080124204621.2c09359e.kim.phillips@freescale.com>
On Thu, 24 Jan 2008, Kim Phillips wrote:
> The mpc8315 shares the same SATA controller as the mpc837x,
> and likelihood is that future SoCs from Freescale will also.
>
> Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> ---
> Kumar, let me know if you want me to post this to the ata list (I'm
> assuming it's not necessary).
>
> drivers/ata/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
applied.
- k
^ permalink raw reply
* Re: ppc32: Weird process scheduling behaviour with 2.6.24-rc
From: Benjamin Herrenschmidt @ 2008-01-25 21:10 UTC (permalink / raw)
To: Michel Dänzer; +Cc: linuxppc-dev, Ingo Molnar, Peter Zijlstra, vatsa
In-Reply-To: <1201273484.6090.12.camel@thor.sulgenrain.local>
On Fri, 2008-01-25 at 16:04 +0100, Michel Dänzer wrote:
> > Hmm, interesting. As I said before, I thought I had tested with this
> > disabled and not seen a difference, but I'll try again to confirm.
>
> So, 2.6.24 final is indeed much better with this disabled, but still
> not
> as good as 2.6.23: While I can reliably move a window again while the
> infinite loop is running, it still stutters badly every couple of
> seconds. With 2.6.23 this is smooth all the time.
This is with or without fair group scheduler enabled ?
Ben.
^ permalink raw reply
* [PATCH] [POWERPC] 85xx: some minor cleanups for stx_gp3 and tqm85xx
From: Kumar Gala @ 2008-01-25 16:39 UTC (permalink / raw)
To: linuxppc-dev
* "simple-bus" covers all our needs for of_platform_bus_probe()
* make device tree name just 'soc' not 'soc85..'
---
arch/powerpc/boot/dts/stx_gp3_8560.dts | 2 +-
arch/powerpc/boot/dts/tqm8540.dts | 2 +-
arch/powerpc/boot/dts/tqm8541.dts | 2 +-
arch/powerpc/boot/dts/tqm8555.dts | 2 +-
arch/powerpc/boot/dts/tqm8560.dts | 2 +-
arch/powerpc/platforms/85xx/stx_gp3.c | 4 ----
arch/powerpc/platforms/85xx/tqm85xx.c | 4 ----
7 files changed, 5 insertions(+), 13 deletions(-)
diff --git a/arch/powerpc/boot/dts/stx_gp3_8560.dts b/arch/powerpc/boot/dts/stx_gp3_8560.dts
index 2e97236..f81fd7f 100644
--- a/arch/powerpc/boot/dts/stx_gp3_8560.dts
+++ b/arch/powerpc/boot/dts/stx_gp3_8560.dts
@@ -46,7 +46,7 @@
reg = <0x00000000 0x10000000>;
};
- soc8560@fdf00000 {
+ soc@fdf00000 {
#address-cells = <1>;
#size-cells = <1>;
device_type = "soc";
diff --git a/arch/powerpc/boot/dts/tqm8540.dts b/arch/powerpc/boot/dts/tqm8540.dts
index a6e3989..1addb3a 100644
--- a/arch/powerpc/boot/dts/tqm8540.dts
+++ b/arch/powerpc/boot/dts/tqm8540.dts
@@ -48,7 +48,7 @@
reg = <0x00000000 0x10000000>;
};
- soc8540@e0000000 {
+ soc@e0000000 {
#address-cells = <1>;
#size-cells = <1>;
device_type = "soc";
diff --git a/arch/powerpc/boot/dts/tqm8541.dts b/arch/powerpc/boot/dts/tqm8541.dts
index 11bdb0f..9e01093 100644
--- a/arch/powerpc/boot/dts/tqm8541.dts
+++ b/arch/powerpc/boot/dts/tqm8541.dts
@@ -47,7 +47,7 @@
reg = <0x00000000 0x10000000>;
};
- soc8541@e0000000 {
+ soc@e0000000 {
#address-cells = <1>;
#size-cells = <1>;
device_type = "soc";
diff --git a/arch/powerpc/boot/dts/tqm8555.dts b/arch/powerpc/boot/dts/tqm8555.dts
index eef9a6b..a20eb06 100644
--- a/arch/powerpc/boot/dts/tqm8555.dts
+++ b/arch/powerpc/boot/dts/tqm8555.dts
@@ -47,7 +47,7 @@
reg = <0x00000000 0x10000000>;
};
- soc8555@e0000000 {
+ soc@e0000000 {
#address-cells = <1>;
#size-cells = <1>;
device_type = "soc";
diff --git a/arch/powerpc/boot/dts/tqm8560.dts b/arch/powerpc/boot/dts/tqm8560.dts
index 8ca7fdd..b9ac6c9 100644
--- a/arch/powerpc/boot/dts/tqm8560.dts
+++ b/arch/powerpc/boot/dts/tqm8560.dts
@@ -48,7 +48,7 @@
reg = <0x00000000 0x10000000>;
};
- soc8560@e0000000 {
+ soc@e0000000 {
#address-cells = <1>;
#size-cells = <1>;
device_type = "soc";
diff --git a/arch/powerpc/platforms/85xx/stx_gp3.c b/arch/powerpc/platforms/85xx/stx_gp3.c
index 0b20c17..18499d7 100644
--- a/arch/powerpc/platforms/85xx/stx_gp3.c
+++ b/arch/powerpc/platforms/85xx/stx_gp3.c
@@ -148,10 +148,6 @@ static void stx_gp3_show_cpuinfo(struct seq_file *m)
}
static struct of_device_id __initdata of_bus_ids[] = {
- { .name = "soc", },
- { .type = "soc", },
- { .name = "cpm", },
- { .name = "localbus", },
{ .compatible = "simple-bus", },
{},
};
diff --git a/arch/powerpc/platforms/85xx/tqm85xx.c b/arch/powerpc/platforms/85xx/tqm85xx.c
index 2a08b31..77681ac 100644
--- a/arch/powerpc/platforms/85xx/tqm85xx.c
+++ b/arch/powerpc/platforms/85xx/tqm85xx.c
@@ -146,10 +146,6 @@ static void tqm85xx_show_cpuinfo(struct seq_file *m)
}
static struct of_device_id __initdata of_bus_ids[] = {
- { .name = "soc", },
- { .type = "soc", },
- { .name = "cpm", },
- { .name = "localbus", },
{ .compatible = "simple-bus", },
{},
};
--
1.5.3.7
^ permalink raw reply related
* Re: [PATCH v2] [POWERPC] 85xx: Port STX GP3 board over from arch/ppc
From: Kumar Gala @ 2008-01-25 16:23 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev
In-Reply-To: <20080125160820.GA7750@ld0162-tx32.am.freescale.net>
On Jan 25, 2008, at 10:08 AM, Scott Wood wrote:
> On Thu, Jan 24, 2008 at 10:47:21PM -0600, Kumar Gala wrote:
>> + soc8560@fdf00000 {
>
> soc@fdf00000
will fix this up in the tqm port as well.
>
>
> -Scott
>> + cpm@919c0 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "fsl,mpc8560-cpm", "fsl,cpm2";
>
> This is also a simple-bus.
yeah, I realized I missed this. Its fixed in my tree.
>
>
>> +static struct of_device_id __initdata of_bus_ids[] = {
>> + { .name = "soc", },
>> + { .type = "soc", },
>> + { .name = "cpm", },
>> + { .name = "localbus", },
>> + { .compatible = "simple-bus", },
>> + {},
>> +};
>
> You should be able to get rid of the others besides simple-bus
> (there may
> have been some confusion in what you asked over IRC yesterday -- I
> thought you were talking about compatible in the device tree, not
> here).
yep :)
fixed and in the tqm port as well.
- k
^ permalink raw reply
* Re: [PATCH] mpc834x_mds: Convert device tree source to dts-v1
From: Kumar Gala @ 2008-01-25 16:19 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: linuxppc-dev
In-Reply-To: <479A0B6E.20507@windriver.com>
On Jan 25, 2008, at 10:16 AM, Paul Gortmaker wrote:
> Kumar Gala wrote:
>> On Fri, 25 Jan 2008, Paul Gortmaker wrote:
>>
>>
>>> Move mpc834x_mds device tree source forward to dts-v1 format.
>>> Nothing
>>> too complex in this one, so it boils down to just adding a bunch
>>> of 0x
>>> in the right places and converting clock speeds to decimal.
>>>
>>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>>> ---
>>> arch/powerpc/boot/dts/mpc834x_mds.dts | 254 ++++++++++++++++
>>> +----------------
>>> 1 files changed, 128 insertions(+), 126 deletions(-)
>>>
>>>
>>
>> applied. I fixed up things so that interrupts use decimal.
>>
>
> Yeah, IRQ was one of those gray areas where I wasn't 100%
> sure whether DTS folks would rather hex or decimal values.
decimal is easier since UMs tend to reference IRQs in dec.
I think on 85xx I might have left them as hex since the IRQs don't
directly reflect the UMs.
- k
^ permalink raw reply
* Re: [PATCH 6/5] [POWERPC] get rid of `model = "UCC"' in the ucc nodes
From: Kumar Gala @ 2008-01-25 16:33 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: linuxppc-dev
In-Reply-To: <20080125143700.GA24027@localhost.localdomain>
On Jan 25, 2008, at 8:37 AM, Anton Vorontsov wrote:
> It isn't used anywhere, so remove it. If we'll ever need something
> like this, we'll use compatible property instead.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
>
> New cleanup in this series...
>
> Documentation/powerpc/booting-without-of.txt | 1 -
> arch/powerpc/boot/dts/mpc832x_mds.dts | 3 ---
> arch/powerpc/boot/dts/mpc832x_rdb.dts | 2 --
> arch/powerpc/boot/dts/mpc836x_mds.dts | 2 --
> arch/powerpc/boot/dts/mpc8568mds.dts | 2 --
> 5 files changed, 0 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/powerpc/booting-without-of.txt b/
> Documentation/powerpc/booting-without-of.txt
> index a3b6e2a..ab9f0bf 100644
> --- a/Documentation/powerpc/booting-without-of.txt
> +++ b/Documentation/powerpc/booting-without-of.txt
> @@ -1675,7 +1675,6 @@ platforms are moved over to use the flattened-
> device-tree model.
> ucc@2000 {
> device_type = "network";
> compatible = "ucc_geth";
> - model = "UCC";
> device-id = <1>;
can device-id be changed to cell-index?
- k
^ permalink raw reply
* Re: [PATCH 7/9] powerpc: add MPC837x RDB platform support
From: Kumar Gala @ 2008-01-25 16:17 UTC (permalink / raw)
To: Kim Phillips; +Cc: linuxppc-dev, Joe D'Abbraccio
In-Reply-To: <20080124204711.02ba14f0.kim.phillips@freescale.com>
On Jan 24, 2008, at 8:47 PM, Kim Phillips wrote:
> primarily based on mpc837x mds code.
>
> Signed-off-by: Joe D'Abbraccio <ljd015@freescale.com>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> ---
Who's the actual other of these patches? (all 9 of them).
- k
^ permalink raw reply
* Re: [PATCH 5/5] [POWERPC] fsl_soc, legacy_serial: add support for "soc" compatible matching
From: Kumar Gala @ 2008-01-25 16:35 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: Scott Wood, linuxppc-dev list, Yoder Stuart
In-Reply-To: <20080124154010.GE23246@localhost.localdomain>
On Jan 24, 2008, at 9:40 AM, Anton Vorontsov wrote:
> We'll match on "soc" compatible for generic code, and "fsl,soc"
> for fsl specific code.
>
> Unfortunately it's still impossible to remove device_type = "soc"
> from the existing device tree, because older u-boots are looking for
> it.
>
> Neither we can remove model number from the soc name to heal
> arch/powerpc/boot/cuboot-85xx.c, because then dts'es will be
> incompatible with older u-boots again.
>
> So, just one machine converted so far: MPC8360E-RDK. It's new machine
> so we don't care about backward compatibility yet.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
>
> I know, this patch will conflict with the legacy serial rework[1].
> It's okay though, if [1] will hit galak/powerpc.git first, I'll
> simply rebase that patch.
>
> [1] http://ozlabs.org/pipermail/linuxppc-dev/2008-January/050096.html
>
> Documentation/powerpc/booting-without-of.txt | 18 ++++------
> arch/powerpc/boot/dts/mpc836x_rdk.dts | 1 -
> arch/powerpc/kernel/legacy_serial.c | 3 +-
> arch/powerpc/sysdev/fsl_soc.c | 51 ++++++++++++++
> +-----------
> 4 files changed, 39 insertions(+), 34 deletions(-)
this needs a bit more discussion. "fsl,soc" is terrible describe. I
think we want some generic for the compat that implies 'soc register
space'.
- k
^ permalink raw reply
* Re: [PATCH 5/5] [POWERPC] fsl_soc, legacy_serial: add support for "soc" compatible matching
From: Anton Vorontsov @ 2008-01-25 19:18 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev list, Yoder Stuart
In-Reply-To: <479A3280.5070401@freescale.com>
On Fri, Jan 25, 2008 at 01:03:28PM -0600, Scott Wood wrote:
> Anton Vorontsov wrote:
> >$ grep qe@ arch/powerpc/boot/dts/*
> >arch/powerpc/boot/dts/mpc832x_mds.dts: qe@e0100000 {
> >arch/powerpc/boot/dts/mpc832x_rdb.dts: qe@e0100000 {
> >arch/powerpc/boot/dts/mpc836x_mds.dts: qe@e0100000 {
> >arch/powerpc/boot/dts/mpc8568mds.dts: qe@e0080000 {
> >
> >^^^ if the practice is wrong, then we should fix it, and then
> >-immr would be the good name indeed (just as I've said previously).
>
> It's wrong, and we should fix it.
Ok, good. I'll fix that for at least new RDK board. Though, fixing
other boards would be not trivial because of backward compatibility
and such. I'll also use -immr for RDK.
> It would make sense if the QE block
> were relocatable separately from IMMR (but even if it were, the QE
> compatible should be fsl,xxxx-qe or similar, so no conflict with
> fsl,xxxx-immr) -- but it isn't, at least on the 8323 and 8360 (I don't
> have an 8568 manual handy).
Nobody have an MPC8568E manual handy. :-P I've just looked there..
no QE isn't relocatable.
Oh, and I lied regarding CPM being relocatable. It isn't,
at least CPM2 and at least on MPC8555E. What a pity.
--
Anton Vorontsov
email: cbou@mail.ru
backup email: ya-cbou@yandex.ru
irc://irc.freenode.net/bd2
^ permalink raw reply
* Re: [PATCH 5/5] [POWERPC] fsl_soc, legacy_serial: add support for "soc" compatible matching
From: Anton Vorontsov @ 2008-01-25 17:13 UTC (permalink / raw)
To: Kumar Gala; +Cc: Scott Wood, linuxppc-dev list, Yoder Stuart
In-Reply-To: <9C11FC54-29CF-4027-97C3-FEB1EBA2D78B@kernel.crashing.org>
On Fri, Jan 25, 2008 at 10:35:06AM -0600, Kumar Gala wrote:
>
> On Jan 24, 2008, at 9:40 AM, Anton Vorontsov wrote:
>
> >We'll match on "soc" compatible for generic code, and "fsl,soc"
> >for fsl specific code.
> >
> >Unfortunately it's still impossible to remove device_type = "soc"
> >from the existing device tree, because older u-boots are looking for
> >it.
> >
> >Neither we can remove model number from the soc name to heal
> >arch/powerpc/boot/cuboot-85xx.c, because then dts'es will be
> >incompatible with older u-boots again.
> >
> >So, just one machine converted so far: MPC8360E-RDK. It's new machine
> >so we don't care about backward compatibility yet.
> >
> >Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> >---
> >
> >I know, this patch will conflict with the legacy serial rework[1].
> >It's okay though, if [1] will hit galak/powerpc.git first, I'll
> >simply rebase that patch.
> >
> >[1] http://ozlabs.org/pipermail/linuxppc-dev/2008-January/050096.html
> >
> >Documentation/powerpc/booting-without-of.txt | 18 ++++------
> >arch/powerpc/boot/dts/mpc836x_rdk.dts | 1 -
> >arch/powerpc/kernel/legacy_serial.c | 3 +-
> >arch/powerpc/sysdev/fsl_soc.c | 51 ++++++++++++++
> >+-----------
> >4 files changed, 39 insertions(+), 34 deletions(-)
>
> this needs a bit more discussion.
Ok.
> "fsl,soc" is terrible describe. I
> think we want some generic for the compat that implies 'soc register
> space'.
My thinking:
Freescale soc register space: "fsl,soc"
generic soc device: "soc" (or maybe "linux,soc" better?)
I know, Scott Wood is pushing "xxxx-immr" thing forward... but
I don't like that name because SOC isn't only device with the
Internal Memory Mapped Registers. (Think of QE placed outside
of "soc"/"immr" node).
Though, "soc" by itself is fully unfortunate name. QE is the
part of SOC too, as we used to call it when speaking of hardware.
But logically we divide things for "core soc" and "core soc's
companion/communication/offload modules", i.e. QE/CPMs/...
We can remove that ambiguity by moving QE/CPMs nodes inside
the soc node. Then indeed -immr would be the best compatible for
the "soc" node.
--
Anton Vorontsov
email: cbou@mail.ru
backup email: ya-cbou@yandex.ru
irc://irc.freenode.net/bd2
^ permalink raw reply
* Re: drivers/char/hvc_* and /Documentation/powerpc/hvcs.txt
From: Olof Johansson @ 2008-01-26 1:04 UTC (permalink / raw)
To: Timur Tabi; +Cc: linuxppc-dev
In-Reply-To: <479A651F.2070109@freescale.com>
On Fri, Jan 25, 2008 at 04:39:27PM -0600, Timur Tabi wrote:
> Hi,
>
> I'm working on a console driver for the Freescale hypervisor. I notice a bunch
> of hvc_* files in the drivers/char directory. I also noticed
> /Documentation/powerpc/hvcs.txt.
>
> My guess is that hvcs.txt talks about drivers/char/hvcs.c, which is a console
> driver specific to some IBM hypervisor. The hvc_*.c files are based on that
> code but they're more generic and allow people to write console drivers for
> other hypervisors easliy. Am I right?
Hvcs is the server-side driver in some environments. I.e. a hvc console
connects through the hypervisor to a hvcs in another partition.
> If so, does this mean that I can take hvc_beat.c, modify it to make Freescale
> hypervisor calls instead, and presto, I'm done?
Yep, pretty much. It's real easy to write a new backend to hvc, I've got
a couple for various bringup environments here as well.
-Olof
^ permalink raw reply
* Re: Reminder: removal of arch/ppc
From: Josh Boyer @ 2008-01-26 1:21 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev list, linuxppc-embedded
In-Reply-To: <E83C3B2F-0FC4-4248-B718-0C45B56E969A@kernel.crashing.org>
On Fri, 25 Jan 2008 10:55:25 -0600
Kumar Gala <galak@kernel.crashing.org> wrote:
> Just a reminder that the plan is to remove arch/ppc this summer (June
> 2008). The following boards still existing over in arch/ppc. Some of
> them have been ported over to arch/powerpc. If you care about one of
> these boards and its not ported speak up (it helps if you have access
> to the board). Also, if you know a given board is free to die of
> bitrot let us know so we know not to worry about it:
> 4xx:
> BAMBOO
Ported (mostly)
> CPCI405
Doubt this will be ported.
> EBONY
Ported (mostly)
> EP405
Ported (mostly)
> BUBINGA
> LUAN
No idea on these.
> YUCCA
Yucca was what again? 440spe?
> OCOTEA
This one will be ported soon. I have an ocotea now.
> REDWOOD_5
> REDWOOD_6
Don't have either of these.
> SYCAMORE
I think Mathias was working on a 405gpr port somewhere.
> TAISHAN
> WALNUT
Ported (mostly)
> XILINX_ML300
> XILINX_ML403
Grant should have these in decent shape.
josh
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox