* Re: [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers
From: Johannes Berg @ 2009-04-20 21:04 UTC (permalink / raw)
To: Jean Delvare; +Cc: Takashi Iwai, linuxppc-dev, alsa-devel, Andreas Schwab
In-Reply-To: <20090420225425.2a150a4f@hyperion.delvare>
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
On Mon, 2009-04-20 at 22:54 +0200, Jean Delvare wrote:
> The legacy i2c binding model is going away soon, so convert the AOA
> codec drivers to the new model or they'll break.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Tested-by: Johannes Berg <johannes@sipsolutions.net>
> Tested-by: Andreas Schwab <schwab@linux-m68k.org>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Takashi Iwai <tiwai@suse.de>
> ---
> Takashi, please push this patch to Linus quickly, as this is blocking
> the removal of the legacy i2c binding model, which is scheduled for
> 2.6.30.
Have you taken care of snd-powermac similarly?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply
* Re: Proposed prom parse fix + moving.
From: Grant Likely @ 2009-04-20 21:15 UTC (permalink / raw)
To: Ilpo Järvinen; +Cc: Michal Simek, Arnd Bergmann, linuxppc-dev
In-Reply-To: <fa686aa40904172235u2e39f52jee3f7274cd4bd00b@mail.gmail.com>
On Fri, Apr 17, 2009 at 11:35 PM, Grant Likely
<grant.likely@secretlab.ca> wrote:
> On Fri, Apr 17, 2009 at 4:07 PM, Ilpo J=E4rvinen
>> [PATCH] powerpc & microblaze: add missing of_node_put to error handling
>>
>> While reviewing some microblaze patches a while ago, I noticed
>> a suspicious error handling in of_irq_map_one(), which turned
>> out to be a copy from arch/powerpc. Grant Likely
>> <grant.likely@secretlab.ca> confirmed that this is a real bug.
>>
>> Merge error handling paths using goto with the normal return
>> path.
>>
>> Powerppc compile tested.
>>
>> Signed-off-by: Ilpo J=E4rvinen <ilpo.jarvinen@helsinki.fi>
>
> Looks right to me (but I haven't tested).
>
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
I've picked up the powerpc half of this patch, tested it, and pushed
it out to my -next tree and asked Ben or Paul to pull.
Michal, I leave it to you to pick up the Microblaze half.
Cheers,
g.
>
>> ---
>> =A0arch/microblaze/kernel/prom_parse.c | =A0 11 +++++------
>> =A0arch/powerpc/kernel/prom_parse.c =A0 =A0| =A0 11 +++++------
>> =A02 files changed, 10 insertions(+), 12 deletions(-)
>>
>> diff --git a/arch/microblaze/kernel/prom_parse.c b/arch/microblaze/kerne=
l/prom_parse.c
>> index ae0352e..d16c32f 100644
>> --- a/arch/microblaze/kernel/prom_parse.c
>> +++ b/arch/microblaze/kernel/prom_parse.c
>> @@ -903,7 +903,7 @@ int of_irq_map_one(struct device_node *device,
>> =A0 =A0 =A0 =A0struct device_node *p;
>> =A0 =A0 =A0 =A0const u32 *intspec, *tmp, *addr;
>> =A0 =A0 =A0 =A0u32 intsize, intlen;
>> - =A0 =A0 =A0 int res;
>> + =A0 =A0 =A0 int res =3D -EINVAL;
>>
>> =A0 =A0 =A0 =A0pr_debug("of_irq_map_one: dev=3D%s, index=3D%d\n",
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0device->full_name, index)=
;
>> @@ -926,21 +926,20 @@ int of_irq_map_one(struct device_node *device,
>>
>> =A0 =A0 =A0 =A0/* Get size of interrupt specifier */
>> =A0 =A0 =A0 =A0tmp =3D of_get_property(p, "#interrupt-cells", NULL);
>> - =A0 =A0 =A0 if (tmp =3D=3D NULL) {
>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 of_node_put(p);
>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 return -EINVAL;
>> - =A0 =A0 =A0 }
>> + =A0 =A0 =A0 if (tmp =3D=3D NULL)
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 goto out;
>> =A0 =A0 =A0 =A0intsize =3D *tmp;
>>
>> =A0 =A0 =A0 =A0pr_debug(" intsize=3D%d intlen=3D%d\n", intsize, intlen);
>>
>> =A0 =A0 =A0 =A0/* Check index */
>> =A0 =A0 =A0 =A0if ((index + 1) * intsize > intlen)
>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 return -EINVAL;
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 goto out;
>>
>> =A0 =A0 =A0 =A0/* Get new specifier and map it */
>> =A0 =A0 =A0 =A0res =3D of_irq_map_raw(p, intspec + index * intsize, ints=
ize,
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0addr, out=
_irq);
>> +out:
>> =A0 =A0 =A0 =A0of_node_put(p);
>> =A0 =A0 =A0 =A0return res;
>> =A0}
>> diff --git a/arch/powerpc/kernel/prom_parse.c b/arch/powerpc/kernel/prom=
_parse.c
>> index 8f0856f..8362620 100644
>> --- a/arch/powerpc/kernel/prom_parse.c
>> +++ b/arch/powerpc/kernel/prom_parse.c
>> @@ -971,7 +971,7 @@ int of_irq_map_one(struct device_node *device, int i=
ndex, struct of_irq *out_irq
>> =A0 =A0 =A0 =A0struct device_node *p;
>> =A0 =A0 =A0 =A0const u32 *intspec, *tmp, *addr;
>> =A0 =A0 =A0 =A0u32 intsize, intlen;
>> - =A0 =A0 =A0 int res;
>> + =A0 =A0 =A0 int res =3D -EINVAL;
>>
>> =A0 =A0 =A0 =A0DBG("of_irq_map_one: dev=3D%s, index=3D%d\n", device->ful=
l_name, index);
>>
>> @@ -995,21 +995,20 @@ int of_irq_map_one(struct device_node *device, int=
index, struct of_irq *out_irq
>>
>> =A0 =A0 =A0 =A0/* Get size of interrupt specifier */
>> =A0 =A0 =A0 =A0tmp =3D of_get_property(p, "#interrupt-cells", NULL);
>> - =A0 =A0 =A0 if (tmp =3D=3D NULL) {
>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 of_node_put(p);
>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 return -EINVAL;
>> - =A0 =A0 =A0 }
>> + =A0 =A0 =A0 if (tmp =3D=3D NULL)
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 goto out;
>> =A0 =A0 =A0 =A0intsize =3D *tmp;
>>
>> =A0 =A0 =A0 =A0DBG(" intsize=3D%d intlen=3D%d\n", intsize, intlen);
>>
>> =A0 =A0 =A0 =A0/* Check index */
>> =A0 =A0 =A0 =A0if ((index + 1) * intsize > intlen)
>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 return -EINVAL;
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 goto out;
>>
>> =A0 =A0 =A0 =A0/* Get new specifier and map it */
>> =A0 =A0 =A0 =A0res =3D of_irq_map_raw(p, intspec + index * intsize, ints=
ize,
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 addr, out_irq);
>> +out:
>> =A0 =A0 =A0 =A0of_node_put(p);
>> =A0 =A0 =A0 =A0return res;
>> =A0}
>> --
>> 1.5.6.5
>>
>
>
>
> --
> Grant Likely, B.Sc., P.Eng.
> Secret Lab Technologies Ltd.
>
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply
* Re: Please pull merge branch from git.secretlab.ca
From: Grant Likely @ 2009-04-20 21:10 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras
Cc: Stefan Roese, linuxppc-dev, Subrata Modak
In-Reply-To: <fa686aa40904162258i450c86e9k303933d41405c89b@mail.gmail.com>
Hi Ben/Paul,
Here's an updated pull request with 5200 defconfig updates and a
bugfix to prom_parse.c
Cheers,
g.
The following changes since commit 0882e8dd3aad33eca41696d463bb896e6c8817eb=
:
Linus Torvalds (1):
Linux 2.6.30-rc2
are available in the git repository at:
git://git.secretlab.ca/git/linux-2.6 merge
Anton Vorontsov (1):
powerpc/5200: Bring the legacy fsl_spi_platform_data hooks back
Grant Likely (2):
powerpc/5200: Add FLASH nodes to lite5200 device tree
powerpc/5200: defconfig updates
Ilpo J=E4rvinen (1):
powerpc: Fix of_node_put() exit path in of_irq_map_one()
Stefan Roese (2):
powerpc/of-device-tree: Factor MTD physmap bindings out of
booting-without-of
powerpc/device-tree: Document MTD nodes with multiple "reg" tuples
Documentation/powerpc/booting-without-of.txt | 89 ++--------
Documentation/powerpc/dts-bindings/mtd-physmap.txt | 80 +++++++++
arch/powerpc/boot/dts/lite5200b.dts | 39 ++++
arch/powerpc/configs/52xx/cm5200_defconfig | 69 +++++--
arch/powerpc/configs/52xx/lite5200b_defconfig | 74 ++++++--
arch/powerpc/configs/52xx/motionpro_defconfig | 77 ++++++--
arch/powerpc/configs/52xx/pcm030_defconfig | 69 +++++--
arch/powerpc/configs/52xx/tqm5200_defconfig | 76 ++++++--
arch/powerpc/configs/mpc5200_defconfig | 188 ++++++++++++++++=
----
arch/powerpc/kernel/prom_parse.c | 11 +-
include/linux/fsl_devices.h | 4 +
11 files changed, 568 insertions(+), 208 deletions(-)
create mode 100644 Documentation/powerpc/dts-bindings/mtd-physmap.txt
On Thu, Apr 16, 2009 at 11:58 PM, Grant Likely
<grant.likely@secretlab.ca> wrote:
> Hi Ben/Paul,
>
> Here are some fixups and documentation updates for 2.6.30
>
> The following changes since commit 0882e8dd3aad33eca41696d463bb896e6c8817=
eb:
> =A0Linus Torvalds (1):
> =A0 =A0 =A0 =A0Linux 2.6.30-rc2
>
> are available in the git repository at:
>
> =A0git://git.secretlab.ca/git/linux-2.6 merge
>
> Anton Vorontsov (1):
> =A0 =A0 =A0powerpc/5200: Bring the legacy fsl_spi_platform_data hooks bac=
k
>
> Grant Likely (1):
> =A0 =A0 =A0powerpc/5200: Add FLASH nodes to lite5200 device tree
>
> Stefan Roese (2):
> =A0 =A0 =A0powerpc/of-device-tree: Factor MTD physmap bindings out of
> booting-without-of
> =A0 =A0 =A0powerpc/device-tree: Document MTD nodes with multiple "reg" tu=
ples
>
> =A0Documentation/powerpc/booting-without-of.txt =A0 =A0 =A0 | =A0 89 +++-=
----------------
> =A0Documentation/powerpc/dts-bindings/mtd-physmap.txt | =A0 80 ++++++++++=
++++++++
> =A0arch/powerpc/boot/dts/lite5200b.dts =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| =
=A0 39 +++++++++
> =A0include/linux/fsl_devices.h =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0| =A0 =A04 +
> =A04 files changed, 135 insertions(+), 77 deletions(-)
> =A0create mode 100644 Documentation/powerpc/dts-bindings/mtd-physmap.txt
>
>
> --
> Grant Likely, B.Sc., P.Eng.
> Secret Lab Technologies Ltd.
>
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply
* Re: [PATCH] keywest: Convert to new-style i2c driver
From: Paul Mackerras @ 2009-04-20 22:34 UTC (permalink / raw)
To: Jean Delvare; +Cc: Takashi Iwai, linuxppc-dev, alsa-devel
In-Reply-To: <20090420225659.7b92a184@hyperion.delvare>
Jean Delvare writes:
> Takashi, please push this patch to Linus quickly, as this is blocking
> the removal of the legacy i2c binding model, which is scheduled for
> 2.6.30.
I really don't think you can remove it from Linus' tree at this stage
in the 2.6.30 cycle. If it was going to be removed it should have
been removed in the merge window. Removing it now has too much risk
of introducing regressions in my opinion.
I presume you have a development tree where you queue up commits for
the i2c subsystem for the next merge window. I suggest you do the
removal there now (or whenever you like) and push it to Linus in the
next merge window.
Paul.
^ permalink raw reply
* Re: Porting the ibm_newemac driver to use phylib (and other PHY/MAC questions)
From: Kyle Moffett @ 2009-04-21 0:10 UTC (permalink / raw)
To: Josh Boyer; +Cc: linuxppc-dev, netdev, Linux-Kernel@Vger. Kernel. Org
In-Reply-To: <625fc13d0904200529l152b8d75g33c3f940de1b2920@mail.gmail.com>
On Mon, Apr 20, 2009 at 8:29 AM, Josh Boyer <jwboyer@linux.vnet.ibm.com> wr=
ote:
> On Fri, Apr 17, 2009 at 8:32 PM, Kyle Moffett <kyle@moffetthome.net> wrot=
e:
>> Hello,
>>
>> I'm currently fiddling with a custom embedded prototype board using
>> the ibm_newemac driver with some currently-unsupported PHYs. =C2=A0Those
>> PHYs *are* supported by phylib, but the emac driver seems to have its
>> own PHY layer cribbed from the sungem driver. =C2=A0I'm curious if there=
's
>> some particular reason it hasn't been ported (aside from "nobody has
>> bothered yet").
>
> IIRC, Ben had some issues with how phylib and the EMAC would need to
> interact. =C2=A0Not sure if he has those written down somewhere or not.
> (CC'd).
Hmm, yeah, I'd be interested to see those. There's enough similar
between phylib and the EMAC and sungem drivers that I'm considering a
series of somewhat-mechanical patches to make EMAC and sungem use the
"struct phy_device" and "struct mii_bus" from phylib, possibly
abstracting out some helper functions along the way.
>> Also, if I end up
>> going that route, are there others available with other hardware
>> variants who would be willing to test my patches on their boards?
>
> I have a large variety of boards that I can test with since the entire
> 4xx line relies on this driver for on-board network.
Wonderful! If/when I hack together a patch series I'll make sure to
put you on the CC list. Thanks!
Cheers,
Kyle Moffett
^ permalink raw reply
* Re: [PATCH 2/5] powerpc: Add 36-bit device tree for mpc8641hpcn
From: David Gibson @ 2009-04-21 1:10 UTC (permalink / raw)
To: Becky Bruce; +Cc: fujita.tomonori, linuxppc-dev
In-Reply-To: <1240244810-32193-5-git-send-email-beckyb@kernel.crashing.org>
On Mon, Apr 20, 2009 at 11:26:47AM -0500, Becky Bruce wrote:
> The new dts places most of the devices in physical address space
> above 32-bits, which allows us to have more than 4GB of RAM present.
>
> Signed-off-by: Becky Bruce <beckyb@kernel.crashing.org>
> ---
> arch/powerpc/boot/dts/mpc8641_hpcn_36b.dts | 597 ++++++++++++++++++++++++++++
> 1 files changed, 597 insertions(+), 0 deletions(-)
> create mode 100644 arch/powerpc/boot/dts/mpc8641_hpcn_36b.dts
>
> diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn_36b.dts b/arch/powerpc/boot/dts/mpc8641_hpcn_36b.dts
> new file mode 100644
> index 0000000..baa3dba
> --- /dev/null
> +++ b/arch/powerpc/boot/dts/mpc8641_hpcn_36b.dts
> @@ -0,0 +1,597 @@
> +/*
> + * MPC8641 HPCN Device Tree Source
> + *
> + * Copyright 2006 Freescale Semiconductor Inc.
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the
> + * Free Software Foundation; either version 2 of the License, or (at your
> + * option) any later version.
> + */
[snip]
> + soc8641@fffe00000 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + device_type = "soc";
> + compatible = "simple-bus";
Uh, you definitely need something more specific in the compatible
property before "simple-bus".
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply
* Re: [PATCH 5/5] powerpc: Add 86xx support for SWIOTLB
From: Michael Ellerman @ 2009-04-21 2:14 UTC (permalink / raw)
To: Becky Bruce; +Cc: fujita.tomonori, linuxppc-dev
In-Reply-To: <36CDD079-FEFD-4928-A997-8DE9C2E1D3D0@kernel.crashing.org>
[-- Attachment #1: Type: text/plain, Size: 1480 bytes --]
On Mon, 2009-04-20 at 12:58 -0500, Becky Bruce wrote:
> On Apr 20, 2009, at 12:00 PM, Kumar Gala wrote:
> > On Apr 20, 2009, at 11:26 AM, Becky Bruce wrote:
> >>
> >> config PPC_NEED_DMA_SYNC_OPS
> >> def_bool y
> >> depends on (NOT_COHERENT_CACHE || SWIOTLB)
> >> diff --git a/arch/powerpc/kernel/dma-swiotlb.c b/arch/powerpc/
> >> kernel/dma-swiotlb.c
> >> index 29a68e6..3065d03 100644
> >> --- a/arch/powerpc/kernel/dma-swiotlb.c
> >> +++ b/arch/powerpc/kernel/dma-swiotlb.c
> >> @@ -159,3 +159,5 @@ static int __init setup_bus_notifier(void)
> >>
> >> return 0;
> >> }
> >> +
> >> +machine_arch_initcall(mpc86xx_hpcn, setup_bus_notifier);
> >
> > Hmm, not sure what we chatted about here, but I don't want to have
> > to add every board into this file to register the bus notifiers.
>
> We talked about this, and this was what we decided on - I don't really
> like the idea, either, but there's a lot of precedent for it. I'd
> like to do this differently, but I"m not sure what the solution is -
> we'd need to look into that more (or perhaps someone here will have
> some sage advice).
Give it a better name, export it, and call it from the board setup file?
Actually what depends on the board anyway? It's just the dma window
config in the pci_controller isn't it? So maybe you can always call the
notifier, and if the dma mask isn't 36 bits, and the controller has the
window configured then you use swiotlb?
cheers
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply
* Re: [microblaze-uclinux] [PATCH 11/11] microblaze: Kconfig: Enable drivers for Microblaze
From: John Williams @ 2009-04-21 2:24 UTC (permalink / raw)
To: Grant Likely
Cc: linuxppc-dev, Stephen Neuendorffer, John Linn, linux-kernel,
microblaze-uclinux
In-Reply-To: <fa686aa40904200748t4fc0b623naf7fd8c34a743733@mail.gmail.com>
On Tue, Apr 21, 2009 at 12:48 AM, Grant Likely
<grant.likely@secretlab.ca> wrote:
> On Mon, Apr 20, 2009 at 8:36 AM, John Linn <John.Linn@xilinx.com> wrote:
>>> -----Original Message-----
>>> From: Stephen Neuendorffer
>>> Sent: Sunday, April 19, 2009 11:52 PM
>>> To: John Williams; microblaze-uclinux@itee.uq.edu.au
>>> Cc: grant.likely@secretlab.ca; linuxppc-dev; linux-kernel@vger.kernel.o=
rg; John Linn
>>> Subject: RE: [microblaze-uclinux] [PATCH 11/11] microblaze: Kconfig: En=
able drivers for Microblaze
>>>
>>>
>>> My thinking is that these drivers are likely to be used as a group,
>>> hence it would be nice to make it easy to get them all visible/enabled =
somehow.
>>>
>>> Steve
>>
>>
>> It seems like John's suggestion of no arch filters would satisfy that al=
so. Since FPGAs are used in so many different applications this would seem =
to open the drivers up to everyone regardless of what processor they're usi=
ng. It's certainly less complex so I like it in that way.
>>
>> But maybe I'm missing something here and there's a downside?
>
> No, I don't think there is.
>
> I think CONFIG_OF is the right thing to do.
Some (most?) of the Xilinx drivers currently have this construct:
#ifdef CONFIG_OF
// probe using OF
#else
// probe using platform_device
#endif
so unless this is going to change some time soon, maybe even CONFIG_OF
is too restrictive?
John
--=20
John Williams, PhD, B.Eng, B.IT
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com p: +61-7-30090663 f: +61-7-30090663
^ permalink raw reply
* Re: [PATCH 1/5] powerpc: Use sg->dma_length in sg_dma_len() macro on 32-bit
From: FUJITA Tomonori @ 2009-04-21 2:27 UTC (permalink / raw)
To: galak; +Cc: fujita.tomonori, linuxppc-dev
In-Reply-To: <D90E22E0-F97C-4531-9732-F8489D8BA7AD@kernel.crashing.org>
On Mon, 20 Apr 2009 15:06:16 -0500
Kumar Gala <galak@kernel.crashing.org> wrote:
>
> On Apr 20, 2009, at 11:26 AM, Becky Bruce wrote:
>
> > Currently, the 32-bit code uses sg->length instead of sg->dma_lentgh
> > to report sg_dma_len. However, since the default dma code for 32-bit
> > (the dma_direct case) sets dma_length and length to the same thing,
> > we should be able to use dma_length there as well. This gets rid of
> > some 32-vs-64-bit ifdefs, and is needed by the swiotlb code which
> > actually distinguishes between dma_length and length.
> >
> > Signed-off-by: Becky Bruce <beckyb@kernel.crashing.org>
> > ---
> > arch/powerpc/include/asm/scatterlist.h | 6 +-----
> > 1 files changed, 1 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/powerpc/include/asm/scatterlist.h b/arch/powerpc/
> > include/asm/scatterlist.h
> > index fcf7d55..912bf59 100644
> > --- a/arch/powerpc/include/asm/scatterlist.h
> > +++ b/arch/powerpc/include/asm/scatterlist.h
> > @@ -21,7 +21,7 @@ struct scatterlist {
> > unsigned int offset;
> > unsigned int length;
>
> can we get rid of length?
You can't.
> >
> >
> > - /* For TCE support */
> > + /* For TCE or SWIOTLB support */
> > dma_addr_t dma_address;
> > u32 dma_length;
> > };
> > @@ -34,11 +34,7 @@ struct scatterlist {
> > * is 0.
> > */
> > #define sg_dma_address(sg) ((sg)->dma_address)
> > -#ifdef __powerpc64__
> > #define sg_dma_len(sg) ((sg)->dma_length)
> > -#else
> > -#define sg_dma_len(sg) ((sg)->length)
> > -#endif
> >
> > #ifdef __powerpc64__
> > #define ISA_DMA_THRESHOLD (~0UL)
> > --
> > 1.6.0.6
>
> - k
>
>
^ permalink raw reply
* Re: [PATCH 4/5] powerpc: Add support for swiotlb on 32-bit
From: FUJITA Tomonori @ 2009-04-21 2:39 UTC (permalink / raw)
To: beckyb; +Cc: fujita.tomonori, linuxppc-dev
In-Reply-To: <519AC89C-88A5-418A-AD91-488EC13E8387@kernel.crashing.org>
On Mon, 20 Apr 2009 13:03:20 -0500
Becky Bruce <beckyb@kernel.crashing.org> wrote:
>
> On Apr 20, 2009, at 11:57 AM, Kumar Gala wrote:
>
> >
> > On Apr 20, 2009, at 11:26 AM, Becky Bruce wrote:
> >
> >> This patch includes the basic infrastructure to use swiotlb
> >> bounce buffering on 32-bit powerpc. It is not yet enabled on
> >> any platforms.
> >>
> >> Signed-off-by: Becky Bruce <beckyb@kernel.crashing.org>
> >> ---
> >> arch/powerpc/Kconfig | 2 +-
> >> arch/powerpc/include/asm/dma-mapping.h | 11 ++
> >> arch/powerpc/include/asm/swiotlb.h | 24 +++++
> >> arch/powerpc/kernel/Makefile | 1 +
> >> arch/powerpc/kernel/dma-swiotlb.c | 161 ++++++++++++++++++++++
> >> ++++++++++
> >> arch/powerpc/kernel/dma.c | 2 +-
> >> arch/powerpc/kernel/setup_32.c | 4 +
> >> 7 files changed, 203 insertions(+), 2 deletions(-)
> >> create mode 100644 arch/powerpc/include/asm/swiotlb.h
> >> create mode 100644 arch/powerpc/kernel/dma-swiotlb.c
> >>
> >> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> >> index 5b50e1a..197f6a3 100644
> >> --- a/arch/powerpc/Kconfig
> >> +++ b/arch/powerpc/Kconfig
> >> @@ -294,7 +294,7 @@ config IOMMU_HELPER
> >>
> >> config PPC_NEED_DMA_SYNC_OPS
> >> def_bool y
> >> - depends on NOT_COHERENT_CACHE
> >> + depends on (NOT_COHERENT_CACHE || SWIOTLB)
> >
> > This isn't right, since you haven't introduced the SWIOTLB Kconfig.
> >
> >
> > Why don't we just put the SWIOTLB Kconfig option in here and default
> > it no (and remove the dep on 86xx).
>
> Sure. I'll probably add a comment or something though so people don't
> think they can just enable it on anything and expect it to work. Too
> many people seem to read the config files and decide things are
> possible that actually aren't :)
>
> >
> >
> >> config HOTPLUG_CPU
> >> bool "Support for enabling/disabling CPUs"
> >
> >
> >> diff --git a/arch/powerpc/kernel/dma-swiotlb.c b/arch/powerpc/
> >> kernel/dma-swiotlb.c
> >> new file mode 100644
> >> index 0000000..29a68e6
> >> --- /dev/null
> >> +++ b/arch/powerpc/kernel/dma-swiotlb.c
> >> @@ -0,0 +1,161 @@
> >> +/*
> >> + * Contains routines needed to support swiotlb for ppc.
> >> + *
> >> + * Copyright (C) 2009 Becky Bruce, Freescale Semiconductor
> >> + *
> >> + * This program is free software; you can redistribute it and/or
> >> modify it
> >> + * under the terms of the GNU General Public License as
> >> published by the
> >> + * Free Software Foundation; either version 2 of the License, or
> >> (at your
> >> + * option) any later version.
> >> + *
> >> + */
> >
> > [snip]
> >
> >>
> >> +
> >> +static int ppc_swiotlb_bus_notify(struct notifier_block *nb,
> >> + unsigned long action, void *data)
> >> +{
> >> + struct device *dev = data;
> >> +
> >> + /* We are only intereted in device addition */
> >> + if (action != BUS_NOTIFY_ADD_DEVICE)
> >> + return 0;
> >> +
> >> + if (dma_get_mask(dev) < DMA_BIT_MASK(36))
> >> + set_dma_ops(dev, &swiotlb_dma_ops);
> >> +
> >
> > this isn't right. Isn't possible for a PCI dev to have a
> > DMA_BIT_MASK(64) but us still not be able to dma to it? Also, I
> > dont like the assumption of 36-bit physical here.
>
> You're right - this is just handling the basic case and for now I'm
> assuming that we don't bounce 64-bit devices (or any device that can
> handle 36 bits). We'll need to talk in more detail about a solution
> to that problem, because knowing if a 64b dev *might* need to bounce
> (which is all this is really saying) requires more information. We
> also don't really have infrastructure to deal with holes in the
> visible dev memory, and I don't know if we want to handle that as
> well. I don't want to set the dma_ops to swiotlb unless we have to
> because there's a slight perf hit in running all the checks to see if
> an address needs to be bounced.
I think that you always just set the dma_ops to swiotlb. It's the
cleanest solution. Do you really see the performance drop due to the
checking?
^ permalink raw reply
* Re: Move dtc and libfdt sources from arch/powerpc/boot to scripts/dtc
From: David Gibson @ 2009-04-21 5:17 UTC (permalink / raw)
To: Paul Mackerras
Cc: Andrew Morton, monstr, linux-kernel, linuxppc-dev, Linus Torvalds,
Michal Simek
In-Reply-To: <18906.57833.843101.770634@drongo.ozlabs.ibm.com>
On Tue, Apr 07, 2009 at 03:17:29PM +1000, Paul Mackerras wrote:
> David Gibson writes:
>
> > The vast bulk of this patch is a literal move, the rest is adjusting
> > the various Makefiles to use dtc and libfdt correctly from their new
> > locations.
>
> Did you test this with a separate object directory? I get:
Ugh. Obviously not. New patch coming.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply
* [PATCH] Move dtc and libfdt sources from arch/powerpc/boot to scripts/dtc
From: David Gibson @ 2009-04-21 5:20 UTC (permalink / raw)
To: Andrew Morton
Cc: monstr, linux-kernel, linuxppc-dev, Paul Mackerras, benh,
Michal Simek
The powerpc kernel always requires an Open Firmware like device tree
to supply device information. On systems without OF, this comes from
a flattened device tree blob. This blob is usually generated by dtc,
a tool which compiles a text description of the device tree into the
flattened format used by the kernel. Sometimes, the bootwrapper makes
small changes to the pre-compiled device tree blob (e.g. filling in
the size of RAM). To do this it uses the libfdt library.
Because these are only used on powerpc, the code for both these tools
is included under arch/powerpc/boot (these were imported and are
periodically updated from the upstream dtc tree).
However, the microblaze architecture, currently being prepared for
merging to mainline also uses dtc to produce device tree blobs. A few
other archs have also mentioned some interest in using dtc.
Therefore, this patch moves dtc and libfdt from arch/powerpc into
scripts, where it can be used by any architecture.
The vast bulk of this patch is a literal move, the rest is adjusting
the various Makefiles to use dtc and libfdt correctly from their new
locations.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
arch/powerpc/Kconfig | 4 +
arch/powerpc/boot/Makefile | 67 +++++++-------------
arch/powerpc/boot/simpleboot.c | 2 +-
scripts/Makefile | 1 +
scripts/dtc/Makefile | 54 ++++++++++++++++
.../boot/dtc-src => scripts/dtc}/Makefile.dtc | 0
.../powerpc/boot/dtc-src => scripts/dtc}/checks.c | 0
{arch/powerpc/boot/dtc-src => scripts/dtc}/data.c | 0
.../boot/dtc-src => scripts/dtc}/dtc-lexer.l | 0
.../dtc}/dtc-lexer.lex.c_shipped | 0
.../dtc}/dtc-parser.tab.c_shipped | 0
.../dtc}/dtc-parser.tab.h_shipped | 0
.../boot/dtc-src => scripts/dtc}/dtc-parser.y | 0
{arch/powerpc/boot/dtc-src => scripts/dtc}/dtc.c | 0
{arch/powerpc/boot/dtc-src => scripts/dtc}/dtc.h | 0
.../boot/dtc-src => scripts/dtc}/flattree.c | 0
.../powerpc/boot/dtc-src => scripts/dtc}/fstree.c | 0
.../boot => scripts/dtc}/libfdt/Makefile.libfdt | 0
{arch/powerpc/boot => scripts/dtc}/libfdt/fdt.c | 0
{arch/powerpc/boot => scripts/dtc}/libfdt/fdt.h | 0
{arch/powerpc/boot => scripts/dtc}/libfdt/fdt_ro.c | 0
{arch/powerpc/boot => scripts/dtc}/libfdt/fdt_rw.c | 0
.../boot => scripts/dtc}/libfdt/fdt_strerror.c | 0
{arch/powerpc/boot => scripts/dtc}/libfdt/fdt_sw.c | 0
.../powerpc/boot => scripts/dtc}/libfdt/fdt_wip.c | 0
{arch/powerpc/boot => scripts/dtc}/libfdt/libfdt.h | 0
.../dtc-src => scripts/dtc/libfdt}/libfdt_env.h | 0
.../boot => scripts/dtc}/libfdt/libfdt_internal.h | 0
.../boot/dtc-src => scripts/dtc}/livetree.c | 0
.../powerpc/boot/dtc-src => scripts/dtc}/srcpos.c | 0
.../powerpc/boot/dtc-src => scripts/dtc}/srcpos.h | 0
.../boot/dtc-src => scripts/dtc}/treesource.c | 0
.../boot/dtc-src => scripts/dtc}/version_gen.h | 0
33 files changed, 83 insertions(+), 45 deletions(-)
create mode 100644 scripts/dtc/Makefile
rename {arch/powerpc/boot/dtc-src => scripts/dtc}/Makefile.dtc (100%)
rename {arch/powerpc/boot/dtc-src => scripts/dtc}/checks.c (100%)
rename {arch/powerpc/boot/dtc-src => scripts/dtc}/data.c (100%)
rename {arch/powerpc/boot/dtc-src => scripts/dtc}/dtc-lexer.l (100%)
rename {arch/powerpc/boot/dtc-src => scripts/dtc}/dtc-lexer.lex.c_shipped (100%)
rename {arch/powerpc/boot/dtc-src => scripts/dtc}/dtc-parser.tab.c_shipped (100%)
rename {arch/powerpc/boot/dtc-src => scripts/dtc}/dtc-parser.tab.h_shipped (100%)
rename {arch/powerpc/boot/dtc-src => scripts/dtc}/dtc-parser.y (100%)
rename {arch/powerpc/boot/dtc-src => scripts/dtc}/dtc.c (100%)
rename {arch/powerpc/boot/dtc-src => scripts/dtc}/dtc.h (100%)
rename {arch/powerpc/boot/dtc-src => scripts/dtc}/flattree.c (100%)
rename {arch/powerpc/boot/dtc-src => scripts/dtc}/fstree.c (100%)
rename {arch/powerpc/boot => scripts/dtc}/libfdt/Makefile.libfdt (100%)
rename {arch/powerpc/boot => scripts/dtc}/libfdt/fdt.c (100%)
rename {arch/powerpc/boot => scripts/dtc}/libfdt/fdt.h (100%)
rename {arch/powerpc/boot => scripts/dtc}/libfdt/fdt_ro.c (100%)
rename {arch/powerpc/boot => scripts/dtc}/libfdt/fdt_rw.c (100%)
rename {arch/powerpc/boot => scripts/dtc}/libfdt/fdt_strerror.c (100%)
rename {arch/powerpc/boot => scripts/dtc}/libfdt/fdt_sw.c (100%)
rename {arch/powerpc/boot => scripts/dtc}/libfdt/fdt_wip.c (100%)
rename {arch/powerpc/boot => scripts/dtc}/libfdt/libfdt.h (100%)
rename {arch/powerpc/boot/dtc-src => scripts/dtc/libfdt}/libfdt_env.h (100%)
rename {arch/powerpc/boot => scripts/dtc}/libfdt/libfdt_internal.h (100%)
rename {arch/powerpc/boot/dtc-src => scripts/dtc}/livetree.c (100%)
rename {arch/powerpc/boot/dtc-src => scripts/dtc}/srcpos.c (100%)
rename {arch/powerpc/boot/dtc-src => scripts/dtc}/srcpos.h (100%)
rename {arch/powerpc/boot/dtc-src => scripts/dtc}/treesource.c (100%)
rename {arch/powerpc/boot/dtc-src => scripts/dtc}/version_gen.h (100%)
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 4c78045..a0d1146 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -181,6 +181,10 @@ config SYS_SUPPORTS_APM_EMULATION
default y if PMAC_APM_EMU
bool
+config DTC
+ bool
+ default y
+
config DEFAULT_UIMAGE
bool
help
diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
index 4458abb..8da2bf9 100644
--- a/arch/powerpc/boot/Makefile
+++ b/arch/powerpc/boot/Makefile
@@ -33,7 +33,7 @@ ifeq ($(call cc-option-yn, -fstack-protector),y)
BOOTCFLAGS += -fno-stack-protector
endif
-BOOTCFLAGS += -I$(obj) -I$(srctree)/$(obj) -I$(srctree)/$(src)/libfdt
+BOOTCFLAGS += -I$(obj) -I$(srctree)/$(obj)
DTS_FLAGS ?= -p 1024
@@ -53,9 +53,14 @@ zliblinuxheader := zlib.h zconf.h zutil.h
$(addprefix $(obj)/,$(zlib) cuboot-c2k.o gunzip_util.o main.o prpmc2800.o): \
$(addprefix $(obj)/,$(zliblinuxheader)) $(addprefix $(obj)/,$(zlibheader))
-src-libfdt := fdt.c fdt_ro.c fdt_wip.c fdt_sw.c fdt_rw.c fdt_strerror.c
+libfdt := fdt.c fdt_ro.c fdt_wip.c fdt_sw.c fdt_rw.c fdt_strerror.c
+libfdtheader := fdt.h libfdt.h libfdt_internal.h
+
+$(addprefix $(obj)/,$(libfdt) libfdt-wrapper.o simpleboot.o): \
+ $(addprefix $(obj)/,$(libfdtheader))
+
src-wlib := string.S crt0.S crtsavres.S stdio.c main.c \
- $(addprefix libfdt/,$(src-libfdt)) libfdt-wrapper.c \
+ $(libfdt) libfdt-wrapper.c \
ns16550.c serial.c simple_alloc.c div64.S util.S \
gunzip_util.c elf_util.c $(zlib) devtree.c oflib.c ofconsole.c \
4xx.c ebony.c mv64x60.c mpsc.c mv64x60_i2c.c cuboot.c bamboo.c \
@@ -96,6 +101,12 @@ $(addprefix $(obj)/,$(zlibheader)): $(obj)/%: $(srctree)/lib/zlib_inflate/%
$(addprefix $(obj)/,$(zliblinuxheader)): $(obj)/%: $(srctree)/include/linux/%
$(call cmd,copy_zliblinuxheader)
+quiet_cmd_copy_libfdt = COPY $@
+ cmd_copy_libfdt = cp $< $@
+
+$(addprefix $(obj)/,$(libfdt) $(libfdtheader)): $(obj)/%: $(srctree)/scripts/dtc/libfdt/%
+ $(call cmd,copy_libfdt)
+
$(obj)/empty.c:
@touch $@
@@ -103,6 +114,7 @@ $(obj)/zImage.lds $(obj)/zImage.coff.lds $(obj)/zImage.ps3.lds: $(obj)/%: $(srct
@cp $< $@
clean-files := $(zlib) $(zlibheader) $(zliblinuxheader) \
+ $(libfdt) $(libfdtheader) \
empty.c zImage.coff.lds zImage.ps3.lds zImage.lds
quiet_cmd_bootcc = BOOTCC $@
@@ -114,6 +126,8 @@ quiet_cmd_bootas = BOOTAS $@
quiet_cmd_bootar = BOOTAR $@
cmd_bootar = $(CROSS32AR) -cr $@.$$$$ $(filter-out FORCE,$^); mv $@.$$$$ $@
+$(obj-libfdt): $(obj)/%.o: $(srctree)/scripts/dtc/libfdt/%.c FORCE
+ $(call if_changed_dep,bootcc)
$(patsubst %.c,%.o, $(filter %.c, $(src-boot))): %.o: %.c FORCE
$(Q)mkdir -p $(dir $@)
$(call if_changed_dep,bootcc)
@@ -124,7 +138,7 @@ $(patsubst %.S,%.o, $(filter %.S, $(src-boot))): %.o: %.S FORCE
$(obj)/wrapper.a: $(obj-wlib) FORCE
$(call if_changed,bootar)
-hostprogs-y := addnote addRamDisk hack-coff mktree dtc
+hostprogs-y := addnote addRamDisk hack-coff mktree
targets += $(patsubst $(obj)/%,%,$(obj-boot) wrapper.a)
extra-y := $(obj)/wrapper.a $(obj-plat) $(obj)/empty.o \
@@ -133,47 +147,10 @@ extra-y := $(obj)/wrapper.a $(obj-plat) $(obj)/empty.o \
dtstree := $(srctree)/$(src)/dts
wrapper :=$(srctree)/$(src)/wrapper
-wrapperbits := $(extra-y) $(addprefix $(obj)/,addnote hack-coff mktree dtc) \
+wrapperbits := $(extra-y) $(addprefix $(obj)/,addnote hack-coff mktree) \
$(wrapper) FORCE
#############
-# Bits for building dtc
-# DTC_GENPARSER := 1 # Uncomment to rebuild flex/bison output
-
-dtc-objs := dtc.o flattree.o fstree.o data.o livetree.o treesource.o srcpos.o checks.o
-dtc-objs += dtc-lexer.lex.o dtc-parser.tab.o
-dtc-objs := $(addprefix dtc-src/, $(dtc-objs))
-
-# prerequisites on generated files needs to be explicit
-$(obj)/dtc-src/dtc-parser.tab.o: $(obj)/dtc-src/dtc-parser.tab.c $(obj)/dtc-src/dtc-parser.tab.h
-$(obj)/dtc-src/dtc-lexer.lex.o: $(obj)/dtc-src/dtc-lexer.lex.c $(obj)/dtc-src/dtc-parser.tab.h
-
-HOSTCFLAGS += -I$(src)/dtc-src/ -I$(src)/libfdt/
-
-targets += dtc-src/dtc-parser.tab.c
-targets += dtc-src/dtc-lexer.lex.c
-
-clean-files += dtc-src/dtc-parser.tab.h
-
-ifdef DTC_GENPARSER
-BISON = bison
-FLEX = flex
-
-quiet_cmd_bison = BISON $@
- cmd_bison = $(BISON) -o$@ -d $<; cp $@ $@_shipped
-quiet_cmd_flex = FLEX $@
- cmd_flex = $(FLEX) -o$@ $<; cp $@ $@_shipped
-
-$(obj)/dtc-src/dtc-parser.tab.c: $(src)/dtc-src/dtc-parser.y FORCE
- $(call if_changed,bison)
-
-$(obj)/dtc-src/dtc-parser.tab.h: $(obj)/dtc-src/dtc-parser.tab.c
-
-$(obj)/dtc-src/dtc-lexer.lex.c: $(src)/dtc-src/dtc-lexer.l FORCE
- $(call if_changed,flex)
-endif
-
-#############
# Bits for building various flavours of zImage
ifneq ($(CROSS32_COMPILE),)
@@ -347,8 +324,10 @@ $(obj)/treeImage.%: vmlinux $(obj)/%.dtb $(wrapperbits)
$(call if_changed,wrap,treeboot-$*,,$(obj)/$*.dtb)
# Rule to build device tree blobs
-$(obj)/%.dtb: $(dtstree)/%.dts $(obj)/dtc
- $(obj)/dtc -O dtb -o $(obj)/$*.dtb -b 0 $(DTS_FLAGS) $(dtstree)/$*.dts
+DTC = $(objtree)/scripts/dtc/dtc
+
+$(obj)/%.dtb: $(dtstree)/%.dts
+ $(DTC) -O dtb -o $(obj)/$*.dtb -b 0 $(DTS_FLAGS) $(dtstree)/$*.dts
# If there isn't a platform selected then just strip the vmlinux.
ifeq (,$(image-y))
diff --git a/arch/powerpc/boot/simpleboot.c b/arch/powerpc/boot/simpleboot.c
index c58a0da..21cd480 100644
--- a/arch/powerpc/boot/simpleboot.c
+++ b/arch/powerpc/boot/simpleboot.c
@@ -19,7 +19,7 @@
#include "types.h"
#include "io.h"
#include "stdio.h"
-#include "libfdt/libfdt.h"
+#include <libfdt.h>
BSS_STACK(4*1024);
diff --git a/scripts/Makefile b/scripts/Makefile
index aafdf06..9dd5b25 100644
--- a/scripts/Makefile
+++ b/scripts/Makefile
@@ -21,6 +21,7 @@ hostprogs-y += unifdef
subdir-$(CONFIG_MODVERSIONS) += genksyms
subdir-y += mod
subdir-$(CONFIG_SECURITY_SELINUX) += selinux
+subdir-$(CONFIG_DTC) += dtc
# Let clean descend into subdirs
subdir- += basic kconfig package selinux
diff --git a/scripts/dtc/Makefile b/scripts/dtc/Makefile
new file mode 100644
index 0000000..01cdb36
--- /dev/null
+++ b/scripts/dtc/Makefile
@@ -0,0 +1,54 @@
+# scripts/dtc makefile
+
+hostprogs-y := dtc
+always := $(hostprogs-y)
+
+dtc-objs := dtc.o flattree.o fstree.o data.o livetree.o treesource.o \
+ srcpos.o checks.o
+dtc-objs += dtc-lexer.lex.o dtc-parser.tab.o
+
+# Source files need to get at the userspace version of libfdt_env.h to compile
+
+HOSTCFLAGS_DTC := -I$(src) -I$(src)/libfdt
+
+HOSTCFLAGS_checks.o := $(HOSTCFLAGS_DTC)
+HOSTCFLAGS_data.o := $(HOSTCFLAGS_DTC)
+HOSTCFLAGS_dtc.o := $(HOSTCFLAGS_DTC)
+HOSTCFLAGS_flattree.o := $(HOSTCFLAGS_DTC)
+HOSTCFLAGS_fstree.o := $(HOSTCFLAGS_DTC)
+HOSTCFLAGS_livetree.o := $(HOSTCFLAGS_DTC)
+HOSTCFLAGS_srcpos.o := $(HOSTCFLAGS_DTC)
+HOSTCFLAGS_treesource.o := $(HOSTCFLAGS_DTC)
+
+HOSTCFLAGS_dtc-lexer.lex.o := $(HOSTCFLAGS_DTC)
+HOSTCFLAGS_dtc-parser.tab.o := $(HOSTCFLAGS_DTC)
+
+# dependencies on generated files need to be listed explicitly
+$(obj)/dtc-parser.tab.o: $(obj)/dtc-parser.tab.c $(obj)/dtc-parser.tab.h
+$(obj)/dtc-lexer.lex.o: $(obj)/dtc-lexer.lex.c $(obj)/dtc-parser.tab.h
+
+targets += dtc-parser.tab.c dtc-lexer.lex.c
+
+clean-files += dtc-parser.tab.h
+
+# GENERATE_PARSER := 1 # Uncomment to rebuild flex/bison output
+
+ifdef GENERATE_PARSER
+
+BISON = bison
+FLEX = flex
+
+quiet_cmd_bison = BISON $@
+ cmd_bison = $(BISON) -o$@ -d $<; cp $@ $@_shipped
+quiet_cmd_flex = FLEX $@
+ cmd_flex = $(FLEX) -o$@ $<; cp $@ $@_shipped
+
+$(obj)/dtc-parser.tab.c: $(src)/dtc-parser.y FORCE
+ $(call if_changed,bison)
+
+$(obj)/dtc-parser.tab.h: $(obj)/dtc-parser.tab.c
+
+$(obj)/dtc-lexer.lex.c: $(src)/dtc-lexer.l FORCE
+ $(call if_changed,flex)
+
+endif
diff --git a/arch/powerpc/boot/dtc-src/Makefile.dtc b/scripts/dtc/Makefile.dtc
similarity index 100%
rename from arch/powerpc/boot/dtc-src/Makefile.dtc
rename to scripts/dtc/Makefile.dtc
diff --git a/arch/powerpc/boot/dtc-src/checks.c b/scripts/dtc/checks.c
similarity index 100%
rename from arch/powerpc/boot/dtc-src/checks.c
rename to scripts/dtc/checks.c
diff --git a/arch/powerpc/boot/dtc-src/data.c b/scripts/dtc/data.c
similarity index 100%
rename from arch/powerpc/boot/dtc-src/data.c
rename to scripts/dtc/data.c
diff --git a/arch/powerpc/boot/dtc-src/dtc-lexer.l b/scripts/dtc/dtc-lexer.l
similarity index 100%
rename from arch/powerpc/boot/dtc-src/dtc-lexer.l
rename to scripts/dtc/dtc-lexer.l
diff --git a/arch/powerpc/boot/dtc-src/dtc-lexer.lex.c_shipped b/scripts/dtc/dtc-lexer.lex.c_shipped
similarity index 100%
rename from arch/powerpc/boot/dtc-src/dtc-lexer.lex.c_shipped
rename to scripts/dtc/dtc-lexer.lex.c_shipped
diff --git a/arch/powerpc/boot/dtc-src/dtc-parser.tab.c_shipped b/scripts/dtc/dtc-parser.tab.c_shipped
similarity index 100%
rename from arch/powerpc/boot/dtc-src/dtc-parser.tab.c_shipped
rename to scripts/dtc/dtc-parser.tab.c_shipped
diff --git a/arch/powerpc/boot/dtc-src/dtc-parser.tab.h_shipped b/scripts/dtc/dtc-parser.tab.h_shipped
similarity index 100%
rename from arch/powerpc/boot/dtc-src/dtc-parser.tab.h_shipped
rename to scripts/dtc/dtc-parser.tab.h_shipped
diff --git a/arch/powerpc/boot/dtc-src/dtc-parser.y b/scripts/dtc/dtc-parser.y
similarity index 100%
rename from arch/powerpc/boot/dtc-src/dtc-parser.y
rename to scripts/dtc/dtc-parser.y
diff --git a/arch/powerpc/boot/dtc-src/dtc.c b/scripts/dtc/dtc.c
similarity index 100%
rename from arch/powerpc/boot/dtc-src/dtc.c
rename to scripts/dtc/dtc.c
diff --git a/arch/powerpc/boot/dtc-src/dtc.h b/scripts/dtc/dtc.h
similarity index 100%
rename from arch/powerpc/boot/dtc-src/dtc.h
rename to scripts/dtc/dtc.h
diff --git a/arch/powerpc/boot/dtc-src/flattree.c b/scripts/dtc/flattree.c
similarity index 100%
rename from arch/powerpc/boot/dtc-src/flattree.c
rename to scripts/dtc/flattree.c
diff --git a/arch/powerpc/boot/dtc-src/fstree.c b/scripts/dtc/fstree.c
similarity index 100%
rename from arch/powerpc/boot/dtc-src/fstree.c
rename to scripts/dtc/fstree.c
diff --git a/arch/powerpc/boot/libfdt/Makefile.libfdt b/scripts/dtc/libfdt/Makefile.libfdt
similarity index 100%
rename from arch/powerpc/boot/libfdt/Makefile.libfdt
rename to scripts/dtc/libfdt/Makefile.libfdt
diff --git a/arch/powerpc/boot/libfdt/fdt.c b/scripts/dtc/libfdt/fdt.c
similarity index 100%
rename from arch/powerpc/boot/libfdt/fdt.c
rename to scripts/dtc/libfdt/fdt.c
diff --git a/arch/powerpc/boot/libfdt/fdt.h b/scripts/dtc/libfdt/fdt.h
similarity index 100%
rename from arch/powerpc/boot/libfdt/fdt.h
rename to scripts/dtc/libfdt/fdt.h
diff --git a/arch/powerpc/boot/libfdt/fdt_ro.c b/scripts/dtc/libfdt/fdt_ro.c
similarity index 100%
rename from arch/powerpc/boot/libfdt/fdt_ro.c
rename to scripts/dtc/libfdt/fdt_ro.c
diff --git a/arch/powerpc/boot/libfdt/fdt_rw.c b/scripts/dtc/libfdt/fdt_rw.c
similarity index 100%
rename from arch/powerpc/boot/libfdt/fdt_rw.c
rename to scripts/dtc/libfdt/fdt_rw.c
diff --git a/arch/powerpc/boot/libfdt/fdt_strerror.c b/scripts/dtc/libfdt/fdt_strerror.c
similarity index 100%
rename from arch/powerpc/boot/libfdt/fdt_strerror.c
rename to scripts/dtc/libfdt/fdt_strerror.c
diff --git a/arch/powerpc/boot/libfdt/fdt_sw.c b/scripts/dtc/libfdt/fdt_sw.c
similarity index 100%
rename from arch/powerpc/boot/libfdt/fdt_sw.c
rename to scripts/dtc/libfdt/fdt_sw.c
diff --git a/arch/powerpc/boot/libfdt/fdt_wip.c b/scripts/dtc/libfdt/fdt_wip.c
similarity index 100%
rename from arch/powerpc/boot/libfdt/fdt_wip.c
rename to scripts/dtc/libfdt/fdt_wip.c
diff --git a/arch/powerpc/boot/libfdt/libfdt.h b/scripts/dtc/libfdt/libfdt.h
similarity index 100%
rename from arch/powerpc/boot/libfdt/libfdt.h
rename to scripts/dtc/libfdt/libfdt.h
diff --git a/arch/powerpc/boot/dtc-src/libfdt_env.h b/scripts/dtc/libfdt/libfdt_env.h
similarity index 100%
rename from arch/powerpc/boot/dtc-src/libfdt_env.h
rename to scripts/dtc/libfdt/libfdt_env.h
diff --git a/arch/powerpc/boot/libfdt/libfdt_internal.h b/scripts/dtc/libfdt/libfdt_internal.h
similarity index 100%
rename from arch/powerpc/boot/libfdt/libfdt_internal.h
rename to scripts/dtc/libfdt/libfdt_internal.h
diff --git a/arch/powerpc/boot/dtc-src/livetree.c b/scripts/dtc/livetree.c
similarity index 100%
rename from arch/powerpc/boot/dtc-src/livetree.c
rename to scripts/dtc/livetree.c
diff --git a/arch/powerpc/boot/dtc-src/srcpos.c b/scripts/dtc/srcpos.c
similarity index 100%
rename from arch/powerpc/boot/dtc-src/srcpos.c
rename to scripts/dtc/srcpos.c
diff --git a/arch/powerpc/boot/dtc-src/srcpos.h b/scripts/dtc/srcpos.h
similarity index 100%
rename from arch/powerpc/boot/dtc-src/srcpos.h
rename to scripts/dtc/srcpos.h
diff --git a/arch/powerpc/boot/dtc-src/treesource.c b/scripts/dtc/treesource.c
similarity index 100%
rename from arch/powerpc/boot/dtc-src/treesource.c
rename to scripts/dtc/treesource.c
diff --git a/arch/powerpc/boot/dtc-src/version_gen.h b/scripts/dtc/version_gen.h
similarity index 100%
rename from arch/powerpc/boot/dtc-src/version_gen.h
rename to scripts/dtc/version_gen.h
--
1.6.2.3
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply related
* Re: [RFC v2] virtio: add virtio-over-PCI driver
From: Grant Likely @ 2009-04-21 6:09 UTC (permalink / raw)
To: Ira Snyder
Cc: Arnd Bergmann, Jan-Bernd Themann, netdev, Rusty Russell,
linux-kernel, linuxppc-dev
In-Reply-To: <20090226214919.GA19959@ovro.caltech.edu>
On Thu, Feb 26, 2009 at 3:49 PM, Ira Snyder <iws@ovro.caltech.edu> wrote:
> On Thu, Feb 26, 2009 at 09:37:14PM +0100, Arnd Bergmann wrote:
>> If the registers for setting up this window don't logically fit
>> into the same device as the one you already use, the cleanest
>> solution would be to have another device just for this and then
>> make a function call into that driver to set up the window.
>
> The registers are part of the board control registers. They don't fit at
> all in the message unit. Doing this in the bootloader seems like a
> logical place, but that would require any testers to flash a new U-Boot
> image into their mpc8349emds boards.
Alternately, the board platform code (arch/powerpc/platforms/83xx) is
an ideal place for 'fixups'. ie. to setup things that the firmware
really should be do, but doesn't.
>> > Now, I wouldn't need to access these registers at all if the bootloade=
r
>> > could handle it. I just don't know if it is possible to have Linux not
>> > use some memory that the bootloader allocated, other than with the
>> > mem=3DXXX trick, which I'm sure wouldn't be acceptable. I've just used
>> > regular RAM so this is portable to my custom board (mpc8349emds based)
>> > and a regular mpc8349emds. I didn't want to change anything board
>> > specific.
>> >
>> > I would love to have the bootloader allocate (or reserve somewhere in
>> > the memory map) 16K of RAM, and not be required to allocate it with
>> > dma_alloc_coherent(). It would save me plenty of headaches.
>>
>> I believe you can do that through the "memory" devices in the
>> device tree, by leaving out a small part of the description of
>> main memory, at putting it into the "reg" property of your own
>> device.
>>
>
> I'll explore this option. I didn't even know you could do this. =A0Is a
> driver that requires the trick acceptable for mainline inclusion? Just
> like setting up the 16K PCI window, this is very platform specific.
Yup. You wouldn't even need to write any code to do this. Just
reduce the memory node's RAM size listed in the .dts file by 16k and
add a 16K region to the reg property for the messaging region.
Speaking of which, the device tree changes should be adding 2 nodes; 1
node to describe the messaging unit, and 1 node to describe the virtio
instance. The messaging unit is a general purpose piece of hardware,
so it is not appropriate to write a usage-specific device driver that
binds against it. I'm kind of working on this right now, so I'll show
you what I mean in patch form when I actually get things running.
g.
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply
* Re: [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers
From: Takashi Iwai @ 2009-04-21 6:30 UTC (permalink / raw)
To: Jean Delvare; +Cc: linuxppc-dev, alsa-devel, Andreas Schwab, Johannes Berg
In-Reply-To: <20090420225425.2a150a4f@hyperion.delvare>
At Mon, 20 Apr 2009 22:54:25 +0200,
Jean Delvare wrote:
>
> The legacy i2c binding model is going away soon, so convert the AOA
> codec drivers to the new model or they'll break.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Tested-by: Johannes Berg <johannes@sipsolutions.net>
> Tested-by: Andreas Schwab <schwab@linux-m68k.org>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Takashi Iwai <tiwai@suse.de>
> ---
> Takashi, please push this patch to Linus quickly, as this is blocking
> the removal of the legacy i2c binding model, which is scheduled for
> 2.6.30.
Applied now. Thanks.
Takashi
^ permalink raw reply
* Re: [PATCH] keywest: Convert to new-style i2c driver
From: Takashi Iwai @ 2009-04-21 6:31 UTC (permalink / raw)
To: Jean Delvare; +Cc: alsa-devel, linuxppc-dev
In-Reply-To: <20090420225659.7b92a184@hyperion.delvare>
At Mon, 20 Apr 2009 22:56:59 +0200,
Jean Delvare wrote:
>
> The legacy i2c binding model is going away soon, so convert the ppc
> keywest sound driver to the new model or it will break.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Takashi Iwai <tiwai@suse.de>
> ---
> Takashi, please push this patch to Linus quickly, as this is blocking
> the removal of the legacy i2c binding model, which is scheduled for
> 2.6.30.
>
> I did not get any test report for this one, but it's relatively simple
> so I am confident I got it right.
Applied this one, too. Thanks.
Takashi
^ permalink raw reply
* Re: [PATCH] keywest: Convert to new-style i2c driver
From: Takashi Iwai @ 2009-04-21 6:33 UTC (permalink / raw)
To: Paul Mackerras; +Cc: Jean Delvare, linuxppc-dev, alsa-devel
In-Reply-To: <18924.63578.495727.152443@cargo.ozlabs.ibm.com>
At Tue, 21 Apr 2009 08:34:02 +1000,
Paul Mackerras wrote:
>
> Jean Delvare writes:
>
> > Takashi, please push this patch to Linus quickly, as this is blocking
> > the removal of the legacy i2c binding model, which is scheduled for
> > 2.6.30.
>
> I really don't think you can remove it from Linus' tree at this stage
> in the 2.6.30 cycle. If it was going to be removed it should have
> been removed in the merge window. Removing it now has too much risk
> of introducing regressions in my opinion.
>
> I presume you have a development tree where you queue up commits for
> the i2c subsystem for the next merge window. I suggest you do the
> removal there now (or whenever you like) and push it to Linus in the
> next merge window.
At least, the conversion patch Jean posted can be in 2.6.30, I think.
As the old API is marked deprecated, it should be fixed sooner or
later.
Whether to remove the whole old i2c-binding in 2.6.30 is a different
question, although I myself feel it's feasible.
thanks,
Takashi
^ permalink raw reply
* Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context
From: David Miller @ 2009-04-21 9:07 UTC (permalink / raw)
To: avorontsov; +Cc: netdev, leoli, afleming, Joakim.Tjernlund, linuxppc-dev
In-Reply-To: <20090417220348.GA5429@oksana.dev.rtsoft.ru>
From: Anton Vorontsov <avorontsov@ru.mvista.com>
Date: Sat, 18 Apr 2009 02:03:48 +0400
> This will make the system alot more responsive while ping flooding the
> ucc_geth ethernet interface.
>
> Also set NAPI weight to 64 as this is a common value.
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Applied to net-next-2.6, thank you.
^ permalink raw reply
* Re: [PATCH] keywest: Convert to new-style i2c driver
From: Jean Delvare @ 2009-04-21 9:23 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel, linuxppc-dev
In-Reply-To: <s5h1vrmikm3.wl%tiwai@suse.de>
On Tue, 21 Apr 2009 08:31:00 +0200, Takashi Iwai wrote:
> At Mon, 20 Apr 2009 22:56:59 +0200,
> Jean Delvare wrote:
> >
> > The legacy i2c binding model is going away soon, so convert the ppc
> > keywest sound driver to the new model or it will break.
> >
> > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > Cc: Takashi Iwai <tiwai@suse.de>
> > ---
> > Takashi, please push this patch to Linus quickly, as this is blocking
> > the removal of the legacy i2c binding model, which is scheduled for
> > 2.6.30.
> >
> > I did not get any test report for this one, but it's relatively simple
> > so I am confident I got it right.
>
> Applied this one, too. Thanks.
Thanks Takashi.
BTW, I forgot to mention again that the new i2c binding model is
functional since kernel 2.6.25, so for the external alsa driver tree
you will want to guard these changes with appropriate ifdef magic.
--
Jean Delvare
^ permalink raw reply
* Re: [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers
From: Jean Delvare @ 2009-04-21 9:29 UTC (permalink / raw)
To: Johannes Berg; +Cc: Takashi Iwai, linuxppc-dev, alsa-devel, Andreas Schwab
In-Reply-To: <1240261492.4632.21.camel@johannes.local>
Hi Johannes,
On Mon, 20 Apr 2009 23:04:52 +0200, Johannes Berg wrote:
> On Mon, 2009-04-20 at 22:54 +0200, Jean Delvare wrote:
> > The legacy i2c binding model is going away soon, so convert the AOA
> > codec drivers to the new model or they'll break.
> >
> > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > Tested-by: Johannes Berg <johannes@sipsolutions.net>
> > Tested-by: Andreas Schwab <schwab@linux-m68k.org>
> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > Cc: Takashi Iwai <tiwai@suse.de>
> > ---
> > Takashi, please push this patch to Linus quickly, as this is blocking
> > the removal of the legacy i2c binding model, which is scheduled for
> > 2.6.30.
>
> Have you taken care of snd-powermac similarly?
Yes I did, see my patch "keywest: Convert to new-style i2c driver" to
the alsa-devel and linuxppc-dev mailing lists:
http://ozlabs.org/pipermail/linuxppc-dev/2009-April/070884.html
Would you be able to test this patch? This would be very welcome. I can
resend it to you if it helps.
Thanks,
--
Jean Delvare
^ permalink raw reply
* Re: [PATCH] keywest: Convert to new-style i2c driver
From: Takashi Iwai @ 2009-04-21 9:30 UTC (permalink / raw)
To: Jean Delvare; +Cc: alsa-devel, linuxppc-dev
In-Reply-To: <20090421112300.467e9f9b@hyperion.delvare>
At Tue, 21 Apr 2009 11:23:00 +0200,
Jean Delvare wrote:
>
> On Tue, 21 Apr 2009 08:31:00 +0200, Takashi Iwai wrote:
> > At Mon, 20 Apr 2009 22:56:59 +0200,
> > Jean Delvare wrote:
> > >
> > > The legacy i2c binding model is going away soon, so convert the ppc
> > > keywest sound driver to the new model or it will break.
> > >
> > > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > > Cc: Takashi Iwai <tiwai@suse.de>
> > > ---
> > > Takashi, please push this patch to Linus quickly, as this is blocking
> > > the removal of the legacy i2c binding model, which is scheduled for
> > > 2.6.30.
> > >
> > > I did not get any test report for this one, but it's relatively simple
> > > so I am confident I got it right.
> >
> > Applied this one, too. Thanks.
>
> Thanks Takashi.
>
> BTW, I forgot to mention again that the new i2c binding model is
> functional since kernel 2.6.25, so for the external alsa driver tree
> you will want to guard these changes with appropriate ifdef magic.
I thought some patch (applied on 2.6.30) was needed to get them
working properly? Anyway, I already added ifdef in alsa-driver
external tree to make 2.6.29 and earlier building with the old i2c
code.
thanks,
Takashi
^ permalink raw reply
* Re: [PATCH] keywest: Convert to new-style i2c driver
From: Paul Mackerras @ 2009-04-21 9:33 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Jean Delvare, linuxppc-dev, alsa-devel
In-Reply-To: <s5hzleah5x4.wl%tiwai@suse.de>
Takashi Iwai writes:
> At least, the conversion patch Jean posted can be in 2.6.30, I think.
Really? What regression, security hole or serious bug are you going
to tell Linus that it fixes? :)
Paul.
^ permalink raw reply
* Re: [PATCH] keywest: Convert to new-style i2c driver
From: Takashi Iwai @ 2009-04-21 9:36 UTC (permalink / raw)
To: Paul Mackerras; +Cc: Jean Delvare, linuxppc-dev, alsa-devel
In-Reply-To: <18925.37580.812802.785170@cargo.ozlabs.ibm.com>
At Tue, 21 Apr 2009 19:33:00 +1000,
Paul Mackerras wrote:
>
> Takashi Iwai writes:
>
> > At least, the conversion patch Jean posted can be in 2.6.30, I think.
>
> Really? What regression, security hole or serious bug are you going
> to tell Linus that it fixes? :)
Build warning fixes :)
Takashi
^ permalink raw reply
* Re: [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers
From: Johannes Berg @ 2009-04-21 9:41 UTC (permalink / raw)
To: Jean Delvare; +Cc: Takashi Iwai, linuxppc-dev, alsa-devel, Andreas Schwab
In-Reply-To: <20090421112921.373fae89@hyperion.delvare>
[-- Attachment #1: Type: text/plain, Size: 493 bytes --]
Hi,
> > Have you taken care of snd-powermac similarly?
>
> Yes I did, see my patch "keywest: Convert to new-style i2c driver" to
> the alsa-devel and linuxppc-dev mailing lists:
> http://ozlabs.org/pipermail/linuxppc-dev/2009-April/070884.html
>
> Would you be able to test this patch? This would be very welcome. I can
> resend it to you if it helps.
Cool. No, was just wondering, I can't test it, none of my machines can
use that (which is why I wrote aoa, heh)
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply
* Re: [PATCH] keywest: Convert to new-style i2c driver
From: Jean Delvare @ 2009-04-21 9:44 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel, linuxppc-dev
In-Reply-To: <20090421112300.467e9f9b@hyperion.delvare>
On Tue, 21 Apr 2009 11:23:00 +0200, Jean Delvare wrote:
> On Tue, 21 Apr 2009 08:31:00 +0200, Takashi Iwai wrote:
> > At Mon, 20 Apr 2009 22:56:59 +0200,
> > Jean Delvare wrote:
> > >
> > > The legacy i2c binding model is going away soon, so convert the ppc
> > > keywest sound driver to the new model or it will break.
> > >
> > > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > > Cc: Takashi Iwai <tiwai@suse.de>
> > > ---
> > > Takashi, please push this patch to Linus quickly, as this is blocking
> > > the removal of the legacy i2c binding model, which is scheduled for
> > > 2.6.30.
> > >
> > > I did not get any test report for this one, but it's relatively simple
> > > so I am confident I got it right.
> >
> > Applied this one, too. Thanks.
>
> Thanks Takashi.
>
> BTW, I forgot to mention again that the new i2c binding model is
> functional since kernel 2.6.25, so for the external alsa driver tree
> you will want to guard these changes with appropriate ifdef magic.
Err, make that 2.6.30, sorry. While the infrastructure was there since
2.6.25, the way I converted the sound drivers doesn't fit in what
earlier kernels considered acceptable (the checks on which driver
methods were implemented was a little too strict IMHO). So the
converted drivers can only be used with kernels >= 2.6.30.
--
Jean Delvare
^ permalink raw reply
* [PATCH] [net, 83xx] ucc_geth.c: Fix upsmr setting in RMII mode
From: Heiko Schocher @ 2009-04-21 8:36 UTC (permalink / raw)
To: Li Yang; +Cc: Shlomi Gridish, netdev, linuxppc-dev
If using the UCC on a MPC8360 in RMII mode, don;t set
UCC_GETH_UPSMR_RPM bit in the upsmr register.
Signed-off-by: Heiko Schocher <hs@denx.de>
---
drivers/net/ucc_geth.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c
index d3f39e8..44f8392 100644
--- a/drivers/net/ucc_geth.c
+++ b/drivers/net/ucc_geth.c
@@ -1394,7 +1394,8 @@ static int adjust_enet_interface(struct ucc_geth_private *ugeth)
(ugeth->phy_interface == PHY_INTERFACE_MODE_RGMII_RXID) ||
(ugeth->phy_interface == PHY_INTERFACE_MODE_RGMII_TXID) ||
(ugeth->phy_interface == PHY_INTERFACE_MODE_RTBI)) {
- upsmr |= UCC_GETH_UPSMR_RPM;
+ if (ugeth->phy_interface != PHY_INTERFACE_MODE_RMII)
+ upsmr |= UCC_GETH_UPSMR_RPM;
switch (ugeth->max_speed) {
case SPEED_10:
upsmr |= UCC_GETH_UPSMR_R10M;
--
1.6.0.6
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox