* Re: [PATCH v2] 83xx: add support for the kmeter1 board.
From: Heiko Schocher @ 2009-06-11 6:03 UTC (permalink / raw)
To: Kumar Gala; +Cc: Scott Wood, linuxppc-dev
In-Reply-To: <C934E2FC-7597-4D10-AA2F-F28884D1DD1B@kernel.crashing.org>
Hello Kumar,
Kumar Gala wrote:
> On Apr 28, 2009, at 11:48 PM, Heiko Schocher wrote:
>
>> The following series implements basic board support for
>> the kmeter1 board from keymile, based on a MPC8360.
[...]
>> + };
>> + };
>> +};
>
> Sorry for taking so long to review this again.
No problem, we are all just working
Reworked patch with your comments will follow, thanks.
bye
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply
* [PATCH] powerpc/cell: Use driver_data acessors, not platform_data
From: Michael Ellerman @ 2009-06-11 5:06 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: linuxppc-dev
The Axon MSI driver incorrectly uses platform_data, rather than
the proper accessors for driver_data.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
arch/powerpc/platforms/cell/axon_msi.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/cell/axon_msi.c b/arch/powerpc/platforms/cell/axon_msi.c
index 0ce45c2..c71498d 100644
--- a/arch/powerpc/platforms/cell/axon_msi.c
+++ b/arch/powerpc/platforms/cell/axon_msi.c
@@ -329,7 +329,7 @@ static struct irq_host_ops msic_host_ops = {
static int axon_msi_shutdown(struct of_device *device)
{
- struct axon_msic *msic = device->dev.platform_data;
+ struct axon_msic *msic = dev_get_drvdata(&device->dev);
u32 tmp;
pr_debug("axon_msi: disabling %s\n",
@@ -416,7 +416,7 @@ static int axon_msi_probe(struct of_device *device,
msic->read_offset = dcr_read(msic->dcr_host, MSIC_WRITE_OFFSET_REG)
& MSIC_FIFO_SIZE_MASK;
- device->dev.platform_data = msic;
+ dev_set_drvdata(&device->dev, msic);
ppc_md.setup_msi_irqs = axon_msi_setup_msi_irqs;
ppc_md.teardown_msi_irqs = axon_msi_teardown_msi_irqs;
--
1.6.2.1
^ permalink raw reply related
* [PATCH] powerpc: Fix warning in setup_64.c when CONFIG_RELOCATABLE=y
From: Michael Ellerman @ 2009-06-11 5:05 UTC (permalink / raw)
To: linuxppc-dev
When CONFIG_RELOCATABLE is enabled, PHYSICAL_START is actually a
variable of type phys_addr_t. That means to print it we need to
cast to unsigned long long and use llx.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
arch/powerpc/kernel/setup_64.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
index f46548e..1f68160 100644
--- a/arch/powerpc/kernel/setup_64.c
+++ b/arch/powerpc/kernel/setup_64.c
@@ -424,8 +424,8 @@ void __init setup_system(void)
printk("htab_hash_mask = 0x%lx\n", htab_hash_mask);
#endif /* CONFIG_PPC_STD_MMU_64 */
if (PHYSICAL_START > 0)
- printk("physical_start = 0x%lx\n",
- PHYSICAL_START);
+ printk("physical_start = 0x%llx\n",
+ (unsigned long long)PHYSICAL_START);
printk("-----------------------------------------------------\n");
DBG(" <- setup_system()\n");
--
1.6.2.1
^ permalink raw reply related
* Re: [PATCH 5/6] rio: warn_unused_result warnings fix
From: Kumar Gala @ 2009-06-11 4:34 UTC (permalink / raw)
To: Li Yang; +Cc: netdev, linux-kernel, davem, linuxppc-dev, akpm
In-Reply-To: <1242117363-14949-5-git-send-email-leoli@freescale.com>
On May 12, 2009, at 3:36 AM, Li Yang wrote:
> Adding failure path for the following two cases.
>
> warning: ignoring return value of 'device_add', declared with
> attribute warn_unused_result
> warning: ignoring return value of 'sysfs_create_bin_file', declared
> with attribute warn_unused_result
>
> Signed-off-by: Li Yang <leoli@freescale.com>
> ---
> drivers/rapidio/rio-scan.c | 44 +++++++++++++++++++++++++
> +----------------
> drivers/rapidio/rio-sysfs.c | 6 +++-
> 2 files changed, 31 insertions(+), 19 deletions(-)
applied w/fixup based on Andrew's comments.
- k
^ permalink raw reply
* Re: [PATCH] powerpc/fsl_lbc: Increase the number of possible lbc banks
From: Kumar Gala @ 2009-06-11 4:33 UTC (permalink / raw)
To: mware; +Cc: linuxppc-dev
In-Reply-To: <38410.1244689279@internode.on.net>
On Jun 10, 2009, at 10:01 PM, mware@internode.on.net wrote:
> Currently the fsl,*lbc devices support 8 banks (ie OR and BR
> registers).
> This is adequate for most pq2 and pq3 processors, but not the
> MPC8280 which
> has 12 banks.
>
> Signed-Off-By: Mark Ware <mware@elphinstone.net>
> ---
> arch/powerpc/include/asm/fsl_lbc.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
fsl_lbc is not applicable to the MPC8280. Its only used for MPC83xx,
MPC85xx, and MPC86xx.
- k
^ permalink raw reply
* Re: MPC85xx erratum "I2C1 - I2C controller is unable to generate clocks when SDA is low coming out of reset"
From: Kumar Gala @ 2009-06-11 4:32 UTC (permalink / raw)
To: Fredrik Arnerup; +Cc: linuxppc-dev
In-Reply-To: <738D541FBC1741A18DB4F3CB466DF78A@edgeware.tv>
On May 26, 2009, at 3:22 AM, Fredrik Arnerup wrote:
> We've had some trouble with I2C not working after a soft reboot,
> which we think is due to the the erratum "I2C1" which is present in
> at least the mpc8540 and the mpc8560. Since there is no good
> workaround,
> the only choice seems to be to avoid resetting the CPU while the I2C
> bus is
> busy.
>
> The problem seems to be that the i2c-mpc driver leaves I2C in a busy
> state
> when
> it receives a signal (e.g. upon shutdown).
> The code below is not meant as a patch, just me thinking aloud.
> Thoughts?
>
> /Fredrik Arnerup
> fredrik.arnerup@edgeware.tv
>
> Index: drivers/i2c/busses/i2c-mpc.c
> ===================================================================
> --- drivers/i2c/busses/i2c-mpc.c (revision 6933)
> +++ drivers/i2c/busses/i2c-mpc.c (working copy)
> @@ -262,12 +262,14 @@
> /* Allow bus up to 1s to become not busy */
> while (readb(i2c->base + MPC_I2C_SR) & CSR_MBB) {
> if (signal_pending(current)) {
> - pr_debug("I2C: Interrupted\n");
> - writeccr(i2c, 0);
> + printk(KERN_WARNING "I2C: Interrupted\n");
> + if (readb(i2c->base + MPC_I2C_SR) ==
> + (CSR_MCF | CSR_MBB | CSR_RXAK))
> + mpc_i2c_fixup(i2c);
> return -EINTR;
> }
> if (time_after(jiffies, orig_jiffies + HZ)) {
> - pr_debug("I2C: timeout\n");
> + printk(KERN_WARNING "I2C: mpc_xfer() timeout
> \n");
> if (readb(i2c->base + MPC_I2C_SR) ==
> (CSR_MCF | CSR_MBB | CSR_RXAK))
> mpc_i2c_fixup(i2c);
I don't think we should have the printk's. Its possible that we hit
the interrupted condition while using the i2c from user space.
- k
^ permalink raw reply
* Re: [PATCH 1/6] rapidio: add common mapping APIs for RapidIO memory access
From: Kumar Gala @ 2009-06-11 4:13 UTC (permalink / raw)
To: Li Yang; +Cc: Zhang Wei, netdev, linux-kernel, davem, linuxppc-dev, akpm
In-Reply-To: <1242117363-14949-1-git-send-email-leoli@freescale.com>
On May 12, 2009, at 3:35 AM, Li Yang wrote:
> Add the mapping functions used to support direct IO memory access of
> rapidIO.
>
> Signed-off-by: Zhang Wei <zw@zh-kernel.org>
> Signed-off-by: Li Yang <leoli@freescale.com>
Use inbnd/outbnd instead of inb/outb which make one think of byte
level io accessors.
As I look at this I don't think this is the correct API. I think we
should be using the DMA mapping API to hide these details. The
concept of mapping like this seems to be more a function of FSL's
Address translation/mapping unit (ATMU) than anything specific to the
RIO bus standard.
> ---
> drivers/rapidio/rio.c | 95 ++++++++++++++++++++++++++++++++++++++
> +++++++++
> include/linux/rio.h | 25 ++++++++++++
> include/linux/rio_drv.h | 24 +++++++++---
> 3 files changed, 138 insertions(+), 6 deletions(-)
- k
^ permalink raw reply
* [PATCH] sata_fsl: Add power mgmt support
From: Kumar Gala @ 2009-06-11 3:53 UTC (permalink / raw)
To: jeff; +Cc: linuxppc-dev, linux-kernel, linux-ide
From: Dave Liu <daveliu@freescale.com>
Signed-off-by: Dave Liu <daveliu@freescale.com>
Signed-off-by: Liu Yu <yu.liu@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
drivers/ata/sata_fsl.c | 35 +++++++++++++++++++++++++++++++++++
1 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index 36b8629..94eaa43 100644
--- a/drivers/ata/sata_fsl.c
+++ b/drivers/ata/sata_fsl.c
@@ -1378,6 +1378,37 @@ static int sata_fsl_remove(struct of_device *ofdev)
return 0;
}
+#ifdef CONFIG_PM
+static int sata_fsl_suspend(struct of_device *op, pm_message_t state)
+{
+ struct ata_host *host = dev_get_drvdata(&op->dev);
+ return ata_host_suspend(host, state);
+}
+
+static int sata_fsl_resume(struct of_device *op)
+{
+ struct ata_host *host = dev_get_drvdata(&op->dev);
+ struct sata_fsl_host_priv *host_priv = host->private_data;
+ int ret;
+ void __iomem *hcr_base = host_priv->hcr_base;
+ struct ata_port *ap = host->ports[0];
+ struct sata_fsl_port_priv *pp = ap->private_data;
+
+ ret = sata_fsl_init_controller(host);
+ if (ret) {
+ dev_printk(KERN_ERR, &op->dev,
+ "Error initialize hardware\n");
+ return ret;
+ }
+
+ /* Recovery the CHBA register in host controller cmd register set */
+ iowrite32(pp->cmdslot_paddr & 0xffffffff, hcr_base + CHBA);
+
+ ata_host_resume(host);
+ return 0;
+}
+#endif
+
static struct of_device_id fsl_sata_match[] = {
{
.compatible = "fsl,pq-sata",
@@ -1392,6 +1423,10 @@ static struct of_platform_driver fsl_sata_driver = {
.match_table = fsl_sata_match,
.probe = sata_fsl_probe,
.remove = sata_fsl_remove,
+#ifdef CONFIG_PM
+ .suspend = sata_fsl_suspend,
+ .resume = sata_fsl_resume,
+#endif
};
static int __init sata_fsl_init(void)
--
1.6.0.6
^ permalink raw reply related
* [PATCH][BUILD FAILURE 03/04] Next June 04:PPC64 randconfig [drivers/net/lance.o]
From: Subrata Modak @ 2009-06-11 3:50 UTC (permalink / raw)
To: netdev, Paul Mackerras, Benjamin Herrenschmidt, Linuxppc-dev
Cc: Sachin P Sant, Stephen Rothwell, Linux-Kernel, Linux-Next,
Subrata Modak, Balbir Singh
Hi Benjamin/Paul,
>On Thu, 2009-06-04 at 19:02 +0530, Subrata Modak wrote:
>CC drivers/net/lance.o
> drivers/net/lance.c: In function 'lance_probe1':
> drivers/net/lance.c:575: error: implicit declaration of function 'isa_virt_to_bus'
> drivers/net/lance.c: In function 'lance_rx':
> drivers/net/lance.c:1197: error: implicit declaration of function 'isa_bus_to_virt'
> make[2]: *** [drivers/net/lance.o] Error 1
> make[1]: *** [drivers/net] Error 2
> make: *** [drivers] Error 2
Reference: http://lkml.org/lkml/2009/6/4/240,
To fix the following build error:
drivers/net/lance.c: In function 'lance_probe1':
drivers/net/lance.c:575: error: implicit declaration of function 'isa_virt_to_bus'
drivers/net/lance.c: In function 'lance_rx':
drivers/net/lance.c:1197: error: implicit declaration of function 'isa_bus_to_virt'
make[2]: *** [drivers/net/lance.o] Error 1
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
I would like to propose the following patch. The prototypes for the functions:
'isa_virt_to_bus' & 'isa_virt_to_bus' are existing for some archs like the
mips, x86, parisc, arm & alpha, but, is missing for powerpc. Is it safe to
introduce the following soultion for powerpc ? It fixes the build problem
i reported earlier.
Signed-off-by: Subrata Modak <subrata@linux.vnet.ibm.com>
---
--- linux-2.6.30-rc8/arch/powerpc/include/asm/io.h.orig 2009-06-10 21:56:49.000000000 -0500
+++ linux-2.6.30-rc8/arch/powerpc/include/asm/io.h 2009-06-10 22:21:35.000000000 -0500
@@ -680,6 +680,9 @@ extern void __iounmap_at(void *ea, unsig
#define mmio_outsw(addr, src, count) writesw(addr, src, count)
#define mmio_outsl(addr, src, count) writesl(addr, src, count)
+#define isa_virt_to_bus virt_to_phys
+#define isa_bus_to_virt phys_to_virt
+
/**
* virt_to_phys - map virtual addresses to physical
* @address: address to remap
---
Regards--
Subrata
^ permalink raw reply
* Re: [PATCH] powerpc/boot: cuboot: Fix up ethernet3 MAC address on MPC85xx
From: Kumar Gala @ 2009-06-11 3:48 UTC (permalink / raw)
To: Nate Case; +Cc: linuxppc-dev
In-Reply-To: <1244499462-18719-1-git-send-email-ncase@xes-inc.com>
On Jun 8, 2009, at 5:17 PM, Nate Case wrote:
> MPC85xx platforms do support 4 ethernet ports, so make sure the boot
> wrapper fixes up all of them in the fdt.
>
> Signed-off-by: Nate Case <ncase@xes-inc.com>
> ---
> arch/powerpc/boot/cuboot-85xx.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
applied (updated commit message) to next
- k
^ permalink raw reply
* Re: [PATCH] powerpc/boot: cuboot: Fix up ethernet3 MAC address on MPC85xx
From: Kumar Gala @ 2009-06-11 3:44 UTC (permalink / raw)
To: Nathaniel Case; +Cc: linuxppc-dev
In-Reply-To: <155ffc0deec796912080304f76bb09e7@xes-inc.com>
On Jun 10, 2009, at 10:40 PM, Nathaniel Case wrote:
> On Wed, 10 Jun 2009 21:54:01 -0500, Kumar Gala <galak@kernel.crashing.org
> >
> wrote:
>>> #define TARGET_85xx
>>> +#define TARGET_HAS_ETH3
>>
>> This is problematic in that we'd be changing the memory layout of the
>> bd_t and not ALL 85xx's have HAS_ETH3 set.
>
> It shouldn't be problematic. The bi_enet3addr field is at the end
> of the
> structure on MPC85xx. The only fields after it in ppcboot.h are
> 4xx-specific
> fields. I believe the MAC addresses were placed at the end of the
> struct
> for
> this very reason.
ahh, good point... I'll add this detail to the commit message when I
commit this.
- k
^ permalink raw reply
* Re: [PATCH] serial: Fix bug of ucc_uart
From: Kumar Gala @ 2009-06-11 3:39 UTC (permalink / raw)
To: Dave Liu; +Cc: linuxppc-dev, timur, linux-serial
In-Reply-To: <1244471076-25905-1-git-send-email-daveliu@freescale.com>
On Jun 8, 2009, at 9:24 AM, Dave Liu wrote:
> Current ucc_uart driver doesn't work at UART mode,
> The TxBD[READY] is not cleared by H/W (RISC engine)
> when user send characters to Tx buffer of QE UART.
> so, these characters stay on the QE forever, never
> go to UART line.
>
> The patch is fixing th bug.
>
> Signed-off-by: Dave Liu <daveliu@freescale.com>
> ---
> drivers/serial/ucc_uart.c | 19 ++++++++++++++-----
> 1 files changed, 14 insertions(+), 5 deletions(-)
applied to next.
(Cleaned up the commit message a bit)
- k
^ permalink raw reply
* Re: [PATCH] powerpc/boot: cuboot: Fix up ethernet3 MAC address on MPC85xx
From: Nathaniel Case @ 2009-06-11 3:40 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
In-Reply-To: <094F1487-85D2-400A-A2B6-5ED54685907A@kernel.crashing.org>
On Wed, 10 Jun 2009 21:54:01 -0500, Kumar Gala <galak@kernel.crashing.org>
wrote:
>> #define TARGET_85xx
>> +#define TARGET_HAS_ETH3
>
> This is problematic in that we'd be changing the memory layout of the
> bd_t and not ALL 85xx's have HAS_ETH3 set.
It shouldn't be problematic. The bi_enet3addr field is at the end of the
structure on MPC85xx. The only fields after it in ppcboot.h are
4xx-specific
fields. I believe the MAC addresses were placed at the end of the struct
for
this very reason.
--
Nate Case <ncase@xes-inc.com>
^ permalink raw reply
* Re: [PATCH -next] powerpc/fsl-booke: Enable L1 cache on e500v1/e500v2/e500mc CPUs
From: Kumar Gala @ 2009-06-11 3:39 UTC (permalink / raw)
To: Nate Case; +Cc: linuxppc-dev
In-Reply-To: <1244666248-23322-1-git-send-email-ncase@xes-inc.com>
On Jun 10, 2009, at 3:37 PM, Nate Case wrote:
> Some boot loaders may not enable L1 instruction/data cache. Check if
> data and instruction caches are enabled, and enable them if needed.
>
> Signed-off-by: Nate Case <ncase@xes-inc.com>
> ---
> arch/powerpc/include/asm/reg_booke.h | 2 +
> arch/powerpc/kernel/cpu_setup_fsl_booke.S | 49 ++++++++++++++++++++
> +++++++--
> 2 files changed, 48 insertions(+), 3 deletions(-)
applied to next
- k
^ permalink raw reply
* [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o]
From: Subrata Modak @ 2009-06-11 3:37 UTC (permalink / raw)
To: Tony Breeds, netdev, michael, Li Yang, Stephen Rothwell,
Nathan Lynch
Cc: Sachin P Sant, Linux-Kernel, Linuxppc-dev, Linux-Next,
Subrata Modak, Balbir Singh
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2187 bytes --]
Hi Nathan,
>On Wed, 2009-06-10 at 21:28 -0500, Nathan Lynch wrote:
>Subrata Modak <subrata@linux.vnet.ibm.com> writes:
>
> > On Thu, 2009-06-11 at 11:05 +1000, Stephen Rothwell wrote:
> >> Hi Subrata,
> >>
> >> On Wed, 10 Jun 2009 23:13:23 +0530 Subrata Modak <subrata@linux.vnet.ibm.com> wrote:
> >> >
> >> > /* Find the TBI PHY. If it's not there, we don't support SGMII */
> >> > - ph = of_get_property(np, "tbi-handle", NULL);
> >> > + ph = (phandle *)of_get_property(np, "tbi-handle", NULL);
> >>
> >> You don't need this cast because of_get_property() returns "void *".
> >
> > Stephen,
> >
> > True. But without this gcc complains:
> >
> > CC [M] drivers/net/ucc_geth.o
> > drivers/net/ucc_geth.c: In function ‘ucc_geth_probe’:
> > drivers/net/ucc_geth.c:3824: warning: assignment discards qualifiers
> > from pointer target type
>
> ph should be declared const phandle *. Look at other uses of
> of_get_property.
>
Ok fine. Here is a revised patch again.
Subject: [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o]
Reference(s):
http://lkml.org/lkml/2009/6/4/241,
http://lkml.org/lkml/2009/6/10/338,
Fix the following build error:
drivers/net/ucc_geth.c: In function bucc_geth_probeb:
drivers/net/ucc_geth.c:3822: error: 'ph' undeclared (first use in this function)
drivers/net/ucc_geth.c:3822: error: (Each undeclared identifier is reported only once
drivers/net/ucc_geth.c:3822: error: for each function it appears in.)
drivers/net/ucc_geth.c:3832: error: 'mdio' undeclared (first use in this function)
make[2]: *** [drivers/net/ucc_geth.o] Error 1
Signed-off-by: Subrata Modak <subrata@linux.vnet.ibm.com>
---
--- linux-2.6.30-rc8/drivers/net/ucc_geth.c.orig 2009-06-10 11:58:39.000000000 -0500
+++ linux-2.6.30-rc8/drivers/net/ucc_geth.c 2009-06-10 22:28:13.000000000 -0500
@@ -3595,6 +3595,8 @@ static const struct net_device_ops ucc_g
static int ucc_geth_probe(struct of_device* ofdev, const struct of_device_id *match)
{
+ struct device_node *mdio;
+ const phandle *ph;
struct device *device = &ofdev->dev;
struct device_node *np = ofdev->node;
struct net_device *dev = NULL;
---
Regards--
Subrata
^ permalink raw reply
* Re: [PATCH] mpc83xx/usb.c: fix usb mux setup for mpc834x
From: Kumar Gala @ 2009-06-11 3:32 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: linuxppc-dev
In-Reply-To: <1244547812-3811-1-git-send-email-jacmet@sunsite.dk>
On Jun 9, 2009, at 6:43 AM, Peter Korsgaard wrote:
> usb0 and usb1 mux settings in the sicrl register were swapped (twice!)
> in mpc834x_usb_cfg(), leading to various strange issues with fsl-ehci
> and full speed devices.
>
> The USB port config on mpc834x is done using 2 muxes: Port 0 is always
> used for MPH port 0, and port 1 can either be used for MPH port 1 or
> DR
> (unless DR uses TMDI phy or OTG, then it uses both ports) - See 8349
> RM
> figure 1-4..
>
> mpc8349_usb_cfg() had this inverted for the DR, and it also had the
> bit
> positions of the usb0 / usb1 mux settings swapped. It would basically
> work if you specified port1 instead of port0 for the MPH controller
> (and
> happened to use ULPI phys), which is what all the 834x dts have done,
> even though that configuration is physically invalid.
>
> Instead fix mpc8349_usb_cfg() and adjust the dts files to match
> reality.
>
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
> ---
> arch/powerpc/boot/dts/asp834x-redboot.dts | 2 +-
> arch/powerpc/boot/dts/mpc8349emitx.dts | 2 +-
> arch/powerpc/boot/dts/mpc834x_mds.dts | 2 +-
> arch/powerpc/boot/dts/sbc8349.dts | 2 +-
> arch/powerpc/platforms/83xx/mpc83xx.h | 4 ++--
> arch/powerpc/platforms/83xx/usb.c | 10 +++++-----
> 6 files changed, 11 insertions(+), 11 deletions(-)
applied.. Please remind me to send this linux-stable for .30 and .29
- k
^ permalink raw reply
* Re: ipr boot failure caused by MSI (2.6.30-rc1+)
From: Wayne Boyer @ 2009-06-11 3:23 UTC (permalink / raw)
To: Brian King; +Cc: James Bottomley, ppc-dev, linux-scsi
In-Reply-To: <4A205B40.30306@linux.vnet.ibm.com>
Brian King wrote:
> James Bottomley wrote:
>> On Thu, 2009-05-21 at 14:51 -0500, James Bottomley wrote:
>> I saw the quirk fix for this go by:
>>
>> http://ozlabs.org/pipermail/linuxppc-dev/2009-May/072436.html
>>
>> Is there an easy way to trigger an interrupt on this device? Preferably
>> in ipr_probe_ioa() so we can at least print out if the interrupts are
>> misrouted and fall back from MSI to normal using the PCI infrastructure?
>
> I just talked with one of the adapter firmware developers and it sounds like
> this might be possible. I'll work with Wayne on coding something up to try.
>
> -Brian
>
I've put together some code to trigger the test MSI and either fall back to
LSI if it isn't detected, or continue on using MSI. In the routine that
does the setup and test I have this call to request_irq:
rc = request_irq(pdev->irq, ipr_test_intr, 0, IPR_NAME, ioa_cfg);
Note that the flags value is '0'. The question came up as to whether or
not this value should really be IRQF_SHARED. Given that this is for an MSI
interrupt and MSI interrupts are not shared by definition, IRQF_SHARED did
not seem correct.
What should the flags value be in this case?
--
Wayne Boyer
IBM - Beaverton, Oregon
LTC S/W Development - eServerIO
(503) 578-5236, T/L 775-5236
^ permalink raw reply
* Re: linux-next: powerpc tree build warning
From: Benjamin Herrenschmidt @ 2009-06-11 3:14 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linuxppc-dev, linux-next, Paul Mackerras, linux-kernel
In-Reply-To: <20090611113930.78a42893.sfr@canb.auug.org.au>
On Thu, 2009-06-11 at 11:39 +1000, Stephen Rothwell wrote:
> Hi Ben,
>
> Today's linux-next build (powerpc ppc64_defconfig) produced this warning:
>
> arch/powerpc/platforms/Kconfig.cputype:60:warning: defaults for choice values not supported
>
> We appear to have CONFIG_PPC_BOOK3S int two places which is confusing
> Kconfig.
Yes, I see that. One place depends on PPC32 and the other one PPC64, but
it still seems to be somewhat confused. In any case, it seems to still
do the right thing, so not a big hurry here, but I'll do a patch that
does it differently.
Cheers,
Ben.
^ permalink raw reply
* [PATCH] powerpc/fsl_lbc: Increase the number of possible lbc banks
From: mware @ 2009-06-11 3:01 UTC (permalink / raw)
To: linuxppc-dev
Currently the fsl,*lbc devices support 8 banks (ie OR and BR registers).
This is adequate for most pq2 and pq3 processors, but not the MPC8280 which
has 12 banks.
Signed-Off-By: Mark Ware <mware@elphinstone.net>
---
arch/powerpc/include/asm/fsl_lbc.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/include/asm/fsl_lbc.h b/arch/powerpc/include/asm/=
fsl_lbc.h
index 63a4f77..1b5a210 100644
--- a/arch/powerpc/include/asm/fsl_lbc.h
+++ b/arch/powerpc/include/asm/fsl_lbc.h
@@ -95,8 +95,8 @@ struct fsl_lbc_bank {
};
struct fsl_lbc_regs {
- struct fsl_lbc_bank bank[8];
- u8 res0[0x28];
+ struct fsl_lbc_bank bank[12];
+ u8 res0[0x8];
__be32 mar; /**< UPM Address Register */
u8 res1[0x4];
__be32 mamr; /**< UPMA Mode Register */
--
1.5.6.5
^ permalink raw reply related
* Re: [PATCH] powerpc/boot: cuboot: Fix up ethernet3 MAC address on MPC85xx
From: Kumar Gala @ 2009-06-11 2:54 UTC (permalink / raw)
To: Nate Case; +Cc: linuxppc-dev
In-Reply-To: <1244499462-18719-1-git-send-email-ncase@xes-inc.com>
On Jun 8, 2009, at 5:17 PM, Nate Case wrote:
> MPC85xx platforms do support 4 ethernet ports, so make sure the boot
> wrapper fixes up all of them in the fdt.
>
> Signed-off-by: Nate Case <ncase@xes-inc.com>
> ---
> arch/powerpc/boot/cuboot-85xx.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/boot/cuboot-85xx.c b/arch/powerpc/boot/
> cuboot-85xx.c
> index 6776a1a..277ba4a 100644
> --- a/arch/powerpc/boot/cuboot-85xx.c
> +++ b/arch/powerpc/boot/cuboot-85xx.c
> @@ -15,6 +15,7 @@
> #include "cuboot.h"
>
> #define TARGET_85xx
> +#define TARGET_HAS_ETH3
This is problematic in that we'd be changing the memory layout of the
bd_t and not ALL 85xx's have HAS_ETH3 set.
- k
^ permalink raw reply
* Re: [PATCH] fsldma: use PCI Read Multiple command
From: Kumar Gala @ 2009-06-11 2:45 UTC (permalink / raw)
To: Dan Williams
Cc: David Hawkins, Ira Snyder, Liu Dave-R63238, linux-kernel,
linuxppc-dev, Timur Tabi
In-Reply-To: <e9c3a7c20904271349m134ff7f2s9d7901015454cf3d@mail.gmail.com>
On Apr 27, 2009, at 3:49 PM, Dan Williams wrote:
> On Mon, Apr 27, 2009 at 1:47 PM, Timur Tabi <timur@freescale.com>
> wrote:
>> Adding Kumar to the CC: list, since he might pick up the patch.
>>
>
> Acked-by: Dan Williams <dan.j.williams@intel.com>
>
> I agree with taking this through Kumar's tree.
I'm going through patches for .31.. Should I still pick this up?
Going forward should I pick up fsldma patches?
- k
^ permalink raw reply
* Re: [PATCH] powerpc: minimizing the configuration of linkstation_defconfig
From: Kumar Gala @ 2009-06-11 2:46 UTC (permalink / raw)
To: Rogério Brito; +Cc: linuxppc-dev, Guennadi Liakhovetski, linux-kernel
In-Reply-To: <20090516160453.GA15138@ime.usp.br>
On May 16, 2009, at 11:04 AM, Rog=E9rio Brito wrote:
> Hi, Kumar, Guennadi, and Co.
>
>
> This patch addresses the following issues:
>
> 01. makes CFQ the default scheduler, to be in line with the rest of
> the kernel.
>
> 02. since linkstations are meant to store files, enable large blk
> devices.
>
> 03. disable CONFIG_MIGRATION in in such low memory devices.
>
> 04. disable CONFIG_BLK_DEV_RAM.
>
> 05. disable CONFIG_SCSI_LOWLEVEL, as no device under that tree is
> used.
>
> 06. idem for CONFIG_NETDEV_10000.
>
> 07. idem for CONFIG_WIRELESS.
>
> 08. idem for CONFIG_HWMON.
>
> 09. idem for CONFIG_CRYPTO_HW.
>
> 10. disable CONFIG_VIDEO_OUTPUT_CONTROL.
>
> 11. keep consistency and disable extended attributes in CIFS, ext3,
> and NFS.
>
> 12. enable CONFIG_PRINTK_TIME.
>
> Signed-off-by: Rog=E9rio Brito <rbrito@ime.usp.br>
>
> ---
>
> This is the patch for tidying the defconfig. I'm still having issues
> with the MTD devices, it seems. :-( I will investigate this now.
>
> I can send a similar patch to storcenter.
Did you ever resolve the MTD issue?
- k=
^ permalink raw reply
* Re: [PATCH v2] 83xx: add support for the kmeter1 board.
From: Kumar Gala @ 2009-06-11 2:43 UTC (permalink / raw)
To: hs; +Cc: Scott Wood, linuxppc-dev
In-Reply-To: <49F7DC0C.3080409@denx.de>
On Apr 28, 2009, at 11:48 PM, Heiko Schocher wrote:
> The following series implements basic board support for
> the kmeter1 board from keymile, based on a MPC8360.
>
> This series provides the following functionality:
>
> - The board can boot with a serial console on UART1
> - Ethernet:
> UCC1 in RGMII mode
> UCC2 in RGMII mode
> UCC4 in RMII mode
> UCC5 in RMII mode
> UCC6 in RMII mode
> UCC7 in RMII mode
> UCC8 in RMII mode
>
> following patch is necessary for working UCC in RMII mode:
>
> http://ozlabs.org/pipermail/linuxppc-dev/2009-April/070909.html
>
> - Flash accessed via MTD layer
>
> On this hardware there is an Intel P30 flash, following patch
> series is necessary for working with this hardware:
>
> http://ozlabs.org/pipermail/linuxppc-dev/2009-April/070716.html
>
> - I2C using I2C Bus 1 from the MPC8360 cpu
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
> changes since v1:
> - added comments from Kumar Gala and Scott Wood
> - get rid of using get_immrbase() in board specific code
>
> $ ./scripts/checkpatch.pl 0001--Patch-v2-83xx-add-support-for-the-
> kmeter1-board.patch
> total: 0 errors, 0 warnings, 1626 lines checked
>
> 0001--Patch-v2-83xx-add-support-for-the-kmeter1-board.patch has no
> obvious style problems and is ready for submission.
>
> arch/powerpc/boot/dts/kmeter1.dts | 513 +++++++++++++++
> arch/powerpc/configs/83xx/kmeter1_defconfig | 908 ++++++++++++++++++
> +++++++++
> arch/powerpc/platforms/83xx/Kconfig | 7 +
> arch/powerpc/platforms/83xx/Makefile | 1 +
> arch/powerpc/platforms/83xx/kmeter1.c | 188 ++++++
> 5 files changed, 1617 insertions(+), 0 deletions(-)
> create mode 100644 arch/powerpc/boot/dts/kmeter1.dts
> create mode 100644 arch/powerpc/configs/83xx/kmeter1_defconfig
> create mode 100644 arch/powerpc/platforms/83xx/kmeter1.c
>
> diff --git a/arch/powerpc/boot/dts/kmeter1.dts b/arch/powerpc/boot/
> dts/kmeter1.dts
> new file mode 100644
> index 0000000..63c27da
> --- /dev/null
> +++ b/arch/powerpc/boot/dts/kmeter1.dts
> @@ -0,0 +1,513 @@
> +/*
> + * Keymile KMETER1 Device Tree Source
> + *
> + * 2008 DENX Software Engineering GmbH
> + *
> + * This program is free software; you can redistribute it and/or
> modify it
> + * under the terms of the GNU General Public License as
> published by the
> + * Free Software Foundation; either version 2 of the License, or
> (at your
> + * option) any later version.
> + */
> +
> +/dts-v1/;
> +
> +/ {
> + model = "KMETER1";
> + compatible = "keymile,KMETER1";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + aliases {
> + ethernet0 = &enet_piggy2;
> + ethernet1 = &enet_estar1;
> + ethernet2 = &enet_estar2;
> + ethernet3 = &enet_eth1;
> + ethernet4 = &enet_eth2;
> + ethernet5 = &enet_eth3;
> + ethernet6 = &enet_eth4;
> + serial0 = &serial0;
> + };
> +
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + PowerPC,8360@0 {
> + device_type = "cpu";
> + reg = <0x0>;
> + d-cache-line-size = <32>; // 32 bytes
> + i-cache-line-size = <32>; // 32 bytes
> + d-cache-size = <32768>; // L1, 32K
> + i-cache-size = <32768>; // L1, 32K
> + timebase-frequency = <0>; /* Filled in by U-Boot */
> + bus-frequency = <0>; /* Filled in by U-Boot */
> + clock-frequency = <0>; /* Filled in by U-Boot */
> + };
> + };
> +
> + memory {
> + device_type = "memory";
> + reg = <0 0>; /* Filled in by U-Boot */
> + };
> +
> + soc8360@e0000000 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + device_type = "soc";
> + compatible = "simple-bus";
this should be:
compatible = "fsl,mpc8360-immr", "simple-bus";
>
> + ranges = <0x0 0xe0000000 0x00200000>;
> + reg = <0xe0000000 0x00000200>;
> + bus-frequency = <0>; /* Filled in by U-Boot */
> +
>
> + ipic: pic@700 {
> + #address-cells = <0>;
> + #interrupt-cells = <2>;
> + compatible = "fsl,pq2pro-pic", "fsl,ipic";
> + interrupt-controller;
> + reg = <0x700 0x100>;
> + device_type = "ipic";
drop the device_type.
>
> + };
> +
> + qe@100000 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + device_type = "qe";
> + compatible = "fsl,qe";
> + ranges = <0x0 0x100000 0x100000>;
> + reg = <0x100000 0x480>;
> + clock-frequency = <0>; /* Filled in by U-Boot */
> + brg-frequency = <0>; /* Filled in by U-Boot */
> + bus-frequency = <0>; /* Filled in by U-Boot */
> +
> +
> +
> + mdio@3320 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x3320 0x18>;
> + compatible = "fsl,ucc-mdio";
> +
> + /* Piggy2 (UCC4, MDIO 0x00, RMII) */
> + phy_piggy2: ethernet-phy@00 {
> + reg = <0x0>;
> + device_type = "ethernet-phy";
drop the device_type (and the one's below)
>
> + };
> +
> + /* Eth-1 (UCC5, MDIO 0x08, RMII) */
> + phy_eth1: ethernet-phy@08 {
> + reg = <0x08>;
> + device_type = "ethernet-phy";
> + };
> +
> + /* Eth-2 (UCC6, MDIO 0x09, RMII) */
> + phy_eth2: ethernet-phy@09 {
> + reg = <0x09>;
> + device_type = "ethernet-phy";
> + };
> +
> + /* Eth-3 (UCC7, MDIO 0x0a, RMII) */
> + phy_eth3: ethernet-phy@0a {
> + reg = <0x0a>;
> + device_type = "ethernet-phy";
> + };
> +
> + /* Eth-4 (UCC8, MDIO 0x0b, RMII) */
> + phy_eth4: ethernet-phy@0b {
> + reg = <0x0b>;
> + device_type = "ethernet-phy";
> + };
> +
> + /* ESTAR-1 (UCC1, MDIO 0x10, RGMII) */
> + phy_estar1: ethernet-phy@10 {
> + interrupt-parent = <&ipic>;
> + interrupts = <17 0x8>;
> + reg = <0x10>;
> + device_type = "ethernet-phy";
> + };
> +
> + /* ESTAR-2 (UCC2, MDIO 0x11, RGMII) */
> + phy_estar2: ethernet-phy@11 {
> + interrupt-parent = <&ipic>;
> + interrupts = <18 0x8>;
> + reg = <0x11>;
> + device_type = "ethernet-phy";
> + };
> + };
> +
> + qeic: interrupt-controller@80 {
> + interrupt-controller;
> + compatible = "fsl,qe-ic";
> + #address-cells = <0>;
> + #interrupt-cells = <1>;
> + reg = <0x80 0x80>;
> + interrupts = <32 8 33 8>;
> + interrupt-parent = <&ipic>;
> + };
> + };
> + };
> +
> + localbus@e0005000 {
> + #address-cells = <2>;
> + #size-cells = <1>;
> + compatible = "fsl,mpc8360-localbus", "fsl,pq2pro-localbus",
> + "simple-bus";
> + reg = <0xe0005000 0xd8>;
> + ranges = <0 0 0xf0000000 0x04000000>; /* Filled in by U-Boot */
> +
> + flash@f0000000,0 {
> + compatible = "cfi-flash";
> + /*
> + * The Intel P30 chip has 2 non-identical chips on
> + * one die, so we need to define 2 seperate regions
> + * that are scanned by physmap_of independantly.
> + */
> + reg = <0 0x00000000 0x02000000
> + 0 0x02000000 0x02000000>; /* Filled in by U-Boot */
> + bank-width = <2>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + partition@0 {
> + label = "u-boot";
> + reg = <0 0x40000>;
> + };
> + partition@40000 {
> + label = "env";
> + reg = <0x40000 0x40000>;
> + };
> + partition@80000 {
> + label = "dtb";
> + reg = <0x80000 0x20000>;
> + };
> + partition@a0000 {
> + label = "kernel";
> + reg = <0xa0000 0x300000>;
> + };
> + partition@3a0000 {
> + label = "ramdisk";
> + reg = <0x3a0000 0x800000>;
> + };
> + partition@ba0000 {
> + label = "user";
> + reg = <0xba0000 0x3460000>;
> + };
> + };
> + };
> +};
Sorry for taking so long to review this again.
- k
^ permalink raw reply
* Re: [PATCH] Re:[BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o]
From: Nathan Lynch @ 2009-06-11 2:28 UTC (permalink / raw)
To: subrata
Cc: Sachin P Sant, Stephen Rothwell, netdev, Linux-Kernel,
Linuxppc-dev, Linux-Next, Li Yang, Balbir Singh
In-Reply-To: <1244685364.6494.14.camel@subratamodak.linux.ibm.com>
Subrata Modak <subrata@linux.vnet.ibm.com> writes:
> On Thu, 2009-06-11 at 11:05 +1000, Stephen Rothwell wrote:
>> Hi Subrata,
>>=20
>> On Wed, 10 Jun 2009 23:13:23 +0530 Subrata Modak <subrata@linux.vnet.ibm=
.com> wrote:
>> >
>> > /* Find the TBI PHY. If it's not there, we don't support SGMII */
>> > - ph =3D of_get_property(np, "tbi-handle", NULL);
>> > + ph =3D (phandle *)of_get_property(np, "tbi-handle", NULL);
>>=20
>> You don't need this cast because of_get_property() returns "void *".
>
> Stephen,
>
> True. But without this gcc complains:
>
> CC [M] drivers/net/ucc_geth.o
> drivers/net/ucc_geth.c: In function =E2=80=98ucc_geth_probe=E2=80=99:
> drivers/net/ucc_geth.c:3824: warning: assignment discards qualifiers
> from pointer target type
ph should be declared const phandle *. Look at other uses of
of_get_property.
^ permalink raw reply
* Re: [PATCH] powerpc/85xx: add nor flash partitions for mpc8569mds
From: Kumar Gala @ 2009-06-11 2:20 UTC (permalink / raw)
To: Kevin Hao; +Cc: linuxppc-dev, Haiying Wang
In-Reply-To: <1243389905.13410.6.camel@kevin>
On May 26, 2009, at 9:05 PM, Kevin Hao wrote:
> Add 4 partitions in nor flash. Also fix nor flash
> bank width bug.
Can you explain this.. I'm trying to understand why you set the bank-
width to 1
- k
>
>
> Signed-off-by: Kevin Hao <kexin.hao@windriver.com>
> ---
> arch/powerpc/boot/dts/mpc8569mds.dts | 24 +++++++++++++++++++++++-
> 1 files changed, 23 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/mpc8569mds.dts b/arch/powerpc/
> boot/dts/mpc8569mds.dts
> index 39c2927..1f98990 100644
> --- a/arch/powerpc/boot/dts/mpc8569mds.dts
> +++ b/arch/powerpc/boot/dts/mpc8569mds.dts
> @@ -70,8 +70,30 @@
> #size-cells = <1>;
> compatible = "cfi-flash";
> reg = <0x0 0x0 0x02000000>;
> - bank-width = <2>;
> + bank-width = <1>;
> device-width = <1>;
> + partition@0 {
> + label = "ramdisk";
> + reg = <0x00000000 0x01c00000>;
> + };
> + partition@1c00000 {
> + label = "kernel";
> + reg = <0x01c00000 0x002e0000>;
> + };
> + partiton@1ee0000 {
> + label = "dtb";
> + reg = <0x01ee0000 0x00020000>;
> + };
> + partition@1f00000 {
> + label = "firmware";
> + reg = <0x01f00000 0x00080000>;
> + read-only;
> + };
> + partition@1f80000 {
> + label = "u-boot";
> + reg = <0x01f80000 0x00080000>;
> + read-only;
> + };
> };
>
> bcsr@1,0 {
> --
> 1.6.0.4.771.gef3b3
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox