* Re: [06/19] powerpc: Make function btext_initialize static
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, kvm-ppc, Paul Mackerras,
linuxppc-dev
In-Reply-To: <20180322202007.23088-7-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 443 bytes --]
On Thu, 2018-03-22 at 20:19:52 UTC, Mathieu Malaterre wrote:
> This function can be static, make it so, this fix a warning treated as
> error with W=1:
>
> arch/powerpc/kernel/btext.c:173:5: error: no previous prototype for ‘btext_initialize’ [-Werror=missing-prototypes]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/86e11b6e9c56e605475462bf9ba7c1
cheers
^ permalink raw reply
* Re: [08/19] powerpc/tau: Make some function static
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, kvm-ppc, Paul Mackerras,
linuxppc-dev
In-Reply-To: <20180322202007.23088-9-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 925 bytes --]
On Thu, 2018-03-22 at 20:19:54 UTC, Mathieu Malaterre wrote:
> These functions can all be static, make it so. Fix warnings treated as
> errors with W=1:
>
> arch/powerpc/kernel/tau_6xx.c:53:6: error: no previous prototype for ‘set_thresholds’ [-Werror=missing-prototypes]
> arch/powerpc/kernel/tau_6xx.c:73:6: error: no previous prototype for ‘TAUupdate’ [-Werror=missing-prototypes]
> arch/powerpc/kernel/tau_6xx.c:208:13: error: no previous prototype for ‘TAU_init_smp’ [-Werror=missing-prototypes]
> arch/powerpc/kernel/tau_6xx.c:220:12: error: no previous prototype for ‘TAU_init’ [-Werror=missing-prototypes]
> arch/powerpc/kernel/tau_6xx.c:126:6: error: no previous prototype for ‘TAUException’ [-Werror=missing-prototypes]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/9e0d86cd2d749998c3792059221cef
cheers
^ permalink raw reply
* Re: [10/19] powerpc/chrp/time: Make some functions static, add missing header include
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, kvm-ppc, Paul Mackerras,
linuxppc-dev
In-Reply-To: <20180322202007.23088-11-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]
On Thu, 2018-03-22 at 20:19:56 UTC, Mathieu Malaterre wrote:
> Add a missing include <platforms/chrp/chrp.h>.
>
> These functions can all be static, make it so. Fix warnings treated as
> errors with W=1:
>
> arch/powerpc/platforms/chrp/time.c:41:13: error: no previous prototype for ‘chrp_time_init’ [-Werror=missing-prototypes]
> arch/powerpc/platforms/chrp/time.c:66:5: error: no previous prototype for ‘chrp_cmos_clock_read’ [-Werror=missing-prototypes]
> arch/powerpc/platforms/chrp/time.c:74:6: error: no previous prototype for ‘chrp_cmos_clock_write’ [-Werror=missing-prototypes]
> arch/powerpc/platforms/chrp/time.c:86:5: error: no previous prototype for ‘chrp_set_rtc_time’ [-Werror=missing-prototypes]
> arch/powerpc/platforms/chrp/time.c:130:6: error: no previous prototype for ‘chrp_get_rtc_time’ [-Werror=missing-prototypes]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/b87a358b4a1421abd544c0b554b1b7
cheers
^ permalink raw reply
* Re: [17/19] powerpc/32: Add a missing include header
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, kvm-ppc, Paul Mackerras,
linuxppc-dev
In-Reply-To: <20180322202007.23088-18-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 481 bytes --]
On Thu, 2018-03-22 at 20:20:03 UTC, Mathieu Malaterre wrote:
> The header file <linux/syscalls.h> was missing from the includes. Fix the
> following warning, treated as error with W=1:
>
> arch/powerpc/kernel/pci_32.c:286:6: error: no previous prototype for ‘sys_pciconfig_iobase’ [-Werror=missing-prototypes]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/c89ca593220931c150cffda24b4d4c
cheers
^ permalink raw reply
* Re: [18/19] powerpc: Add a missing include header
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, kvm-ppc, Paul Mackerras,
linuxppc-dev
In-Reply-To: <20180322202007.23088-19-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 475 bytes --]
On Thu, 2018-03-22 at 20:20:04 UTC, Mathieu Malaterre wrote:
> The header file <asm/switch_to.h> was missing from the includes. Fix the
> following warning, treated as error with W=1:
>
> arch/powerpc/kernel/vecemu.c:260:5: error: no previous prototype for ‘emulate_altivec’ [-Werror=missing-prototypes]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/d647b210ac738b401c7f824bbebdcb
cheers
^ permalink raw reply
* Re: [v2] xmon: Use __printf markup to silence compiler
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, Paul Mackerras, linuxppc-dev, linux-kernel
In-Reply-To: <20180325090648.1029-1-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 3731 bytes --]
On Sun, 2018-03-25 at 09:06:47 UTC, Mathieu Malaterre wrote:
> Update the other prototype declarations in asm/xmon.h.
>
> Silence warnings (triggered at W=1) by adding relevant __printf attribute.
> Move #define at bottom of the file to prevent conflict with gcc attribute.
>
> Solve the original warning:
>
> arch/powerpc/xmon/nonstdio.c:178:2: error: function might be possible candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
>
> In turn this uncovered the following (partial list) warnings (treated as
> errors with W=1):
>
> arch/powerpc/xmon/xmon.c:2866:17: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘unsigned char *’ [-Werror=format=]
> arch/powerpc/xmon/xmon.c:1607:31: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘struct pt_regs *’ [-Werror=format=]
> arch/powerpc/xmon/xmon.c:1611:9: error: too many arguments for format [-Werror=format-extra-args]
> arch/powerpc/xmon/xmon.c:1623:26: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘struct task_struct *’ [-Werror=format=]
> arch/powerpc/xmon/xmon.c:630:36: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘int’ [-Werror=format=]
> arch/powerpc/xmon/xmon.c:1392:15: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long int’ [-Werror=format=]
> arch/powerpc/xmon/xmon.c:2570:16: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘u64 {aka long long unsigned int}’ [-Werror=format=]
> arch/powerpc/xmon/xmon.c:1629:25: error: format ‘%ld’ expects argument of type ‘long int’, but argument 2 has type ‘pid_t {aka int}’ [-Werror=format=]
> arch/powerpc/xmon/xmon.c:1168:18: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’ [-Werror=format=]
> arch/powerpc/xmon/xmon.c:3016:24: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘pgd_t * {aka struct <anonymous> *}’ [-Werror=format=]
> arch/powerpc/xmon/xmon.c:2339:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘u64 {aka long long unsigned int}’ [-Werror=format=]
> arch/powerpc/xmon/xmon.c:2339:9: error: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘long unsigned int’ [-Werror=format=]
> arch/powerpc/xmon/xmon.c:3827:10: error: format ‘%p’ expects argument of type ‘void *’, but argument 4 has type ‘long long unsigned int’ [-Werror=format=]
> arch/powerpc/xmon/xmon.c:3896:50: error: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘long unsigned int’ [-Werror=format=]
> arch/powerpc/xmon/spu-dis.c:137:18: error: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘long unsigned int’ [-Werror=format=]
> arch/powerpc/xmon/xmon.c:3827:10: error: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘u64 {aka long long unsigned int}’ [-Werror=format=]
> arch/powerpc/xmon/xmon.c:1665:17: error: format ‘%ld’ expects argument of type ‘long int’, but argument 2 has type ‘int’ [-Werror=format=]
> arch/powerpc/xmon/xmon.c:2339:9: error: '#' flag used with ‘%p’ gnu_printf format [-Werror=format=]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/e70d8f55268ba95f00c61857df2bab
cheers
^ permalink raw reply
* Re: [v3] powerpc/altivec: Add missing prototypes for altivec
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Matt Brown, Paul Mackerras,
linuxppc-dev
In-Reply-To: <20180328185531.10945-1-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1466 bytes --]
On Wed, 2018-03-28 at 18:55:25 UTC, Mathieu Malaterre wrote:
> Some functions prototypes were missing for the non-altivec code. Add the
> missing prototypes in a new header file, fix warnings treated as errors
> with W=1:
>
> arch/powerpc/lib/xor_vmx_glue.c:18:6: error: no previous prototype for ‘xor_altivec_2’ [-Werror=missing-prototypes]
> arch/powerpc/lib/xor_vmx_glue.c:29:6: error: no previous prototype for ‘xor_altivec_3’ [-Werror=missing-prototypes]
> arch/powerpc/lib/xor_vmx_glue.c:40:6: error: no previous prototype for ‘xor_altivec_4’ [-Werror=missing-prototypes]
> arch/powerpc/lib/xor_vmx_glue.c:52:6: error: no previous prototype for ‘xor_altivec_5’ [-Werror=missing-prototypes]
>
> The prototypes were already present in <asm/xor.h> but this header file is
> meant to be included after <include/linux/raid/xor.h>. Trying to re-use
> <asm/xor.h> directly would lead to warnings such as:
>
> arch/powerpc/include/asm/xor.h:39:15: error: variable ‘xor_block_altivec’ has initializer but incomplete type
>
> Trying to re-use <asm/xor.h> after <include/linux/raid/xor.h> in
> xor_vmx_glue.c would in turn trigger the following warnings:
>
> include/asm-generic/xor.h:688:34: error: ‘xor_block_32regs’ defined but not used [-Werror=unused-variable]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/7cf76a68f1bcf69214da2812e8f615
cheers
^ permalink raw reply
* Re: [v3,01/19] powerpc/powermac: Mark variable x as unused
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Paul Mackerras, linuxppc-dev
In-Reply-To: <20180404200746.27379-1-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 554 bytes --]
On Wed, 2018-04-04 at 20:07:46 UTC, Mathieu Malaterre wrote:
> Since the value of x is never intended to be read, declare it with gcc
> attribute as unused. Fix warning treated as error with W=1:
>
> arch/powerpc/platforms/powermac/bootx_init.c:471:21: error: variable ‘x’ set but not used [-Werror=unused-but-set-variable]
>
> Suggested-by: Christophe Leroy <christophe.leroy@c-s.fr>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/5a4b475cf8511da721f20ba432c244
cheers
^ permalink raw reply
* Re: [v3, 05/19] powerpc/chrp/setup: Remove idu_size variable and make some functions static
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Paul Mackerras, linuxppc-dev
In-Reply-To: <20180404200911.27506-1-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]
On Wed, 2018-04-04 at 20:09:11 UTC, Mathieu Malaterre wrote:
> Remove variable declaration idu_size and associated code since not used.
>
> These functions can all be static, make it so. Fix warnings treated as
> errors with W=1:
>
> arch/powerpc/platforms/chrp/setup.c:97:6: error: no previous prototype for ‘chrp_show_cpuinfo’ [-Werror=missing-prototypes]
> arch/powerpc/platforms/chrp/setup.c:302:13: error: no previous prototype for ‘chrp_setup_arch’ [-Werror=missing-prototypes]
> arch/powerpc/platforms/chrp/setup.c:385:16: error: variable ‘idu_size’ set but not used [-Werror=unused-but-set-variable]
> arch/powerpc/platforms/chrp/setup.c:526:13: error: no previous prototype for ‘chrp_init_IRQ’ [-Werror=missing-prototypes]
> arch/powerpc/platforms/chrp/setup.c:559:1: error: no previous prototype for ‘chrp_init2’ [-Werror=missing-prototypes]
>
> Suggested-by: Christophe Leroy <christophe.leroy@c-s.fr>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/f0e0b86638e9df6731b1d61c71ae18
cheers
^ permalink raw reply
* Re: [v3,09/19] powerpc/chrp/pci: Make some functions static
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Paul Mackerras, linuxppc-dev
In-Reply-To: <20180404201504.28003-1-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 837 bytes --]
On Wed, 2018-04-04 at 20:15:03 UTC, Mathieu Malaterre wrote:
> These functions can all be static, make it so. Fix warnings treated as
> errors with W=1:
>
> arch/powerpc/platforms/chrp/pci.c:34:5: error: no previous prototype for ‘gg2_read_config’ [-Werror=missing-prototypes]
> arch/powerpc/platforms/chrp/pci.c:61:5: error: no previous prototype for ‘gg2_write_config’ [-Werror=missing-prototypes]
> arch/powerpc/platforms/chrp/pci.c:97:5: error: no previous prototype for ‘rtas_read_config’ [-Werror=missing-prototypes]
> arch/powerpc/platforms/chrp/pci.c:112:5: error: no previous prototype for ‘rtas_write_config’ [-Werror=missing-prototypes]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/910be6be6c00e6d33d47985586c392
cheers
^ permalink raw reply
* Re: [v3, 11/19] powerpc/powermac: Move pmac_pfunc_base_install prototype to header file
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Paul Mackerras, linuxppc-dev
In-Reply-To: <20180404201355.27925-1-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 645 bytes --]
On Wed, 2018-04-04 at 20:13:55 UTC, Mathieu Malaterre wrote:
> The pmac_pfunc_base_install prototype was declared in powermac/smp.c since
> function was used there, move it to pmac_pfunc.h header to be visible in
> pfunc_base.c. Fix a warning treated as error with W=1:
>
> arch/powerpc/platforms/powermac/pfunc_base.c:330:12: error: no previous prototype for ‘pmac_pfunc_base_install’ [-Werror=missing-prototypes]
>
> Suggested-by: Christophe Leroy <christophe.leroy@c-s.fr>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/f91d5998996819eaf194ff48e00d49
cheers
^ permalink raw reply
* Re: [v3, 12/19] powerpc/powermac: Add missing prototype for note_bootable_part()
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Paul Mackerras, linuxppc-dev
In-Reply-To: <20180404201306.27818-1-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 536 bytes --]
On Wed, 2018-04-04 at 20:13:05 UTC, Mathieu Malaterre wrote:
> Add a missing prototype for function `note_bootable_part` to silence a
> warning treated as error with W=1:
>
> arch/powerpc/platforms/powermac/setup.c:361:12: error: no previous prototype for ‘note_bootable_part’ [-Werror=missing-prototypes]
>
> Suggested-by: Christophe Leroy <christophe.leroy@c-s.fr>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/f72cf3f1d49f2c35d6cb682af2e8c9
cheers
^ permalink raw reply
* Re: [v3,13/19] powerpc/52xx: Add missing functions prototypes
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Paul Mackerras, linuxppc-dev
In-Reply-To: <20180404201230.27756-1-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 973 bytes --]
On Wed, 2018-04-04 at 20:12:30 UTC, Mathieu Malaterre wrote:
> The function prototypes were declared within a `#ifdef CONFIG_PPC_LITE5200`
> block which would prevent them from being visible when compiling
> `mpc52xx_pm.c`. Move the prototypes outside of the `#ifdef` block to fix
> the following warnings treated as errors with W=1:
>
> arch/powerpc/platforms/52xx/mpc52xx_pm.c:58:5: error: no previous prototype for ‘mpc52xx_pm_prepare’ [-Werror=missing-prototypes]
> arch/powerpc/platforms/52xx/mpc52xx_pm.c:113:5: error: no previous prototype for ‘mpc52xx_pm_enter’ [-Werror=missing-prototypes]
> arch/powerpc/platforms/52xx/mpc52xx_pm.c:181:6: error: no previous prototype for ‘mpc52xx_pm_finish’ [-Werror=missing-prototypes]
>
> Suggested-by: Christophe Leroy <christophe.leroy@c-s.fr>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/c3f0515ea1277558e7c0c3240d17c7
cheers
^ permalink raw reply
* Re: [v3,15/19] powerpc: Add missing prototype
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Paul Mackerras, linuxppc-dev
In-Reply-To: <20180404201142.27691-1-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 496 bytes --]
On Wed, 2018-04-04 at 20:11:42 UTC, Mathieu Malaterre wrote:
> Add one missing prototype for function rh_dump_blk. Fix warning treated as
> error in W=1:
>
> arch/powerpc/lib/rheap.c:740:6: error: no previous prototype for ‘rh_dump_blk’ [-Werror=missing-prototypes]
>
> Suggested-by: Christophe Leroy <christophe.leroy@c-s.fr>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/3fc5ee9b2846db2eaddeadf089ef25
cheers
^ permalink raw reply
* Re: [v3,19/19] powerpc/tau: Synchronize function prototypes and body
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Paul Mackerras, linuxppc-dev
In-Reply-To: <20180404201028.27621-1-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]
On Wed, 2018-04-04 at 20:10:28 UTC, Mathieu Malaterre wrote:
> Some function prototypes and body for Thermal Assist Units were not in
> sync. Update the function definition to match the existing function
> declaration found in `setup-common.c`, changing an `int` return type to a
> `u32` return type. Move the prototypes to a header file. Fix the following
> warnings, treated as error with W=1:
>
> arch/powerpc/kernel/tau_6xx.c:257:5: error: no previous prototype for ‘cpu_temp_both’ [-Werror=missing-prototypes]
> arch/powerpc/kernel/tau_6xx.c:262:5: error: no previous prototype for ‘cpu_temp’ [-Werror=missing-prototypes]
> arch/powerpc/kernel/tau_6xx.c:267:5: error: no previous prototype for ‘tau_interrupts’ [-Werror=missing-prototypes]
>
> Compile tested with CONFIG_TAU_INT.
>
> Suggested-by: Christophe Leroy <christophe.leroy@c-s.fr>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/bd13ac95f954570e01fba5a6caf771
cheers
^ permalink raw reply
* Re: powerpc: add __printf verification to prom_printf
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, Paul Mackerras, linuxppc-dev, linux-kernel
In-Reply-To: <20180406201220.31957-1-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 3487 bytes --]
On Fri, 2018-04-06 at 20:12:19 UTC, Mathieu Malaterre wrote:
> __printf is useful to verify format and arguments. Fix arg mismatch
> reported by gcc, remove the following warnings (with W=1):
>
> arch/powerpc/kernel/prom_init.c:1467:31: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’ [-Werror=format=]
> arch/powerpc/kernel/prom_init.c:1471:31: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’ [-Werror=format=]
> arch/powerpc/kernel/prom_init.c:1504:33: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’ [-Werror=format=]
> arch/powerpc/kernel/prom_init.c:1505:33: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’ [-Werror=format=]
> arch/powerpc/kernel/prom_init.c:1506:33: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’ [-Werror=format=]
> arch/powerpc/kernel/prom_init.c:1507:33: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’ [-Werror=format=]
> arch/powerpc/kernel/prom_init.c:1508:33: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’ [-Werror=format=]
> arch/powerpc/kernel/prom_init.c:1509:33: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’ [-Werror=format=]
> arch/powerpc/kernel/prom_init.c:1975:39: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘unsigned int’ [-Werror=format=]
> arch/powerpc/kernel/prom_init.c:1986:27: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’ [-Werror=format=]
> arch/powerpc/kernel/prom_init.c:2567:38: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’ [-Werror=format=]
> arch/powerpc/kernel/prom_init.c:2567:46: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘long unsigned int’ [-Werror=format=]
> arch/powerpc/kernel/prom_init.c:2569:38: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’ [-Werror=format=]
> arch/powerpc/kernel/prom_init.c:2569:46: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘long unsigned int’ [-Werror=format=]
>
> The patch also include arg mismatch fix for case with #define DEBUG_PROM
> (warning not listed here).
>
> This patch fix also the following warnings revealed by checkpatch:
>
> WARNING: Prefer using '"%s...", __func__' to using 'alloc_up', this function's name, in a string
> #101: FILE: arch/powerpc/kernel/prom_init.c:1235:
> + prom_debug("alloc_up(%lx, %lx)\n", size, align);
>
> and
>
> WARNING: Prefer using '"%s...", __func__' to using 'alloc_down', this function's name, in a string
> #138: FILE: arch/powerpc/kernel/prom_init.c:1278:
> + prom_debug("alloc_down(%lx, %lx, %s)\n", size, align,
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/eae5f709a4d738c52b6ab636981755
cheers
^ permalink raw reply
* Re: [v2] powerpc/sparse: fix plain integer as NULL pointer warning
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Mathieu Malaterre, Benjamin Herrenschmidt
Cc: Mathieu Malaterre, Paul Mackerras, linuxppc-dev, linux-kernel
In-Reply-To: <20180413184144.25183-1-malat@debian.org>
On Fri, 2018-04-13 at 18:41:43 UTC, Mathieu Malaterre wrote:
> Trivial fix to remove the following sparse warnings:
>
> arch/powerpc/kernel/module_32.c:112:74: warning: Using plain integer as NULL pointer
> arch/powerpc/kernel/module_32.c:117:74: warning: Using plain integer as NULL pointer
> drivers/macintosh/via-pmu.c:1155:28: warning: Using plain integer as NULL pointer
> drivers/macintosh/via-pmu.c:1230:20: warning: Using plain integer as NULL pointer
> drivers/macintosh/via-pmu.c:1385:36: warning: Using plain integer as NULL pointer
> drivers/macintosh/via-pmu.c:1752:23: warning: Using plain integer as NULL pointer
> drivers/macintosh/via-pmu.c:2084:19: warning: Using plain integer as NULL pointer
> drivers/macintosh/via-pmu.c:2110:32: warning: Using plain integer as NULL pointer
> drivers/macintosh/via-pmu.c:2167:19: warning: Using plain integer as NULL pointer
> drivers/macintosh/via-pmu.c:2183:19: warning: Using plain integer as NULL pointer
> drivers/macintosh/via-pmu.c:277:20: warning: Using plain integer as NULL pointer
> arch/powerpc/platforms/powermac/setup.c:155:67: warning: Using plain integer as NULL pointer
> arch/powerpc/platforms/powermac/setup.c:247:27: warning: Using plain integer as NULL pointer
> arch/powerpc/platforms/powermac/setup.c:249:27: warning: Using plain integer as NULL pointer
> arch/powerpc/platforms/powermac/setup.c:252:37: warning: Using plain integer as NULL pointer
> arch/powerpc/mm/tlb_hash32.c:127:21: warning: Using plain integer as NULL pointer
> arch/powerpc/mm/tlb_hash32.c:148:21: warning: Using plain integer as NULL pointer
> arch/powerpc/mm/tlb_hash32.c:44:21: warning: Using plain integer as NULL pointer
> arch/powerpc/mm/tlb_hash32.c:57:21: warning: Using plain integer as NULL pointer
> arch/powerpc/mm/tlb_hash32.c:87:21: warning: Using plain integer as NULL pointer
> arch/powerpc/kernel/btext.c:160:31: warning: Using plain integer as NULL pointer
> arch/powerpc/kernel/btext.c:167:22: warning: Using plain integer as NULL pointer
> arch/powerpc/kernel/btext.c:274:21: warning: Using plain integer as NULL pointer
> arch/powerpc/kernel/btext.c:285:31: warning: Using plain integer as NULL pointer
> arch/powerpc/include/asm/hugetlb.h:204:16: warning: Using plain integer as NULL pointer
> arch/powerpc/mm/ppc_mmu_32.c:170:21: warning: Using plain integer as NULL pointer
> arch/powerpc/platforms/powermac/pci.c:1227:23: warning: Using plain integer as NULL pointer
> arch/powerpc/platforms/powermac/pci.c:65:24: warning: Using plain integer as NULL pointer
>
> Also use `--fix` command line option from `script/checkpatch --strict` to
> remove the following:
>
> CHECK: Comparison to NULL could be written "!dispDeviceBase"
> #72: FILE: arch/powerpc/kernel/btext.c:160:
> + if (dispDeviceBase == NULL)
>
> CHECK: Comparison to NULL could be written "!vbase"
> #80: FILE: arch/powerpc/kernel/btext.c:167:
> + if (vbase == NULL)
>
> CHECK: Comparison to NULL could be written "!base"
> #89: FILE: arch/powerpc/kernel/btext.c:274:
> + if (base == NULL)
>
> CHECK: Comparison to NULL could be written "!dispDeviceBase"
> #98: FILE: arch/powerpc/kernel/btext.c:285:
> + if (dispDeviceBase == NULL)
>
> CHECK: Comparison to NULL could be written "strstr"
> #117: FILE: arch/powerpc/kernel/module_32.c:117:
> + if (strstr(secstrings + sechdrs[i].sh_name, ".debug") != NULL)
>
> CHECK: Comparison to NULL could be written "!Hash"
> #130: FILE: arch/powerpc/mm/ppc_mmu_32.c:170:
> + if (Hash == NULL)
>
> CHECK: Comparison to NULL could be written "Hash"
> #143: FILE: arch/powerpc/mm/tlb_hash32.c:44:
> + if (Hash != NULL) {
>
> CHECK: Comparison to NULL could be written "!Hash"
> #152: FILE: arch/powerpc/mm/tlb_hash32.c:57:
> + if (Hash == NULL) {
>
> CHECK: Comparison to NULL could be written "!Hash"
> #161: FILE: arch/powerpc/mm/tlb_hash32.c:87:
> + if (Hash == NULL) {
>
> CHECK: Comparison to NULL could be written "!Hash"
> #170: FILE: arch/powerpc/mm/tlb_hash32.c:127:
> + if (Hash == NULL) {
>
> CHECK: Comparison to NULL could be written "!Hash"
> #179: FILE: arch/powerpc/mm/tlb_hash32.c:148:
> + if (Hash == NULL) {
>
> ERROR: space required after that ';' (ctx:VxV)
> #192: FILE: arch/powerpc/platforms/powermac/pci.c:65:
> + for (; node != NULL;node = node->sibling) {
>
> CHECK: Comparison to NULL could be written "node"
> #192: FILE: arch/powerpc/platforms/powermac/pci.c:65:
> + for (; node != NULL;node = node->sibling) {
>
> CHECK: Comparison to NULL could be written "!region"
> #201: FILE: arch/powerpc/platforms/powermac/pci.c:1227:
> + if (region == NULL)
>
> CHECK: Comparison to NULL could be written "of_get_property"
> #214: FILE: arch/powerpc/platforms/powermac/setup.c:155:
> + if (of_get_property(np, "cache-unified", NULL) != NULL && dc) {
>
> CHECK: Comparison to NULL could be written "!np"
> #223: FILE: arch/powerpc/platforms/powermac/setup.c:247:
> + if (np == NULL)
>
> CHECK: Comparison to NULL could be written "np"
> #226: FILE: arch/powerpc/platforms/powermac/setup.c:249:
> + if (np != NULL) {
>
> CHECK: Comparison to NULL could be written "l2cr"
> #230: FILE: arch/powerpc/platforms/powermac/setup.c:252:
> + if (l2cr != NULL) {
>
> CHECK: Comparison to NULL could be written "via"
> #243: FILE: drivers/macintosh/via-pmu.c:277:
> + if (via != NULL)
>
> CHECK: Comparison to NULL could be written "current_req"
> #252: FILE: drivers/macintosh/via-pmu.c:1155:
> + if (current_req != NULL) {
>
> CHECK: Comparison to NULL could be written "!req"
> #261: FILE: drivers/macintosh/via-pmu.c:1230:
> + if (req == NULL || pmu_state != idle
>
> CHECK: Comparison to NULL could be written "!req"
> #270: FILE: drivers/macintosh/via-pmu.c:1385:
> + if (req == NULL) {
>
> CHECK: Comparison to NULL could be written "!pp"
> #288: FILE: drivers/macintosh/via-pmu.c:2084:
> + if (pp == NULL)
>
> CHECK: Comparison to NULL could be written "!pp"
> #297: FILE: drivers/macintosh/via-pmu.c:2110:
> + if (count < 1 || pp == NULL)
>
> CHECK: Comparison to NULL could be written "!pp"
> #306: FILE: drivers/macintosh/via-pmu.c:2167:
> + if (pp == NULL)
>
> CHECK: Comparison to NULL could be written "pp"
> #315: FILE: drivers/macintosh/via-pmu.c:2183:
> + if (pp != NULL) {
>
> Link: https://github.com/linuxppc/linux/issues/37
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/d8731527acee53b4d46d59ff0b5fc3
cheers
^ permalink raw reply
* Re: [v2] powerpc/mm/radix: use do/while(0) trick for single statement block
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, Randy Dunlap, linux-kernel, Paul Mackerras,
linuxppc-dev
In-Reply-To: <20180423193638.10535-1-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 684 bytes --]
On Mon, 2018-04-23 at 19:36:38 UTC, Mathieu Malaterre wrote:
> In commit 7a22d6321c3d ("powerpc/mm/radix: Update command line parsing for
> disable_radix") an `if` statement was added for a possible empty body
> (prom_debug).
>
> Fix the following warning, treated as error with W=1:
>
> arch/powerpc/kernel/prom_init.c:656:46: error: suggest braces around empty body in an ‘if’ statement [-Werror=empty-body]
>
> Suggested-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/85aa4b98419d74dd5cc914e0893498
cheers
^ permalink raw reply
* Re: powerpc/wii: Make hlwd_pic_init function static
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, Paul Mackerras, linuxppc-dev, linux-kernel
In-Reply-To: <20180423194533.23487-1-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 480 bytes --]
On Mon, 2018-04-23 at 19:45:32 UTC, Mathieu Malaterre wrote:
> The function hlwd_pic_init can be made static, so do it. Fix the following
> warning treated as error (W=1):
>
> ../arch/powerpc/platforms/embedded6xx/hlwd-pic.c:158:20: error: no previous prototype for ‘hlwd_pic_init’ [-Werror=missing-prototypes]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/eed6964bce59294f293b1746a6e4a6
cheers
^ permalink raw reply
* Re: [1/3] powernv: opal-sensor: Add support to read 64bit sensor values
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Shilpasri G Bhat, linux
Cc: linux-hwmon, stewart, jdelvare, linux-kernel, paulus,
Shilpasri G Bhat, linuxppc-dev
In-Reply-To: <1525688738-9185-2-git-send-email-shilpa.bhat@linux.vnet.ibm.com>
On Mon, 2018-05-07 at 10:25:36 UTC, Shilpasri G Bhat wrote:
> This patch adds support to read 64-bit sensor values. This method is
> used to read energy sensors and counters which are of type u64.
>
> Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/5cdcb01e0af5a709c9bebe0e0450dc
cheers
^ permalink raw reply
* Re: [2/3] hwmon: (ibmpowernv): Add support to read 64 bit sensors
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Shilpasri G Bhat, linux
Cc: linux-hwmon, stewart, jdelvare, linux-kernel, paulus,
Shilpasri G Bhat, linuxppc-dev
In-Reply-To: <1525688738-9185-3-git-send-email-shilpa.bhat@linux.vnet.ibm.com>
On Mon, 2018-05-07 at 10:25:37 UTC, Shilpasri G Bhat wrote:
> The firmware has supported for reading sensor values of size u32.
> This patch adds support to use newer firmware functions which allows
> to read the sensors of size u64.
>
> Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
> Acked-by: Guenter Roeck <linux@roeck-us.net>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/3c8c049aa7bdffaab2e53401fd5270
cheers
^ permalink raw reply
* Re: [3/3] hwmon: (ibmpowernv) Add energy sensors
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Shilpasri G Bhat, linux
Cc: linux-hwmon, stewart, jdelvare, linux-kernel, paulus,
Shilpasri G Bhat, linuxppc-dev
In-Reply-To: <1525688738-9185-4-git-send-email-shilpa.bhat@linux.vnet.ibm.com>
On Mon, 2018-05-07 at 10:25:38 UTC, Shilpasri G Bhat wrote:
> This patch exports the accumulated power numbers of each power
> sensor maintained by OCC.
>
> Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
> Acked-by: Guenter Roeck <linux@roeck-us.net>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/43d2974b66d916a6df16e536da542e
cheers
^ permalink raw reply
* Re: powerpc/xmon: Update paca fields dumped in xmon
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Michael Ellerman, linuxppc-dev
In-Reply-To: <20180521094720.15338-1-mpe@ellerman.id.au>
On Mon, 2018-05-21 at 09:47:20 UTC, Michael Ellerman wrote:
> The set of paca fields we dump in xmon has gotten somewhat out of
> date. Update to add some recently added fields.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Applied to powerpc next.
https://git.kernel.org/powerpc/c/2e0986d761324376021c880ddbf00c
cheers
^ permalink raw reply
* Re: selftests/powerpc: Add missing .gitignores
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Michael Neuling; +Cc: mikey, linuxppc-dev
In-Reply-To: <20180522061359.4954-1-mikey@neuling.org>
On Tue, 2018-05-22 at 06:13:59 UTC, Michael Neuling wrote:
> Signed-off-by: Michael Neuling <mikey@neuling.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/bd79010fb3a9aa160e1780e2496798
cheers
^ permalink raw reply
* Re: powerpc/mm: Use instruction symbolic names in store_updates_sp()
From: Michael Ellerman @ 2018-05-25 11:41 UTC (permalink / raw)
To: Christophe Leroy, Benjamin Herrenschmidt, Paul Mackerras, npiggin
Cc: linuxppc-dev, linux-kernel
In-Reply-To: <484449fcfad0f718ce6d63a056d2aafc073991e7.1527058932.git.christophe.leroy@c-s.fr>
On Wed, 2018-05-23 at 07:04:04 UTC, Christophe Leroy wrote:
> Use symbolic names defined in asm/ppc-opcode.h
> instead of hardcoded values.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/8a0b1120cb25ccd4480ba4fe3650bc
cheers
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox