* Re: [PATCH v4] powerpc: use probe_user_read() and probe_user_write()
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Christophe Leroy, Benjamin Herrenschmidt, Paul Mackerras
Cc: linuxppc-dev, linux-kernel
In-Reply-To: <e041f5eedb23f09ab553be8a91c3de2087147320.1579800517.git.christophe.leroy@c-s.fr>
On Thu, 2020-01-23 at 17:30:47 UTC, Christophe Leroy wrote:
> Instead of opencoding, use probe_user_read() to failessly read
> a user location and probe_user_write() for writing to user.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/def0bfdbd6039e96a9eb2baaa4470b079daab0d4
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/papr_scm: Fix leaking 'bus_desc.provider_name' in some paths
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Vaibhav Jain, linuxppc-dev
Cc: Vaibhav Jain, Oliver O'Halloran, Aneesh Kumar K . V
In-Reply-To: <20200122155140.120429-1-vaibhav@linux.ibm.com>
On Wed, 2020-01-22 at 15:51:40 UTC, Vaibhav Jain wrote:
> String 'bus_desc.provider_name' allocated inside
> papr_scm_nvdimm_init() will leaks in case call to
> nvdimm_bus_register() fails or when papr_scm_remove() is called.
>
> This minor patch ensures that 'bus_desc.provider_name' is freed in
> error path for nvdimm_bus_register() as well as in papr_scm_remove().
>
> Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/5649607a8d0b0e019a4db14aab3de1e16c3a2b4f
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/pseries/vio: Fix iommu_table use-after-free refcount warning
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Tyrel Datwyler
Cc: Tyrel Datwyler, aik, Tyrel Datwyler, drt, linuxppc-dev, david
In-Reply-To: <1579558202-26052-1-git-send-email-tyreld@linux.ibm.com>
On Mon, 2020-01-20 at 22:10:02 UTC, Tyrel Datwyler wrote:
> From: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
>
> Commit e5afdf9dd515 ("powerpc/vfio_spapr_tce: Add reference counting to
> iommu_table") missed an iommu_table allocation in the pseries vio code.
> The iommu_table is allocated with kzalloc and as a result the associated
> kref gets a value of zero. This has the side effect that during a DLPAR
> remove of the associated virtual IOA the iommu_tce_table_put() triggers
> a use-after-free underflow warning.
>
> Call Trace:
> [c0000002879e39f0] [c00000000071ecb4] refcount_warn_saturate+0x184/0x190
> (unreliable)
> [c0000002879e3a50] [c0000000000500ac] iommu_tce_table_put+0x9c/0xb0
> [c0000002879e3a70] [c0000000000f54e4] vio_dev_release+0x34/0x70
> [c0000002879e3aa0] [c00000000087cfa4] device_release+0x54/0xf0
> [c0000002879e3b10] [c000000000d64c84] kobject_cleanup+0xa4/0x240
> [c0000002879e3b90] [c00000000087d358] put_device+0x28/0x40
> [c0000002879e3bb0] [c0000000007a328c] dlpar_remove_slot+0x15c/0x250
> [c0000002879e3c50] [c0000000007a348c] remove_slot_store+0xac/0xf0
> [c0000002879e3cd0] [c000000000d64220] kobj_attr_store+0x30/0x60
> [c0000002879e3cf0] [c0000000004ff13c] sysfs_kf_write+0x6c/0xa0
> [c0000002879e3d10] [c0000000004fde4c] kernfs_fop_write+0x18c/0x260
> [c0000002879e3d60] [c000000000410f3c] __vfs_write+0x3c/0x70
> [c0000002879e3d80] [c000000000415408] vfs_write+0xc8/0x250
> [c0000002879e3dd0] [c0000000004157dc] ksys_write+0x7c/0x120
> [c0000002879e3e20] [c00000000000b278] system_call+0x5c/0x68
>
> Further, since the refcount was always zero the iommu_tce_table_put()
> fails to call the iommu_table release function resulting in a leak.
>
> Fix this issue be initilizing the iommu_table kref immediately after
> allocation.
>
> Fixes: e5afdf9dd515 ("powerpc/vfio_spapr_tce: Add reference counting to iommu_table")
> Signed-off-by: Tyrel Datwyler <tyreld@linux.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/aff8c8242bc638ba57247ae1ec5f272ac3ed3b92
cheers
^ permalink raw reply
* Re: [PATCH] selftests/eeh: Bump EEH wait time to 60s
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Oliver O'Halloran, linuxppc-dev
Cc: Oliver O'Halloran, Douglas Miller, Steve Best
In-Reply-To: <20200122031125.25991-1-oohall@gmail.com>
On Wed, 2020-01-22 at 03:11:25 UTC, Oliver O'Halloran wrote:
> Some newer cards supported by aacraid can take up to 40s to recover
> after an EEH event. This causes spurious failures in the basic EEH
> self-test since the current maximim timeout is only 30s.
>
> Fix the immediate issue by bumping the timeout to a default of 60s,
> and allow the wait time to be specified via an environmental variable
> (EEH_MAX_WAIT).
>
> Reported-by: Steve Best <sbest@redhat.com>
> Suggested-by: Douglas Miller <dougmill@us.ibm.com>
> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/414f50434aa2463202a5b35e844f4125dd1a7101
cheers
^ permalink raw reply
* Re: [PATCH 1/5] powerpc/32: add support of KASAN_VMALLOC
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Christophe Leroy, Benjamin Herrenschmidt, Paul Mackerras,
erhard_f, dja
Cc: linuxppc-dev, linux-kernel
In-Reply-To: <031dec5487bde9b2181c8b3c9800e1879cf98c1a.1579024426.git.christophe.leroy@c-s.fr>
On Tue, 2020-01-14 at 17:54:00 UTC, Christophe Leroy wrote:
> Add support of KASAN_VMALLOC on PPC32.
>
> To allow this, the early shadow covering the VMALLOC space
> need to be removed once high_memory var is set and before
> freeing memblock.
>
> And the VMALLOC area need to be aligned such that boundaries
> are covered by a full shadow page.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Series applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/3d4247fcc938d0ab5cf6fdb752dae07fdeab9736
cheers
^ permalink raw reply
* Re: [PATCH -next] powerpc/maple: fix comparing pointer to 0
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Chen Zhou, benh, paulus
Cc: chenzhou10, gregkh, linux-kernel, nivedita, tglx, linuxppc-dev,
allison
In-Reply-To: <20200121013153.9937-1-chenzhou10@huawei.com>
On Tue, 2020-01-21 at 01:31:53 UTC, Chen Zhou wrote:
> Fixes coccicheck warning:
> ./arch/powerpc/platforms/maple/setup.c:232:15-16:
> WARNING comparing pointer to 0
>
> Compare pointer-typed values to NULL rather than 0.
>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/1e3531982ee70adf1880715a968d9c3365f321ed
cheers
^ permalink raw reply
* Re: [PATCH v2] Fix display of Maximum Memory
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Michael Bringmann, linuxppc-dev, linux-kernel, Gustavo Walbon,
Paul Mackerras
In-Reply-To: <5577aef8-1d5a-ca95-ff0a-9c7b5977e5bf@linux.ibm.com>
On Wed, 2020-01-15 at 14:53:59 UTC, Michael Bringmann wrote:
> Correct overflow problem in calculation+display of Maximum Memory
> value to syscfg where 32bits is insufficient.
>
> Signed-off-by: Michael Bringmann <mwb@linux.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/f1dbc1c5c70d0d4c60b5d467ba941fba167c12f6
cheers
^ permalink raw reply
* Re: [PATCH] MAINTAINERS: Add myself as maintainer of ehv_bytechan tty driver
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Laurentiu Tudor, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Cc: sfr@canb.auug.org.au, timur@kernel.org,
gregkh@linuxfoundation.org, Diana Madalina Craciun,
swood@redhat.com, Laurentiu Tudor
In-Reply-To: <20200114110012.17351-1-laurentiu.tudor@nxp.com>
On Tue, 2020-01-14 at 11:00:25 UTC, Laurentiu Tudor wrote:
> Michael Ellerman made a call for volunteers from NXP to maintain
> this driver and I offered myself.
>
> Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/173bf44bdfc768af3c07cd0aeeb6ad8d1331b77d
cheers
^ permalink raw reply
* Re: [PATCH v2] powerpc/ptdump: don't entirely rebuild kernel when selecting CONFIG_PPC_DEBUG_WX
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Christophe Leroy, Benjamin Herrenschmidt, Paul Mackerras
Cc: linuxppc-dev, linux-kernel
In-Reply-To: <bf34fd9dca61eadf9a134a9f89ebbc162cfd5f86.1578986011.git.christophe.leroy@c-s.fr>
On Tue, 2020-01-14 at 07:14:40 UTC, Christophe Leroy wrote:
> Selecting CONFIG_PPC_DEBUG_WX only impacts ptdump and pgtable_32/64
> init calls. Declaring related functions in asm/pgtable.h implies
> rebuilding almost everything.
>
> Move ptdump_check_wx() declaration in mm/mmu_decl.h
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/1e1c8b2cc37afb333c1829e8e0360321813bf220
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/ptdump: only enable PPC_CHECK_WX with STRICT_KERNEL_RWX
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Christophe Leroy, Benjamin Herrenschmidt, Paul Mackerras
Cc: linuxppc-dev, linux-kernel
In-Reply-To: <922d4939c735c6b52b4137838bcc066fffd4fc33.1578989545.git.christophe.leroy@c-s.fr>
On Tue, 2020-01-14 at 08:13:10 UTC, Christophe Leroy wrote:
> ptdump_check_wx() is called from mark_rodata_ro() which only exists
> when CONFIG_STRICT_KERNEL_RWX is selected.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> Fixes: 453d87f6a8ae ("powerpc/mm: Warn if W+X pages found on boot")
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/f509247b08f2dcf7754d9ed85ad69a7972aa132b
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/ptdump: fix W+X verification
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Christophe Leroy, Benjamin Herrenschmidt, Paul Mackerras
Cc: linuxppc-dev, linux-kernel
In-Reply-To: <0d894839fdbb19070f0e1e4140363be4f2bb62fc.1578989540.git.christophe.leroy@c-s.fr>
On Tue, 2020-01-14 at 08:13:09 UTC, Christophe Leroy wrote:
> Verification cannot rely on simple bit checking because on some
> platforms PAGE_RW is 0, checking that a page is not W means
> checking that PAGE_RO is set instead of checking that PAGE_RW
> is not set.
>
> Use pte helpers instead of checking bits.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> Fixes: 453d87f6a8ae ("powerpc/mm: Warn if W+X pages found on boot")
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/d80ae83f1f932ab7af47b54d0d3bef4f4dba489f
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/ptdump: fix W+X verification call in mark_rodata_ro()
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Christophe Leroy, Benjamin Herrenschmidt, Paul Mackerras
Cc: linuxppc-dev, linux-kernel
In-Reply-To: <37517da8310f4457f28921a4edb88fb21d27b62a.1578989531.git.christophe.leroy@c-s.fr>
On Tue, 2020-01-14 at 08:13:08 UTC, Christophe Leroy wrote:
> ptdump_check_wx() also have to be called when pages are mapped
> by blocks.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> Fixes: 453d87f6a8ae ("powerpc/mm: Warn if W+X pages found on boot")
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/e26ad936dd89d79f66c2b567f700e0c2a7103070
cheers
^ permalink raw reply
* Re: [PATCH 1/5] powerpc/pci: Fold pcibios_setup_device() into pcibios_bus_add_device()
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Oliver O'Halloran, linuxppc-dev; +Cc: Oliver O'Halloran
In-Reply-To: <20200110070207.439-2-oohall@gmail.com>
On Fri, 2020-01-10 at 07:02:03 UTC, Oliver O'Halloran wrote:
> pcibios_bus_add_device() is the only caller of pcibios_setup_device().
> Fold them together since there's no real reason to keep them separate.
>
> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Series applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/3ab3f3c9df348324029e3fbdf381f551b1df8f1e
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/papr_scm: Don't enable direct map for a region by default
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Aneesh Kumar K.V, dan.j.williams, Oliver O'Halloran
Cc: Aneesh Kumar K.V, linuxppc-dev
In-Reply-To: <20200108064647.169637-1-aneesh.kumar@linux.ibm.com>
On Wed, 2020-01-08 at 06:46:47 UTC, "Aneesh Kumar K.V" wrote:
> Setting ND_REGION_PAGEMAP flag implies namespace mode defaults to fsdax mode.
> This also means kernel ends up creating struct page backing for these namspace
> ranges. With large namespaces that is not the right thing to do. We
> should let the user select the mode he/she wants the namespace to be created
> with.
>
> Hence disable ND_REGION_PAGEMAP for papr_scm regions. We still keep the flag for
> of_pmem because it supports only small persistent memory regions.
>
> This is similar to what is done for x86 with commit
> commit: 004f1afbe199 ("libnvdimm, pmem: direct map legacy pmem by default")
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/7e6f8cbc5e10cf7601c762db267b795273d53078
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/pseries: in lmb_is_removable(), advance pfn if section is not present
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Pingfan Liu, linuxppc-dev; +Cc: Paul Mackerras, Pingfan Liu
In-Reply-To: <1578632042-12415-1-git-send-email-kernelfans@gmail.com>
On Fri, 2020-01-10 at 04:54:02 UTC, Pingfan Liu wrote:
> In lmb_is_removable(), if a section is not present, it should continue to
> test the rest sections in the block. But the current code fails to do so.
>
> Signed-off-by: Pingfan Liu <kernelfans@gmail.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> To: linuxppc-dev@lists.ozlabs.org
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/fbee6ba2dca30d302efe6bddb3a886f5e964a257
cheers
^ permalink raw reply
* Re: powerpc/xmon: don't access ASDR in VMs
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Sukadev Bhattiprolu; +Cc: linuxppc-dev
In-Reply-To: <20200107021633.GB29843@us.ibm.com>
On Tue, 2020-01-07 at 02:16:33 UTC, Sukadev Bhattiprolu wrote:
> >From 91a77dbea3c909ff15c66cded37f1334304a293d Mon Sep 17 00:00:00 2001
> From: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
> Date: Mon, 6 Jan 2020 13:50:02 -0600
> Subject: [PATCH 1/1] powerpc/xmon: don't access ASDR in VMs
>
> ASDR is HV-privileged and must only be accessed in HV-mode.
> Fixes a Program Check (0x700) when xmon in a VM dumps SPRs.
>
> Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/c2a20711fc181e7f22ee5c16c28cb9578af84729
cheers
^ permalink raw reply
* Re: [PATCH v3 1/2] powerpc32/booke: consistently return phys_addr_t in __pa()
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: yingjie_bai, Scott Wood, Kumar Gala
Cc: Jason Yan, Aneesh Kumar K.V, linux-kernel, Nicholas Piggin,
Paul Mackerras, Nicolas Saenz Julienne, Greg Kroah-Hartman,
Bai Yingjie, Thomas Gleixner, linuxppc-dev, Allison Randal
In-Reply-To: <20200106042957.26494-1-yingjie_bai@126.com>
On Mon, 2020-01-06 at 04:29:53 UTC, yingjie_bai@126.com wrote:
> From: Bai Yingjie <byj.tea@gmail.com>
>
> When CONFIG_RELOCATABLE=y is set, VIRT_PHYS_OFFSET is a 64bit variable,
> thus __pa() returns as 64bit value.
> But when CONFIG_RELOCATABLE=n, __pa() returns 32bit value.
>
> When CONFIG_PHYS_64BIT is set, __pa() should consistently return as
> 64bit value irrelevant to CONFIG_RELOCATABLE.
> So we'd make __pa() consistently return phys_addr_t, which is 64bit
> when CONFIG_PHYS_64BIT is set.
>
> Signed-off-by: Bai Yingjie <byj.tea@gmail.com>
Series applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/6ad4afc97bc6c5cca9786030492ddfab871ce79e
cheers
^ permalink raw reply
* Re: [PATCH 10/10] powerpc/powernv: use resource_size
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Julia Lawall, Benjamin Herrenschmidt
Cc: kernel-janitors, Paul Mackerras, linuxppc-dev, linux-kernel
In-Reply-To: <1577900990-8588-11-git-send-email-Julia.Lawall@inria.fr>
On Wed, 2020-01-01 at 17:49:50 UTC, Julia Lawall wrote:
> Use resource_size rather than a verbose computation on
> the end and start fields.
>
> The semantic patch that makes these changes is as follows:
> (http://coccinelle.lip6.fr/)
>
> <smpl>
> @@ struct resource ptr; @@
> - (ptr.end - ptr.start + 1)
> + resource_size(&ptr)
> </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/552aa086944a9aeabd599892007c2c7faedb894e
cheers
^ permalink raw reply
* Re: [PATCH 05/10] powerpc/83xx: use resource_size
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Julia Lawall, Scott Wood
Cc: Paul Mackerras, linuxppc-dev, kernel-janitors, linux-kernel
In-Reply-To: <1577900990-8588-6-git-send-email-Julia.Lawall@inria.fr>
On Wed, 2020-01-01 at 17:49:45 UTC, Julia Lawall wrote:
> Use resource_size rather than a verbose computation on
> the end and start fields.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> <smpl>
> @@ struct resource ptr; @@
> - (ptr.end - ptr.start + 1)
> + resource_size(&ptr)
> </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/bfbe37f0ce994e7a9945653d7624fadc5c500a9f
cheers
^ permalink raw reply
* Re: [PATCH 1/4] misc: cxl: use mmgrab
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Julia Lawall, Frederic Barrat
Cc: Andrew Donnellan, Arnd Bergmann, Greg Kroah-Hartman,
kernel-janitors, linux-kernel, linuxppc-dev
In-Reply-To: <1577634178-22530-2-git-send-email-Julia.Lawall@inria.fr>
On Sun, 2019-12-29 at 15:42:55 UTC, Julia Lawall wrote:
> Mmgrab was introduced in commit f1f1007644ff ("mm: add new mmgrab()
> helper") and most of the kernel was updated to use it. Update a
> remaining file.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> <smpl>
> @@ expression e; @@
> - atomic_inc(&e->mm_count);
> + mmgrab(e);
> </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/30e813cf46ccaeea6508607632e49b4a1d743d2a
cheers
^ permalink raw reply
* Re: [PATCH 09/16] powerpc/mpic: constify copied structure
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Julia Lawall, Benjamin Herrenschmidt
Cc: kernel-janitors, Paul Mackerras, linuxppc-dev, linux-kernel
In-Reply-To: <1577864614-5543-10-git-send-email-Julia.Lawall@inria.fr>
On Wed, 2020-01-01 at 07:43:27 UTC, Julia Lawall wrote:
> The mpic_ipi_chip and mpic_irq_ht_chip structures are only copied
> into other structures, so make them const.
>
> The opportunity for this change was found using Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/5084ff33cac0988c1b979814501dcc2e1ecbf9c0
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/mm: don't log user reads to 0xffffffff
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Christophe Leroy, Benjamin Herrenschmidt, Paul Mackerras
Cc: linuxppc-dev, linux-kernel
In-Reply-To: <0728849e826ba16f1fbd6fa7f5c6cc87bd64e097.1577087627.git.christophe.leroy@c-s.fr>
On Mon, 2019-12-23 at 07:54:22 UTC, Christophe Leroy wrote:
> Running vdsotest leaves many times the following log:
>
> [ 79.629901] vdsotest[396]: User access of kernel address (ffffffff) - exploit attempt? (uid: 0)
>
> A pointer set to (-1) is likely a programming error similar to
> a NULL pointer and is not worth logging as an exploit attempt.
>
> Don't log user accesses to 0xffffffff.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/0f9aee0cb9da7db7d96f63cfa2dc5e4f1bffeb87
cheers
^ permalink raw reply
* Re: [PATCH 1/2] powerpc/book3s64/hash: Disable 16M linear mapping size if not aligned
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Russell Currey, linuxppc-dev; +Cc: ajd, npiggin, kernel-hardening
In-Reply-To: <20191224064126.183670-1-ruscur@russell.cc>
On Tue, 2019-12-24 at 06:41:25 UTC, Russell Currey wrote:
> With STRICT_KERNEL_RWX on in a relocatable kernel under the hash MMU, if
> the position the kernel is loaded at is not 16M aligned, the kernel
> miscalculates its ALIGN*()s and things go horribly wrong.
>
> We can easily avoid this when selecting the linear mapping size, so do
> so and print a warning. I tested this for various alignments and as
> long as the position is 64K aligned it's fine (the base requirement for
> powerpc).
>
> Signed-off-by: Russell Currey <ruscur@russell.cc>
Series applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/970d54f99ceac5bbf27929cb5ebfe18338ba1543
cheers
^ permalink raw reply
* Re: [PATCH v5 01/17] powerpc/32: replace MTMSRD() by mtmsr
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Christophe Leroy, Benjamin Herrenschmidt, Paul Mackerras, dja
Cc: linux-mm, linuxppc-dev, linux-kernel
In-Reply-To: <22469e78230edea3dbd0c79a555d73124f6c6d93.1576916812.git.christophe.leroy@c-s.fr>
On Sat, 2019-12-21 at 08:32:22 UTC, Christophe Leroy wrote:
> On PPC32, MTMSRD() is simply defined as mtmsr.
>
> Replace MTMSRD(reg) by mtmsr reg in files dedicated to PPC32,
> this makes the code less obscure.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Series applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/39bccfd164970557c5cfc60b2db029f70542549f
cheers
^ permalink raw reply
* Re: [PATCH v3] powerpc/mm: Remove kvm radix prefetch workaround for Power9 DD2.2
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Jordan Niethe, linuxppc-dev, kvm-ppc; +Cc: Jordan Niethe, oohall
In-Reply-To: <20191206031722.25781-1-jniethe5@gmail.com>
On Fri, 2019-12-06 at 03:17:22 UTC, Jordan Niethe wrote:
> Commit a25bd72badfa ("powerpc/mm/radix: Workaround prefetch issue with
> KVM") introduced a number of workarounds as coming out of a guest with
> the mmu enabled would make the cpu would start running in hypervisor
> state with the PID value from the guest. The cpu will then start
> prefetching for the hypervisor with that PID value.
>
> In Power9 DD2.2 the cpu behaviour was modified to fix this. When
> accessing Quadrant 0 in hypervisor mode with LPID != 0 prefetching will
> not be performed. This means that we can get rid of the workarounds for
> Power9 DD2.2 and later revisions. Add a new cpu feature
> CPU_FTR_P9_RADIX_PREFETCH_BUG to indicate if the workarounds are needed.
>
> Signed-off-by: Jordan Niethe <jniethe5@gmail.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/736bcdd3a9fc672af33fb83230ecd0570ec38ec6
cheers
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox