From: Takashi Iwai <tiwai@suse.de>
To: "Nicholas Mc Guire" <hofrat@osadl.org>
Cc: "Johannes Berg" <johannes@sipsolutions.net>,
<alsa-devel@alsa-project.org>, <linuxppc-dev@lists.ozlabs.org>,
"Jaroslav Kysela" <perex@perex.cz>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: snd-aoa: add of_node_put() in error path
Date: Fri, 29 Jun 2018 20:37:28 +0200 [thread overview]
Message-ID: <s5hvaa1iglz.wl-tiwai@suse.de> (raw)
In-Reply-To: <1530292062-31567-1-git-send-email-hofrat@osadl.org>
On Fri, 29 Jun 2018 19:07:42 +0200,
Nicholas Mc Guire wrote:
>
> Both calls to of_find_node_by_name() and of_get_next_child() return a
> node pointer with refcount incremented thus it must be explicidly
> decremented here after the last usage. As we are assured to have a
> refcounted np either from the initial
> of_find_node_by_name(NULL, name); or from the of_get_next_child(gpio, np)
> in the while loop if we reached the error code path below, an
> x of_node_put(np) is needed.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> Fixes: commit f3d9478b2ce4 ("[ALSA] snd-aoa: add snd-aoa")
> ---
>
> Problem located by an experimental coccinelle script
>
> Patch was compiletested with: ppc64_defconfig (implies CONFIG_SND_AOA=m)
>
> Patch is against 4.18-rc2 (localversion-next is next-20180629)
Applied, thanks.
Takashi
prev parent reply other threads:[~2018-06-29 18:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 17:07 [PATCH] ALSA: snd-aoa: add of_node_put() in error path Nicholas Mc Guire
2018-06-29 18:37 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hvaa1iglz.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=hofrat@osadl.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox