* [PATCH] perf symbols: ignore livepatch symbols
@ 2026-06-24 20:12 Joe Lawrence
2026-06-25 9:10 ` Petr Mladek
0 siblings, 1 reply; 2+ messages in thread
From: Joe Lawrence @ 2026-06-24 20:12 UTC (permalink / raw)
To: linux-perf-users, linux-kernel, live-patching
Livepatch modules contain special symbols (prefixed by ".klp.sym.") that
act as relocation placeholders. Once resolved, they point to the same
addresses as the original kernel symbols they reference. [1]
These special symbols confuse the 'vmlinux symtab matches kallsyms' perf
test as kallsyms may report multiple symbols sharing a single kernel
address. For example:
kallsyms (without livepatch)
----------------------------
ffffffff81a41110 T __pfx_arch_release_task_struct
> ffffffff81a41120 T arch_release_task_struct
ffffffff81a41140 T __pfx_exit_thread
ffffffff81a41150 T exit_thread
kallsyms (with livepatch loaded)
---------------------------------
ffffffff81a41110 T __pfx_arch_release_task_struct
> ffffffff81a41120 T arch_release_task_struct
ffffffff81a41140 T __pfx_exit_thread
ffffffff81a41150 T exit_thread
> ffffffff81a41120 w .klp.sym.vmlinux.arch_release_task_struct,0 [kpatch_5_14_0_570_94_1_1_3]
When perf loads kallsyms, both symbols are inserted into the
symbol table at the same address, corrupting symbol end-address
calculations and causing test failures.
Filter out symbols prefixed with ".klp.sym." when loading kallsyms, as
they alias existing kernel symbols.
Link: https://docs.kernel.org/livepatch/module-elf-format.html#livepatch-symbols [1]
Reported-and-tested-by: Ben Procknow <bprockno@redhat.com>
Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
---
tools/perf/util/symbol.c | 4 ++++
1 file changed, 4 insertions(+)
From Ben's tests:
Without patch:
./tools/perf/perf test 1
1: vmlinux symtab matches kallsyms : FAILED!
With patch:
./tools/perf/perf test 1
1: vmlinux symtab matches kallsyms : Ok
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index fcaeeddbbb6b..eeaed3f5cf50 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -774,6 +774,10 @@ static int map__process_kallsym_symbol(void *arg, const char *name,
if (name[0] == '$')
return 0;
+ /* Ignore livepatch symbols */
+ if (strstarts(name, ".klp.sym."))
+ return 0;
+
/*
* module symbols are not sorted so we add all
* symbols, setting length to 0, and rely on
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] perf symbols: ignore livepatch symbols
2026-06-24 20:12 [PATCH] perf symbols: ignore livepatch symbols Joe Lawrence
@ 2026-06-25 9:10 ` Petr Mladek
0 siblings, 0 replies; 2+ messages in thread
From: Petr Mladek @ 2026-06-25 9:10 UTC (permalink / raw)
To: Joe Lawrence; +Cc: linux-perf-users, linux-kernel, live-patching
On Wed 2026-06-24 16:12:54, Joe Lawrence wrote:
> Livepatch modules contain special symbols (prefixed by ".klp.sym.") that
> act as relocation placeholders. Once resolved, they point to the same
> addresses as the original kernel symbols they reference. [1]
>
> These special symbols confuse the 'vmlinux symtab matches kallsyms' perf
> test as kallsyms may report multiple symbols sharing a single kernel
> address. For example:
>
> kallsyms (without livepatch)
> ----------------------------
> ffffffff81a41110 T __pfx_arch_release_task_struct
> > ffffffff81a41120 T arch_release_task_struct
> ffffffff81a41140 T __pfx_exit_thread
> ffffffff81a41150 T exit_thread
>
> kallsyms (with livepatch loaded)
> ---------------------------------
> ffffffff81a41110 T __pfx_arch_release_task_struct
> > ffffffff81a41120 T arch_release_task_struct
> ffffffff81a41140 T __pfx_exit_thread
> ffffffff81a41150 T exit_thread
> > ffffffff81a41120 w .klp.sym.vmlinux.arch_release_task_struct,0 [kpatch_5_14_0_570_94_1_1_3]
>
> When perf loads kallsyms, both symbols are inserted into the
> symbol table at the same address, corrupting symbol end-address
> calculations and causing test failures.
>
> Filter out symbols prefixed with ".klp.sym." when loading kallsyms, as
> they alias existing kernel symbols.
>
> Link: https://docs.kernel.org/livepatch/module-elf-format.html#livepatch-symbols [1]
> Reported-and-tested-by: Ben Procknow <bprockno@redhat.com>
> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
> ---
> tools/perf/util/symbol.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> >From Ben's tests:
>
> Without patch:
> ./tools/perf/perf test 1
> 1: vmlinux symtab matches kallsyms : FAILED!
>
> With patch:
> ./tools/perf/perf test 1
> 1: vmlinux symtab matches kallsyms : Ok
>
> diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
> index fcaeeddbbb6b..eeaed3f5cf50 100644
> --- a/tools/perf/util/symbol.c
> +++ b/tools/perf/util/symbol.c
> @@ -774,6 +774,10 @@ static int map__process_kallsym_symbol(void *arg, const char *name,
> if (name[0] == '$')
> return 0;
It seems that the above checks has been moved into is_ignored_kernel_symbol(),
in the current Linus' tree, see
https://lore.kernel.org/lkml/20260522082604.89447-2-qirui.001@bytedance.com/
> + /* Ignore livepatch symbols */
> + if (strstarts(name, ".klp.sym."))
> + return 0;
I guess that this check should be moved there as well.
Nit: It might be possible to include <linux/livepatch_external.h>
and use KLP_SYM_PREFIX instead of ".klp.sym."
> +
> /*
> * module symbols are not sorted so we add all
> * symbols, setting length to 0, and rely on
Best Regards,
Petr
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-25 9:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-24 20:12 [PATCH] perf symbols: ignore livepatch symbols Joe Lawrence
2026-06-25 9:10 ` Petr Mladek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox