Live Patching
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: attreyee-muk <tintinm2017@gmail.com>,
	jpoimboe@kernel.org, jikos@kernel.org, mbenes@suse.cz,
	pmladek@suse.com, joe.lawrence@redhat.com, corbet@lwn.net
Cc: live-patching@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Took care of some grammatical mistakes
Date: Mon, 27 Nov 2023 11:41:31 -0800	[thread overview]
Message-ID: <202dbdf5-1adf-4ffa-a50d-0424967286ba@infradead.org> (raw)
In-Reply-To: <20231127155758.33070-1-tintinm2017@gmail.com>

Hi,

On 11/27/23 07:57, attreyee-muk wrote:
> Respected Maintainers, 
> 
> I have made some grammatical changes in the livepatch.rst file where I
> felt that the sentence would have sounded more correct and would have become easy for
> beginners to understand by reading. 
> Requesting review of my proposed changes from the mainatiners. 
> 
> Thank You
> Attreyee Mukherjee
> 
> Signed-off-by: attreyee-muk <tintinm2017@gmail.com>
> ---
>  Documentation/livepatch/livepatch.rst | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/livepatch/livepatch.rst b/Documentation/livepatch/livepatch.rst
> index 68e3651e8af9..a2d2317b7d6b 100644
> --- a/Documentation/livepatch/livepatch.rst
> +++ b/Documentation/livepatch/livepatch.rst
> @@ -35,11 +35,11 @@ and livepatching:
>  
>  All three approaches need to modify the existing code at runtime. Therefore
> -they need to be aware of each other and not step over each other's toes.
> +they need to be aware of each other and not step over each others' toes.

I've never seen that written like that, so I disagree here. FWIW.

>  Most of these problems are solved by using the dynamic ftrace framework as
>  a base. A Kprobe is registered as a ftrace handler when the function entry
>  is probed, see CONFIG_KPROBES_ON_FTRACE. Also an alternative function from

thanks.
-- 
~Randy

  parent reply	other threads:[~2023-11-27 19:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-27 15:57 [PATCH] Took care of some grammatical mistakes attreyee-muk
2023-11-27 16:47 ` Jonathan Corbet
2023-11-27 19:41 ` Randy Dunlap [this message]
2023-11-28 14:12   ` Matthew Wilcox
2023-11-28 16:18     ` Randy Dunlap
2023-11-29 10:08       ` Miroslav Benes
2023-11-29 12:47         ` Bagas Sanjaya
2023-11-29 14:48         ` Joe Lawrence

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202dbdf5-1adf-4ffa-a50d-0424967286ba@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=corbet@lwn.net \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=jpoimboe@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=pmladek@suse.com \
    --cc=tintinm2017@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox