* [PATCH] livepatch: Add a missing newline character in klp_module_coming()
@ 2022-08-30 11:28 Zhen Lei
2022-09-01 15:10 ` Petr Mladek
0 siblings, 1 reply; 2+ messages in thread
From: Zhen Lei @ 2022-08-30 11:28 UTC (permalink / raw)
To: Josh Poimboeuf, Jiri Kosina, Miroslav Benes, Petr Mladek,
Joe Lawrence, live-patching, linux-kernel
Cc: Zhen Lei
The error message is not printed immediately because it does not end with
a newline character.
Before:
root@localhost:~# insmod vmlinux.ko
insmod: ERROR: could not insert module vmlinux.ko: Invalid parameters
After:
root@localhost:~# insmod vmlinux.ko
[ 43.982558] livepatch: vmlinux.ko: invalid module name
insmod: ERROR: could not insert module vmlinux.ko: Invalid parameters
Fixes: dcf550e52f56 ("livepatch: Disallow vmlinux.ko")
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
kernel/livepatch/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index bc475e62279d2a3..42f7e716d56bf72 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -1171,7 +1171,7 @@ int klp_module_coming(struct module *mod)
return -EINVAL;
if (!strcmp(mod->name, "vmlinux")) {
- pr_err("vmlinux.ko: invalid module name");
+ pr_err("vmlinux.ko: invalid module name\n");
return -EINVAL;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] livepatch: Add a missing newline character in klp_module_coming()
2022-08-30 11:28 [PATCH] livepatch: Add a missing newline character in klp_module_coming() Zhen Lei
@ 2022-09-01 15:10 ` Petr Mladek
0 siblings, 0 replies; 2+ messages in thread
From: Petr Mladek @ 2022-09-01 15:10 UTC (permalink / raw)
To: Zhen Lei
Cc: Josh Poimboeuf, Jiri Kosina, Miroslav Benes, Joe Lawrence,
live-patching, linux-kernel
On Tue 2022-08-30 19:28:55, Zhen Lei wrote:
> The error message is not printed immediately because it does not end with
> a newline character.
>
> Before:
> root@localhost:~# insmod vmlinux.ko
> insmod: ERROR: could not insert module vmlinux.ko: Invalid parameters
>
> After:
> root@localhost:~# insmod vmlinux.ko
> [ 43.982558] livepatch: vmlinux.ko: invalid module name
> insmod: ERROR: could not insert module vmlinux.ko: Invalid parameters
>
> Fixes: dcf550e52f56 ("livepatch: Disallow vmlinux.ko")
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Great catch! The message is not pushed to the console because
the line is not finished and might be eventually extended by pr_cont().
Reviewed-by: Petr Mladek <pmladek@suse.com>
The fix is trivial. I have pushed it into livepatching/livepatching.git,
branch for-6.1/fixes.
Best Regards,
Petr
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-01 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-30 11:28 [PATCH] livepatch: Add a missing newline character in klp_module_coming() Zhen Lei
2022-09-01 15:10 ` Petr Mladek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox