From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Kees Cook <keescook@chromium.org>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
Petr Mladek <pmladek@suse.com>,
Joe Lawrence <joe.lawrence@redhat.com>,
<live-patching@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Masahiro Yamada" <masahiroy@kernel.org>,
Alexei Starovoitov <ast@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Luis Chamberlain" <mcgrof@kernel.org>,
<linux-modules@vger.kernel.org>
Subject: Re: [PATCH v2 8/8] kallsyms: Add self-test facility
Date: Sat, 17 Sep 2022 20:40:49 +0800 [thread overview]
Message-ID: <dab5fc68-0ac5-306a-bd81-0165f3b741ec@huawei.com> (raw)
In-Reply-To: <C889CF38-A80A-4DF6-9648-3B8947494CBC@chromium.org>
On 2022/9/17 16:07, Kees Cook wrote:
>
>
> On September 9, 2022 2:00:16 PM GMT+01:00, Zhen Lei <thunder.leizhen@huawei.com> wrote:
>> Add some test cases to test the function and performance of some kallsyms
>> interfaces, such as kallsyms_lookup_name. It also calculates the
>> compression rate of the kallsyms compression algorithm for the current
>> symbol set.
>>
>> Start self-test automatically after system startup.
if CONFIG_KALLSYMS_SELFTEST=y
>
> I wonder if this would be better implemented as a kunit test? Shouldn't be too hard to convert. Take a look at things like lib/overflow_kunit.c, etc.
Yes, I can try to define one for each type of symbol, such as: bss, data, weak, static.
In addition, we can use kallsyms_offsets[] to do a full test.
>
> -Kees
>
--
Regards,
Zhen Lei
next prev parent reply other threads:[~2022-09-17 12:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 13:00 [PATCH v2 0/8] kallsyms: Optimizes the performance of lookup symbols Zhen Lei
2022-09-09 13:00 ` [PATCH v2 1/8] scripts/kallsyms: don't compress symbol type when CONFIG_KALLSYMS_ALL=y Zhen Lei
2022-09-20 17:26 ` Petr Mladek
2022-09-21 2:42 ` Leizhen (ThunderTown)
2022-09-21 6:51 ` Leizhen (ThunderTown)
2022-09-21 7:13 ` Petr Mladek
2022-09-09 13:00 ` [PATCH v2 2/8] scripts/kallsyms: rename build_initial_tok_table() Zhen Lei
2022-09-09 13:00 ` [PATCH v2 3/8] kallsyms: Adjust the types of some local variables Zhen Lei
2022-09-09 13:00 ` [PATCH v2 4/8] kallsyms: Improve the performance of kallsyms_lookup_name() Zhen Lei
2022-09-09 13:00 ` [PATCH v2 5/8] kallsyms: Add helper kallsyms_on_each_match_symbol() Zhen Lei
2022-09-09 13:00 ` [PATCH v2 6/8] livepatch: Use kallsyms_on_each_match_symbol() to improve performance Zhen Lei
2022-09-09 13:00 ` [PATCH v2 7/8] livepatch: Improve the search performance of module_kallsyms_on_each_symbol() Zhen Lei
2022-09-20 12:08 ` Petr Mladek
2022-09-20 14:01 ` Leizhen (ThunderTown)
2022-09-21 6:56 ` Petr Mladek
2022-09-09 13:00 ` [PATCH v2 8/8] kallsyms: Add self-test facility Zhen Lei
2022-09-17 8:07 ` Kees Cook
2022-09-17 12:40 ` Leizhen (ThunderTown) [this message]
2022-09-16 1:27 ` [PATCH v2 0/8] kallsyms: Optimizes the performance of lookup symbols Leizhen (ThunderTown)
2022-09-16 3:17 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dab5fc68-0ac5-306a-bd81-0165f3b741ec@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jolsa@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox