From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: "'Andrew Morton'" <akpm@osdl.org>,
"'Jeff Garzik'" <jgarzik@pobox.com>, <davem@davemloft.net>
Cc: "'Linux Kernel Mailing List'" <linux-kernel@vger.kernel.org>,
"'NetDev'" <netdev@vger.kernel.org>
Subject: [patch] fix up generic csum_ipv6_magic function prototype
Date: Wed, 8 Nov 2006 18:02:06 -0800 [thread overview]
Message-ID: <000301c703a3$0eedb340$ff0da8c0@amr.corp.intel.com> (raw)
The generic version of csum_ipv6_magic has the len argument declared as
__u16, while most arch dependent version declare it as __u32. After
looking at the call site of this function, I come up to a conclusion
that __u32 is a better match with the actual usage.
Hence, patch to change argument type for greater consistency.
Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>
---
asm-m32r and asm-parisc both have it declared as __u16. I think it is a
copy-n-paste error and needs to be fixed by arch maintainer, I hope.
--- ./include/net/ip6_checksum.h.orig 2006-11-08 18:49:50.000000000 -0800
+++ ./include/net/ip6_checksum.h 2006-11-08 18:50:04.000000000 -0800
@@ -36,7 +36,7 @@
static __inline__ unsigned short int csum_ipv6_magic(struct in6_addr *saddr,
struct in6_addr *daddr,
- __u16 len,
+ __u32 len,
unsigned short proto,
unsigned int csum)
{
next reply other threads:[~2006-11-09 2:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-09 2:02 Chen, Kenneth W [this message]
2006-11-09 7:00 ` [patch] fix up generic csum_ipv6_magic function prototype David Miller
2006-11-09 7:22 ` Al Viro
2006-11-09 7:55 ` David Miller
2006-11-13 8:52 ` Al Viro
2006-11-13 9:12 ` Russell King
2006-11-13 9:25 ` Al Viro
2006-11-13 9:37 ` Andi Kleen
2006-11-14 0:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000301c703a3$0eedb340$ff0da8c0@amr.corp.intel.com' \
--to=kenneth.w.chen@intel.com \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox