From: David Miller <davem@davemloft.net>
To: viro@ftp.linux.org.uk
Cc: kenneth.w.chen@intel.com, akpm@osdl.org, jgarzik@pobox.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [patch] fix up generic csum_ipv6_magic function prototype
Date: Mon, 13 Nov 2006 16:16:56 -0800 (PST) [thread overview]
Message-ID: <20061113.161656.90118004.davem@davemloft.net> (raw)
In-Reply-To: <20061113085223.GR29920@ftp.linux.org.uk>
From: Al Viro <viro@ftp.linux.org.uk>
Date: Mon, 13 Nov 2006 08:52:23 +0000
> The first question is in the types we are using for length. OK,
> csum_tcpudp_...() is a special case; there we want u16 and unless
> there's a reason _not_ to do so on sparc, I'd rather convert it
> to the same thing.
That's fine.
> csum_partial_copy_fromuser(): Can die, only 3 targets have its rudiment
> and nothing in the tree uses it. ACK?
ACK.
> csum_partial_copy(). Rare alias for csum_partial_copy_nocheck(). Can die;
> all instances simply should be renamed to csum_partial_copy_nocheck. ACK?
ACK.
prev parent reply other threads:[~2006-11-14 0:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-09 2:02 [patch] fix up generic csum_ipv6_magic function prototype Chen, Kenneth W
2006-11-09 7:00 ` David Miller
2006-11-09 7:22 ` Al Viro
2006-11-09 7:55 ` David Miller
2006-11-13 8:52 ` Al Viro
2006-11-13 9:12 ` Russell King
2006-11-13 9:25 ` Al Viro
2006-11-13 9:37 ` Andi Kleen
2006-11-14 0:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061113.161656.90118004.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox